GNU bug report logs - #32266
Cannot add directory names ending in .el with normal-top-level-add-subdirs-to-load-path

Previous Next

Full log

Message #11 received at 32266 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Håkon Hægland <hakon.hagland <at> gmail.com>,
 32266 <at> debbugs.gnu.org
Subject: Re: bug#32266: Cannot add directory names ending in .el with
 normal-top-level-add-subdirs-to-load-path
Date: Wed, 26 Aug 2020 14:50:13 +0200

Robert Pluim <rpluim <at> gmail.com> writes:

> The comment just above says
>
> 		 ;; Avoid doing a `stat' when it isn't necessary because
> 		 ;; that can cause trouble when an NFS server is down.
>
> which has been there for a long time. If an NFS server *is* down, then
> that will manifest itself with other files anyway, so I don't see why
> we'd need special handling here. I propose:

Yeah, that's just odd.  And having directories called .el isn't that
strange, anyway, so I've applied your patch to Emacs 28:

> -		 ;; Avoid doing a `stat' when it isn't necessary because
> -		 ;; that can cause trouble when an NFS server is down.
> -		 (not (string-match "\\.elc?\\'" file))

I did a "make" and "make bootstrap" and I can't see any adverse effects.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.