Subject: bug#32252: [PATCH] %o and %x now format signed numbers

From: Drew Adams <[email-masked]>
Date: Wed, 25 Jul 2018 14:56:04 -0700 (PDT)

>   > > Although it is indeed an incompatible change, I surveyed the existing
>   > > Emacs source code and couldn't find anything that the change would
>   > > break.
> 
>   > Inadequate.  Never wholly irrelevant, but certainly not
>   > sufficient.  You surveyed something mostly irrelevant.
> 
> How about saying "incomplete"?  It states the valid point but is far less harsh.

Incomplete, of course; thank you.

But also inadequate, IMO - or insufficient, if you prefer - perhaps that is less harsh than inadequate.

The intention was not to be harsh but to say that, while it is good to check the sources distributed with Emacs, it is not good enough.

"Incomplete" tells part of the story, but it doesn't imply that there is a problem. (Unless there is agreement on a completeness requirement -  I wasn't assuming such agreement.)

Saying it's not sufficient to just check the Emacs sources says both that doing so is incomplete _and_ that such an incomplete search is not enough.

But you're no doubt right that there is likely more agreement that such a search is incomplete than there is that it's also not enough.