GNU bug report logs - #32243
26.1; eldoc takes priority over flymake-diagnostics

Previous Next

Package: emacs;

Reported by: James Nguyen <james <at> jojojames.com>

Date: Sat, 21 Jul 2018 19:23:01 UTC

Severity: minor

Found in version 26.1

Done: Lars Ingebrigtsen <larsi <at> gnus.org>

Bug is archived. No further changes may be made.

Full log

Message #8 received at 32243 <at> debbugs.gnu.org (full text, mbox):

From: João Távora <joaotavora <at> gmail.com>
To: 32243 <at> debbugs.gnu.org, Dmitry Gutov <dgutov <at> yandex.ru>
Subject: Re: bug#32243: 26.1; eldoc takes priority over flymake-diagnostics
Date: Sun, 19 Aug 2018 19:48:22 +0100

[Message part 1 (text/plain, inline)]
A naive fix for this could be

diff --git a/lisp/emacs-lisp/eldoc.el b/lisp/emacs-lisp/eldoc.el
index 49ba71fb1b..5fafd066db 100644
--- a/lisp/emacs-lisp/eldoc.el
+++ b/lisp/emacs-lisp/eldoc.el
@@ -272,7 +272,9 @@ eldoc-minibuffer-message
                 (when (stringp format-string)
                   (apply #'format-message format-string args)))
           (force-mode-line-update)))
-    (apply 'message format-string args)))
+    (unless (and (current-message)
+             (not (string= (current-message) "Quit")))
+      (apply 'message format-string args))))

 (defun eldoc-message (&optional string)
   "Display STRING as an ElDoc message if it's non-nil.

which imitates what help-at-pt-maybe-display-does.

It seems to work more or less well in my testing, but not always. Obviously
I haven't studied the full impact of this.

Dmitry, do you have any thoughts on this?

-- 
João Távora

[Message part 2 (text/html, inline)]
This bug report was last modified 4 years and 335 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.