GNU bug report logs - #32243
26.1; eldoc takes priority over flymake-diagnostics

Previous Next

Full log

View this message in rfc822 format

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: João Távora <joaotavora <at> gmail.com>
Cc: 32243 <at> debbugs.gnu.org, Dmitry Gutov <dgutov <at> yandex.ru>
Subject: bug#32243: 26.1; eldoc takes priority over flymake-diagnostics
Date: Sat, 22 Aug 2020 17:03:05 +0200

João Távora <joaotavora <at> gmail.com> writes:

> A naive fix for this could be

[...]

> which imitates what help-at-pt-maybe-display-does.  
>
> It seems to work more or less well in my testing, but not always. Obviously 
> I haven't studied the full impact of this.
>
> Dmitry, do you have any thoughts on this?

This was two years ago.  I've respun the patch; included below.

Is this something that should be applied or not?

diff --git a/lisp/emacs-lisp/eldoc.el b/lisp/emacs-lisp/eldoc.el
index 4825b5c5e6..0bcd04f84a 100644
--- a/lisp/emacs-lisp/eldoc.el
+++ b/lisp/emacs-lisp/eldoc.el
@@ -300,7 +300,9 @@ eldoc-minibuffer-message
                 (when (stringp format-string)
                   (apply #'format-message format-string args)))
           (force-mode-line-update)))
-    (apply #'message format-string args)))
+    (unless (and (current-message)
+                 (not (string= (current-message) "Quit")))
+      (apply #'message format-string args))))
 
 (make-obsolete
  'eldoc-message "use `eldoc-documentation-functions' instead." "eldoc-1.1.0")


-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.