GNU bug report logs - #32235
[PATCH] Fix Agda compilation, add Agda's emacs mode.

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Marius Bakke <mbakke <at> fastmail.com>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#32235: closed ([PATCH] Fix Agda compilation, add Agda's emacs
 mode.)
Date: Sun, 29 Jul 2018 21:40:01 +0000

[Message part 1 (text/plain, inline)]

Your message dated Sun, 29 Jul 2018 23:39:07 +0200
with message-id <874lgh4t8k.fsf <at> fastmail.com>
and subject line Re: [bug#32235] [PATCH] Fix Agda compilation, add Agda's emacs mode.
has caused the debbugs.gnu.org bug report #32235,
regarding [PATCH] Fix Agda compilation, add Agda's emacs mode.
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
32235: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=32235
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Alex ter Weele <alex.ter.weele <at> gmail.com>
To: guix-patches <at> gnu.org
Subject: [PATCH] Fix Agda compilation, add Agda's emacs mode.
Date: Sat, 21 Jul 2018 10:59:50 -0500

[Message part 3 (message/rfc822, inline)]

From: Marius Bakke <mbakke <at> fastmail.com>
To: Alex ter Weele <alex.ter.weele <at> gmail.com>
Cc: Alex ter Weele <alex.ter.weele <at> gmail.com>, 32235-done <at> debbugs.gnu.org
Subject: Re: [bug#32235] [PATCH] Fix Agda compilation, add Agda's emacs mode.
Date: Sun, 29 Jul 2018 23:39:07 +0200

[Message part 4 (text/plain, inline)]

Marius Bakke <mbakke <at> fastmail.com> writes:

> Alex ter Weele <alex.ter.weele <at> gmail.com> writes:
>
>> Marius Bakke <mbakke <at> fastmail.com> writes:
>>
>>> Alex ter Weele <alex.ter.weele <at> gmail.com> writes:
>>>
>>>> From 2774cc719fa132ed8fd34a1d71f2c5a0f8697645 Mon Sep 17 00:00:00 2001
>>>> From: Alex ter Weele <alex.ter.weele <at> gmail.com>
>>>> Date: Fri, 20 Jul 2018 21:35:14 -0500
>>>> Subject: [PATCH 1/2] gnu: agda: Compile .agda files.
>>>>
>>>> * gnu/packages/agda.scm: (agda)[arguments]: Compile .agda files.
>>>
>>> [...]
>>>
>>>> +    (arguments
>>>> +     `(#:modules ((guix build haskell-build-system)
>>>> +                  (guix build utils)
>>>> +                  (srfi srfi-26))
>>>> +       #:phases
>>>> +       (modify-phases %standard-phases
>>>> +         (add-after 'compile 'agda-compile
>>>> +           (lambda* (#:key outputs #:allow-other-keys)
>>>> +             (let* ((out (assoc-ref outputs "out"))
>>>> +                    (agda-compiler (string-append out "/bin/agda"))
>>>> +                    (agda-files-path (string-append
>>>> +                                      out
>>>> +                                      "/share/x86_64-linux-ghc-8.0.2/Agda-"
>>>
>>> This is unfortunate, since it hard-codes both architecture and GHC
>>> version.  Can you think of another method to find these files?
>>>
>>> Are there ".agda" files elsewhere under "/share"?  Could the find-files
>>> invokation below simply search "out/share", for example?
>>>
>>
>> That works!
>>
>>>> +                                      ,version
>>>> +                                      "/lib/prim/Agda/"))
>>>> +                    (agda-files (append
>>>> +                                 (find-files agda-files-path "\\.agda$")
>>>> +                                 (find-files (string-append
>>>> +                                              agda-files-path
>>>> +                                              "Builtin")
>>>> +                                             "\\.agda$"))))
>>>
>>> (find-files ...) recurses through subdirectories, are you sure adding an
>>> extra pass for "Builtin/*.agda" makes a difference here?
>>>
>>
>> Removed.
>>
>>>> +               (for-each (cut invoke agda-compiler <>) agda-files)
>>>> +               #t))))))
>>>>      (home-page "http://wiki.portal.chalmers.se/agda/")
>>>
>>> Otherwise LGTM.
>>>
>>> [...]
>>>
>>>> From ff441cb0b500d247de9a54c3212f80b4fcfaf04f Mon Sep 17 00:00:00 2001
>>>> From: Alex ter Weele <alex.ter.weele <at> gmail.com>
>>>> Date: Sat, 21 Jul 2018 10:57:35 -0500
>>>> Subject: [PATCH 2/2] gnu: Add emacs-agda2-mode
>>>>
>>>> * gnu/packages/agda.scm (emacs-agda2-mode): New variable.
>>>
>>> LGTM!
>>
>> I found a few potential issues with it. The variable and package names
>> were mismatched, the inputs were inherited, and the home page was
>> misspelled. Corrected in the following patch series.
>>
>> Thanks for the review!
>
> Thanks for catching my review mistake!  All LGTM.

Whoops, Ludovic helpfully reminded me on IRC that you don't yet have
commit access.  I've pushed these patches.

(note that I added a #t after the chdir for emacs-agda2-mode, since the
return value of chdir is unspecified)

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.