GNU bug report logs - #32234
Cuirass: The SQLite built in busy handler might block the Fibers scheduler

Previous Next

Full log

View this message in rfc822 format

From: Clément Lassieur <clement <at> lassieur.org>
To: 32234 <at> debbugs.gnu.org
Subject: bug#32234: [PATCH 2/2] database: Serialize all database accesses in a thread.
Date: Mon, 06 Aug 2018 21:35:08 +0200

Hi,

Clément Lassieur <clement <at> lassieur.org> writes:

[...]

>  bin/cuirass.in           |  23 +-
>  src/cuirass/base.scm     |  94 +++----
>  src/cuirass/database.scm | 550 +++++++++++++++++++++------------------
>  src/cuirass/http.scm     | 136 +++++-----
>  src/cuirass/utils.scm    |  23 +-
>  tests/database.scm       | 103 ++++----
>  tests/http.scm           |  21 +-
>  7 files changed, 494 insertions(+), 456 deletions(-)

Pros:
  - fix the fact that long SQL queries block the scheduler
  - simplify the code, and make it more uniform

Cons:
  - we don't take advantage of the SQLite multi-threading features
    anymore

I've run some tests, and I didn't see any difference in terms of
performance.

Clément

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.