From unknown Mon Aug 18 09:02:12 2025 X-Loop: help-debbugs@gnu.org Subject: bug#32230: 27.0.50; GCC 7 warning due to -Wformat-overflow Resent-From: Ken Brown Original-Sender: "Debbugs-submit" Resent-CC: eggert@cs.ucla.edu, bug-gnu-emacs@gnu.org Resent-Date: Fri, 20 Jul 2018 22:03:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 32230 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 32230@debbugs.gnu.org Cc: Paul Eggert X-Debbugs-Original-To: bug-gnu-emacs@gnu.org X-Debbugs-Original-Xcc: Paul Eggert Received: via spool by submit@debbugs.gnu.org id=B.15321241432433 (code B ref -1); Fri, 20 Jul 2018 22:03:01 +0000 Received: (at submit) by debbugs.gnu.org; 20 Jul 2018 22:02:23 +0000 Received: from localhost ([127.0.0.1]:50043 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fgdTi-0000dB-O1 for submit@debbugs.gnu.org; Fri, 20 Jul 2018 18:02:22 -0400 Received: from eggs.gnu.org ([208.118.235.92]:55309) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fgdTg-0000cv-E0 for submit@debbugs.gnu.org; Fri, 20 Jul 2018 18:02:20 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fgdTa-0008JR-Ft for submit@debbugs.gnu.org; Fri, 20 Jul 2018 18:02:15 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-0.0 required=5.0 tests=BAYES_20 autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:41514) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1fgdTa-0008JL-Bs for submit@debbugs.gnu.org; Fri, 20 Jul 2018 18:02:14 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:46280) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fgdTZ-0005F2-Cd for bug-gnu-emacs@gnu.org; Fri, 20 Jul 2018 18:02:14 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fgdTW-0008HX-Ar for bug-gnu-emacs@gnu.org; Fri, 20 Jul 2018 18:02:13 -0400 Received: from limerock02.mail.cornell.edu ([128.84.13.242]:52661) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fgdTW-0008HJ-5V for bug-gnu-emacs@gnu.org; Fri, 20 Jul 2018 18:02:10 -0400 X-CornellRouted: This message has been Routed already. Received: from authusersmtp.mail.cornell.edu (granite4.serverfarm.cornell.edu [10.16.197.9]) by limerock02.mail.cornell.edu (8.14.4/8.14.4_cu) with ESMTP id w6KM28Rr002530 for ; Fri, 20 Jul 2018 18:02:09 -0400 Received: from [192.168.0.15] (mta-68-175-129-7.twcny.rr.com [68.175.129.7] (may be forged)) (authenticated bits=0) by authusersmtp.mail.cornell.edu (8.14.4/8.12.10) with ESMTP id w6KM27vB017201 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NOT) for ; Fri, 20 Jul 2018 18:02:08 -0400 From: Ken Brown Message-ID: <2d9037f1-e52f-f3ca-7c53-e203ea6ae520@cornell.edu> Date: Fri, 20 Jul 2018 18:02:07 -0400 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US X-PMX-Cornell-Gauge: Gauge=XXXXX X-PMX-CORNELL-AUTH-RESULTS: dkim-out=none; Content-Transfer-Encoding: quoted-printable X-MIME-Autoconverted: from 8bit to quoted-printable by limerock02.mail.cornell.edu id w6KM28Rr002530 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x [fuzzy] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.3 (----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.3 (-----) The Cygwin-w32 build has turned up another GCC 7 warning: ../../master/src/w32term.c: In function =E2=80=98x_draw_glyph_string=E2=80= =99: ../../master/src/w32term.c:1477:27: warning: =E2=80=98__builtin___sprintf= _chk=E2=80=99=20 may write a terminating nul past the end of the destination=20 [-Wformat-overflow=3D] sprintf ((char *) buf, "%0*X", ^ ../../master/src/w32term.c:1477:4: note: =E2=80=98__builtin___sprintf_chk= =E2=80=99=20 output between 5 and 8 bytes into a destination of size 7 sprintf ((char *) buf, "%0*X", ^ The method that Paul used in bug#32189 could be used here too, but I'm not sure it's worth the trouble. My inclination is to just increase the buffer size from 7 to 8. Ken From unknown Mon Aug 18 09:02:12 2025 X-Loop: help-debbugs@gnu.org Subject: bug#32230: 27.0.50; GCC 7 warning due to -Wformat-overflow Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 21 Jul 2018 06:54:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 32230 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Ken Brown Cc: 32230@debbugs.gnu.org, eggert@cs.ucla.edu Received: via spool by 32230-submit@debbugs.gnu.org id=B32230.153215599625513 (code B ref 32230); Sat, 21 Jul 2018 06:54:02 +0000 Received: (at 32230) by debbugs.gnu.org; 21 Jul 2018 06:53:16 +0000 Received: from localhost ([127.0.0.1]:50126 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fgllU-0006dR-6O for submit@debbugs.gnu.org; Sat, 21 Jul 2018 02:53:16 -0400 Received: from eggs.gnu.org ([208.118.235.92]:51843) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fgllS-0006dC-Fb for 32230@debbugs.gnu.org; Sat, 21 Jul 2018 02:53:14 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fgllM-0007l0-8v for 32230@debbugs.gnu.org; Sat, 21 Jul 2018 02:53:09 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-0.5 required=5.0 tests=BAYES_05 autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:54518) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fgllH-0007i9-4b; Sat, 21 Jul 2018 02:53:03 -0400 Received: from [176.228.60.248] (port=3531 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1fgllG-0003WD-F8; Sat, 21 Jul 2018 02:53:02 -0400 Date: Sat, 21 Jul 2018 09:53:04 +0300 Message-Id: <83fu0dyt9r.fsf@gnu.org> From: Eli Zaretskii In-reply-to: <2d9037f1-e52f-f3ca-7c53-e203ea6ae520@cornell.edu> (message from Ken Brown on Fri, 20 Jul 2018 18:02:07 -0400) References: <2d9037f1-e52f-f3ca-7c53-e203ea6ae520@cornell.edu> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -6.0 (------) > From: Ken Brown > Date: Fri, 20 Jul 2018 18:02:07 -0400 > Cc: Paul Eggert > > The Cygwin-w32 build has turned up another GCC 7 warning: > > ../../master/src/w32term.c: In function ‘x_draw_glyph_string’: > ../../master/src/w32term.c:1477:27: warning: ‘__builtin___sprintf_chk’ > may write a terminating nul past the end of the destination > [-Wformat-overflow=] > sprintf ((char *) buf, "%0*X", > ^ > ../../master/src/w32term.c:1477:4: note: ‘__builtin___sprintf_chk’ > output between 5 and 8 bytes into a destination of size 7 > sprintf ((char *) buf, "%0*X", > ^ > The method that Paul used in bug#32189 could be used here too, but I'm > not sure it's worth the trouble. My inclination is to just increase the > buffer size from 7 to 8. Yes, with a comment explaining why 8. But do you understand why it says "between 5 and 8 bytes"? The corresponding argument to snprintf is either 4 or 6, so it should be between 5 and 7. Where could the extra byte come from? Is that because glyphless.ch is a 25-bit field? From unknown Mon Aug 18 09:02:12 2025 X-Loop: help-debbugs@gnu.org Subject: bug#32230: 27.0.50; GCC 7 warning due to -Wformat-overflow Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 21 Jul 2018 07:27:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 32230 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: kbrown@cornell.edu Cc: 32230@debbugs.gnu.org, eggert@cs.ucla.edu Received: via spool by 32230-submit@debbugs.gnu.org id=B32230.153215798628563 (code B ref 32230); Sat, 21 Jul 2018 07:27:02 +0000 Received: (at 32230) by debbugs.gnu.org; 21 Jul 2018 07:26:26 +0000 Received: from localhost ([127.0.0.1]:50140 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fgmHa-0007Qc-6W for submit@debbugs.gnu.org; Sat, 21 Jul 2018 03:26:26 -0400 Received: from eggs.gnu.org ([208.118.235.92]:55515) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fgmHZ-0007QQ-23 for 32230@debbugs.gnu.org; Sat, 21 Jul 2018 03:26:25 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fgmHS-0000cE-UO for 32230@debbugs.gnu.org; Sat, 21 Jul 2018 03:26:19 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:54763) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fgmHO-0000Zf-IE; Sat, 21 Jul 2018 03:26:14 -0400 Received: from [176.228.60.248] (port=1617 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1fgmHN-0002Z1-CJ; Sat, 21 Jul 2018 03:26:14 -0400 Date: Sat, 21 Jul 2018 10:26:15 +0300 Message-Id: <83effxyrqg.fsf@gnu.org> From: Eli Zaretskii In-reply-to: <83fu0dyt9r.fsf@gnu.org> (message from Eli Zaretskii on Sat, 21 Jul 2018 09:53:04 +0300) References: <2d9037f1-e52f-f3ca-7c53-e203ea6ae520@cornell.edu> <83fu0dyt9r.fsf@gnu.org> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -6.0 (------) > Date: Sat, 21 Jul 2018 09:53:04 +0300 > From: Eli Zaretskii > Cc: 32230@debbugs.gnu.org, eggert@cs.ucla.edu > > But do you understand why it says "between 5 and 8 bytes"? The > corresponding argument to snprintf is either 4 or 6, so it should be > between 5 and 7. Where could the extra byte come from? Is that > because glyphless.ch is a 25-bit field? I meant sprintf, of course. And if the above is the reason, then perhaps using something like (unsigned int) glyph->u.glyphless.ch & 0xffffff is a cleaner solution (assuming it shuts up the warning)? From unknown Mon Aug 18 09:02:12 2025 X-Loop: help-debbugs@gnu.org Subject: bug#32230: 27.0.50; GCC 7 warning due to -Wformat-overflow Resent-From: Ken Brown Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 21 Jul 2018 12:43:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 32230 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Eli Zaretskii Cc: 32230@debbugs.gnu.org, eggert@cs.ucla.edu Received: via spool by 32230-submit@debbugs.gnu.org id=B32230.15321769428452 (code B ref 32230); Sat, 21 Jul 2018 12:43:01 +0000 Received: (at 32230) by debbugs.gnu.org; 21 Jul 2018 12:42:22 +0000 Received: from localhost ([127.0.0.1]:50304 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fgrDK-0002CG-4K for submit@debbugs.gnu.org; Sat, 21 Jul 2018 08:42:22 -0400 Received: from limerock04.mail.cornell.edu ([128.84.13.244]:59634) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fgrDI-0002C0-FN for 32230@debbugs.gnu.org; Sat, 21 Jul 2018 08:42:20 -0400 X-CornellRouted: This message has been Routed already. Received: from authusersmtp.mail.cornell.edu (granite4.serverfarm.cornell.edu [10.16.197.9]) by limerock04.mail.cornell.edu (8.14.4/8.14.4_cu) with ESMTP id w6LCgCSm022402; Sat, 21 Jul 2018 08:42:12 -0400 Received: from [192.168.0.15] (mta-68-175-129-7.twcny.rr.com [68.175.129.7] (may be forged)) (authenticated bits=0) by authusersmtp.mail.cornell.edu (8.14.4/8.12.10) with ESMTP id w6LCgAbY013580 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NOT); Sat, 21 Jul 2018 08:42:11 -0400 References: <2d9037f1-e52f-f3ca-7c53-e203ea6ae520@cornell.edu> <83fu0dyt9r.fsf@gnu.org> <83effxyrqg.fsf@gnu.org> From: Ken Brown Message-ID: <98054dba-8229-9625-d02a-af7fbd06a9d7@cornell.edu> Date: Sat, 21 Jul 2018 08:42:09 -0400 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <83effxyrqg.fsf@gnu.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-PMX-Cornell-Gauge: Gauge=XXXXX X-PMX-CORNELL-AUTH-RESULTS: dkim-out=none; X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) On 7/21/2018 3:26 AM, Eli Zaretskii wrote: >> Date: Sat, 21 Jul 2018 09:53:04 +0300 >> From: Eli Zaretskii >> Cc: 32230@debbugs.gnu.org, eggert@cs.ucla.edu >> >> But do you understand why it says "between 5 and 8 bytes"? The >> corresponding argument to snprintf is either 4 or 6, so it should be >> between 5 and 7. Where could the extra byte come from? Is that >> because glyphless.ch is a 25-bit field? Yes. Changing the field size to 24 silences the warning. > I meant sprintf, of course. And if the above is the reason, then > perhaps using something like > > (unsigned int) glyph->u.glyphless.ch & 0xffffff > > is a cleaner solution (assuming it shuts up the warning)? Yes, it does shut up the warning. Thanks, I'll make that change. I assume it should go to master, or would you rather have it in the emacs-26 branch? Ken From unknown Mon Aug 18 09:02:12 2025 X-Loop: help-debbugs@gnu.org Subject: bug#32230: 27.0.50; GCC 7 warning due to -Wformat-overflow Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 21 Jul 2018 12:48:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 32230 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Ken Brown Cc: 32230@debbugs.gnu.org, eggert@cs.ucla.edu Received: via spool by 32230-submit@debbugs.gnu.org id=B32230.153217727916663 (code B ref 32230); Sat, 21 Jul 2018 12:48:02 +0000 Received: (at 32230) by debbugs.gnu.org; 21 Jul 2018 12:47:59 +0000 Received: from localhost ([127.0.0.1]:50323 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fgrIh-0004Kb-Hk for submit@debbugs.gnu.org; Sat, 21 Jul 2018 08:47:59 -0400 Received: from eggs.gnu.org ([208.118.235.92]:39815) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fgrIf-0004FJ-3t for 32230@debbugs.gnu.org; Sat, 21 Jul 2018 08:47:53 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fgrIZ-0007HB-2K for 32230@debbugs.gnu.org; Sat, 21 Jul 2018 08:47:47 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:60592) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fgrIV-0007FC-6X; Sat, 21 Jul 2018 08:47:43 -0400 Received: from [176.228.60.248] (port=2501 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1fgrIT-0004Be-3y; Sat, 21 Jul 2018 08:47:42 -0400 Date: Sat, 21 Jul 2018 15:47:43 +0300 Message-Id: <83r2jwycuo.fsf@gnu.org> From: Eli Zaretskii In-reply-to: <98054dba-8229-9625-d02a-af7fbd06a9d7@cornell.edu> (message from Ken Brown on Sat, 21 Jul 2018 08:42:09 -0400) References: <2d9037f1-e52f-f3ca-7c53-e203ea6ae520@cornell.edu> <83fu0dyt9r.fsf@gnu.org> <83effxyrqg.fsf@gnu.org> <98054dba-8229-9625-d02a-af7fbd06a9d7@cornell.edu> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -6.0 (------) > Cc: 32230@debbugs.gnu.org, eggert@cs.ucla.edu > From: Ken Brown > Date: Sat, 21 Jul 2018 08:42:09 -0400 > > > I meant sprintf, of course. And if the above is the reason, then > > perhaps using something like > > > > (unsigned int) glyph->u.glyphless.ch & 0xffffff > > > > is a cleaner solution (assuming it shuts up the warning)? > > Yes, it does shut up the warning. Thanks, I'll make that change. I > assume it should go to master, or would you rather have it in the > emacs-26 branch? I think it should go to master, thanks. From unknown Mon Aug 18 09:02:12 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Ken Brown Subject: bug#32230: closed (Re: bug#32230: 27.0.50; GCC 7 warning due to -Wformat-overflow) Message-ID: References: <9acc9617-1a8c-43c1-29ee-d3510ab1ebbb@cornell.edu> <2d9037f1-e52f-f3ca-7c53-e203ea6ae520@cornell.edu> X-Gnu-PR-Message: they-closed 32230 X-Gnu-PR-Package: emacs Reply-To: 32230@debbugs.gnu.org Date: Sat, 21 Jul 2018 16:27:02 +0000 Content-Type: multipart/mixed; boundary="----------=_1532190422-4475-1" This is a multi-part message in MIME format... ------------=_1532190422-4475-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #32230: 27.0.50; GCC 7 warning due to -Wformat-overflow which was filed against the emacs package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 32230@debbugs.gnu.org. --=20 32230: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D32230 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1532190422-4475-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 32230-done) by debbugs.gnu.org; 21 Jul 2018 16:27:01 +0000 Received: from localhost ([127.0.0.1]:51246 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fguij-00019t-1J for submit@debbugs.gnu.org; Sat, 21 Jul 2018 12:27:01 -0400 Received: from limerock01.mail.cornell.edu ([128.84.13.241]:42994) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fguif-00019U-H7 for 32230-done@debbugs.gnu.org; Sat, 21 Jul 2018 12:26:57 -0400 X-CornellRouted: This message has been Routed already. Received: from authusersmtp.mail.cornell.edu (granite3.serverfarm.cornell.edu [10.16.197.8]) by limerock01.mail.cornell.edu (8.14.4/8.14.4_cu) with ESMTP id w6LGQixw025025; Sat, 21 Jul 2018 12:26:44 -0400 Received: from [192.168.0.15] (mta-68-175-129-7.twcny.rr.com [68.175.129.7] (may be forged)) (authenticated bits=0) by authusersmtp.mail.cornell.edu (8.14.4/8.12.10) with ESMTP id w6LGQgT4021980 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NOT); Sat, 21 Jul 2018 12:26:43 -0400 Subject: Re: bug#32230: 27.0.50; GCC 7 warning due to -Wformat-overflow To: Eli Zaretskii References: <2d9037f1-e52f-f3ca-7c53-e203ea6ae520@cornell.edu> <83fu0dyt9r.fsf@gnu.org> <83effxyrqg.fsf@gnu.org> <98054dba-8229-9625-d02a-af7fbd06a9d7@cornell.edu> <83r2jwycuo.fsf@gnu.org> From: Ken Brown Message-ID: <9acc9617-1a8c-43c1-29ee-d3510ab1ebbb@cornell.edu> Date: Sat, 21 Jul 2018 12:26:41 -0400 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <83r2jwycuo.fsf@gnu.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-PMX-Cornell-Gauge: Gauge=XXXXX X-PMX-CORNELL-AUTH-RESULTS: dkim-out=none; X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 32230-done Cc: 32230-done@debbugs.gnu.org, eggert@cs.ucla.edu X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) On 7/21/2018 8:47 AM, Eli Zaretskii wrote: > I think it should go to master, thanks. Done, as commit f3f67cf. But I forgot to reference the bug number in the commit message. I guess there's no way to fix that, except to edit ChangeLog.3. Sorry. Ken ------------=_1532190422-4475-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 20 Jul 2018 22:02:23 +0000 Received: from localhost ([127.0.0.1]:50043 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fgdTi-0000dB-O1 for submit@debbugs.gnu.org; Fri, 20 Jul 2018 18:02:22 -0400 Received: from eggs.gnu.org ([208.118.235.92]:55309) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fgdTg-0000cv-E0 for submit@debbugs.gnu.org; Fri, 20 Jul 2018 18:02:20 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fgdTa-0008JR-Ft for submit@debbugs.gnu.org; Fri, 20 Jul 2018 18:02:15 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-0.0 required=5.0 tests=BAYES_20 autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:41514) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1fgdTa-0008JL-Bs for submit@debbugs.gnu.org; Fri, 20 Jul 2018 18:02:14 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:46280) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fgdTZ-0005F2-Cd for bug-gnu-emacs@gnu.org; Fri, 20 Jul 2018 18:02:14 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fgdTW-0008HX-Ar for bug-gnu-emacs@gnu.org; Fri, 20 Jul 2018 18:02:13 -0400 Received: from limerock02.mail.cornell.edu ([128.84.13.242]:52661) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fgdTW-0008HJ-5V for bug-gnu-emacs@gnu.org; Fri, 20 Jul 2018 18:02:10 -0400 X-CornellRouted: This message has been Routed already. Received: from authusersmtp.mail.cornell.edu (granite4.serverfarm.cornell.edu [10.16.197.9]) by limerock02.mail.cornell.edu (8.14.4/8.14.4_cu) with ESMTP id w6KM28Rr002530 for ; Fri, 20 Jul 2018 18:02:09 -0400 Received: from [192.168.0.15] (mta-68-175-129-7.twcny.rr.com [68.175.129.7] (may be forged)) (authenticated bits=0) by authusersmtp.mail.cornell.edu (8.14.4/8.12.10) with ESMTP id w6KM27vB017201 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NOT) for ; Fri, 20 Jul 2018 18:02:08 -0400 To: bug-gnu-emacs@gnu.org Subject: 27.0.50; GCC 7 warning due to -Wformat-overflow X-Debbugs-Cc: Paul Eggert From: Ken Brown Message-ID: <2d9037f1-e52f-f3ca-7c53-e203ea6ae520@cornell.edu> Date: Fri, 20 Jul 2018 18:02:07 -0400 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US X-PMX-Cornell-Gauge: Gauge=XXXXX X-PMX-CORNELL-AUTH-RESULTS: dkim-out=none; Content-Transfer-Encoding: quoted-printable X-MIME-Autoconverted: from 8bit to quoted-printable by limerock02.mail.cornell.edu id w6KM28Rr002530 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x [fuzzy] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.3 (----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.3 (-----) The Cygwin-w32 build has turned up another GCC 7 warning: ../../master/src/w32term.c: In function =E2=80=98x_draw_glyph_string=E2=80= =99: ../../master/src/w32term.c:1477:27: warning: =E2=80=98__builtin___sprintf= _chk=E2=80=99=20 may write a terminating nul past the end of the destination=20 [-Wformat-overflow=3D] sprintf ((char *) buf, "%0*X", ^ ../../master/src/w32term.c:1477:4: note: =E2=80=98__builtin___sprintf_chk= =E2=80=99=20 output between 5 and 8 bytes into a destination of size 7 sprintf ((char *) buf, "%0*X", ^ The method that Paul used in bug#32189 could be used here too, but I'm not sure it's worth the trouble. My inclination is to just increase the buffer size from 7 to 8. Ken ------------=_1532190422-4475-1-- From unknown Mon Aug 18 09:02:12 2025 X-Loop: help-debbugs@gnu.org Subject: bug#32230: 27.0.50; GCC 7 warning due to -Wformat-overflow Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 21 Jul 2018 16:41:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 32230 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Ken Brown Cc: 32230@debbugs.gnu.org, eggert@cs.ucla.edu Received: via spool by 32230-submit@debbugs.gnu.org id=B32230.15321912205738 (code B ref 32230); Sat, 21 Jul 2018 16:41:01 +0000 Received: (at 32230) by debbugs.gnu.org; 21 Jul 2018 16:40:20 +0000 Received: from localhost ([127.0.0.1]:51257 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fguvb-0001UU-Oz for submit@debbugs.gnu.org; Sat, 21 Jul 2018 12:40:19 -0400 Received: from eggs.gnu.org ([208.118.235.92]:45464) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fguvZ-0001UH-Vw for 32230@debbugs.gnu.org; Sat, 21 Jul 2018 12:40:18 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fguvT-0005yj-Tj for 32230@debbugs.gnu.org; Sat, 21 Jul 2018 12:40:12 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:35029) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fguvP-0005sR-O1; Sat, 21 Jul 2018 12:40:07 -0400 Received: from [176.228.60.248] (port=1025 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1fguvO-0007xp-VH; Sat, 21 Jul 2018 12:40:07 -0400 Date: Sat, 21 Jul 2018 19:40:08 +0300 Message-Id: <83fu0cy23b.fsf@gnu.org> From: Eli Zaretskii In-reply-to: <9acc9617-1a8c-43c1-29ee-d3510ab1ebbb@cornell.edu> (message from Ken Brown on Sat, 21 Jul 2018 12:26:41 -0400) References: <2d9037f1-e52f-f3ca-7c53-e203ea6ae520@cornell.edu> <83fu0dyt9r.fsf@gnu.org> <83effxyrqg.fsf@gnu.org> <98054dba-8229-9625-d02a-af7fbd06a9d7@cornell.edu> <83r2jwycuo.fsf@gnu.org> <9acc9617-1a8c-43c1-29ee-d3510ab1ebbb@cornell.edu> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -6.0 (------) > Cc: 32230-done@debbugs.gnu.org, eggert@cs.ucla.edu > From: Ken Brown > Date: Sat, 21 Jul 2018 12:26:41 -0400 > > Done, as commit f3f67cf. But I forgot to reference the bug number in > the commit message. Happens to me as well. > I guess there's no way to fix that, except to edit ChangeLog.3. > Sorry. No sweat.