GNU bug report logs - #32230
27.0.50; GCC 7 warning due to -Wformat-overflow

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 32230 in the body.
You can then email your comments to 32230 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Ken Brown <kbrown <at> cornell.edu>
To: bug-gnu-emacs <at> gnu.org
Subject: 27.0.50; GCC 7 warning due to -Wformat-overflow
Date: Fri, 20 Jul 2018 18:02:07 -0400

The Cygwin-w32 build has turned up another GCC 7 warning:

../../master/src/w32term.c: In function ‘x_draw_glyph_string’:
../../master/src/w32term.c:1477:27: warning: ‘__builtin___sprintf_chk’ 
may write a terminating nul past the end of the destination 
[-Wformat-overflow=]
    sprintf ((char *) buf, "%0*X",
                           ^
../../master/src/w32term.c:1477:4: note: ‘__builtin___sprintf_chk’ 
output between 5 and 8 bytes into a destination of size 7
    sprintf ((char *) buf, "%0*X",
    ^
The method that Paul used in bug#32189 could be used here too, but I'm
not sure it's worth the trouble.  My inclination is to just increase the
buffer size from 7 to 8.

Ken

Message #8 received at 32230 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Ken Brown <kbrown <at> cornell.edu>
Cc: 32230 <at> debbugs.gnu.org, eggert <at> cs.ucla.edu
Subject: Re: bug#32230: 27.0.50; GCC 7 warning due to -Wformat-overflow
Date: Sat, 21 Jul 2018 09:53:04 +0300

> From: Ken Brown <kbrown <at> cornell.edu>
> Date: Fri, 20 Jul 2018 18:02:07 -0400
> Cc: Paul Eggert <eggert <at> cs.ucla.edu>
> 
> The Cygwin-w32 build has turned up another GCC 7 warning:
> 
> ../../master/src/w32term.c: In function ‘x_draw_glyph_string’:
> ../../master/src/w32term.c:1477:27: warning: ‘__builtin___sprintf_chk’ 
> may write a terminating nul past the end of the destination 
> [-Wformat-overflow=]
>      sprintf ((char *) buf, "%0*X",
>                             ^
> ../../master/src/w32term.c:1477:4: note: ‘__builtin___sprintf_chk’ 
> output between 5 and 8 bytes into a destination of size 7
>      sprintf ((char *) buf, "%0*X",
>      ^
> The method that Paul used in bug#32189 could be used here too, but I'm
> not sure it's worth the trouble.  My inclination is to just increase the
> buffer size from 7 to 8.

Yes, with a comment explaining why 8.

But do you understand why it says "between 5 and 8 bytes"?  The
corresponding argument to snprintf is either 4 or 6, so it should be
between 5 and 7.  Where could the extra byte come from?  Is that
because glyphless.ch is a 25-bit field?

Message #11 received at 32230 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: kbrown <at> cornell.edu
Cc: 32230 <at> debbugs.gnu.org, eggert <at> cs.ucla.edu
Subject: Re: bug#32230: 27.0.50; GCC 7 warning due to -Wformat-overflow
Date: Sat, 21 Jul 2018 10:26:15 +0300

> Date: Sat, 21 Jul 2018 09:53:04 +0300
> From: Eli Zaretskii <eliz <at> gnu.org>
> Cc: 32230 <at> debbugs.gnu.org, eggert <at> cs.ucla.edu
> 
> But do you understand why it says "between 5 and 8 bytes"?  The
> corresponding argument to snprintf is either 4 or 6, so it should be
> between 5 and 7.  Where could the extra byte come from?  Is that
> because glyphless.ch is a 25-bit field?

I meant sprintf, of course.  And if the above is the reason, then
perhaps using something like

  (unsigned int) glyph->u.glyphless.ch & 0xffffff

is a cleaner solution (assuming it shuts up the warning)?

Message #14 received at 32230 <at> debbugs.gnu.org (full text, mbox):

From: Ken Brown <kbrown <at> cornell.edu>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 32230 <at> debbugs.gnu.org, eggert <at> cs.ucla.edu
Subject: Re: bug#32230: 27.0.50; GCC 7 warning due to -Wformat-overflow
Date: Sat, 21 Jul 2018 08:42:09 -0400

On 7/21/2018 3:26 AM, Eli Zaretskii wrote:
>> Date: Sat, 21 Jul 2018 09:53:04 +0300
>> From: Eli Zaretskii <eliz <at> gnu.org>
>> Cc: 32230 <at> debbugs.gnu.org, eggert <at> cs.ucla.edu
>>
>> But do you understand why it says "between 5 and 8 bytes"?  The
>> corresponding argument to snprintf is either 4 or 6, so it should be
>> between 5 and 7.  Where could the extra byte come from?  Is that
>> because glyphless.ch is a 25-bit field?

Yes.  Changing the field size to 24 silences the warning.

> I meant sprintf, of course.  And if the above is the reason, then
> perhaps using something like
> 
>    (unsigned int) glyph->u.glyphless.ch & 0xffffff
> 
> is a cleaner solution (assuming it shuts up the warning)?

Yes, it does shut up the warning.  Thanks, I'll make that change.  I 
assume it should go to master, or would you rather have it in the 
emacs-26 branch?

Ken

Message #17 received at 32230 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Ken Brown <kbrown <at> cornell.edu>
Cc: 32230 <at> debbugs.gnu.org, eggert <at> cs.ucla.edu
Subject: Re: bug#32230: 27.0.50; GCC 7 warning due to -Wformat-overflow
Date: Sat, 21 Jul 2018 15:47:43 +0300

> Cc: 32230 <at> debbugs.gnu.org, eggert <at> cs.ucla.edu
> From: Ken Brown <kbrown <at> cornell.edu>
> Date: Sat, 21 Jul 2018 08:42:09 -0400
> 
> > I meant sprintf, of course.  And if the above is the reason, then
> > perhaps using something like
> > 
> >    (unsigned int) glyph->u.glyphless.ch & 0xffffff
> > 
> > is a cleaner solution (assuming it shuts up the warning)?
> 
> Yes, it does shut up the warning.  Thanks, I'll make that change.  I 
> assume it should go to master, or would you rather have it in the 
> emacs-26 branch?

I think it should go to master, thanks.

Message #22 received at 32230-done <at> debbugs.gnu.org (full text, mbox):

From: Ken Brown <kbrown <at> cornell.edu>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 32230-done <at> debbugs.gnu.org, eggert <at> cs.ucla.edu
Subject: Re: bug#32230: 27.0.50; GCC 7 warning due to -Wformat-overflow
Date: Sat, 21 Jul 2018 12:26:41 -0400

On 7/21/2018 8:47 AM, Eli Zaretskii wrote:
> I think it should go to master, thanks.

Done, as commit f3f67cf.  But I forgot to reference the bug number in 
the commit message.  I guess there's no way to fix that, except to edit 
ChangeLog.3.  Sorry.

Ken

Message #25 received at 32230 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Ken Brown <kbrown <at> cornell.edu>
Cc: 32230 <at> debbugs.gnu.org, eggert <at> cs.ucla.edu
Subject: Re: bug#32230: 27.0.50; GCC 7 warning due to -Wformat-overflow
Date: Sat, 21 Jul 2018 19:40:08 +0300

> Cc: 32230-done <at> debbugs.gnu.org, eggert <at> cs.ucla.edu
> From: Ken Brown <kbrown <at> cornell.edu>
> Date: Sat, 21 Jul 2018 12:26:41 -0400
> 
> Done, as commit f3f67cf.  But I forgot to reference the bug number in 
> the commit message.

Happens to me as well.

> I guess there's no way to fix that, except to edit ChangeLog.3.
> Sorry.

No sweat.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.