GNU bug report logs - #32225
27.0.50; [PATCH] avoid calling vc backend if vc-display-status is nil

Previous Next

Package: emacs;

Reported by: Andy Moreton <andrewjmoreton <at> gmail.com>

Date: Fri, 20 Jul 2018 16:46:01 UTC

Severity: normal

Tags: patch

Found in version 27.0.50

Done: Eli Zaretskii <eliz <at> gnu.org>

Bug is archived. No further changes may be made.

Full log


Message #11 received at 32225 <at> debbugs.gnu.org (full text, mbox):

From: Dmitry Gutov <dgutov <at> yandex.ru>
To: Eli Zaretskii <eliz <at> gnu.org>, Andy Moreton <andrewjmoreton <at> gmail.com>
Cc: 32225 <at> debbugs.gnu.org
Subject: Re: bug#32225: 27.0.50; [PATCH] avoid calling vc backend if
 vc-display-status is nil
Date: Sat, 28 Jul 2018 13:04:23 +0300
On 7/27/18 10:07 AM, Eli Zaretskii wrote:
>> From: Andy Moreton <andrewjmoreton <at> gmail.com>
>> Date: Fri, 20 Jul 2018 17:45:09 +0100
>>
>> If the user sets `vc-display-status' to nil then the VC backend is still
>> called to get a revision number, even though it will not be displayed.
>>
>> The following patch avoids this unneeded work.
>>
>>
>> Do not call VC backend to update mode line if vc-display-status is nil
>>
>> 2018-07-20  Andy Moreton  <andrewjmoreton <at> gmail.com>
>>
>> 	* lisp/vc/vc-hooks.el (vc-mode-line): Avoid calling VC backend if
>> 	vc-display-status is nil.
> 
> LGTM, please push to the master branch.

+1




This bug report was last modified 6 years and 286 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.