GNU bug report logs - #32214
[PATCH] 'message-kill-buffer': fix backup delete question

Previous Next

Full log

Message #17 received at 32214 <at> debbugs.gnu.org (full text, mbox):

From: Sven Willner <sven.willner <at> gmail.com>
To: Robert Pluim <rpluim <at> gmail.com>
Cc: 32214 <at> debbugs.gnu.org
Subject: Re: bug#32214: [PATCH] 'message-kill-buffer': fix backup delete
 question
Date: Thu, 19 Jul 2018 19:16:06 +0200

[Message part 1 (text/plain, inline)]

good idea!

have incorporated that in the appended patch.
also, the 'when' part should only include the actual deletion of 
the backup file
>  	(ignore-errors
>  	  (delete-file auto-save-file-name))
rather than also draft diassociation
>  	(let ((message-draft-article draft-article))
>  	  (message-disassociate-draft)))
also fixed in the updated patch.

Sven

[0001-message-kill-buffer-fix-backup-delete-question.patch (text/x-diff, attachment)]

[Message part 3 (text/plain, inline)]

Robert Pluim <rpluim <at> gmail.com> writes:

> Sven Willner <sven.willner <at> gmail.com> writes:
>
>>  	(ignore-errors
>>  	  (delete-file auto-save-file-name))
>>  	(let ((message-draft-article draft-article))
>>  	  (message-disassociate-draft)))
>> + (when (and (and auto-save-file-name
>> + (file-exists-p auto-save-file-name))
>> + (and file-name
>> + (file-exists-p file-name))
>
> (when (and auto-save-file-name
>            (file-exists-p auto-save-file-name)
>            file-name
>            (file-exists-p file-name))
>
> perhaps? You could even drop the 'when'.
>
> Robert

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.