GNU bug report logs - #32212
26; `subword-mode' doc string shows empty key-binding list

Previous Next

Full log

Message #23 received at control <at> debbugs.gnu.org (full text, mbox):

From: Noam Postavsky <npostavs <at> gmail.com>
To: Stephen Berman <stephen.berman <at> gmx.net>
Cc: Eli Zaretskii <eliz <at> gnu.org>, 32212 <at> debbugs.gnu.org
Subject: Re: bug#32212: 26;
 `subword-mode' doc string shows empty key-binding list
Date: Sun, 22 Jul 2018 16:22:51 -0400

[Message part 1 (text/plain, inline)]

tags 32212 + patch
quit

Stephen Berman <stephen.berman <at> gmx.net> writes:

> Maybe due to this change:

>  (defvar subword-mode-map
> -  (let ((map (make-sparse-keymap)))
> -    (dolist (cmd '(forward-word backward-word mark-word kill-word
> -				backward-kill-word transpose-words
> -                                capitalize-word upcase-word downcase-word
> -                                left-word right-word))
> -      (let ((othercmd (let ((name (symbol-name cmd)))
> -                        (string-match "\\([[:alpha:]-]+\\)-word[s]?" name)
> -                        (intern (concat "subword-" (match-string 1 name))))))
> -        (define-key map (vector 'remap cmd) othercmd)))
> -    map)
> +  ;; We originally remapped motion keys here, but now use Emacs core
> +  ;; hooks.  Leave this keymap around so that user additions to it
> +  ;; keep working.
> +  (make-sparse-keymap)

Aha, then we should just remove it from the docstring, right?

[0001-Omit-keymap-from-subword-mode-docstring-Bug-32212.patch (text/x-diff, inline)]

From 6fd80dcf0fc6261de80c130fb535ad334858cbf3 Mon Sep 17 00:00:00 2001
From: Noam Postavsky <npostavs <at> gmail.com>
Date: Sun, 22 Jul 2018 16:15:43 -0400
Subject: [PATCH] Omit keymap from subword-mode docstring (Bug#32212)

* lisp/progmodes/subword.el (subword-mode): Remove listing of
subword-mode-map bindings, since it is empty as of 2014-03-23 "Merge
capitalized-words-mode and subword-mode".
---
 lisp/progmodes/subword.el | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/lisp/progmodes/subword.el b/lisp/progmodes/subword.el
index cbaa273a7a..c09ba37c85 100644
--- a/lisp/progmodes/subword.el
+++ b/lisp/progmodes/subword.el
@@ -113,9 +113,7 @@ subword-mode
   NSGraphicsContext  =>  \"NS\", \"Graphics\" and \"Context\"
 
 This mode changes the definition of a word so that word commands
-treat nomenclature boundaries as word boundaries.
-
-\\{subword-mode-map}"
+treat nomenclature boundaries as word boundaries."
     :lighter " ,"
     (when subword-mode (superword-mode -1))
     (subword-setup-buffer))
-- 
2.11.0

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.