From unknown Sun Jun 22 04:15:50 2025 X-Loop: help-debbugs@gnu.org Subject: bug#32201: 27.0.50; setenv should not change match-data Resent-From: John Shahid Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 18 Jul 2018 19:20:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 32201 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 32201@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.153194154418543 (code B ref -1); Wed, 18 Jul 2018 19:20:01 +0000 Received: (at submit) by debbugs.gnu.org; 18 Jul 2018 19:19:04 +0000 Received: from localhost ([127.0.0.1]:47180 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ffrya-0004p1-0X for submit@debbugs.gnu.org; Wed, 18 Jul 2018 15:19:04 -0400 Received: from eggs.gnu.org ([208.118.235.92]:52449) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ffryY-0004oV-7O for submit@debbugs.gnu.org; Wed, 18 Jul 2018 15:19:02 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ffryR-0008Vk-I5 for submit@debbugs.gnu.org; Wed, 18 Jul 2018 15:18:57 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,FREEMAIL_FROM, T_DKIM_INVALID autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:40017) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1ffryR-0008Ve-EG for submit@debbugs.gnu.org; Wed, 18 Jul 2018 15:18:55 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:43413) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ffryP-0004OR-KZ for bug-gnu-emacs@gnu.org; Wed, 18 Jul 2018 15:18:55 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ffryM-0008PS-Ba for bug-gnu-emacs@gnu.org; Wed, 18 Jul 2018 15:18:53 -0400 Received: from mail-qt0-x233.google.com ([2607:f8b0:400d:c0d::233]:44127) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1ffryM-0008Oz-4s for bug-gnu-emacs@gnu.org; Wed, 18 Jul 2018 15:18:50 -0400 Received: by mail-qt0-x233.google.com with SMTP id b15-v6so5066781qtp.11 for ; Wed, 18 Jul 2018 12:18:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:subject:date:message-id:mime-version; bh=gpWW/fL+NmvBs5wrA60baGEtZiNnLcGd3t+aF8ufeH0=; b=PUVHyarXtEbbDa8IJEfFoKLJt3P6X0KGMLwRUtBaUPM5D/wnoEkzo5fXNAqT7TEv6L Tam6eHDR3y0J4yR2xoYc/iHNT0Ep1sSQcwrFK3cSBL1g2zE64Xif/Um+5qb6mdgWnGjO DeMd/foCoTjTHUKQJUf8fo+By/jvjmhGZRB9LxeSaVPIE1YuxGL8zneDQc1rqOWYL+hP 71msc5Z3okbDxHWB4oUeX6mA0eoKvOf1ZialDJTUKVMbUEvKqeBVwpMrXWBTGhFqHtQ1 PyZOmUwmGh/aeDd4YWlVsNvxJL/j4FsDEaV0rjmfvdDjji4VnwSj9EOW+sXBZkcJ07mO fIQQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:mime-version; bh=gpWW/fL+NmvBs5wrA60baGEtZiNnLcGd3t+aF8ufeH0=; b=L3LlAlbdw7U6sf9+xKFxbt5e5kVaXIgNw0wmiBVpLJ6eV9lgPvQPQ5yPVlKgWmOIA6 RbMafqLYJL7ZIWc3qBZtMOKzwLesrUNbUZiSMJ3UAVyZD79ipql1wEpc8+Nsv4hAmwVJ L4QQF0kfX56+Q3dJDV5xoNaQwjoWTPSupumh90sx7mGzwAbD2I2toDOy8BO760qpXH69 +eXzRoF2NJSVICQYcWXeMyHlMNJZ3J9eHuEORWZnshlQ2+Ok6sn5Jg/CuQe63EztXNjW 1Q/typlOeioXbw/U/4cv3BpNTjDqY3nqGGWd8W6FjbFA45kAHEPUYWl6+8pubOzDNiy2 f8Mw== X-Gm-Message-State: AOUpUlHrqn7JVYY5a2Pd0uWTvku1cHiAlR3RXo3a5xIKUo/H+aJG1boh bxsaULNVfbY0bKid1aZEnqGYYk+6 X-Google-Smtp-Source: AAOMgpfqNZS14zDefNs+ta6MLPUFpoRc9bxgAwpUu2fYTeMWrmFtPWFMjXBLX/b98XlK+As3xSN5UA== X-Received: by 2002:a0c:df91:: with SMTP id w17-v6mr7920737qvl.39.1531941529074; Wed, 18 Jul 2018 12:18:49 -0700 (PDT) Received: from 8a803f88ebe0 (cpe-184-152-55-93.nyc.res.rr.com. [184.152.55.93]) by smtp.gmail.com with ESMTPSA id f17-v6sm2577068qtp.1.2018.07.18.12.18.47 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 18 Jul 2018 12:18:48 -0700 (PDT) From: John Shahid Date: Wed, 18 Jul 2018 19:18:33 +0000 Message-ID: <87h8kwe4ja.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.0 (----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) I have been running into a weird issue lately due to a 'buffer-list-update-hook' that I added in my init.el file. The hook is shown below: (add-hook 'buffer-list-update-hook (lambda () (when (equal major-mode 'go-mode) (unless (boundp 'gopath) (if-let ((root (locate-dominating-file buffer-file-name ".envrc"))) (setq-local gopath (expand-file-name root)) (setq-local gopath nil))) (and gopath (save-match-data (setenv "GOPATH" gopath)))))) The idea of this hook is to set some env variable based on the current buffer. Changing process-environment isn't sufficient since some minor modes I'm using start processes in separate buffers. The problem seems to happen when all of the suddent 'find-file' will start openning weird files. For example, if I'm currently viewing "~/foo/bar.txt" and use 'C-x C-f' the default file name will be "~/foo/~jvshahid/foo/bar.txt". After some debugging it turns out that the following will happen which cause the match-data to be corrupted: 1. find-file calls abbreviate-file-name 2. abbreviate-file-name calls (expand-file-name "~") 3. expand-file-name runs the buffer-list-update-hook (unknown why) 4. the hook will use setenv which messes up the match-data 5. abbreviate-file-name resumes and use the incorrect match-data and return an invalid path I don't know why '3' is happening. This usually doesn't happen in a new Emacs session, only randomly after using Emacs for a while. May be it has something to do with file name handlers, the debugger doesn't show any function calls between 'expand-file-name' and 'run-hooks(buffer-list-update-hook)'. I also used '(find-file-name-handler default-directory 'expand-file-name)' but got back nil. Usually Emacs gets in a weird state at this point and things like 'buffer-list' starts throwing errors about 'max-lisp-eval-depth'. I usually have to set 'buffer-list-update-hook' to 'nil' before being able to gain control. It is worth noting that I saw around 1000 *code-conversion-work* buffers in my Emacs session. In GNU Emacs 27.0.50 (build 1, x86_64-pc-linux-gnu) of 2018-07-03 built on f388f63bdd5d Repository revision: 893e62ee7e3630c981adb3efa39ef409500d7657 System Description: Ubuntu 16.04.4 LTS Recent messages: Quit [2 times] [mu4e] Started mu4e with 14071 messages in store [mu4e] Contacts received: 4758 [mu4e] Found 327 matching messages Mark saved where search started [mu4e] Include-related turned off [mu4e] Found 471 matching messages Mark set Quit [2 times] Making completion list... Configured using: 'configure --without-x' Configured features: SOUND NOTIFY GNUTLS LIBXML2 ZLIB THREADS Important settings: value of $LANG: en_US.UTF-8 locale-coding-system: utf-8-unix Major mode: mu4e-headers Minor modes in effect: hl-line-mode: t global-auto-complete-mode: t global-display-line-numbers-mode: t show-paren-mode: t display-time-mode: t display-battery-mode: t global-auto-revert-mode: t xterm-mouse-mode: t winner-mode: t flx-ido-mode: t straight-use-package-mode: t straight-package-neutering-mode: t tooltip-mode: t global-eldoc-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t buffer-read-only: t column-number-mode: t line-number-mode: t transient-mark-mode: t Load-path shadows: /home/jvshahid/.emacs.d/straight/build/seq/seq hides /usr/local/share/emacs/27.0.50/lisp/emacs-lisp/seq /home/jvshahid/.emacs.d/straight/build/cl-lib/cl-lib hides /usr/local/share/emacs/27.0.50/lisp/emacs-lisp/cl-lib Features: (shadow sort mail-extr emacsbug misearch multi-isearch org-mu4e org-element avl-tree generator org org-macro org-footnote org-pcomplete pcomplete org-list org-faces org-entities noutline outline easy-mmode org-version ob-emacs-lisp ob ob-tangle org-src ob-ref ob-lob ob-table ob-keys ob-exp ob-comint ob-core ob-eval org-compat org-macs org-loaddefs mu4e desktop frameset mu4e-speedbar speedbar sb-image ezimage dframe mu4e-main mu4e-view cal-menu calendar cal-loaddefs browse-url gnus-art mm-uu mml2015 mm-view mml-smime smime dig mailcap gnus-sum gnus-group gnus-undo gnus-start gnus-cloud nnimap nnmail mail-source utf7 netrc nnoo parse-time gnus-spec gnus-int gnus-range gnus-win gnus nnheader wid-edit mu4e-headers mu4e-compose mu4e-context mu4e-draft mu4e-actions rfc2368 smtpmail auth-source eieio eieio-core eieio-loaddefs sendmail mu4e-mark mu4e-message flow-fill mu4e-proc mu4e-utils doc-view jka-compr image-mode mu4e-lists mu4e-vars message rmc puny format-spec rfc822 mml mml-sec password-cache epa derived epg epg-config gnus-util rmail rmail-loaddefs mm-decode mm-bodies mm-encode mail-parse rfc2231 rfc2047 rfc2045 mm-util ietf-drums mail-prsvr mailabbrev mail-utils gmm-utils mailheader hl-line fringe cl mu4e-meta term/screen term/xterm xterm dired-aux server cl-seq parinfer-ext paredit parinfer ediff-merg ediff-wind ediff-diff ediff-mult ediff-help ediff-init ediff-util ediff mode-local parinferlib flycheck json map find-func rx dash flymake-proc flymake mwheel compile comint regexp-opt ansi-color warnings thingatpt auto-complete-config auto-complete popup elec-pair rect dired-x dired dired-loaddefs display-line-numbers time-date paren time image battery cus-start cus-load autorevert filenotify xt-mouse edmacro kmacro winner ring flx-ido advice flx ido seq seq-25 byte-opt edit-indirect-autoloads parinfer-autoloads ginkgo-mode-autoloads pianobar-autoloads concourse-mode-autoloads hierarchy-autoloads company-lsp-autoloads company-autoloads lsp-ui-autoloads dash-functional-autoloads lsp-java-autoloads lsp-mode-autoloads flx-ido-autoloads flx-autoloads wgrep-autoloads ac-cider-autoloads request-autoloads helm-autoloads helm-core-autoloads paredit-autoloads flycheck-clojure-autoloads flycheck-autoloads cider-autoloads sesman-autoloads seq-autoloads spinner-autoloads queue-autoloads clojure-mode-autoloads go-rename-autoloads ace-window-autoloads avy-autoloads dockerfile-mode-autoloads s-autoloads yasnippet-snippets-autoloads yasnippet-autoloads go-autocomplete-autoloads auto-complete-autoloads go-eldoc-autoloads protobuf-mode-autoloads markdown-mode-autoloads go-guru-autoloads yaml-mode-autoloads etags-select-autoloads magit-autoloads magit-popup-autoloads git-commit-autoloads with-editor-autoloads ghub-autoloads dash-autoloads async-autoloads projectile-autoloads pkg-info-autoloads epl-autoloads go-mode-autoloads debbugs-autoloads finder-inf popup-autoloads cl-lib-autoloads straight-autoloads info tool-bar cl-extra help-mode easymenu straight subr-x straight-compat cl-macs gv cl-loaddefs cl-lib bytecomp byte-compile cconv mule-util tooltip eldoc electric uniquify ediff-hook vc-hooks lisp-float-type tabulated-list replace newcomment text-mode elisp-mode lisp-mode prog-mode register page menu-bar rfn-eshadow isearch timer select mouse jit-lock font-lock syntax facemenu font-core term/tty-colors frame cl-generic cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms cp51932 hebrew greek romanian slovak czech european ethiopic indian cyrillic chinese composite charscript charprop case-table epa-hook jka-cmpr-hook help simple abbrev obarray minibuffer cl-preloaded nadvice loaddefs button faces cus-face macroexp files text-properties overlay sha1 md5 base64 format env code-pages mule custom widget hashtable-print-readable backquote inotify multi-tty make-network-process emacs) Memory information: ((conses 16 364700 312163) (symbols 48 41281 1) (miscs 40 121 416) (strings 32 120184 49417) (string-bytes 1 4054304) (vectors 16 40431) (vector-slots 8 802992 291932) (floats 8 332 1307) (intervals 56 4741 8246) (buffers 992 17) (heap 1024 62832 40993)) From unknown Sun Jun 22 04:15:50 2025 X-Loop: help-debbugs@gnu.org Subject: bug#32201: Acknowledgement (27.0.50; setenv should not change match-data) Resent-From: John Shahid Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 18 Jul 2018 19:26:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 32201 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 32201@debbugs.gnu.org Received: via spool by 32201-submit@debbugs.gnu.org id=B32201.153194193619157 (code B ref 32201); Wed, 18 Jul 2018 19:26:02 +0000 Received: (at 32201) by debbugs.gnu.org; 18 Jul 2018 19:25:36 +0000 Received: from localhost ([127.0.0.1]:47185 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ffs4t-0004yv-Us for submit@debbugs.gnu.org; Wed, 18 Jul 2018 15:25:36 -0400 Received: from mail-qt0-f182.google.com ([209.85.216.182]:43131) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ffs4s-0004yj-K7 for 32201@debbugs.gnu.org; Wed, 18 Jul 2018 15:25:34 -0400 Received: by mail-qt0-f182.google.com with SMTP id f18-v6so5079288qtp.10 for <32201@debbugs.gnu.org>; Wed, 18 Jul 2018 12:25:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=references:user-agent:from:to:subject:in-reply-to:date:message-id :mime-version; bh=5wPCen82PnleTTCXt11Y8Lf4BqdxJkipPZDAFHB0BXU=; b=oMKc+m2kHqryUQQUyWBCdSn8SGOKHSq9UX60e4lHcrKOPm0Z7amnoNKwl5pLriWEtq RNiykl79LL/KVcTQt57mylER8vRSTnkBRWe5cCwxpCCUkYYtcFc4gwuIsGjzJprPDAlp zSknKma1mhcQ2awjbyFYRcV8CkukHtszTPk5I91zp+ldYKARJFA4M23UKZv8rU7kr6ux H7vNdtlaZlHvMZsjlMx/xuP+80T7jiV0K0FkIfVVljLrPsG7MabTVJ3dLt0BJKeqAQOn 0hjFCiyrcnD/t5Lrd350nyDJAQOsI2neVpyjj+CqVg5v2DpeEr2eaEHRyCp5htUWusWt 8eZw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:references:user-agent:from:to:subject :in-reply-to:date:message-id:mime-version; bh=5wPCen82PnleTTCXt11Y8Lf4BqdxJkipPZDAFHB0BXU=; b=Pf+3lpFFMpqkwUefn40luPugNyduOh1vjjsrIrGxwvC8BdSv1viiqWxpDz9wEs++ed Y8lEAgbD2IXZDSEXm3TwvBqZTchdM8o6jvzVei92eYsXPC2RYzSIt1NYQ0JUDzKQtwfj l9YLed5loBR4+6DkU2QoIGiQH95LhAGMxdJdk/usxXWVbcnT2z00GuwJDM2RbmScZ6om ZkKJq/d2cnKXvFYhXcrBeDGwtGoLnUJ+0TyF5rPcsmNc293I99Pu9Z5xXo6AoEa0Zlfa o5gmUmpVm0VQm+GHbOhO/d/1HMFSIsYvIqD6e5Bf9N4bRE3JEChUOmqlEYC1MrSUIoST TXHA== X-Gm-Message-State: AOUpUlFpgHlesaVnhESuZDJfvEMxdL9Lm7mm/d4pZKVNjTWLxpd5rIE0 Lr+SzKnQanFT/o0Wq/kLLrZCJk5H X-Google-Smtp-Source: AAOMgpfCi5KD9CYXYgCrcDTPW3CS7uxVPidOm9jqJsMXqM48SiJzm+NZA5ukxBPKmoaIAqhGn2D3lA== X-Received: by 2002:a0c:b495:: with SMTP id c21-v6mr7736557qve.111.1531941928713; Wed, 18 Jul 2018 12:25:28 -0700 (PDT) Received: from 8a803f88ebe0 (cpe-184-152-55-93.nyc.res.rr.com. [184.152.55.93]) by smtp.gmail.com with ESMTPSA id e20-v6sm4614021qkh.32.2018.07.18.12.25.27 for <32201@debbugs.gnu.org> (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 18 Jul 2018 12:25:28 -0700 (PDT) References: <87h8kwe4ja.fsf@gmail.com> User-agent: mu4e 1.1.0; emacs 27.0.50 From: John Shahid In-reply-to: Date: Wed, 18 Jul 2018 19:25:26 +0000 Message-ID: <87fu0ge47t.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) I incorrectly attached a snippet of the hook after I fixed it by wrapping the call to 'setenv' in 'save-match-data'. The previous version that exhibit the problem didn't have 'save-match-data' GNU bug Tracking System writes: > Thank you for filing a new bug report with debbugs.gnu.org. > > This is an automatically generated reply to let you know your message > has been received. > > Your message is being forwarded to the package maintainers and other > interested parties for their attention; they will reply in due course. > > Your message has been sent to the package maintainer(s): > bug-gnu-emacs@gnu.org > > If you wish to submit further information on this problem, please > send it to 32201@debbugs.gnu.org. > > Please do not send mail to help-debbugs@gnu.org unless you wish > to report a problem with the Bug-tracking system. From unknown Sun Jun 22 04:15:50 2025 X-Loop: help-debbugs@gnu.org Subject: bug#32201: 27.0.50; setenv should not change match-data Resent-From: Noam Postavsky Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 18 Jul 2018 22:53:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 32201 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: John Shahid Cc: 32201@debbugs.gnu.org Received: via spool by 32201-submit@debbugs.gnu.org id=B32201.15319543485679 (code B ref 32201); Wed, 18 Jul 2018 22:53:02 +0000 Received: (at 32201) by debbugs.gnu.org; 18 Jul 2018 22:52:28 +0000 Received: from localhost ([127.0.0.1]:47271 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ffvJ6-0001TR-2f for submit@debbugs.gnu.org; Wed, 18 Jul 2018 18:52:28 -0400 Received: from mail-io0-f169.google.com ([209.85.223.169]:42079) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ffvJ3-0001T7-QK; Wed, 18 Jul 2018 18:52:26 -0400 Received: by mail-io0-f169.google.com with SMTP id g11-v6so5489814ioq.9; Wed, 18 Jul 2018 15:52:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=qL9FOcmRPSY6BJgE5pE5xvif1iHzlxJFtg4f/I13qyk=; b=lknM9wYKJvNsJdwKra7JBxuao/udaPQpScAg6imve4QV2jjZkwjdnvrMKlZRlvDrtM kWHLo0rISUrC95nVlZcmWnlSsM6DJB1pv1yfMMVmo0YN5VFfDzPtTjTKLNUkgX+vA9rw 0SvEODOM5cS1tUX6Sj1pJF5b40KKLcbMerSA54RwyEqt2ssNJmk6prm4zwdwYV6Rc6zg RgVZk6Lw8R/hdm3EPa92c72Gznv6XIslz5WH3iH57lqf0URtEmvgwSZqoI7hp2dioCnn 03mlASvTFSTv7rUc0QueZhG7mpFvQ3b8zPveJUFZ1TZBf2iC2YV0RtjKlFbxZLrAxE4u ZadQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=qL9FOcmRPSY6BJgE5pE5xvif1iHzlxJFtg4f/I13qyk=; b=bvB0l8vR9gRi2jL2DftWfJI2/PPXxZ15e99boyopRs4337G1Vh3ZhnAqhdw5RehHAU CcIY8z2gtjMyksbZRaqmnyCNsb30KGa/PPLDin+MhQp/00hEU3ujtPVGW50w2oFSrMBl 6gUgPmr2Xvit/l93ZhZa4wQCnxjq4WN/5jkB62aKRsb6U6nQqv3sOUzbrM8IiLes2Lp0 0319PsDXHmCrMU2m7GUTTnJD7H7TgzPYRXhDMWbSTZZEdVqltNrmMximLrrhAlfQhZWj zilxaRzJhRNy6vrlyZZ+NL/9LKHi6pnosPRLMioctiE1vJg8CrKNGovJj7yvQfiRN55/ Orag== X-Gm-Message-State: AOUpUlENoF0hmNm0aWxMRJVczMU0nYy2XxLp/v5rlPuCJLR5pYMV/UM7 vy87UFLxsnWIwMQ8f9//MOMPng== X-Google-Smtp-Source: AAOMgpcHH5BLCqE6aItO7FtTMmYlk6JhS1a5u9j4yia0hHtqZDq3POG87qa7t7s7bE5BsNYrjV8MBw== X-Received: by 2002:a6b:3a55:: with SMTP id h82-v6mr2763316ioa.76.1531954339992; Wed, 18 Jul 2018 15:52:19 -0700 (PDT) Received: from zebian (cbl-45-2-119-34.yyz.frontiernetworks.ca. [45.2.119.34]) by smtp.googlemail.com with ESMTPSA id u125-v6sm210869ita.4.2018.07.18.15.52.18 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 18 Jul 2018 15:52:19 -0700 (PDT) From: Noam Postavsky References: <87h8kwe4ja.fsf@gmail.com> Date: Wed, 18 Jul 2018 18:52:18 -0400 In-Reply-To: <87h8kwe4ja.fsf@gmail.com> (John Shahid's message of "Wed, 18 Jul 2018 19:18:33 +0000") Message-ID: <87601c88d9.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-=-= Content-Type: text/plain tags 32201 + patch quit John Shahid writes: > > (add-hook 'buffer-list-update-hook > (lambda () > (setenv "GOPATH" gopath)))))) > The problem seems to happen when all of the suddent 'find-file' will > start openning weird files. For example, if I'm currently viewing > "~/foo/bar.txt" and use 'C-x C-f' the default file name will be > "~/foo/~jvshahid/foo/bar.txt". After some debugging it turns out that > the following will happen which cause the match-data to be corrupted: > > 1. find-file calls abbreviate-file-name > 2. abbreviate-file-name calls (expand-file-name "~") > 3. expand-file-name runs the buffer-list-update-hook (unknown why) > 4. the hook will use setenv which messes up the match-data > 5. abbreviate-file-name resumes and use the incorrect match-data and return an invalid path > > I don't know why '3' is happening. buffer-list-update-hook gets called by get-buffer-create and kill-buffer; it seems plausible that some file name handlers would use make-temp-buffer which calls both of those. Anyway, I don't think setenv should be changed, rather abbreviate-file-name should save-match-data around the expand-file-name call. After all, today you happened to use setenv in a hook, tomorrow someone will use another match-data modifying function. Here's the patch (intended for emacs-26): --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=v1-0001-Add-save-match-data-to-abbreviate-file-name-Bug-3.patch Content-Description: patch >From a0eec7f2e672804f3a7a30e55c821ba2dac213b7 Mon Sep 17 00:00:00 2001 From: Noam Postavsky Date: Wed, 18 Jul 2018 18:45:47 -0400 Subject: [PATCH v1] Add save-match-data to abbreviate-file-name (Bug#32201) * lisp/files.el (abbreviate-file-name): Save match-data around expand-file-name; it is not guaranteed to preserve match-data, and may well do so depending on what file handlers and hooks are in effect. --- lisp/files.el | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lisp/files.el b/lisp/files.el index fb8c34bcae..4eb1560a20 100644 --- a/lisp/files.el +++ b/lisp/files.el @@ -1929,7 +1929,7 @@ abbreviate-file-name (save-match-data (string-match "^[a-zA-`]:/$" filename)))) (equal (get 'abbreviated-home-dir 'home) - (expand-file-name "~"))) + (save-match-data (expand-file-name "~")))) (setq filename (concat "~" (match-string 1 filename) -- 2.11.0 --=-=-=-- From unknown Sun Jun 22 04:15:50 2025 X-Loop: help-debbugs@gnu.org Subject: bug#32201: 27.0.50; setenv should not change match-data Resent-From: John Shahid Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 19 Jul 2018 00:24:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 32201 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Noam Postavsky Cc: 32201@debbugs.gnu.org Received: via spool by 32201-submit@debbugs.gnu.org id=B32201.153195978429264 (code B ref 32201); Thu, 19 Jul 2018 00:24:02 +0000 Received: (at 32201) by debbugs.gnu.org; 19 Jul 2018 00:23:04 +0000 Received: from localhost ([127.0.0.1]:47316 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ffwil-0007bv-D1 for submit@debbugs.gnu.org; Wed, 18 Jul 2018 20:23:04 -0400 Received: from mail-qk0-f170.google.com ([209.85.220.170]:46170) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ffwij-0007b9-GL for 32201@debbugs.gnu.org; Wed, 18 Jul 2018 20:23:01 -0400 Received: by mail-qk0-f170.google.com with SMTP id o2-v6so3395066qkc.13 for <32201@debbugs.gnu.org>; Wed, 18 Jul 2018 17:23:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=references:user-agent:from:to:cc:subject:in-reply-to:date :message-id:mime-version; bh=5jIY7Cm2FwkE9Hm02lsaehf4oY9PbZrG9MwKG9lAG/o=; b=M6M8GGe528dWy9fKT/j2o+e9eO9Zo8LzD3evjHhx0OCdtbMQMz+uH1uLoQuuZTl026 188S1r2n8Gl6AyzK2zTBV5zAW4FeUFciyYEG7X7AAHOWt2+IAb+EjB3YTJWQ6z0t71u/ f/NbQh3YrTqB6R+HxZnKIDvQl0clZi6yLYc+A9xMmCmPGehPX7PMi19pU+KcigdmrjiE 2YhpX0je1WRH2PPvuHkcIsRIj1+hV+DHgRE3Vd+MPBLb3Lvxup3+ocUEo6Lf9Ylx+nPb MRkfz/UUsqx3p7fm/obcEGGBydAZbed+bsNpkcj9BVcRDmaxvDA2XkOEp/wSp1bhaLrW maTQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:references:user-agent:from:to:cc:subject :in-reply-to:date:message-id:mime-version; bh=5jIY7Cm2FwkE9Hm02lsaehf4oY9PbZrG9MwKG9lAG/o=; b=YAUFaZy8xGdF9puX9KvIGfZEs2IFkqEdATcf8JQFmp+yU9dw3sbin5hDHetj5Ae9jQ 2ER/FsWz2lgzgdfPyF82RDKz79gyz6MzTNGJu3MRgz5uCz5YdrJIM5bCjMf1ZKyNS46R CkV+OPbYtAbGTms5t1PEj7xmo67Y/KzbDFVZX6O4FN6NMMNWoiHl0g7gXxf+BZVzBSFq nIoyFjiawYPRSsH1pxxbc8SEKqMXmbOw+2PwS0bRMZ/4DDgvmQvABvO8MFhaUAFkT+VI 1AmeYs1+tHm3Gewhk1vRoL25X3XtCFK2rsWPgQaBNhQtntBnlzVlIGVzLBH3C8m4TyGL HZYg== X-Gm-Message-State: AOUpUlG1li/UV13wiwxjdtpSeVaJz4Uvcj3WrOD0o+x/YC0r2Mm0b00C 7AyOiEvTLN++/NPmo77w3aoBl8g1 X-Google-Smtp-Source: AAOMgpf6pGWx22Mr/lo9JhA8VeR0WcGwN17wk/J64jbDdtOmDY8botaVclSICoyXznsz6PY8hHRMfA== X-Received: by 2002:a37:ab14:: with SMTP id u20-v6mr7214110qke.120.1531959775590; Wed, 18 Jul 2018 17:22:55 -0700 (PDT) Received: from 8a803f88ebe0 (cpe-184-152-55-93.nyc.res.rr.com. [184.152.55.93]) by smtp.gmail.com with ESMTPSA id s31-v6sm4659572qtc.68.2018.07.18.17.22.54 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 18 Jul 2018 17:22:54 -0700 (PDT) References: <87h8kwe4ja.fsf@gmail.com> <87601c88d9.fsf@gmail.com> User-agent: mu4e 1.1.0; emacs 27.0.50 From: John Shahid In-reply-to: <87601c88d9.fsf@gmail.com> Date: Thu, 19 Jul 2018 00:22:49 +0000 Message-ID: <87efg0dqg6.fsf@gmail.com> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: -0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-=-= Content-Type: text/plain Noam Postavsky writes: [...] > Anyway, I don't think setenv should be changed, rather > abbreviate-file-name should save-match-data around the expand-file-name > call. After all, today you happened to use setenv in a hook, tomorrow > someone will use another match-data modifying function. I agree, but I also think that there is no reason for `setenv' to use `string-match' instead of `string-match-p'. It doesn't seem to be using the match data anyway. I attached the patch that replaces `string-match' with `string-match-p' in `setenv' and `setenv-internal'. WDYT ? --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=0001-Avoid-destroying-match-data-in-setenv.patch >From 7b592252f698ae07a2010302c74b42026fbbca5e Mon Sep 17 00:00:00 2001 From: John Shahid Date: Wed, 18 Jul 2018 20:18:19 -0400 Subject: [PATCH] Avoid destroying match data in 'setenv' * lisp/env.el (setenv,setenv-internal): Replace string-match with string-match-p --- lisp/env.el | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/lisp/env.el b/lisp/env.el index e47eb57836..7007ba33e5 100644 --- a/lisp/env.el +++ b/lisp/env.el @@ -113,11 +113,11 @@ setenv-internal (not keep-empty) env (stringp (car env)) - (string-match pattern (car env))) + (string-match-p pattern (car env))) (cdr env) ;; Try to find existing entry for VARIABLE in ENV. (while (and scan (stringp (car scan))) - (when (string-match pattern (car scan)) + (when (string-match-p pattern (car scan)) (if value (setcar scan (concat variable "=" value)) (if keep-empty @@ -184,7 +184,7 @@ setenv (setq variable (encode-coding-string variable locale-coding-system))) (if (and value (multibyte-string-p value)) (setq value (encode-coding-string value locale-coding-system))) - (if (string-match "=" variable) + (if (string-match-p "=" variable) (error "Environment variable name `%s' contains `='" variable)) (if (string-equal "TZ" variable) (set-time-zone-rule value)) -- 2.18.0 --=-=-=-- From unknown Sun Jun 22 04:15:50 2025 X-Loop: help-debbugs@gnu.org Subject: bug#32201: 27.0.50; setenv should not change match-data Resent-From: Noam Postavsky Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 19 Jul 2018 01:57:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 32201 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: John Shahid Cc: 32201@debbugs.gnu.org Received: via spool by 32201-submit@debbugs.gnu.org id=B32201.153196541812812 (code B ref 32201); Thu, 19 Jul 2018 01:57:02 +0000 Received: (at 32201) by debbugs.gnu.org; 19 Jul 2018 01:56:58 +0000 Received: from localhost ([127.0.0.1]:47341 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ffyBe-0003Ka-B7 for submit@debbugs.gnu.org; Wed, 18 Jul 2018 21:56:58 -0400 Received: from mail-io0-f182.google.com ([209.85.223.182]:38557) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ffyBc-0003KM-K1 for 32201@debbugs.gnu.org; Wed, 18 Jul 2018 21:56:57 -0400 Received: by mail-io0-f182.google.com with SMTP id v26-v6so5775303iog.5 for <32201@debbugs.gnu.org>; Wed, 18 Jul 2018 18:56:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=RWwffWtlQloHnkMKgvRHxbZClvklQzeXCSZwW4sY1Bw=; b=HjsLUK6aToHzvGiXkcFDYKfxRxAwm/yQRDnwFfQE2vIICN3PdwnufBiPAXJt7lQVwN NqglFNYGx6RkdaWY2N3wTzZdbSPHPhquuq0R7JNEZg9fmcbPmnW0320D6LKL2gSQM0r6 OYDnW8urWXqAW5oeuwgYi3+EF8hsfGK8Y8t2+sK2Te3WI9GcFOEEq++wil5ngllim80d 8xsh/D/npKW15ZGfE8A/bFE3U1DoYCyYRfgwHCNGqNT8fTe+fH5qbePlI1SSefSmz6f3 ZH7hxKzy5/sNobYrtspwRsXu7UDkpHsycfhUe7WAjxDrXWidLVwlJtXvZ69PqDkSUjrA E/4A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=RWwffWtlQloHnkMKgvRHxbZClvklQzeXCSZwW4sY1Bw=; b=owwJIkR6fCBApJlWOYyNkKoCvn7WQdR+2MHbS7ZA6cOKlyUHltWdn7vBA0n6mgdfvR sVaBUiHtcfZ/sq6W2eyBfywMFg4i7NAlIL04nzVcFylF74RhxgrjQJnOzI7v95i2KXZy sW8sF6l7LVbRY+jRtoWsIEFuUFMnZjDoXik1boVm+4AxDL9hbQ3iCtLIOGJuCkqWjUmJ GTNQ63dtdJBJp3vWsb03TLQdX3YeB8VnzcjDOYQADGiRBdytkJkEcwRE/jdZZMH7MV7z 69aELrtag0qy+xLSjj+lVESk5KM4JX8gALl/jNnAjaD3bgeQK2p2WYug5pcr5HUz5m+p X0Rw== X-Gm-Message-State: AOUpUlEFAwOo7NRlkVZ0MQ7TvlJUuoTVdR+bdiDBiA4WK2SA4+twbOmJ t87p5Kfo7FSBW6H+Jh17Tlg93g== X-Google-Smtp-Source: AAOMgpfQoS+TJu4jF44411qwL8Arpt1HYYb2ZmyphNTrceubQqTdqavMGDg6dizKp4ssJdm3eGGVow== X-Received: by 2002:a6b:1f8e:: with SMTP id f136-v6mr7083585iof.289.1531965410903; Wed, 18 Jul 2018 18:56:50 -0700 (PDT) Received: from zebian (cbl-45-2-119-34.yyz.frontiernetworks.ca. [45.2.119.34]) by smtp.googlemail.com with ESMTPSA id n124-v6sm2122533itg.7.2018.07.18.18.56.50 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 18 Jul 2018 18:56:50 -0700 (PDT) From: Noam Postavsky References: <87h8kwe4ja.fsf@gmail.com> <87601c88d9.fsf@gmail.com> <87efg0dqg6.fsf@gmail.com> Date: Wed, 18 Jul 2018 21:56:49 -0400 In-Reply-To: <87efg0dqg6.fsf@gmail.com> (John Shahid's message of "Thu, 19 Jul 2018 00:22:49 +0000") Message-ID: <87o9f46l9a.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) John Shahid writes: >> Anyway, I don't think setenv should be changed, rather >> abbreviate-file-name should save-match-data around the expand-file-name >> call. After all, today you happened to use setenv in a hook, tomorrow >> someone will use another match-data modifying function. > > I agree, but I also think that there is no reason for `setenv' to use > `string-match' instead of `string-match-p'. It doesn't seem to be using > the match data anyway. I attached the patch that replaces > `string-match' with `string-match-p' in `setenv' and `setenv-internal'. > WDYT ? Seems harmless enough. I'll wait a couple of days, and then push my abbreviate-file-name patch to emacs-26 and this patch to master. From unknown Sun Jun 22 04:15:50 2025 X-Loop: help-debbugs@gnu.org Subject: bug#32201: 27.0.50; setenv should not change match-data Resent-From: Noam Postavsky Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 22 Jul 2018 01:31:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 32201 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: John Shahid Cc: 32201@debbugs.gnu.org Received: via spool by 32201-submit@debbugs.gnu.org id=B32201.15322230134212 (code B ref 32201); Sun, 22 Jul 2018 01:31:02 +0000 Received: (at 32201) by debbugs.gnu.org; 22 Jul 2018 01:30:13 +0000 Received: from localhost ([127.0.0.1]:51473 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fh3CP-00015m-EK for submit@debbugs.gnu.org; Sat, 21 Jul 2018 21:30:13 -0400 Received: from mail-io0-f196.google.com ([209.85.223.196]:46655) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fh3CM-00014c-C5; Sat, 21 Jul 2018 21:30:10 -0400 Received: by mail-io0-f196.google.com with SMTP id i18-v6so12837018ioj.13; Sat, 21 Jul 2018 18:30:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=e3w+TYoaOKLdbe/VFGfStnBw9LXgQdvftvnNLQilA2w=; b=CQKgZxgVLWyBJ1jEzlfOXNBfukp/HRmc/AenbNpfcbgR3nbLEDCKRkQ4MiBKrbb1L4 ZpG1/nodKnE4hkkQV3mB6WrHqysQVGP5eqzLrgRVkmjWHZDLzDbDll+h2hjR+bQXkw9L AIWiH6FDUy7jN7S2YNEAY9TNzPIqqytxdx7n+DM++TJVqEMu3lGhUSD5OKFMs3+trRbF oRLzK9PWvC5JJwXSPOu1pWEKzkA9b2PM3jhs1wwKwoSOJ7wGjvb8uVE2uQRu5PSxaAxl VC2tcTnpEpqPVoPzRMvV7zePBH0SsX7LJamV12oGllKwp+tV2bvNW90CPR0AegWO5cfG xC+Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=e3w+TYoaOKLdbe/VFGfStnBw9LXgQdvftvnNLQilA2w=; b=V8lwsIszIuGDHMgX1XUd2Ptx0/pNQ3DXNFN1dtVhIcBjLZ7IjBK4kd9G1lYSIXmlwp 1RtRUQ+YKCu/SStUzFIDTXkV2AH6lARc3EcO9S4ZY07ZW4PtZn4I38SPUT5ydmsXfcRD XKv9o6Yj+B0Zb27ZkR8QoaRLc2TWv1vIGNH3NbpdqxIBEU9cLnfr+fXNAgt9eHXxh8Oh dq7LflwdJWcuPICiS1d6RoMHYwbk6ArkFGDLDmcAfv1qTYEVWWOYyGMhUbg80A6voW67 LT7b0AhR4/79pR/cu+WuWk+RrjX6tzVYxlegWQfJ+qYr7x/IP/l1/PJiLpyeNyy8yNNy u9gQ== X-Gm-Message-State: AOUpUlEBGHdFXHD6hZNF6jC/zj+WAGhnC2wp99SfehDXtMo9hgdb6wWx UBGrhYpKMJXqH77/3DOtkoHtJ9CM X-Google-Smtp-Source: AAOMgpc0tpzxZj6gckM6PD43GIDLGkuF7mB55feZj3X1rbAmwH9x3F8aaFidEvCAIoEPbpsshQq9Tw== X-Received: by 2002:a6b:1a53:: with SMTP id a80-v6mr5892889ioa.143.1532223004440; Sat, 21 Jul 2018 18:30:04 -0700 (PDT) Received: from zebian (cbl-45-2-119-34.yyz.frontiernetworks.ca. [45.2.119.34]) by smtp.googlemail.com with ESMTPSA id i23-v6sm1726141iog.74.2018.07.21.18.30.02 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sat, 21 Jul 2018 18:30:03 -0700 (PDT) From: Noam Postavsky References: <87h8kwe4ja.fsf@gmail.com> <87601c88d9.fsf@gmail.com> <87efg0dqg6.fsf@gmail.com> <87o9f46l9a.fsf@gmail.com> Date: Sat, 21 Jul 2018 21:30:02 -0400 In-Reply-To: <87o9f46l9a.fsf@gmail.com> (Noam Postavsky's message of "Wed, 18 Jul 2018 21:56:49 -0400") Message-ID: <87pnzg5a79.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) tags 32201 fixed close 32201 26.2 quit Noam Postavsky writes: > John Shahid writes: > >>> Anyway, I don't think setenv should be changed, rather >>> abbreviate-file-name should save-match-data around the expand-file-name >>> call. After all, today you happened to use setenv in a hook, tomorrow >>> someone will use another match-data modifying function. >> >> I agree, but I also think that there is no reason for `setenv' to use >> `string-match' instead of `string-match-p'. It doesn't seem to be using >> the match data anyway. I attached the patch that replaces >> `string-match' with `string-match-p' in `setenv' and `setenv-internal'. >> WDYT ? > > Seems harmless enough. I'll wait a couple of days, and then push my > abbreviate-file-name patch to emacs-26 and this patch to master. Done. [1: 59e8533286]: 2018-07-21 21:07:07 -0400 Add save-match-data to abbreviate-file-name (Bug#32201) https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=59e8533286cc8b5abc80b0966ef4b9fb676fbdfe [2: b7ca3d5d93]: 2018-07-21 21:10:20 -0400 Avoid destroying match data in 'setenv' (Bug#32201) https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=b7ca3d5d932bad6900296679ab87f7d0d64d1de9