GNU bug report logs - #32194
[PATCH] Use Gnulib regex for lib-src

Previous Next

Full log

View this message in rfc822 format

From: Paul Eggert <eggert <at> cs.ucla.edu>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 32194 <at> debbugs.gnu.org
Subject: bug#32194: [PATCH] Use Gnulib regex for lib-src
Date: Thu, 2 Aug 2018 07:41:38 -0700

Eli Zaretskii wrote:

> I thought that using
> 
>    #include "regex.h"
> 
> in src/regex.c should avoid any such "fights".

The problem I ran into was the other way around: lib-src/etags.c and lib/regex.c 
say '#include <regex.h>' and this grabs the wrong regex.h. Changing the 
directives to say '#include "<regex.h>"' would start to diverge from glibc 
source, which I'd rather not do. Also, for non-POSIX compilers, the '#include 
"<regex.h>"' trick might not work; it also might not work if the builder puts 
'-I-' in CFLAGS with GCC. The whole mess is easily avoidable by renaming 
src/regex.h.

Renaming is appropriate anyway, since the APIs are not the same, and it's 
confusing to have two include files with the same name.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.