GNU bug report logs - #32192
[PATCH 0/7] Remove duplicated packages.

Previous Next

Package: guix-patches;

Reported by: Christopher Baines <mail <at> cbaines.net>

Date: Tue, 17 Jul 2018 20:29:02 UTC

Severity: normal

Tags: patch

Done: Christopher Baines <mail <at> cbaines.net>

Bug is archived. No further changes may be made.

Full log


View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Christopher Baines <mail <at> cbaines.net>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#32192: closed ([PATCH 0/7] Remove duplicated packages.)
Date: Sun, 29 Jul 2018 17:05:02 +0000
[Message part 1 (text/plain, inline)]
Your message dated Sun, 29 Jul 2018 18:04:37 +0100
with message-id <8736w2km6y.fsf <at> cbaines.net>
and subject line Re: [bug#32192] [PATCH 0/7] Remove duplicated packages.
has caused the debbugs.gnu.org bug report #32192,
regarding [PATCH 0/7] Remove duplicated packages.
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
32192: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=32192
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems
[Message part 2 (message/rfc822, inline)]
From: Christopher Baines <mail <at> cbaines.net>
To: guix-patches <at> gnu.org
Subject: [PATCH 0/7] Remove duplicated packages.
Date: Tue, 17 Jul 2018 21:27:45 +0100
[Message part 3 (text/plain, inline)]
As part of messing up packaging Ruby on Rails, I ended up duplicating
some packages, and this prompted me to look if any duplicates made it in
to guix. I ran the following command, it produces a few false positives.

  grep define-public -R | sort | uniq -d

The following patches attempt to remove the duplicates, favouring the
original package definition.

Is there any way of guarding against adding these, or more accurately
checking for duplicate definitions?
[signature.asc (application/pgp-signature, inline)]
[Message part 5 (message/rfc822, inline)]
From: Christopher Baines <mail <at> cbaines.net>
To: Leo Famulari <leo <at> famulari.name>
Cc: 32192-done <at> debbugs.gnu.org
Subject: Re: [bug#32192] [PATCH 0/7] Remove duplicated packages.
Date: Sun, 29 Jul 2018 18:04:37 +0100
[Message part 6 (text/plain, inline)]
Leo Famulari <leo <at> famulari.name> writes:

> On Tue, Jul 17, 2018 at 09:27:45PM +0100, Christopher Baines wrote:
>> The following patches attempt to remove the duplicates, favouring the
>> original package definition.
>
> I sent one comment, otherwise the patches LGTM.

Thanks, I've now fixed that issue and pushed :)
[signature.asc (application/pgp-signature, inline)]

This bug report was last modified 6 years and 359 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.