GNU bug report logs - #32165
[PATCH] gnu: Add cdrkit-libre.

Previous Next

Full log

Message #11 received at 32165 <at> debbugs.gnu.org (full text, mbox):

From: ludo <at> gnu.org (Ludovic Courtès)
To: Oleg Pykhalov <go.wigust <at> gmail.com>
Cc: 32165 <at> debbugs.gnu.org
Subject: Re: [bug#32165] [PATCH] gnu: Add cdrkit-libre.
Date: Tue, 24 Jul 2018 10:38:57 +0200

Hi Oleg,

Oleg Pykhalov <go.wigust <at> gmail.com> skribis:

> * gnu/packages/cdrom.scm (cdrkit-libre): New variable.

[...]

> +    (source (origin
> +              (method url-fetch)
> +              (uri (string-append
> +                    "https://repo.parabola.nu/other/cdrkit-libre/cdrkit-libre-"
> +                    version ".tar.gz"))

Like Nils I wonder: can you explain how it differs from cdrkit?  Could
we use upstream cdrkit + snippet/patches instead of taking the source
from Parabola’s repo?

> +    (build-system cmake-build-system)
> +    (native-inputs
> +     `(("bzip2" ,bzip2)
> +       ("libcap" ,libcap)
> +       ("perl" ,perl)
> +       ("zlib" ,zlib)))

It may be that all of these should be ‘inputs’.  Could you check:

  guix gc --references $(guix build cdrkit-libre)

?  If they show up here, then ‘inputs’.

> +    (arguments
> +     `(#:tests? #f ;no tests
> +       #:phases
> +       (modify-phases %standard-phases
> +         (add-after 'install 'old-cdrecord
> +           (lambda* (#:key outputs #:allow-other-keys)
> +             (with-directory-excursion (string-append (assoc-ref outputs "out")
> +                                                      "/bin")
> +               (symlink "genisoimage" "mkisofs")
> +               (symlink "wodim" "cdrecord")))))))

Please return #t.

> +    (home-page "http://cdrkit.org/")

Like Nils wrote, is this the right URL?

> +    (synopsis "Portable command-line CD/DVD recorder software, mostly
> +compatible with cdrtools")

“Command-line CD/DVD recorder” is enough IMO.

> +    (description "Cdrkit is a suite of programs for recording CDs and DVDs,
> +blanking CD-RW media, creating ISO-9660 filesystem images, extracting audio CD
> +data, and more.")

Here you can mention that it’s “mostly compatible …”.
Note: “file system” (two words).  :-)

Thanks,
Ludo’.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.