GNU bug report logs - #32155
[PATCH 0/4] sfml updates

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Marius Bakke <mbakke <at> fastmail.com>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#32155: closed ([PATCH 0/4] sfml updates)
Date: Tue, 17 Jul 2018 23:19:02 +0000

[Message part 1 (text/plain, inline)]

Your message dated Wed, 18 Jul 2018 01:18:35 +0200
with message-id <87lga95u44.fsf <at> fastmail.com>
and subject line Re: [bug#32155] [PATCH 0/4] sfml updates
has caused the debbugs.gnu.org bug report #32155,
regarding [PATCH 0/4] sfml updates
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
32155: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=32155
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Marius Bakke <mbakke <at> fastmail.com>
To: guix-patches <at> gnu.org
Cc: Marius Bakke <mbakke <at> fastmail.com>
Subject: [PATCH 0/4] sfml updates
Date: Sat, 14 Jul 2018 16:41:21 +0200

This series updates sfml to the latest release, and adds some of the
"stb" <https://github.com/nothings/stb> libraries in order to unbundle
all dependencies.

Marius Bakke (4):
  gnu: sfml: Update to 2.5.0.
  gnu: Add stb-image.
  gnu: Add stb-image-write.
  gnu: sfml: Remove all bundled dependencies.

 gnu/local.mk                      |   1 +
 gnu/packages/game-development.scm |  27 ++++++--
 gnu/packages/stb.scm              | 101 ++++++++++++++++++++++++++++++
 3 files changed, 123 insertions(+), 6 deletions(-)
 create mode 100644 gnu/packages/stb.scm

-- 
2.18.0

[Message part 3 (message/rfc822, inline)]

From: Marius Bakke <mbakke <at> fastmail.com>
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: 32155-done <at> debbugs.gnu.org
Subject: Re: [bug#32155] [PATCH 0/4] sfml updates
Date: Wed, 18 Jul 2018 01:18:35 +0200

[Message part 4 (text/plain, inline)]

Hello Ludo,

ludo <at> gnu.org (Ludovic Courtès) writes:

>> +(define (make-stb-header-package name version description)
>> +  (package
>> +    (inherit stb)
>> +    (name name)
>> +    (version version)
>> +    (source #f)
>> +    (inputs `(("stb" ,stb)))
>> +    (build-system trivial-build-system)
>> +    (arguments
>> +     `(#:modules ((guix build utils))
>> +       #:builder (begin
>> +                   (use-modules (guix build utils))
>> +                   (let ((stb (assoc-ref %build-inputs "stb"))
>> +                         (lib (string-join (string-split ,name #\-) "_"))
>> +                         (out (assoc-ref %outputs "out")))
>> +                     (install-file (string-append stb "/" lib ".h")
>> +                                   (string-append out "/include"))
>> +                     #t))))
>> +    (description description)))
>> +
>> +(define-public stb-image
>> +  (make-stb-header-package
>> +   "stb-image" "2.19"
>> +   "stb-image is a small and self-contained library for image loading or
>> +decoding from file or memory.  A variety of formats are supported."))
>
> Not sure if it really matters here, but note that the description here
> won’t be subject to translation.
>
> To make it translatable, it would have to be embedded in a (description
> "…") form.  I address that with phony macros as in
> ‘define-word-list-dictionary’ in aspell.scm.

Oh, thanks for the heads-up!  I did not know that.

I added a TODO note about it and committed.

As always, thanks a lot for reviewing! :-)

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.