Subject: Re: [bug#32137] [PATCH] gnu: Add luakit

From: [email-masked] (Ludovic Courtès)
Date: Tue, 17 Jul 2018 15:14:39 +0200

Hello Raphaël,

Raphaël Mélotte <[email-masked]> skribis:

> This patch adds luakit, a lightweight web browser based on webkitgtk.
>
> NB: this is my first patch submission, I apologize in advance if I did
> something wrong.
> From 36bae98701a1c04de2820781dd8b7488cac61e30 Mon Sep 17 00:00:00 2001
> From: 43317 <[email-masked]>
> Date: Fri, 13 Jul 2018 15:28:41 +0200
> Subject: [PATCH] add luakit
>
> ---
>  gnu/packages/web-browsers.scm | 65 +++++++++++++++++++++++++++++++++++
>  1 file changed, 65 insertions(+)

Thanks for this first patch and welcome!  I made only minor
modifications (patch below):

  1. Add ‘file-name’ to the source to please ‘guix lint’.

  2. Return #t at the end of the ‘wrap’ phase.

  3. Tweak the synopses and description.

  4. Change license to ‘gpl3+’ because source file headers explicitly
     say “version 3 or any later version”.

I provided a commit log that matches our conventions too.

  https://git.savannah.gnu.org/cgit/guix.git/commit/?id=700987f72c870b9a8e3ed6cd538064e2c2b8f3ce

That’s it!

I tried running “luakit -c /dev/null” but it insists on having an rc
file that explicitly creates a window, right?

Thank you!

Ludo’.

diff --git a/gnu/packages/web-browsers.scm b/gnu/packages/web-browsers.scm
index 02f076bbe..56bfa6ab2 100644
--- a/gnu/packages/web-browsers.scm
+++ b/gnu/packages/web-browsers.scm
@@ -144,7 +144,8 @@ features including, tables, builtin image display, bookmarks, SSL and more.")
                                   ".tar.gz"))
               (sha256
                (base32
-                "0dwxhnq90whakgdg21lzcf03n2g1c7hqgliwhav8av5na5mqpn93"))))
+                "0dwxhnq90whakgdg21lzcf03n2g1c7hqgliwhav8av5na5mqpn93"))
+              (file-name (string-append name "-" version ".tar.gz"))))
     (inputs
      `(("lua-5.1", lua-5.1)
        ("gtk+" ,gtk+)
@@ -184,14 +185,16 @@ features including, tables, builtin image display, bookmarks, SSL and more.")
                     (gtk (assoc-ref inputs "gtk+"))
                     (gtk-share (string-append gtk "/share")))
                (wrap-program (string-append luakit "/bin/luakit")
-                 `("LUA_CPATH" prefix (,(string-append
-                                         lua5.1-filesystem "/lib/lua/5.1/?.so;;"))))))))))
-    (synopsis "Fast, light and simple browser based on webkit")
-    (description "Luakit is a fast, light and simple to use micro-browser
- framework extensible by Lua
- using the WebKit web content engine and the GTK+ toolkit.")
+                 `("LUA_CPATH" prefix
+                   (,(string-append lua5.1-filesystem
+                                    "/lib/lua/5.1/?.so;;"))))
+               #t))))))
+    (synopsis "Fast, lightweight, and simple browser based on WebKit")
+    (description "Luakit is a fast, lightweight, and simple to use
+micro-browser framework extensible by Lua using the WebKit web content engine
+and the GTK+ toolkit.")
     (home-page "https://luakit.github.io/")
-    (license license:gpl3)))
+    (license license:gpl3+)))
 
 (define-public lynx
   (package