From debbugs-submit-bounces@debbugs.gnu.org Thu Jul 12 10:31:34 2018 Received: (at submit) by debbugs.gnu.org; 12 Jul 2018 14:31:34 +0000 Received: from localhost ([127.0.0.1]:57223 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fdcd4-00038P-Le for submit@debbugs.gnu.org; Thu, 12 Jul 2018 10:31:34 -0400 Received: from eggs.gnu.org ([208.118.235.92]:59356) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fdcd3-00038C-C7 for submit@debbugs.gnu.org; Thu, 12 Jul 2018 10:31:33 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fdccx-0001pp-6E for submit@debbugs.gnu.org; Thu, 12 Jul 2018 10:31:28 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,T_DKIM_INVALID autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:42527) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1fdccx-0001pi-1s for submit@debbugs.gnu.org; Thu, 12 Jul 2018 10:31:27 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:50289) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fdccv-0002yz-IO for guix-patches@gnu.org; Thu, 12 Jul 2018 10:31:26 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fdccs-0001ls-E9 for guix-patches@gnu.org; Thu, 12 Jul 2018 10:31:25 -0400 Received: from out4-smtp.messagingengine.com ([66.111.4.28]:49793) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1fdccs-0001lW-63 for guix-patches@gnu.org; Thu, 12 Jul 2018 10:31:22 -0400 Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.nyi.internal (Postfix) with ESMTP id 99D0A2193A; Thu, 12 Jul 2018 10:31:21 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute4.internal (MEProxy); Thu, 12 Jul 2018 10:31:21 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=famulari.name; h=date:from:message-id:subject:to:x-me-sender:x-me-sender :x-sasl-enc; s=mesmtp; bh=xqS9gGSGyb5ElWNxtSaYTtE/dii8RhhZaKVBJK lQtI4=; b=CcKpDEPdlAQzNoGhcWW1yaDbqL+XCkb+CVx0++UoHgHWJmj+n4Djxh /cLx7Oip6fFc1bKqjuz8NnGvmE1q0rOgeWpFhZj+NTbPIWnloXApC63i5QOvsMBl tCxdDiCMx/ZXVKhmJK6KlsuciUQ1LVgIUoBtIHziou5lHu6JAxZ18= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=date:from:message-id:subject:to :x-me-sender:x-me-sender:x-sasl-enc; s=fm3; bh=xqS9gGSGyb5ElWNxt SaYTtE/dii8RhhZaKVBJKlQtI4=; b=onCKelhXoLVSmPDMf8AdZXeT2EaJKASav SawDryWNXLW08p5rkIPfpaIwBZGiHzVNtCQD9TGWt32wB2VPYkl/GPYIO92yZPMr dlM+UCghOCprcm+031pqgTEivVx+f5UNn0i81kMtQGYRsbFMARu8bKU7UtaHEr9L 0F1RgEeRmuFuSHz1UzsImD/gPf3rQ8mN99yFbwN+A/WMQVLLux0IGYIIpJjLacqb lFe5niTtNKUTNVb/LBX9IHox9uuNxnHCvq5GgWotdn5HJkF3HhftTnybG1N7iHrC dNKzaildVb4U76djlyGZ+trDK09x+JCjIc5fcdQ9n/pxqRlkZ1SAA== X-ME-Proxy: X-ME-Sender: Received: from jasmine.lan (c-76-124-202-137.hsd1.pa.comcast.net [76.124.202.137]) by mail.messagingengine.com (Postfix) with ESMTPA id 432E91028D for ; Thu, 12 Jul 2018 10:31:21 -0400 (EDT) From: Leo Famulari To: guix-patches@gnu.org Subject: [PATCH] build-system/go: Use invoke instead of system*. Date: Thu, 12 Jul 2018 10:31:17 -0400 Message-Id: <24a770957d0cba9639eaa10d5f38ef95ccca4609.1531405875.git.leo@famulari.name> X-Mailer: git-send-email 2.18.0 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.1 (----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.1 (-----) * guix/build/go-build-system.scm (unpack, build): Use invoke. (install-source): Unconditionally return #t. (check): Use invoke and unconditionally return #t. --- guix/build/go-build-system.scm | 38 ++++++++++++++++++---------------- 1 file changed, 20 insertions(+), 18 deletions(-) diff --git a/guix/build/go-build-system.scm b/guix/build/go-build-system.scm index 7c833a616..6be016706 100644 --- a/guix/build/go-build-system.scm +++ b/guix/build/go-build-system.scm @@ -125,17 +125,17 @@ unset. When SOURCE is a directory, copy it instead of unpacking." (copy-recursively source dest #:keep-mtime? #t) #t) (if (string-suffix? ".zip" source) - (zero? (system* "unzip" "-d" dest source)) - (zero? (system* "tar" "-C" dest "-xvf" source)))))) + (invoke "unzip" "-d" dest source) + (invoke "tar" "-C" dest "-xvf" source))))) (define* (install-source #:key install-source? outputs #:allow-other-keys) "Install the source code to the output directory." (let* ((out (assoc-ref outputs "out")) (source "src") (dest (string-append out "/" source))) - (if install-source? - (copy-recursively source dest #:keep-mtime? #t) - #t))) + (when install-source? + (copy-recursively source dest #:keep-mtime? #t)) + #t)) (define (go-package? name) (string-prefix? "go-" name)) @@ -178,24 +178,26 @@ respectively." (define* (build #:key import-path #:allow-other-keys) "Build the package named by IMPORT-PATH." - (or - (zero? (system* "go" "install" - "-v" ; print the name of packages as they are compiled - "-x" ; print each command as it is invoked - ;; Respectively, strip the symbol table and debug - ;; information, and the DWARF symbol table. - "-ldflags=-s -w" - import-path)) - (begin + (with-throw-handler + #t + (lambda _ + (invoke "go" "install" + "-v" ; print the name of packages as they are compiled + "-x" ; print each command as it is invoked + ;; Respectively, strip the symbol table and debug + ;; information, and the DWARF symbol table. + "-ldflags=-s -w" + import-path)) + (lambda (key . args) (display (string-append "Building '" import-path "' failed.\n" "Here are the results of `go env`:\n")) - (system* "go" "env") - #f))) + (invoke "go" "env")))) (define* (check #:key tests? import-path #:allow-other-keys) "Run the tests for the package named by IMPORT-PATH." - (if tests? - (zero? (system* "go" "test" import-path)))) + (when tests? + (invoke "go" "test" import-path)) + #t) (define* (install #:key outputs #:allow-other-keys) "Install the compiled libraries. `go install` installs these files to -- 2.18.0 From debbugs-submit-bounces@debbugs.gnu.org Fri Jul 20 15:36:13 2018 Received: (at control) by debbugs.gnu.org; 20 Jul 2018 19:36:13 +0000 Received: from localhost ([127.0.0.1]:49964 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fgbCH-0003So-Gt for submit@debbugs.gnu.org; Fri, 20 Jul 2018 15:36:13 -0400 Received: from out1-smtp.messagingengine.com ([66.111.4.25]:34485) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fgbCG-0003Sh-Bh for control@debbugs.gnu.org; Fri, 20 Jul 2018 15:36:12 -0400 Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.nyi.internal (Postfix) with ESMTP id 310AE20FE0; Fri, 20 Jul 2018 15:36:12 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute4.internal (MEProxy); Fri, 20 Jul 2018 15:36:12 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=famulari.name; h=content-type:date:from:message-id:mime-version:to:x-me-sender :x-me-sender:x-sasl-enc; s=mesmtp; bh=D1dRDSW90uhSUZpr7tA3Smvnck jAnIPQOdEmHj6YbIQ=; b=Bf04KMFgV4Xk6EUUIuyePcZm3WELzCN8CR9tRMf6SS pE+bLyVEdYorkteIOgm9WIF8aZkHqyivXp+b1HbOHl3AgT6Rwib/q1DoYcOJpa9P MXTXVYemM6YI0TYDbQw10lHz6FzejcWMDQ2bfQs66P9BKN29+Xz2SqW1FajXJL58 o= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=content-type:date:from:message-id :mime-version:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; bh=D 1dRDSW90uhSUZpr7tA3SmvnckjAnIPQOdEmHj6YbIQ=; b=Inz6qZQPIWp6exa3z UAcr1GkHhKwNnaXUMAayIrcy1vLaM6y7f0EeDbU4627mGKXmEGa6/VP9FuArlm+d nx4SdRcCWZ/ATzI4QlDX4kuhK0QQmm9xOMlTjLo+rUbpLhxJ85O90Btq4o562EsH RyY/EINQ5N/3Ss4pOB4OtEpBiJXfQXHEXE1RLq2kFyJuPA349rPDGIl0nC+5tSG5 ZL/w0rgr750ePIuRkQGxwHA05/Z8NQOmExQYH/vP9CjVCVoCUkyiWgcKgXKiO/P1 Wt6sm91JRdJHNCnU2WVEmozhA0wsbIiSSZjLLmiGYj8ovMHHvGWB50kx/o6eimBj zERLA== X-ME-Proxy: X-ME-Sender: Received: from localhost (c-76-124-202-137.hsd1.pa.comcast.net [76.124.202.137]) by mail.messagingengine.com (Postfix) with ESMTPA id C58DE1025D for ; Fri, 20 Jul 2018 15:36:11 -0400 (EDT) Date: Fri, 20 Jul 2018 15:36:11 -0400 From: Leo Famulari To: control@debbugs.gnu.org Message-ID: <20180720193611.GA11329@jasmine.lan> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="0F1p//8PRICkK4MW" Content-Disposition: inline User-Agent: Mutt/1.10.1 (2018-07-13) X-Spam-Score: 1.3 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: close 32133 [...] Content analysis details: (1.3 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at http://www.dnswl.org/, low trust [66.111.4.25 listed in list.dnswl.org] -0.0 SPF_HELO_PASS SPF: HELO matches SPF record -0.0 SPF_PASS SPF: sender matches SPF record 1.8 MISSING_SUBJECT Missing Subject: header 0.2 NO_SUBJECT Extra score for no subject 0.0 T_DKIM_INVALID DKIM-Signature header exists but is not valid 0.0 TVD_SPACE_RATIO No description available. X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.3 (/) --0F1p//8PRICkK4MW Content-Type: text/plain; charset=us-ascii Content-Disposition: inline close 32133 --0F1p//8PRICkK4MW Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEsFFZSPHn08G5gDigJkb6MLrKfwgFAltSOasACgkQJkb6MLrK fwjZsBAAuuapefmmCo4JY9q9CVyy67ZtyYOXC1OQo6uj66YTW24TFN+7xEp886wq W7W4FLWwowJtvICfTCEwNvUp3kkx8iXNqiHolOqC6V+8lmtRYtHsMhaqYl32vpxJ mzXFn1ArzSMv8hVfiNmmzBH7feQ+RsrC/G4/M4RsIkWoZch+oktFLAoPHl9E5D4F ouPCPChDbp/DF+0R5uSz9oi9FAC7/2a00e+LFl6PDTTyzlksmMILlGBTimpO88Iu t7w9UKK4hOxXmfpMzRNk80D4Es/5vQho17PYSIgEkzOZzPR//4CVfL+nhF4YqzJa hyNQVJmv6/ESxp/u+BBiy3ieT7d87uTE4BHGDxkkpcB8Tgos7apO9l1Ez55ATcMg ZuF7BUMtID4xYmp0kcJBnXeMrj38qMWAV+bxClVMzPZf9v9hqnbmvt46CYmiJj6k ANFZBxT9eVIBoziu8QWmUxFs9ydhYQwfux//RWnaSWhY8WUso/SPFhTQoZde1WxO RuQIF/zl82RtFQ0DQzoOIx9DuG/o+rEuqTy+cO4/DynYNmRxbRPm2HEnhOZqgkhW xnQizUl2f6NayrWXdKxNE4Flo2Iu5wTUQ4RakbuB/kKvHjb8ZP7sSkdwTzIuH1/9 gh08PweF53O3Ta6nJ3NtGw9KxQL7tDxrXKTpYf2AU6ZlQwn1tC0= =I2f8 -----END PGP SIGNATURE----- --0F1p//8PRICkK4MW-- From debbugs-submit-bounces@debbugs.gnu.org Tue Jul 24 04:32:07 2018 Received: (at 32133) by debbugs.gnu.org; 24 Jul 2018 08:32:07 +0000 Received: from localhost ([127.0.0.1]:54562 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fhsjn-00012E-LL for submit@debbugs.gnu.org; Tue, 24 Jul 2018 04:32:07 -0400 Received: from eggs.gnu.org ([208.118.235.92]:38604) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fhsjl-00011k-E7 for 32133@debbugs.gnu.org; Tue, 24 Jul 2018 04:32:06 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fhsjb-0003Wv-5E for 32133@debbugs.gnu.org; Tue, 24 Jul 2018 04:32:00 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:55049) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fhsjb-0003Wn-1Z; Tue, 24 Jul 2018 04:31:55 -0400 Received: from [193.50.110.227] (port=49862 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1fhsja-0006kQ-Er; Tue, 24 Jul 2018 04:31:54 -0400 From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=) To: Leo Famulari Subject: Re: [bug#32133] [PATCH] build-system/go: Use invoke instead of system*. References: <24a770957d0cba9639eaa10d5f38ef95ccca4609.1531405875.git.leo@famulari.name> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: 6 Thermidor an 226 de la =?utf-8?Q?R=C3=A9volution?= X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-pc-linux-gnu Date: Tue, 24 Jul 2018 10:31:53 +0200 In-Reply-To: <24a770957d0cba9639eaa10d5f38ef95ccca4609.1531405875.git.leo@famulari.name> (Leo Famulari's message of "Thu, 12 Jul 2018 10:31:17 -0400") Message-ID: <871sbt6nly.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 32133 Cc: 32133@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -6.0 (------) Leo Famulari skribis: > * guix/build/go-build-system.scm (unpack, build): Use invoke. > (install-source): Unconditionally return #t. > (check): Use invoke and unconditionally return #t. Definitely LGTM, thanks! Ludo=E2=80=99. From unknown Tue Aug 19 10:03:03 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Tue, 21 Aug 2018 11:24:04 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator