GNU bug report logs - #32130
[PATCH] gnu: Add electron-cash.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 32130 in the body.
You can then email your comments to 32130 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Vagrant Cascadian <vagrant <at> debian.org>
To: guix-patches <at> gnu.org
Subject: [PATCH] gnu: Add electron-cash.
Date: Wed, 11 Jul 2018 22:05:13 -0700

[Message part 1 (text/plain, inline)]

* gnu/packages/finance.scm (electron-cash): New variable.
---
 gnu/packages/finance.scm | 52 ++++++++++++++++++++++++++++++++++++++++
 1 file changed, 52 insertions(+)

diff --git a/gnu/packages/finance.scm b/gnu/packages/finance.scm
index 1d3e6a7a6..594c835d3 100644
--- a/gnu/packages/finance.scm
+++ b/gnu/packages/finance.scm
@@ -279,6 +279,58 @@ It's not clear at the moment whether one day it will be possible to
 do so.")
     (license license:agpl3+)))
 
+(define-public electron-cash
+  (package
+    (name "electron-cash")
+    (version "3.3")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (string-append "https://electroncash.org/downloads/"
+                           version
+                           "/win-linux/ElectronCash-"
+                           version
+                           ".tar.gz"))
+       (sha256
+        (base32
+         "1x487hyacdm1qhik1mhfimr4jwcwz7sgsbkh11awrb6j19sxdxym"))
+       (modules '((guix build utils)))
+       (snippet
+        '(begin
+           ;; Delete the bundled dependencies.
+           (delete-file-recursively "packages")
+           #t))))
+    (build-system python-build-system)
+    (inputs
+     `(("python-pyaes" ,python-pyaes)
+       ("python-pysocks" ,python-pysocks)
+       ("python-sip" ,python-sip)
+       ("python-pyqt" ,python-pyqt)
+       ("python-ecdsa" ,python-ecdsa)
+       ("python-pbkdf2" ,python-pbkdf2)
+       ("python-requests" ,python-requests)
+       ("python-qrcode" ,python-qrcode)
+       ("python-protobuf" ,python-protobuf)
+       ("python-dnspython" ,python-dnspython)
+       ("python-jsonrpclib-pelix" ,python-jsonrpclib-pelix)))
+    (arguments
+     `(#:tests? #f ;; package doesn't have any tests
+       #:phases
+       (modify-phases %standard-phases
+         (add-before 'build 'patch-home
+           (lambda* (#:key outputs #:allow-other-keys)
+             (substitute* "setup.py"
+               (("~/.local/share")
+                (string-append (assoc-ref outputs "out") "/local/share"))))))))
+    (home-page "https://electroncash.org/")
+    (synopsis "Bitcoin Cash wallet")
+    (description
+     "Electroncash is a lightweight Bitcoin Cash client, based on a client-server
+protocol.  It supports Simple Payment Verification (SPV) and deterministic key
+generation from a seed.  Your secret keys are encrypted and are never sent to
+other machines/servers.  Electroncash does not download the Bitcoin Cash blockchain.")
+    (license license:expat)))
+
 (define-public electrum
   (package
     (name "electrum")
-- 
2.18.0

[signature.asc (application/pgp-signature, inline)]

Message #8 received at 32130 <at> debbugs.gnu.org (full text, mbox):

From: ludo <at> gnu.org (Ludovic Courtès)
To: Vagrant Cascadian <vagrant <at> debian.org>
Cc: 32130 <at> debbugs.gnu.org
Subject: Re: [bug#32130] [PATCH] gnu: Add electron-cash.
Date: Fri, 13 Jul 2018 00:03:20 +0200

Hello,

Vagrant Cascadian <vagrant <at> debian.org> skribis:

> * gnu/packages/finance.scm (electron-cash): New variable.

[...]

> +    (build-system python-build-system)
> +    (inputs
> +     `(("python-pyaes" ,python-pyaes)
> +       ("python-pysocks" ,python-pysocks)
> +       ("python-sip" ,python-sip)
> +       ("python-pyqt" ,python-pyqt)
> +       ("python-ecdsa" ,python-ecdsa)
> +       ("python-pbkdf2" ,python-pbkdf2)
> +       ("python-requests" ,python-requests)
> +       ("python-qrcode" ,python-qrcode)
> +       ("python-protobuf" ,python-protobuf)
> +       ("python-dnspython" ,python-dnspython)
> +       ("python-jsonrpclib-pelix" ,python-jsonrpclib-pelix)))
> +    (arguments
> +     `(#:tests? #f ;; package doesn't have any tests
> +       #:phases
> +       (modify-phases %standard-phases
> +         (add-before 'build 'patch-home
> +           (lambda* (#:key outputs #:allow-other-keys)
> +             (substitute* "setup.py"
> +               (("~/.local/share")
> +                (string-append (assoc-ref outputs "out") "/local/share"))))))))
> +    (home-page "https://electroncash.org/")

This seems to be pretty much the same thing as ‘electrum’.  Should we
define it as:

  (package
    (inherit electrum)
    (name "electron-cash")
    …)

?

Thanks,
Ludo’.

Message #11 received at 32130 <at> debbugs.gnu.org (full text, mbox):

From: Vagrant Cascadian <vagrant <at> debian.org>
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: 32130 <at> debbugs.gnu.org
Subject: Re: [bug#32130] [PATCH] gnu: Add electron-cash.
Date: Thu, 12 Jul 2018 15:40:44 -0700

[Message part 1 (text/plain, inline)]

On 2018-07-12, Ludovic Courtès wrote:
> Vagrant Cascadian <vagrant <at> debian.org> skribis:
>
>> * gnu/packages/finance.scm (electron-cash): New variable.
>
> [...]
>
>> +    (build-system python-build-system)
>> +    (inputs
>> +     `(("python-pyaes" ,python-pyaes)
>> +       ("python-pysocks" ,python-pysocks)
>> +       ("python-sip" ,python-sip)
>> +       ("python-pyqt" ,python-pyqt)
>> +       ("python-ecdsa" ,python-ecdsa)
>> +       ("python-pbkdf2" ,python-pbkdf2)
>> +       ("python-requests" ,python-requests)
>> +       ("python-qrcode" ,python-qrcode)
>> +       ("python-protobuf" ,python-protobuf)
>> +       ("python-dnspython" ,python-dnspython)
>> +       ("python-jsonrpclib-pelix" ,python-jsonrpclib-pelix)))
>> +    (arguments
>> +     `(#:tests? #f ;; package doesn't have any tests
>> +       #:phases
>> +       (modify-phases %standard-phases
>> +         (add-before 'build 'patch-home
>> +           (lambda* (#:key outputs #:allow-other-keys)
>> +             (substitute* "setup.py"
>> +               (("~/.local/share")
>> +                (string-append (assoc-ref outputs "out") "/local/share"))))))))
>> +    (home-page "https://electroncash.org/")
>
> This seems to be pretty much the same thing as ‘electrum’.  Should we
> define it as:
>
>   (package
>     (inherit electrum)
>     (name "electron-cash")
>     …)

Yes, it is a fork of electrum. The release cycles are independent and
possibly the needed inputs may differ over time. But for now that will
probably work fine.

live well,
  vagrant

[signature.asc (application/pgp-signature, inline)]

Message #14 received at 32130 <at> debbugs.gnu.org (full text, mbox):

From: Vagrant Cascadian <vagrant <at> debian.org>
To: Ludovic Courtès <ludo <at> gnu.org>
Subject: Re: [bug#32130] [PATCH] gnu: Add electron-cash.
Date: Fri, 13 Jul 2018 15:55:40 -0700

[Message part 1 (text/plain, inline)]

On 2018-07-12, Ludovic Courtès wrote:
> Vagrant Cascadian <vagrant <at> debian.org> skribis:
>
>> * gnu/packages/finance.scm (electron-cash): New variable.
...
> This seems to be pretty much the same thing as ‘electrum’.  Should we
> define it as:
>
>   (package
>     (inherit electrum)
>     (name "electron-cash")
>     …)

Updated patch attached inheriting from electrum.

live well,
  vagrant

[electron-cash-3.3-v2.patch (text/x-diff, inline)]

From 9e655d9cb2898b3ccdf2350b49ab75e6e542c297 Mon Sep 17 00:00:00 2001
From: Vagrant Cascadian <vagrant <at> debian.org>
Date: Fri, 13 Jul 2018 22:39:16 +0000
Subject: [PATCH] gnu: Add electron-cash.

* gnu/packages/finance.scm (electron-cash): New variable.
---
 gnu/packages/finance.scm | 31 +++++++++++++++++++++++++++++++
 1 file changed, 31 insertions(+)

diff --git a/gnu/packages/finance.scm b/gnu/packages/finance.scm
index 1d3e6a7a6..29bf3040e 100644
--- a/gnu/packages/finance.scm
+++ b/gnu/packages/finance.scm
@@ -329,6 +329,37 @@ generation from a seed.  Your secret keys are encrypted and are never sent to
 other machines/servers.  Electrum does not download the Bitcoin blockchain.")
     (license license:expat)))
 
+(define-public electron-cash
+  (package
+    (inherit electrum)
+    (name "electron-cash")
+    (version "3.3")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (string-append "https://electroncash.org/downloads/"
+                           version
+                           "/win-linux/ElectronCash-"
+                           version
+                           ".tar.gz"))
+       (sha256
+        (base32
+         "1x487hyacdm1qhik1mhfimr4jwcwz7sgsbkh11awrb6j19sxdxym"))
+       (modules '((guix build utils)))
+       (snippet
+        '(begin
+           ;; Delete the bundled dependencies.
+           (delete-file-recursively "packages")
+           #t))))
+    (home-page "https://electroncash.org/")
+    (synopsis "Bitcoin Cash wallet")
+    (description
+     "Electroncash is a lightweight Bitcoin Cash client, based on a client-server
+protocol.  It supports Simple Payment Verification (SPV) and deterministic key
+generation from a seed.  Your secret keys are encrypted and are never sent to
+other machines/servers.  Electroncash does not download the Bitcoin Cash blockchain.")
+    (license license:expat)))
+
 (define-public monero
   ;; This package bundles easylogging++ and lmdb.
   ;; The bundled easylogging++ is modified, and the changes will not be upstreamed.
-- 
2.18.0

[signature.asc (application/pgp-signature, inline)]

Message #19 received at 32130-done <at> debbugs.gnu.org (full text, mbox):

From: ludo <at> gnu.org (Ludovic Courtès)
To: Vagrant Cascadian <vagrant <at> debian.org>
Cc: 32130-done <at> debbugs.gnu.org
Subject: Re: [bug#32130] [PATCH] gnu: Add electron-cash.
Date: Mon, 16 Jul 2018 15:36:25 +0200

Vagrant Cascadian <vagrant <at> debian.org> skribis:

> From 9e655d9cb2898b3ccdf2350b49ab75e6e542c297 Mon Sep 17 00:00:00 2001
> From: Vagrant Cascadian <vagrant <at> debian.org>
> Date: Fri, 13 Jul 2018 22:39:16 +0000
> Subject: [PATCH] gnu: Add electron-cash.
>
> * gnu/packages/finance.scm (electron-cash): New variable.

Applied, thanks!

Ludo'.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.