From unknown Thu Aug 14 21:42:43 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#3213 <3213@debbugs.gnu.org> To: bug#3213 <3213@debbugs.gnu.org> Subject: Status: 23.0.92; vc-svn-parse-status doesn't recognize deleted files Reply-To: bug#3213 <3213@debbugs.gnu.org> Date: Fri, 15 Aug 2025 04:42:43 +0000 retitle 3213 23.0.92; vc-svn-parse-status doesn't recognize deleted files reassign 3213 emacs submitter 3213 Bob Rogers severity 3213 normal thanks From rogers-emacs@rgrjr.dyndns.org Mon May 4 15:14:24 2009 Received: (at submit) by emacsbugs.donarmstrong.com; 4 May 2009 22:14:24 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=0.1 required=4.0 tests=FOURLA,MURPHY_DRUGS_REL8 autolearn=no version=3.2.5-bugs.debian.org_2005_01_02 Received: from fencepost.gnu.org (fencepost.gnu.org [140.186.70.10]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id n44MEHrJ026236 for ; Mon, 4 May 2009 15:14:19 -0700 Received: from mx10.gnu.org ([199.232.76.166]:34693) by fencepost.gnu.org with esmtp (Exim 4.67) (envelope-from ) id 1M16QT-0007W6-4w for emacs-pretest-bug@gnu.org; Mon, 04 May 2009 18:14:17 -0400 Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim 4.60) (envelope-from ) id 1M16QQ-0008Jd-Ve for emacs-pretest-bug@gnu.org; Mon, 04 May 2009 18:14:17 -0400 Received: from rgrjr.com ([216.146.47.5]:42799) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1M16QQ-0008JU-LC for emacs-pretest-bug@gnu.org; Mon, 04 May 2009 18:14:14 -0400 Received: from rgrjr.dyndns.org (c-66-30-196-77.hsd1.ma.comcast.net [66.30.196.77]) by rgrjr.com (Postfix on CentOS) with ESMTP id 2424A16011E for ; Mon, 4 May 2009 22:14:14 +0000 (UTC) Received: (qmail 15173 invoked by uid 89); 4 May 2009 22:14:13 -0000 Received: from unknown (HELO rgr.rgrjr.com) (192.168.57.1) by home with SMTP; 4 May 2009 22:14:13 -0000 Received: by rgr.rgrjr.com (Postfix, from userid 500) id 145794862E; Mon, 4 May 2009 18:14:12 -0400 (EDT) From: Bob Rogers To: emacs-pretest-bug@gnu.org Subject: 23.0.92; vc-svn-parse-status doesn't recognize deleted files Message-Id: <20090504221412.145794862E@rgr.rgrjr.com> Date: Mon, 4 May 2009 18:14:12 -0400 (EDT) X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 3) To reproduce: 1. "emacs -Q" in a Subversion working copy (I'm using a 1.5.0 client). 2. "C-x v d" to get in to VC dir mode. 3. Flag any file for removal via M-x vc-delete-file. The deleted file will show up in the VC dir window as "edited" rather than removed (and can be reverted afterwards). This seems to be a simple case of failing to recognize "D" as meaning deletion in vc-svn-parse-status; it only knows about "R". The patch below adds "D" as a synonym, as I assume "R" is still necessary for compatibility with older versions of Subversion. (Though if SVN ever did use "R", I don't remember it.) -- Bob Rogers http://www.rgrjr.com/ ------------------------------------------------------------------------ Index: lisp/vc-svn.el =================================================================== RCS file: /sources/emacs/emacs/lisp/vc-svn.el,v retrieving revision 1.113 diff -c -r1.113 vc-svn.el *** lisp/vc-svn.el 15 Apr 2009 00:32:51 -0000 1.113 --- lisp/vc-svn.el 4 May 2009 21:59:32 -0000 *************** *** 662,668 **** 'edited)) ((eq status ?I) (vc-file-setprop file 'vc-state 'ignored)) ! ((eq status ?R) (vc-file-setprop file 'vc-state 'removed)) (t 'edited))))) (when filename (vc-file-getprop filename 'vc-state)))) --- 662,668 ---- 'edited)) ((eq status ?I) (vc-file-setprop file 'vc-state 'ignored)) ! ((memq status '(?D ?R)) (vc-file-setprop file 'vc-state 'removed)) (t 'edited))))) (when filename (vc-file-getprop filename 'vc-state)))) ------------------------------------------------------------------------ In GNU Emacs 23.0.92.1 (i686-pc-linux-gnu, GTK+ Version 2.12.9) of 2009-04-24 on rgr Windowing system distributor `The X.Org Foundation', version 11.0.10400090 Important settings: value of $LC_ALL: nil value of $LC_COLLATE: nil value of $LC_CTYPE: nil value of $LC_MESSAGES: nil value of $LC_MONETARY: nil value of $LC_NUMERIC: nil value of $LC_TIME: nil value of $LANG: en_US.UTF-8 value of $XMODIFIERS: nil locale-coding-system: utf-8-unix default-enable-multibyte-characters: t Major mode: VM Minor modes in effect: mc-read-mode: t diff-auto-refine-mode: t shell-dirtrack-mode: t mouse-wheel-mode: t menu-bar-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t blink-cursor-mode: t auto-encryption-mode: t auto-compression-mode: t line-number-mode: t Recent input: e v e r t SPC f o o M-p M-p M-p M-p s v n SPC d i f f SPC l i s p - M-b - M-b c v s SPC M-f C-f C-f u SPC c SPC C-e / v c - s v C-x o C-u C-u C-n C-c C-c C-e C-M-b ( o C-r m e m q C-r C-u C-SPC C-f m C-f m M-f M-f C-f ' ( M-f SPC ? R ) C-e C-M-b C-M-f C-M-f C-e C-M-b C-M-b C-M-f C-M-f C-c C-c C-x C-s M-p M-p C-_ C-x C-b C-n d C-n C-n SPC C-e C-M-b ( m e m b q SPC M-d M-f SPC ' ( R ? R M-t C-e ) C-c C-c C-M-b C-M-f C-M-f C-e C-M-b C-M-b C-M-f C-M-f C-x d g q C-x C-s C-x d g p p B SPC g g q q C-_ p w d s r c / e m a SPC - Q SPC ~ / p r o t e s 2 / t e f o s v n SPC s t a t s v n SPC s t a t s v n SPC r e v e r t SPC f o M-p M-p M-p M-p C-x C-b C-s * m a i C-a SPC M-< C-n C-n C-e s v c C-n C-n C-n C-n M-> C-w C-x k C-x b e m M-x v c e r e p o r Recent messages: Partially completed Completed Partially completed Completed History item: 1 History item: 2 History item: 3 History item: 4 Mark saved where search started Mark set [2 times] From monnier@iro.umontreal.ca Mon May 4 21:18:12 2009 Received: (at 3213-done) by emacsbugs.donarmstrong.com; 5 May 2009 04:18:13 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=-2.6 required=4.0 tests=AWL,HAS_BUG_NUMBER, MURPHY_DRUGS_REL8,XIRONPORT autolearn=ham version=3.2.5-bugs.debian.org_2005_01_02 Received: from ironport2-out.teksavvy.com (ironport2-out.pppoe.ca [206.248.154.182]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id n454I9Lj031581 for <3213-done@emacsbugs.donarmstrong.com>; Mon, 4 May 2009 21:18:11 -0700 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: AhoFAE5b/0nO+IYe/2dsb2JhbACBUMx2g30FhUk X-IronPort-AV: E=Sophos;i="4.40,295,1238990400"; d="scan'208";a="37996983" Received: from 206-248-134-30.dsl.teksavvy.com (HELO pastel.home) ([206.248.134.30]) by ironport2-out.teksavvy.com with ESMTP; 05 May 2009 00:18:04 -0400 Received: by pastel.home (Postfix, from userid 20848) id 32B647FDC; Tue, 5 May 2009 00:18:04 -0400 (EDT) From: Stefan Monnier To: Bob Rogers Cc: 3213-done@debbugs.gnu.org Subject: Re: bug#3213: 23.0.92; vc-svn-parse-status doesn't recognize deleted files Message-ID: References: <20090504221412.145794862E@rgr.rgrjr.com> Date: Tue, 05 May 2009 00:18:04 -0400 In-Reply-To: <20090504221412.145794862E@rgr.rgrjr.com> (Bob Rogers's message of "Mon, 4 May 2009 18:14:12 -0400 (EDT)") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.0.93 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii > This seems to be a simple case of failing to recognize "D" as meaning > deletion in vc-svn-parse-status; it only knows about "R". The patch Thanks, installed. Stefan From unknown Thu Aug 14 21:42:43 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: $requester Subject: Internal Control Message-Id: bug archived. Date: Tue, 02 Jun 2009 14:24:09 +0000 User-Agent: Fakemail v42.6.9 # A New Hope # A log time ago, in a galaxy far, far away # something happened. # # Magically this resulted in the following # action being taken, but this fake control # message doesn't tell you why it happened # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator