GNU bug report logs - #32121
Cuirass: add support for multiple inputs

Previous Next

Full log

Message #35 received at 32121 <at> debbugs.gnu.org (full text, mbox):

From: Clément Lassieur <clement <at> lassieur.org>
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: 32121 <at> debbugs.gnu.org
Subject: Re: [bug#32121] [PATCH 1/5] base: Compile CHECKOUT in the fiber.
Date: Fri, 13 Jul 2018 10:55:27 +0200

Morning :-)

Ludovic Courtès <ludo <at> gnu.org> writes:

> Morning!
>
> Clément Lassieur <clement <at> lassieur.org> skribis:
>
>> Because it may take time and thus prevent PROCESS-SPECS to run every INTERVAL
>> seconds.
>>
>> * src/cuirass/base.scm (process-specs): move the COMPILE invocation inside
>> SPAWN-FIBER's thunk.  Add log message.
>
> [...]
>
>> -               (when compile?
>> -                 (non-blocking (compile checkout)))
>> -
>>                 (spawn-fiber
>>                  (lambda ()
>> +                  (when compile?
>> +                    (log-message "compiling '~a' with commit ~s" name commit)
>> +                    (non-blocking (compile checkout)))
>
> I think this doesn’t bring anything compared to the existing
> ‘non-blocking’ call.
> The ‘non-blocking’ procedure evaluates its argument in a separate
> thread; the calling fiber then “waits” for a message from that thread,
> which it gets when the computation is over.  The ‘get-message’ is
> non-blocking though: the calling fiber is simply unscheduled until the
> message has arrived.
>
> Does that make sense?

Well, no :-)

My understanding is that non-blocking is, actually... blocking, because
get-message is blocking.  (It doesn't block the scheduler because it's
in another thread, but that's not the problem here.)

What I wanted to fix here is the fact that if the build takes one hour,
we will block for one hour in the COMPILE call, and process-spec won't
return for one hour.  If it doesn't return for one hour, that means we
can't evaluate anything else for all that time.

With my change, the one-hour call will be in the fiber, which means that
process-spec can return, and other evaluations can be processed.

But this is untested (because compilation doesn't work IIRC), so I can't
be sure.

Clément

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.