GNU bug report logs - #32121
Cuirass: add support for multiple inputs

Previous Next

Package: guix-patches;

Reported by: Clément Lassieur <clement <at> lassieur.org>

Date: Tue, 10 Jul 2018 22:59:02 UTC

Severity: normal

Done: Clément Lassieur <clement <at> lassieur.org>

Bug is archived. No further changes may be made.

Full log


View this message in rfc822 format

From: ludo <at> gnu.org (Ludovic Courtès)
To: Clément Lassieur <clement <at> lassieur.org>
Cc: 32121 <at> debbugs.gnu.org
Subject: [bug#32121] [PATCH 1/5] base: Compile CHECKOUT in the fiber.
Date: Fri, 13 Jul 2018 10:32:41 +0200
Morning!

Clément Lassieur <clement <at> lassieur.org> skribis:

> Because it may take time and thus prevent PROCESS-SPECS to run every INTERVAL
> seconds.
>
> * src/cuirass/base.scm (process-specs): move the COMPILE invocation inside
> SPAWN-FIBER's thunk.  Add log message.

[...]

> -               (when compile?
> -                 (non-blocking (compile checkout)))
> -
>                 (spawn-fiber
>                  (lambda ()
> +                  (when compile?
> +                    (log-message "compiling '~a' with commit ~s" name commit)
> +                    (non-blocking (compile checkout)))

I think this doesn’t bring anything compared to the existing
‘non-blocking’ call.

The ‘non-blocking’ procedure evaluates its argument in a separate
thread; the calling fiber then “waits” for a message from that thread,
which it gets when the computation is over.  The ‘get-message’ is
non-blocking though: the calling fiber is simply unscheduled until the
message has arrived.

Does that make sense?

Ludo’.




This bug report was last modified 7 years and 5 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.