From unknown Fri Jun 20 18:22:26 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#32116 <32116@debbugs.gnu.org> To: bug#32116 <32116@debbugs.gnu.org> Subject: Status: Allow bytevector as content of plain-file for binary data. Reply-To: bug#32116 <32116@debbugs.gnu.org> Date: Sat, 21 Jun 2025 01:22:26 +0000 retitle 32116 Allow bytevector as content of plain-file for binary data. reassign 32116 guix-patches submitter 32116 Jan Nieuwenhuizen severity 32116 normal tag 32116 patch thanks From debbugs-submit-bounces@debbugs.gnu.org Tue Jul 10 13:41:44 2018 Received: (at submit) by debbugs.gnu.org; 10 Jul 2018 17:41:44 +0000 Received: from localhost ([127.0.0.1]:54304 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fcwe0-0002vf-I2 for submit@debbugs.gnu.org; Tue, 10 Jul 2018 13:41:44 -0400 Received: from eggs.gnu.org ([208.118.235.92]:56644) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fcwdy-0002vH-Q1 for submit@debbugs.gnu.org; Tue, 10 Jul 2018 13:41:43 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fcwds-0006oh-RI for submit@debbugs.gnu.org; Tue, 10 Jul 2018 13:41:37 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:50090) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1fcwds-0006oM-OS for submit@debbugs.gnu.org; Tue, 10 Jul 2018 13:41:36 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:47592) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fcwdr-0000eO-DM for guix-patches@gnu.org; Tue, 10 Jul 2018 13:41:36 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fcwdq-0006nE-GW for guix-patches@gnu.org; Tue, 10 Jul 2018 13:41:35 -0400 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:35383) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fcwdq-0006n3-CI; Tue, 10 Jul 2018 13:41:34 -0400 Received: from [2001:980:1b4f:1:42d2:832d:bb59:862] (port=47140 helo=dundal.fritz.box) by fencepost.gnu.org with esmtpa (Exim 4.82) (envelope-from ) id 1fcwdp-0005Bz-Si; Tue, 10 Jul 2018 13:41:34 -0400 From: Jan Nieuwenhuizen To: guix-patches@gnu.org Subject: Allow bytevector as content of plain-file for binary data. Date: Tue, 10 Jul 2018 19:41:26 +0200 Message-Id: <20180710174128.6360-1-janneke@gnu.org> X-Mailer: git-send-email 2.18.0 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -6.0 (------) Currently, plain-file does not handle binary content correctly. As discussed on IRC[0] I added bytevector support to plain-file. This allows for using a package source directly from git, doing something like --8<---------------cut here---------------start------------->8--- (define (command->bytevector command) (let ((port (apply open-pipe* OPEN_READ command))) (let ((output (get-bytevector-all port))) (close-port port) output))) (define-public hello-git (package (name "hello") (version "git") (source (let* ((commit "stable-2.0") (content (command->bytevector `("git" "archive" "--format" "tar" "--prefix" ,(string-append commit "/") ,commit))) (file-name (string-append "hello-" commit))) (plain-file file-name content))) ... )) --8<---------------cut here---------------end--------------->8--- Greetings, janneke [0] https://gnunet.org/bot/log/guix/2018-07-10#T1763807 From debbugs-submit-bounces@debbugs.gnu.org Tue Jul 10 14:03:06 2018 Received: (at control) by debbugs.gnu.org; 10 Jul 2018 18:03:06 +0000 Received: from localhost ([127.0.0.1]:54322 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fcwyg-0005TC-Cw for submit@debbugs.gnu.org; Tue, 10 Jul 2018 14:03:06 -0400 Received: from eggs.gnu.org ([208.118.235.92]:34044) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fcwyc-0005Se-I7 for control@debbugs.gnu.org; Tue, 10 Jul 2018 14:03:04 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fcwyW-0000yp-LL for control@debbugs.gnu.org; Tue, 10 Jul 2018 14:02:57 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:35827) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fcwyW-0000yk-Gz for control@debbugs.gnu.org; Tue, 10 Jul 2018 14:02:56 -0400 Received: from [2001:980:1b4f:1:42d2:832d:bb59:862] (port=47206 helo=dundal.peder.onsbrabantnet.nl) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1fcwyV-0005gr-Tl for control@debbugs.gnu.org; Tue, 10 Jul 2018 14:02:56 -0400 Date: Tue, 10 Jul 2018 20:02:51 +0200 Message-Id: <87in5nm0j8.fsf@gnu.org> To: control@debbugs.gnu.org From: Jan Nieuwenhuizen Subject: control message for bug #32116 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -6.0 (------) merge 32116 32117 From debbugs-submit-bounces@debbugs.gnu.org Tue Jul 10 14:03:21 2018 Received: (at control) by debbugs.gnu.org; 10 Jul 2018 18:03:21 +0000 Received: from localhost ([127.0.0.1]:54325 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fcwyt-0005Te-Mu for submit@debbugs.gnu.org; Tue, 10 Jul 2018 14:03:21 -0400 Received: from eggs.gnu.org ([208.118.235.92]:34104) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fcwys-0005TP-1F for control@debbugs.gnu.org; Tue, 10 Jul 2018 14:03:18 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fcwym-00012R-D5 for control@debbugs.gnu.org; Tue, 10 Jul 2018 14:03:13 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:35832) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fcwym-00012N-AB for control@debbugs.gnu.org; Tue, 10 Jul 2018 14:03:12 -0400 Received: from [2001:980:1b4f:1:42d2:832d:bb59:862] (port=47210 helo=dundal.peder.onsbrabantnet.nl) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1fcwyl-000684-Qr for control@debbugs.gnu.org; Tue, 10 Jul 2018 14:03:12 -0400 Date: Tue, 10 Jul 2018 20:03:08 +0200 Message-Id: <87h8l7m0ir.fsf@gnu.org> To: control@debbugs.gnu.org From: Jan Nieuwenhuizen Subject: control message for bug #32116 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -6.0 (------) merge 32116 32118 From debbugs-submit-bounces@debbugs.gnu.org Wed Jul 11 18:09:52 2018 Received: (at 32116) by debbugs.gnu.org; 11 Jul 2018 22:09:52 +0000 Received: from localhost ([127.0.0.1]:56025 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fdNJ1-0007Vf-Mj for submit@debbugs.gnu.org; Wed, 11 Jul 2018 18:09:51 -0400 Received: from eggs.gnu.org ([208.118.235.92]:60773) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fdNIx-0007VP-Bs for 32116@debbugs.gnu.org; Wed, 11 Jul 2018 18:09:47 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fdNIr-0002pr-AG for 32116@debbugs.gnu.org; Wed, 11 Jul 2018 18:09:42 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:59478) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fdNIl-0002M5-74; Wed, 11 Jul 2018 18:09:35 -0400 Received: from [2a01:e0a:1d:7270:af76:b9b:ca24:c465] (port=59940 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1fdNIk-0000IL-NP; Wed, 11 Jul 2018 18:09:35 -0400 From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=) To: Jan Nieuwenhuizen Subject: Re: [bug#32117] [PATCH 1/2] store: Add `binary-file'. References: <20180710174128.6360-1-janneke@gnu.org> <20180710174128.6360-2-janneke@gnu.org> Date: Thu, 12 Jul 2018 00:09:33 +0200 In-Reply-To: <20180710174128.6360-2-janneke@gnu.org> (Jan Nieuwenhuizen's message of "Tue, 10 Jul 2018 19:41:27 +0200") Message-ID: <87y3ehh1b6.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 32116 Cc: 32116@debbugs.gnu.org, 32117@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -6.0 (------) Hello, Jan Nieuwenhuizen skribis: > * guix/store.scm (binary-file): New function. > * doc/guix.texi (G-Expressions): Describe binary-file*. [...] > +@deffn {Monadic Procedure} binary-file* @var{name} @var{data} @dots{} There=E2=80=99s no =E2=80=98*=E2=80=99 in the actual procedure name. Also, could you move this @deffn to =E2=80=9CThe Store Monad=E2=80=9D, righ= t after =E2=80=98text-file=E2=80=99? Apart from that it LGTM, thanks! Ludo=E2=80=99. From debbugs-submit-bounces@debbugs.gnu.org Wed Jul 11 18:10:07 2018 Received: (at 32116) by debbugs.gnu.org; 11 Jul 2018 22:10:07 +0000 Received: from localhost ([127.0.0.1]:56034 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fdNJH-0007Wy-AL for submit@debbugs.gnu.org; Wed, 11 Jul 2018 18:10:07 -0400 Received: from eggs.gnu.org ([208.118.235.92]:32846) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fdNJG-0007W9-Aa for 32116@debbugs.gnu.org; Wed, 11 Jul 2018 18:10:06 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fdNJA-000465-9g for 32116@debbugs.gnu.org; Wed, 11 Jul 2018 18:10:01 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:59492) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fdNJ6-0003qp-6s; Wed, 11 Jul 2018 18:09:56 -0400 Received: from [2a01:e0a:1d:7270:af76:b9b:ca24:c465] (port=59942 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1fdNJ5-0000JJ-R3; Wed, 11 Jul 2018 18:09:56 -0400 From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=) To: Jan Nieuwenhuizen Subject: Re: [bug#32117] [PATCH 1/2] store: Add `binary-file'. In-Reply-To: <20180710174128.6360-2-janneke@gnu.org> (Jan Nieuwenhuizen's message of "Tue, 10 Jul 2018 19:41:27 +0200") References: <20180710174128.6360-1-janneke@gnu.org> <20180710174128.6360-2-janneke@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) Date: Thu, 12 Jul 2018 00:09:54 +0200 Message-ID: <87wou1h1al.fsf@gnu.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 32116 Cc: 32116@debbugs.gnu.org, 32117@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -6.0 (------) Hello, Jan Nieuwenhuizen skribis: > * guix/store.scm (binary-file): New function. > * doc/guix.texi (G-Expressions): Describe binary-file*. [...] > +@deffn {Monadic Procedure} binary-file* @var{name} @var{data} @dots{} There=E2=80=99s no =E2=80=98*=E2=80=99 in the actual procedure name. Also, could you move this @deffn to =E2=80=9CThe Store Monad=E2=80=9D, righ= t after =E2=80=98text-file=E2=80=99? Apart from that it LGTM, thanks! Ludo=E2=80=99. From debbugs-submit-bounces@debbugs.gnu.org Wed Jul 11 18:11:48 2018 Received: (at 32116) by debbugs.gnu.org; 11 Jul 2018 22:11:48 +0000 Received: from localhost ([127.0.0.1]:56042 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fdNKt-0007Zd-Ty for submit@debbugs.gnu.org; Wed, 11 Jul 2018 18:11:48 -0400 Received: from eggs.gnu.org ([208.118.235.92]:33783) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fdNKs-0007ZS-LK for 32116@debbugs.gnu.org; Wed, 11 Jul 2018 18:11:46 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fdNKm-0005Wu-LM for 32116@debbugs.gnu.org; Wed, 11 Jul 2018 18:11:41 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:59521) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fdNKf-0005U4-Ex; Wed, 11 Jul 2018 18:11:33 -0400 Received: from [2a01:e0a:1d:7270:af76:b9b:ca24:c465] (port=59944 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1fdNKf-0000RH-1X; Wed, 11 Jul 2018 18:11:33 -0400 From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=) To: Jan Nieuwenhuizen Subject: Re: [bug#32118] [PATCH 2/2] gexp: Allow bytevector as content of `plain-file'. References: <20180710174128.6360-1-janneke@gnu.org> <20180710174128.6360-3-janneke@gnu.org> Date: Thu, 12 Jul 2018 00:11:31 +0200 In-Reply-To: <20180710174128.6360-3-janneke@gnu.org> (Jan Nieuwenhuizen's message of "Tue, 10 Jul 2018 19:41:28 +0200") Message-ID: <87sh4ph17w.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 32116 Cc: 32116@debbugs.gnu.org, 32118@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -6.0 (------) Jan Nieuwenhuizen skribis: > This allows for using a package source directly from git, doing something like > > (define (command->bytevector command) > (let ((port (apply open-pipe* OPEN_READ command))) > (let ((output (get-bytevector-all port))) > (close-port port) > output))) > > (define-public hello-git > (package > (name "hello") > (version "git") > (source (let* ((commit "stable-2.0") > (content (command->bytevector > `("git" "archive" "--format" "tar" "--prefix" > ,(string-append commit "/") ,commit))) > (file-name (string-append "hello-" commit))) > (plain-file file-name content))) > ... > )) > > * guix/gexp.scm (): Also allow bytevector content. > (plain-file-compiler): Handle bytevector content. > * doc/guix.texi (G-Expressions): Describe plain-file now also taking > bytevectors. LGTM, thanks! Ludo'. From debbugs-submit-bounces@debbugs.gnu.org Thu Jul 12 00:30:56 2018 Received: (at 32116-done) by debbugs.gnu.org; 12 Jul 2018 04:30:56 +0000 Received: from localhost ([127.0.0.1]:56196 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fdTFm-0001VB-5z for submit@debbugs.gnu.org; Thu, 12 Jul 2018 00:30:55 -0400 Received: from eggs.gnu.org ([208.118.235.92]:44540) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fdTFk-0001Ux-6l for 32116-done@debbugs.gnu.org; Thu, 12 Jul 2018 00:30:52 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fdTFe-0001V3-3k for 32116-done@debbugs.gnu.org; Thu, 12 Jul 2018 00:30:47 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:36023) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fdTFW-0001Lx-Rd; Thu, 12 Jul 2018 00:30:38 -0400 Received: from [2001:980:1b4f:1:42d2:832d:bb59:862] (port=50448 helo=dundal.peder.onsbrabantnet.nl) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1fdTFW-0001ny-AT; Thu, 12 Jul 2018 00:30:38 -0400 From: Jan Nieuwenhuizen To: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=) Subject: Re: [bug#32117] [PATCH 1/2] store: Add `binary-file'. Organization: AvatarAcademy.nl References: <20180710174128.6360-1-janneke@gnu.org> <20180710174128.6360-2-janneke@gnu.org> <87y3ehh1b6.fsf@gnu.org> X-Url: http://AvatarAcademy.nl Date: Thu, 12 Jul 2018 06:30:31 +0200 In-Reply-To: <87y3ehh1b6.fsf@gnu.org> ("Ludovic \=\?utf-8\?Q\?Court\=C3\=A8s\=22'\?\= \=\?utf-8\?Q\?s\?\= message of "Thu, 12 Jul 2018 00:09:33 +0200") Message-ID: <87tvp5jct4.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 32116-done Cc: 32116-done@debbugs.gnu.org, 32117-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -6.0 (------) Ludovic Court=C3=A8s writes: >> +@deffn {Monadic Procedure} binary-file* @var{name} @var{data} @dots{} > > There=E2=80=99s no =E2=80=98*=E2=80=99 in the actual procedure name. > > Also, could you move this @deffn to =E2=80=9CThe Store Monad=E2=80=9D, ri= ght after > =E2=80=98text-file=E2=80=99? Ah, I based this on the `text-file*' description! Moved, and rewritten as @deffn {Monadic Procedure} binary-file @var{name} @var{data} [@var{referenc= es}] Return as a monadic value the absolute file name in the store of the file containing @var{data}, a bytevector. @var{references} is a list of store items that the resulting binary file refers to; it defaults to the empty li= st. @end deffn > Apart from that it LGTM, thanks! Pushed to master as f3a422511f793fb6c6cfeec2bb8735965a03294a janneke --=20 Jan Nieuwenhuizen | GNU LilyPond http://lilypond.org Freelance IT http://JoyofSource.com | Avatar=C2=AE http://AvatarAcademy.com From debbugs-submit-bounces@debbugs.gnu.org Thu Jul 12 00:31:59 2018 Received: (at 32116-done) by debbugs.gnu.org; 12 Jul 2018 04:31:59 +0000 Received: from localhost ([127.0.0.1]:56211 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fdTGp-0001Xs-5C for submit@debbugs.gnu.org; Thu, 12 Jul 2018 00:31:59 -0400 Received: from eggs.gnu.org ([208.118.235.92]:45434) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fdTGo-0001Xe-31 for 32116-done@debbugs.gnu.org; Thu, 12 Jul 2018 00:31:58 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fdTGi-0002zO-0Z for 32116-done@debbugs.gnu.org; Thu, 12 Jul 2018 00:31:53 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:36044) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fdTGb-0002fK-T1; Thu, 12 Jul 2018 00:31:45 -0400 Received: from [2001:980:1b4f:1:42d2:832d:bb59:862] (port=50450 helo=dundal.peder.onsbrabantnet.nl) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1fdTGb-0003FZ-4u; Thu, 12 Jul 2018 00:31:45 -0400 From: Jan Nieuwenhuizen To: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=) Subject: Re: [bug#32118] [PATCH 2/2] gexp: Allow bytevector as content of `plain-file'. Organization: AvatarAcademy.nl References: <20180710174128.6360-1-janneke@gnu.org> <20180710174128.6360-3-janneke@gnu.org> <87sh4ph17w.fsf@gnu.org> X-Url: http://AvatarAcademy.nl Date: Thu, 12 Jul 2018 06:31:38 +0200 In-Reply-To: <87sh4ph17w.fsf@gnu.org> ("Ludovic \=\?utf-8\?Q\?Court\=C3\=A8s\=22'\?\= \=\?utf-8\?Q\?s\?\= message of "Thu, 12 Jul 2018 00:11:31 +0200") Message-ID: <87pnztjcr9.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 32116-done Cc: 32116-done@debbugs.gnu.org, 32118-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -6.0 (------) Ludovic Court=C3=A8s writes: >> * guix/gexp.scm (): Also allow bytevector content. >> (plain-file-compiler): Handle bytevector content. >> * doc/guix.texi (G-Expressions): Describe plain-file now also taking >> bytevectors. > > LGTM, thanks! Pushed to master as e8e1f295f15fa56660a2c460d422795b1a31bed8 janneke --=20 Jan Nieuwenhuizen | GNU LilyPond http://lilypond.org Freelance IT http://JoyofSource.com | Avatar=C2=AE http://AvatarAcademy.com From unknown Fri Jun 20 18:22:26 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Thu, 09 Aug 2018 11:24:04 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator