GNU bug report logs - #32102
[PATCH] utils: Fix wrap-program filename generation.

Previous Next

Package: guix-patches;

Reported by: Arun Isaac <arunisaac <at> systemreboot.net>

Date: Mon, 9 Jul 2018 01:32:02 UTC

Severity: normal

Tags: patch

Done: Arun Isaac <arunisaac <at> systemreboot.net>

Bug is archived. No further changes may be made.

Full log


Message #38 received at 32102 <at> debbugs.gnu.org (full text, mbox):

From: Arun Isaac <arunisaac <at> systemreboot.net>
To: Clément Lassieur <clement <at> lassieur.org>
Cc: mhw <at> netris.org, andreas <at> enge.fr, 32102 <at> debbugs.gnu.org
Subject: Re: [PATCH v2 1/2] build-system: python: Only wrap non-hidden
 executable files.
Date: Fri, 13 Jul 2018 14:05:31 +0530
> What about adding a function like 'is-wrapped?'?  Because it could be
> used somewhere else, and it would make the code self-descriptive.
>
> It would check that the name looks like .xxx-real, and also check that
> xxx exists.  (And check that it's an executable.)

Yes, that's a good idea. I'll add `is-wrapped?' to (guix build utils)
and export it. That way, both `wrap-program' from (guix build utils) and
the wrap phase from python-build-system can make use of it. I will send
an updated patchset once I'm done.




This bug report was last modified 6 years and 256 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.