GNU bug report logs - #32095
[PATCH 0/2] Update libuv and node

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Mathieu Lirzin <mthl <at> gnu.org>
Subject: bug#32095: closed (Re: [bug#32095] [PATCH 2/2] gnu: node: Update
 to 10.6.0.)
Date: Tue, 25 Sep 2018 22:46:02 +0000

[Message part 1 (text/plain, inline)]

Your bug report

#32095: [PATCH 0/2] Update libuv and node

which was filed against the guix-patches package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to 32095 <at> debbugs.gnu.org.

-- 
32095: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=32095
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Marius Bakke <mbakke <at> fastmail.com>
To: Mathieu Lirzin <mthl <at> gnu.org>
Cc: Ludovic Courtès <ludo <at> gnu.org>, 32095-done <at> debbugs.gnu.org
Subject: Re: [bug#32095] [PATCH 2/2] gnu: node: Update to 10.6.0.
Date: Wed, 26 Sep 2018 00:45:26 +0200

[Message part 3 (text/plain, inline)]

Mathieu Lirzin <mthl <at> gnu.org> writes:

> Marius Bakke <mbakke <at> fastmail.com> writes:
>
>> I managed to build Node LTS on 'core-updates' with this patch:
>>
>> From 9556fc13a77d2619cfd1e861f0269bccf0a58986 Mon Sep 17 00:00:00 2001
>> From: Marius Bakke <mbakke <at> fastmail.com>
>> Date: Sun, 23 Sep 2018 13:12:23 +0200
>> Subject: [PATCH] gnu: Add Node LTS.
>>
>> * gnu/packages/libevent.scm (libuv-1.19): New public variable.
>> * gnu/packages/node.scm (node)[arguments]: Adjust 'patch-files' phase to
>> ignore missing files.
>> (node-lts): New public variable.
>> ---
>>  gnu/packages/libevent.scm | 13 +++++++++++++
>>  gnu/packages/node.scm     | 30 +++++++++++++++++++++++++++---
>>  2 files changed, 40 insertions(+), 3 deletions(-)
>
> Excellent! The patch looks good to me.

It turned out the OpenSSL related test failure when I first tried this
on 'master' was due to recently expired TLS certificates, and not
due to a difference in OpenSSL version on 'core-updates'.

So I pushed another patch to disable tests that require valid TLS
certificates (it also caused the current Node package to FTBFS), and
then the Node LTS patch to 'master'.

Thanks for the review!

[signature.asc (application/pgp-signature, inline)]

[Message part 5 (message/rfc822, inline)]

From: Mathieu Lirzin <mthl <at> gnu.org>
To: guix-patches <at> gnu.org
Cc: Mathieu Lirzin <mthl <at> gnu.org>
Subject: [PATCH 0/2] Update libuv and node
Date: Sun,  8 Jul 2018 17:16:39 +0200

Node now requires a newer ‘libuv’ and doesn't build without ‘openssl-next’.

Mathieu Lirzin (2):
  gnu: libuv: Update to 1.21.0.
  gnu: node: Update to 10.6.0.

 gnu/packages/libevent.scm | 4 ++--
 gnu/packages/node.scm     | 6 +++---
 2 files changed, 5 insertions(+), 5 deletions(-)

-- 
2.18.0

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.