Subject: Re: bug#32093: 27.0.50; M-x grep appends /dev/null to command line

From: David Kastrup <[email-masked]>
Date: Tue, 10 Jul 2018 09:33:29 +0200

Noam Postavsky <[email-masked]> writes:

>>>From 3b0f302b7d06c37cc6fbff2f1e18904020de51f2 Mon Sep 17 00:00:00 2001
> From: Noam Postavsky <[email-masked]>
> Date: Mon, 9 Jul 2018 17:38:40 -0400
> Subject: [PATCH v1] Use README instead of HELLO for grep probing (Bug#32093)
>
> * lisp/progmodes/grep.el (grep-compute-defaults): Check README for the
> string COPYRIGHT; HELLO no longer has "English" at the beginning of a
> line since 2018-05-19 "Use Enriched mode in etc/HELLO to keep charset
> information".
> ---
>  lisp/progmodes/grep.el | 14 +++++++-------
>  1 file changed, 7 insertions(+), 7 deletions(-)
>
> diff --git a/lisp/progmodes/grep.el b/lisp/progmodes/grep.el
> index b7c44d6083..b466e205b8 100644
> --- a/lisp/progmodes/grep.el
> +++ b/lisp/progmodes/grep.el
> @@ -626,28 +626,28 @@ grep-compute-defaults
>      (unless (or (not grep-use-null-device) (eq grep-use-null-device t))
>        (setq grep-use-null-device
>  	    (with-temp-buffer
> -	      (let ((hello-file (expand-file-name "HELLO" data-directory)))
> +	      (let ((hello-file (expand-file-name "README" data-directory)))

Using `hello-file' for indicating "README" does not particularly help
reading comprehension.

-- 
David Kastrup