GNU bug report logs - #3209
23.0.92; vc-delete-file is not autoloaded

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 3209 in the body.
You can then email your comments to 3209 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> emacsbugs.donarmstrong.com (full text, mbox):

From: Bob Rogers <rogers-emacs <at> rgrjr.dyndns.org>
To: emacs-pretest-bug <at> gnu.org
Subject: 23.0.92; vc-delete-file is not autoloaded
Date: Mon, 4 May 2009 15:53:24 -0400

   If I do "emacs -Q vc-controlled-file", I then find that I can't do
"M-x vc-delete-file" immediately, because this command is undefined.
It's in vc.el, and the mode line shows that Emacs knows the file is
under version control, so I assume that vc.el must not be loaded as a
side-effect of finding a version-controlled file.  So shouldn't
vc-delete-file be autoloaded in that case?  (And possibly other commands
in vc.el?)

   Note that this *is* a regression wrt 22.3.

					-- Bob Rogers
					   http://www.rgrjr.com/

------------------------------------------------------------------------
In GNU Emacs 23.0.92.1 (i686-pc-linux-gnu, GTK+ Version 2.12.9)
 of 2009-04-24 on rgr
Windowing system distributor `The X.Org Foundation', version 11.0.10400090
Important settings:
  value of $LC_ALL: nil
  value of $LC_COLLATE: nil
  value of $LC_CTYPE: nil
  value of $LC_MESSAGES: nil
  value of $LC_MONETARY: nil
  value of $LC_NUMERIC: nil
  value of $LC_TIME: nil
  value of $LANG: en_US.UTF-8
  value of $XMODIFIERS: nil
  locale-coding-system: utf-8-unix
  default-enable-multibyte-characters: t

Major mode: Text

Minor modes in effect:
  tooltip-mode: t
  mouse-wheel-mode: t
  menu-bar-mode: t
  file-name-shadow-mode: t
  global-font-lock-mode: t
  font-lock-mode: t
  blink-cursor-mode: t
  global-auto-composition-mode: t
  auto-composition-mode: t
  auto-encryption-mode: t
  auto-compression-mode: t
  line-number-mode: t
  transient-mark-mode: t

Recent input:
C-x C-f f o o <tab> <return> M-x v c - d e l e <tab> 
C-g M-x r e p o r <tab> <return>

Recent messages:
For information about GNU Emacs and the GNU system, type C-h C-a.
Loading vc-svn...done
Quit

Message #10 received at 3209 <at> emacsbugs.donarmstrong.com (full text, mbox):

From: Chong Yidong <cyd <at> stupidchicken.com>
To: emacs-devel <at> gnu.org
Cc: Bob Rogers <rogers-emacs <at> rgrjr.dyndns.org>,
        3209 <at> debbugs.gnu.org
Subject: Re: 23.0.92; vc-delete-file is not autoloaded
Date: Mon, 04 May 2009 21:29:44 -0400

>    If I do "emacs -Q vc-controlled-file", I then find that I can't do
> "M-x vc-delete-file" immediately, because this command is undefined.
> It's in vc.el, and the mode line shows that Emacs knows the file is
> under version control, so I assume that vc.el must not be loaded as a
> side-effect of finding a version-controlled file.  So shouldn't
> vc-delete-file be autoloaded in that case?  (And possibly other
> commands in vc.el?)
>
>    Note that this *is* a regression wrt 22.3.

I think vc-create-repo, vc-register-with, and vc-delete-file should be
autoloaded.  Anyone on this list have any objection?

*** trunk/lisp/vc.el.~1.715.~	2009-03-21 11:52:16.000000000 -0400
--- trunk/lisp/vc.el	2009-05-04 21:27:35.000000000 -0400
***************
*** 1182,1187 ****
--- 1182,1188 ----
       (t
        (error "Fileset is in an unknown state %s" state)))))
  
+ ;;;###autoload
  (defun vc-create-repo (backend)
    "Create an empty repository in the current directory."
    (interactive
***************
*** 1258,1263 ****
--- 1259,1265 ----
             )
  	 (message "Registering %s... done" files))))))
  
+ ;;;###autoload
  (defun vc-register-with (backend)
    "Register the current file with a specified back end."
    (interactive "SBackend: ")
***************
*** 2138,2143 ****
--- 2140,2146 ----
  	      (throw 'found f)))
         (error "New file lacks a version control directory")))))
  
+ ;;;###autoload
  (defun vc-delete-file (file)
    "Delete file and mark it as such in the version control system."
    (interactive "fVC delete file: ")

Message #15 received at submit <at> emacsbugs.donarmstrong.com (full text, mbox):

From: Stefan Monnier <monnier <at> iro.umontreal.ca>
To: Bob Rogers <rogers-emacs <at> rgrjr.dyndns.org>
Cc: 3209 <at> debbugs.gnu.org, emacs-pretest-bug <at> gnu.org
Subject: Re: bug#3209: 23.0.92; vc-delete-file is not autoloaded
Date: Mon, 04 May 2009 23:58:02 -0400

>    If I do "emacs -Q vc-controlled-file", I then find that I can't do
> "M-x vc-delete-file" immediately, because this command is undefined.
> It's in vc.el, and the mode line shows that Emacs knows the file is
> under version control, so I assume that vc.el must not be loaded as a
> side-effect of finding a version-controlled file.  So shouldn't
> vc-delete-file be autoloaded in that case?  (And possibly other commands
> in vc.el?)

Yes, it should be autoloaded, indeed.

>    Note that this *is* a regression wrt 22.3.

I don't think so.


        Stefan

Message #25 received at 3209-done <at> emacsbugs.donarmstrong.com (full text, mbox):

From: Stefan Monnier <monnier <at> iro.umontreal.ca>
To: Bob Rogers <rogers-emacs <at> rgrjr.dyndns.org>
Cc: 3209-done <at> debbugs.gnu.org
Subject: Re: bug#3209: 23.0.92; vc-delete-file is not autoloaded
Date: Tue, 05 May 2009 00:03:15 -0400

> So shouldn't vc-delete-file be autoloaded in that case?

Yes, done,


        Stefan

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.