GNU bug report logs - #32059
Improve etc/snippets

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Arun Isaac <arunisaac <at> systemreboot.net>
Subject: bug#32059: closed (Re: [bug#32059] [PATCH 2/3] etc: snippets:
 Improve indentation in the package snippet.)
Date: Fri, 13 Jul 2018 07:34:02 +0000

[Message part 1 (text/plain, inline)]

Your bug report

#32059: Improve etc/snippets

which was filed against the guix-patches package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to 32059 <at> debbugs.gnu.org.

-- 
32059: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=32059
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Arun Isaac <arunisaac <at> systemreboot.net>
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: 32059-done <at> debbugs.gnu.org
Subject: Re: [bug#32059] [PATCH 2/3] etc: snippets: Improve indentation in the
 package snippet.
Date: Fri, 13 Jul 2018 13:03:26 +0530

>> -    (source origin...$0)
>> +    (source
>> +     origin...$0)
>
> I personally prefer the original version.  :-)

Oh, well... :-( But, I understand... :-)

I have pushed the other two patches to master.

[Message part 3 (message/rfc822, inline)]

From: Arun Isaac <arunisaac <at> systemreboot.net>
To: guix-patches <at> gnu.org
Cc: Arun Isaac <arunisaac <at> systemreboot.net>
Subject: Improve etc/snippets
Date: Thu,  5 Jul 2018 17:48:12 +0530

Patch 1 adds the android-ndk and scons build systems as possibilities for the
build-system field in the package snippet.

Patch 2 modifies the package snippet so that 'origin' comes on the next line
after 'source'. I feel this is better because it makes better use of space
(less whitespace on the left of the source description). Often, this is
necessary to not run afoul of the line length limitations of `guix lint`.

Patch 3 adds a guix commit message snippet for changing the home page of
packages to HTTPS.

Patch 1 is uncontroversial. But, I don't know if others would agree on patches
2 and 3. Anyways, I am just submitting them here for consideration.

Arun Isaac (3):
  etc: snippets: Add new build systems to package snippet.
  etc: snippets: Improve indentation in the package snippet.
  etc: snippets: Add guix-commit-message-use-https-home-page.

 doc/contributing.texi                                          | 3 ++-
 etc/snippets/scheme-mode/guix-package                          | 7 +++++--
 etc/snippets/text-mode/guix-commit-message-use-https-home-page | 9 +++++++++
 3 files changed, 16 insertions(+), 3 deletions(-)
 create mode 100644 etc/snippets/text-mode/guix-commit-message-use-https-home-page

-- 
2.15.1

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.