GNU bug report logs - #32056
too many arguments for abort-if-file-too-large

Previous Next

Full log

Message #30 received at 32056 <at> debbugs.gnu.org (full text, mbox):

From: Noam Postavsky <npostavs <at> gmail.com>
To: "Gian Uberto Lauri" <saint <at> eng.it>
Cc: Robert Pluim <rpluim <at> gmail.com>, 32056 <at> debbugs.gnu.org
Subject: Re: bug#32056: Small patch
Date: Wed, 17 Apr 2019 20:13:56 -0400

"Gian Uberto Lauri" <saint <at> eng.it> writes:

> +;; I am unsure if letting this customizable is a good idea.
> +(defvar ignore-file-size-list '() "A list of file for which the user is
> +not warned when the size exceeds `large-file-warning-threshold'." )

Hmm, this feels a bit unmotivated.  I don't quite understand why the
user would choose only certain files to ignore the threshold instead of
just making the threshold higher.

> +                     ;; The user does not want to be bothered for
> +                     ;; these files (full path).
> +                     (not (let (rv)
> +                            (dolist (test-file-name ignore-file-size-list rv)
> +	                      (setq rv
> +                                    (or rv (string= filename test-file-name))))))

Though it might be more convenient to have a regexp rather than a
straight list.

> -	    (mapcar #'find-file-noselect files)))
> +	    (mapcar 'find-file-noselect files)))

No need for this.  #' is fine.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.