GNU bug report logs - #32055
[PATCH 0/2] Add sqlcrush.

Previous Next

Full log

Message #22 received at 32055-done <at> debbugs.gnu.org (full text, mbox):

From: Tobias Geerinckx-Rice <me <at> tobias.gr>
To: 32055-done <at> debbugs.gnu.org
Subject: Re: [PATCH 0/2] Add sqlcrush.
Date: Wed, 22 Aug 2018 00:53:56 +0200

Ludo',

This got buried after the holdays. Thanks for the review!

Ludovic Courtès wrote:
> Tobias Geerinckx-Rice <me <at> tobias.gr> skribis:

[...]

>> +      (propagated-inputs
>> +       `(("python-cryptography" ,python-cryptography)
>> +         ("python-psycopg2" ,python-psycopg2)
>> +         ("python-pymysql" ,python-pymysql)
>> +         ("python-sqlalchemy" ,python-sqlalchemy)))

[...]

> If it’s an application rather than a library, then perhaps we 
> don’t need
> to propagate these?

Agreed.

>> +    (synopsis "Pure-Python MySQL Driver")
>
> Nitpick: "driver" (lowercase).
>
> Otherwise LGTM, thanks!

Pushed with the suggested changes as 311f06c et al.

Kind regards,

T G-R

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.