From unknown Sat Aug 16 11:41:52 2025 X-Loop: help-debbugs@gnu.org Subject: bug#32048: Remove redundant value checks Resent-From: Fritz Stelzer Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 04 Jul 2018 12:00:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 32048 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 32048@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.153070558930129 (code B ref -1); Wed, 04 Jul 2018 12:00:02 +0000 Received: (at submit) by debbugs.gnu.org; 4 Jul 2018 11:59:49 +0000 Received: from localhost ([127.0.0.1]:45939 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fagRp-0007pt-EB for submit@debbugs.gnu.org; Wed, 04 Jul 2018 07:59:49 -0400 Received: from eggs.gnu.org ([208.118.235.92]:44606) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fagRo-0007pe-FV for submit@debbugs.gnu.org; Wed, 04 Jul 2018 07:59:48 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fagRi-0008TT-5p for submit@debbugs.gnu.org; Wed, 04 Jul 2018 07:59:43 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,FREEMAIL_FROM, HTML_MESSAGE,T_DKIM_INVALID autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:38525) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1fagRi-0008TJ-1z for submit@debbugs.gnu.org; Wed, 04 Jul 2018 07:59:42 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:35575) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fagRf-0001rc-Ue for bug-gnu-emacs@gnu.org; Wed, 04 Jul 2018 07:59:41 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fagRf-0008RY-2K for bug-gnu-emacs@gnu.org; Wed, 04 Jul 2018 07:59:40 -0400 Received: from mail-yb0-x230.google.com ([2607:f8b0:4002:c09::230]:34743) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fagRe-0008RC-Sa for bug-gnu-emacs@gnu.org; Wed, 04 Jul 2018 07:59:38 -0400 Received: by mail-yb0-x230.google.com with SMTP id e9-v6so1985822ybq.1 for ; Wed, 04 Jul 2018 04:59:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:from:date:message-id:subject:to; bh=5DOXF3UFOUjB8c0tgcW2XxxKfEJFA1WfC9YsMP917UE=; b=CB1r3aBMQks9LSuUEld+VEcCKOMT30OuQjM1iW9ijwbTDiCY5e7TdtXeXOBkvC201k 0xilXcCnT20qLSBWH4QYUX3pqYBjnh2P0gT176s/fluKa7BjBKj8vPddMG2CMlogsICG Q2YVWM1ATMhUbBeYPGLWIEZJUDq564f75w6W63sZ6WhEswryPWOQpMXq2lrUSbu7Sr6T kJs0qyogFfvaeVyAp9dDGo3x24tQzkBUz+JsFpcoqMDZs+U8xVuo3Pdd2xBluZyY2en5 aBxyvRAbQOLaHJ5tDs9aTZG1YsZ2dEx/BDR+q0KrwWJx+jSGmDVON2HNxcCcleGUNJZu 84Mw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=5DOXF3UFOUjB8c0tgcW2XxxKfEJFA1WfC9YsMP917UE=; b=pjM8lc8SXCMSw/UU4ocdBznwnHmUziKMXwUVfCwKsBgfN5So0u5h6w5WMnfxOQjrOU l41RYIDom7RziaV11/rXA2mveWS9O5xouovtjq8DfJUsFjUrqFYl2mBy1buf9TrVLmkV HNC0HsnBEBziVggoXTeigi3QWNo/R3UDCMg1yRvXRDomknY3DvWJZ+KwiyjmSbLmLGV9 /OFbszAp11WbknnGmXDoAI2usoJ25tV6WbAF4I9uPXkeCZorbAxjRRQX66krrcc7YTyv KOr91sij1slHE0MNsz/ScLTnQP0aYwnNOHckquxpH8eXJnlKTG0gRDqzk9r/a4yMnGyS /5ow== X-Gm-Message-State: APt69E0srPVsAy5hegi+Tua/c53KwISUHzpIF6p4M47ZIoZzw+5DVwKF O3ANQQV5B7nAiLPJrLsYpVAD39uy0pko1e+F52PaJg== X-Google-Smtp-Source: AAOMgpf0oADoyyVkUbIKV2XATQRVfMtB7K7J5qTPvGPytNuNnxo2LC9I/CDa9IrUMhNFzWGQq6MjON3VjyTNlq/KfkY= X-Received: by 2002:a25:3416:: with SMTP id b22-v6mr773743yba.42.1530705577632; Wed, 04 Jul 2018 04:59:37 -0700 (PDT) MIME-Version: 1.0 Received: by 2002:a81:e446:0:0:0:0:0 with HTTP; Wed, 4 Jul 2018 04:59:37 -0700 (PDT) From: Fritz Stelzer Date: Wed, 4 Jul 2018 13:59:37 +0200 Message-ID: Content-Type: multipart/alternative; boundary="00000000000035eaab05702b2add" X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.0 (----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) --00000000000035eaab05702b2add Content-Type: text/plain; charset="UTF-8" These checks are done in pset_filter and pset_sentinel. master 05c42757da95e2697c08ce54f91b07649a431408 Author: brotzeit AuthorDate: Wed Jul 4 14:55:02 2018 +0200 Commit: brotzeit CommitDate: Wed Jul 4 14:55:02 2018 +0200 Parent: 3bbd4ffc68 * lisp/shell.el (shell-completion-vars): Merged: master Containing: master Follows: emacs-26.1 (2428) Remove redundant NILP calls 1 file changed, 6 deletions(-) src/process.c | 6 ------ modified src/process.c @@ -1274,9 +1274,6 @@ The string argument is normally a multibyte string, except: (debug) (set-process-filter process ...) */ - if (NILP (filter)) - filter = Qinternal_default_process_filter; - pset_filter (p, filter); if (p->infd >= 0) @@ -1310,9 +1307,6 @@ It gets two arguments: the process, and a string describing the change. */) CHECK_PROCESS (process); p = XPROCESS (process); - if (NILP (sentinel)) - sentinel = Qinternal_default_process_sentinel; - pset_sentinel (p, sentinel); if (NETCONN1_P (p) || SERIALCONN1_P (p) || PIPECONN1_P (p)) pset_childp (p, Fplist_put (p->childp, QCsentinel, sentinel)); --00000000000035eaab05702b2add Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
These checks are done in pset_filter and pset_sentine= l.

master 05c42757da95e2697c08ce54f91b07649a431408=
Author:=C2=A0=C2=A0=C2=A0=C2=A0 brotzeit <brotzeitmacher@gmail.com>
AuthorDate: Wed Jul 4= 14:55:02 2018 +0200
Commit:=C2=A0=C2=A0=C2=A0=C2=A0 brotzeit <brotzeitmacher@gmail.com>
C= ommitDate: Wed Jul 4 14:55:02 2018 +0200

Parent:=C2=A0=C2=A0=C2=A0= =C2=A0 3bbd4ffc68 * lisp/shell.el (shell-completion-vars):
Merged:=C2=A0= =C2=A0=C2=A0=C2=A0 master
Containing: master
Follows:=C2=A0=C2=A0=C2= =A0 emacs-26.1 (2428)

Remove redundant NILP calls

1 file chan= ged, 6 deletions(-)
src/process.c | 6 ------

modified=C2=A0=C2=A0= src/process.c
@@ -1274,9 +1274,6 @@ The string argument is normally a m= ultibyte string, except:
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 (debug)
=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0 (set-process-filter process ...)=C2=A0 */
= =C2=A0
-=C2=A0 if (NILP (filter))
-=C2=A0=C2=A0=C2=A0 filter =3D Qint= ernal_default_process_filter;
-
=C2=A0=C2=A0 pset_filter (p, filter);=
=C2=A0
=C2=A0=C2=A0 if (p->infd >=3D 0)
@@ -1310,9 +1307,6 = @@ It gets two arguments: the process, and a string describing the change.= =C2=A0 */)
=C2=A0=C2=A0 CHECK_PROCESS (process);
=C2=A0=C2=A0 p =3D X= PROCESS (process);
=C2=A0
-=C2=A0 if (NILP (sentinel))
-=C2=A0=C2= =A0=C2=A0 sentinel =3D Qinternal_default_process_sentinel;
-
=C2=A0= =C2=A0 pset_sentinel (p, sentinel);
=C2=A0=C2=A0 if (NETCONN1_P (p) || S= ERIALCONN1_P (p) || PIPECONN1_P (p))
=C2=A0=C2=A0=C2=A0=C2=A0 pset_child= p (p, Fplist_put (p->childp, QCsentinel, sentinel));

--00000000000035eaab05702b2add-- From debbugs-submit-bounces@debbugs.gnu.org Wed Jul 04 08:14:50 2018 Received: (at control) by debbugs.gnu.org; 4 Jul 2018 12:14:51 +0000 Received: from localhost ([127.0.0.1]:45964 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1faggM-0008Dy-NN for submit@debbugs.gnu.org; Wed, 04 Jul 2018 08:14:50 -0400 Received: from mail-io0-f181.google.com ([209.85.223.181]:44256) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1faggK-0008Df-0U; Wed, 04 Jul 2018 08:14:50 -0400 Received: by mail-io0-f181.google.com with SMTP id q19-v6so4691815ioh.11; Wed, 04 Jul 2018 05:14:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=jFSeMfBnuZeuH+KdUAwyPs9FKP4qK0zkvOOE8zT2+xs=; b=gtj3m3ytBxGAgKl4qJdnrHqhydNwwggTQUa1/ShwhiBEyoF8mATWvGHL/taeHxrSBu qvMeuSHVEufbblBgqTLHhWGmOeqAAYBsKUIywrKyW26zYxFoc4UIKvYaTWTZ+s/cmZ4m xRGQiGpjeLOeT3gEcm3dSmTKhvKWOBsRuXgBzoZ7hwdS3XD6EPrUb67YyuSevvm0A+AH cmo9ZNlPKd6o/M0CYfgizktxuvhgB0J4e3p9BO98SrreC6ZsUKmexXgBtsEyZzNibiXH slYqUYpcxyoNGUIgZDcgoSPMprfOU/SdqiMSFVv3Jq+XfYbgi3QFBuQEp8/Dc0KDh3DS SqlA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=jFSeMfBnuZeuH+KdUAwyPs9FKP4qK0zkvOOE8zT2+xs=; b=PdpFJdlZGlquFEQ2eKpEfsMs0MezrO/TUZfyTdLy/M9hjJJOzXRGONEH6mlDNPa5Xp f3BimT1qAzo8ULwLiL+o/tuEMJ9eaGgPUa5JsyykGMgoSneA8O+9PD/ktLcU1wdRPRbD 5hTr9iKIV4j5szOErpNYUODBIh6KWCMPNANXsv4lvxPk8cUCxWhY9so+l7pSXznrVwvr zJqRtqW1nQvNey10P1pIG9U4BKsOX49dXkqWtmECkFhTDi43npr4NGivd999p5+E6n9O xjKbq3XgkNgDEZI8oggfEq+XkAOityyTGcczUg5U2HCQIXfPlVbwMKaeg735Lr6tA1A+ WQIg== X-Gm-Message-State: APt69E1Y18C0qJoYKkaMEyDQmHvxqmIhLNLt8RQWu2L00lE9ccd4BJcO NDsX0AYJ7QwKZr3c80jWUfPKHw== X-Google-Smtp-Source: AAOMgpf6CUYM54l7eUZBzqTY/Ok4+anjCAb3FhtstdHzsXxLh6CBdSR0FNlYkWG94OOLYf5vZRrvsQ== X-Received: by 2002:a6b:df4a:: with SMTP id d10-v6mr1394255iop.152.1530706482548; Wed, 04 Jul 2018 05:14:42 -0700 (PDT) Received: from zebian (cbl-45-2-119-34.yyz.frontiernetworks.ca. [45.2.119.34]) by smtp.googlemail.com with ESMTPSA id g17-v6sm1641880iti.1.2018.07.04.05.14.41 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 04 Jul 2018 05:14:42 -0700 (PDT) From: Noam Postavsky To: Fritz Stelzer Subject: Re: bug#32049: Bug can be closed References: Date: Wed, 04 Jul 2018 08:14:41 -0400 In-Reply-To: (Fritz Stelzer's message of "Wed, 4 Jul 2018 14:02:26 +0200") Message-ID: <87k1qbkxji.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: control Cc: 32049@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) merge 32049 32048 tags 32049 notabug wontfix close 32049 quit Fritz Stelzer writes: > My bad. My previous bug can be closed. Okay, closing this and #32048. > I don't know how to respond to my own mail :) You can send mail to 32048@debbugs.gnu.org.