GNU bug report logs - #32046
[PATCH] import: gem: Add recursive import.

Previous Next

Full log

Message #11 received at 32046 <at> debbugs.gnu.org (full text, mbox):

From: Oleg Pykhalov <go.wigust <at> gmail.com>
To: ludo <at> gnu.org (Ludovic Courtès)
Cc: 32046 <at> debbugs.gnu.org
Subject: Re: [bug#32046] [PATCH] import: gem: Add recursive import.
Date: Tue, 10 Jul 2018 16:31:59 +0300

[Message part 1 (text/plain, inline)]

Hello Ludovic,

Thank you for review.

ludo <at> gnu.org (Ludovic Courtès) writes:

> Hi Oleg,
>
> Oleg Pykhalov <go.wigust <at> gmail.com> skribis:
>
>> * doc/guix.texi (Invoking guix import): Document gem recursive import.
>> * guix/import/gem.scm (gem->guix-package): Return package and dependencies
>> values.
>> (gem-recursive-import): New procedure.
>> * guix/scripts/import/gem.scm (show-help, %options): Add recursive option.
>> (guix-import-gem): Use 'gem-recursive-import'.
>
> Nice!
>
> Could you add a test in tests/gem.scm?
>
>>  (define-module (guix import gem)
>>    #:use-module (ice-9 match)
>>    #:use-module (ice-9 pretty-print)
>> +  #:use-module (ice-9 receive)
>
> I don’t think this is needed.
>
>> @@ -44,6 +46,8 @@ Import and convert the RubyGems package for PACKAGE-NAME.\n"))
>>    -h, --help             display this help and exit"))
>>    (display (G_ "
>>    -V, --version          display version information and exit"))
>> +  (display (G_ "
>> + -r, --recursive generate package expressions for all Gem packages
>> that are not yet in Guix"))
>
> Please keep lines below 80-char wide.
>
> Apart form that LGTM.  Could you send an  updated patch?

I applied all your suggestions.  Here is a new patch.

<#secure method=pgpmime mode=sign>

[0001-import-gem-Add-recursive-import.patch (text/x-patch, attachment)]

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.