From unknown Sat Sep 06 09:43:53 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#32029 <32029@debbugs.gnu.org> To: bug#32029 <32029@debbugs.gnu.org> Subject: Status: PATCH: xref-find-definitions-at-mouse Reply-To: bug#32029 <32029@debbugs.gnu.org> Date: Sat, 06 Sep 2025 16:43:53 +0000 retitle 32029 PATCH: xref-find-definitions-at-mouse reassign 32029 emacs submitter 32029 Tobias Gerdin severity 32029 wishlist thanks From debbugs-submit-bounces@debbugs.gnu.org Sun Jul 01 19:51:51 2018 Received: (at submit) by debbugs.gnu.org; 1 Jul 2018 23:51:51 +0000 Received: from localhost ([127.0.0.1]:42462 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fZm8E-0003Vf-OK for submit@debbugs.gnu.org; Sun, 01 Jul 2018 19:51:50 -0400 Received: from eggs.gnu.org ([208.118.235.92]:49963) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fZlcZ-0002mF-Bx for submit@debbugs.gnu.org; Sun, 01 Jul 2018 19:19:07 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fZlcT-0004aX-6L for submit@debbugs.gnu.org; Sun, 01 Jul 2018 19:19:02 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=BAYES_20,FREEMAIL_FROM, T_DKIM_INVALID autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:55005) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1fZlcT-0004aQ-2Y for submit@debbugs.gnu.org; Sun, 01 Jul 2018 19:19:01 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:40929) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fZlcR-0004rP-TI for bug-gnu-emacs@gnu.org; Sun, 01 Jul 2018 19:19:00 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fZlcM-0004Xw-VV for bug-gnu-emacs@gnu.org; Sun, 01 Jul 2018 19:18:59 -0400 Received: from mail-lf0-x229.google.com ([2a00:1450:4010:c07::229]:36599) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fZlcM-0004XB-N5 for bug-gnu-emacs@gnu.org; Sun, 01 Jul 2018 19:18:54 -0400 Received: by mail-lf0-x229.google.com with SMTP id n24-v6so10576913lfh.3 for ; Sun, 01 Jul 2018 16:18:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=to:from:subject:message-id:date:user-agent:mime-version :content-transfer-encoding:content-language; bh=V1kmihtEHTw3k2xrET5iVAaMfeGKyUxm+7wl4gtJKO0=; b=uog1UfXE0rsFpgkFgo5GBISNKsDhrU8oVqxZQ/MhlcXHsGbzyKgRsosLOPpCautHOz +kDVwVFa8a0DXgrQ+LpiWJFWIrZpFG+afr3CoFaPodmOGMZRpp++JoibyPIKOptxXkzf k7zQOYY5CAwclpeIxF9+r8XTUXuWAQJIBXEa5iKNtEVr64l5uxEQNtCeFNYY2l5PWvOZ eglulYyOabnNjgbBXKmcpbkiQowZAxPA2Kcy1ly2E0g+WGW9jOFQiWQ/LcEoEdsYjZEZ I1ZsuT+GeM7EsVpU6PMSduegxTZX4pB2sYKW9MNk3YqdY8ojCASlQddcyjdYj2HvrnB5 Uv2A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:to:from:subject:message-id:date:user-agent :mime-version:content-transfer-encoding:content-language; bh=V1kmihtEHTw3k2xrET5iVAaMfeGKyUxm+7wl4gtJKO0=; b=H+YAE3OftpIy7hVzQ05x/sEJ2+FKIU+4k7UPk9PPZtve6nCGlayVhxu47Un8FEfTak qIkh/lksIubTXFP82coysqGLguj2RqgocS9yVJzs86cvK0M1NsRcLBet54MRqg63OJOT DWKvIw3hh7prGwwDtJ8itI4sBhSdMqCkYvuucPLxcrrrXYcSSwiB0g3FyocjFR00SU3W NcM3H2WWDsE/MVdTx5M1vBwwlPvLMETWfYtmSDfdFSl7irS5BjPFHiHPPAW65hFu8ARA whtoXOdOiNb8l1sUthf2/XEj8Wgq3DuJfVG4UfcZmcbTCdrGrwxJgqwOibtGeH001EA9 nQdQ== X-Gm-Message-State: APt69E1hH8Np3jServSO/jl1gmxAf0CVELBDHLZ1mZ74LMAZEik+vLkR a/RaAzxMgQCtws+KBrb19JL1MyX5 X-Google-Smtp-Source: AAOMgpcXFKP7l9J6UoAOBxhWPVzt8LfjskaeW6t+MCpoVGsCIjgvbCvtIknMkgs4yB/oFMfxlOE6HA== X-Received: by 2002:a19:d313:: with SMTP id k19-v6mr7633774lfg.29.1530487132712; Sun, 01 Jul 2018 16:18:52 -0700 (PDT) Received: from Tobias-MBP.lan (h83-209-121-192.cust.se.alltele.net. [83.209.121.192]) by smtp.gmail.com with ESMTPSA id o34-v6sm1439181lfg.12.2018.07.01.16.18.50 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 01 Jul 2018 16:18:51 -0700 (PDT) To: bug-gnu-emacs@gnu.org From: Tobias Gerdin Subject: PATCH: xref-find-definitions-at-mouse Message-ID: <9af0d021-361d-ccc6-a051-f102589bccb7@gmail.com> Date: Mon, 2 Jul 2018 01:18:50 +0200 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.13; rv:52.0) Gecko/20100101 Thunderbird/52.8.0 MIME-Version: 1.0 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.0 (----) X-Debbugs-Envelope-To: submit X-Mailman-Approved-At: Sun, 01 Jul 2018 19:51:49 -0400 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) Hello, I find it convenient to be able to go to definitions using the mouse (especially when getting to know new code bases). I have the below function bound to C-mouse-1 like so: (global-set-key [C-mouse-1] 'xref-find-definitions-at-mouse) (global-set-key [C-down-mouse-1] nil) I also find it convenient to be able to get back to where I was using only the mouse (enabling keyboard-free navigation): (global-set-key [C-mouse-3] 'xref-pop-marker-stack) (global-set-key [C-down-mouse-3] nil) Finding suitable default keybindings (well, "mouse bindings") is beyond the scope of this patch, but what I have above is the same binding as other popular IDEs such as IntelliJ and VS Code. Regards, Tobias Gerdin diff --git a/lisp/progmodes/xref.el b/lisp/progmodes/xref.el index 9a437b6f69..85a1bc6be4 100644 --- a/lisp/progmodes/xref.el +++ b/lisp/progmodes/xref.el @@ -873,6 +873,18 @@ With prefix argument, prompt for the identifier."    (interactive (list (xref--read-identifier "Find references of: ")))    (xref--find-xrefs identifier 'references identifier nil)) +;;;###autoload +(defun xref-find-definitions-at-mouse (event) +  "Find the definition of identifier around mouse click." +  (interactive "e") +  (let* ((backend (xref-find-backend)) +     (identifier (save-excursion +              (mouse-set-point event) +              (xref-backend-identifier-at-point backend)))) +    (if identifier +    (xref--find-definitions identifier nil) +      (user-error "No identifier here")))) +  (declare-function apropos-parse-pattern "apropos" (pattern))  ;;;###autoload From debbugs-submit-bounces@debbugs.gnu.org Tue Jul 03 09:15:43 2018 Received: (at 32029) by debbugs.gnu.org; 3 Jul 2018 13:15:43 +0000 Received: from localhost ([127.0.0.1]:44472 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1faL9j-0006Zr-0w for submit@debbugs.gnu.org; Tue, 03 Jul 2018 09:15:43 -0400 Received: from mail-ed1-f41.google.com ([209.85.208.41]:39659) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1faL9g-0006Ze-4l for 32029@debbugs.gnu.org; Tue, 03 Jul 2018 09:15:41 -0400 Received: by mail-ed1-f41.google.com with SMTP id w14-v6so1597681eds.6 for <32029@debbugs.gnu.org>; Tue, 03 Jul 2018 06:15:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=2IbTx1MdhmeE460kucoU9wDDbCSGz/xNej8aK5kpVQI=; b=tv26y9QiAnqj4GNxSaEgYHUYUM93MbYmJEeLC3gpnYvWcRBtNVCb5B3w8jU/QAGQOI 0/sv7S8igOcqCNJuVT6k5VwwpJY4xki06t8BiRYybG0Qzga9EOvARnaTheh4WEk6FFNL NLjNnmR4+u8+uKqwq6RVECbX59mLhM4GCQQsZBraqtFpgi3EXDBhEa+F2MvQPz72jLBd ic3m1A9orqb9uVQmoGkBKjx7UWYc1vCn6BSQBXCLPw/g6TOMDFirlAX8SStHiHxVJFbp gqGo9MrqWJPFgcwExvW/tYNYng2FGpDMI7jeb81D+IK/vNPBWXa2jRF8GXhbaEfkNTnk HXHg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=2IbTx1MdhmeE460kucoU9wDDbCSGz/xNej8aK5kpVQI=; b=qVqyAvGeEnR2TWBKq9b28jF9CP6X2lSR8FT4LNk6Uuci48fF2ZLFE/UK+P6TBWoLl3 VLUXBw7bvlzhQart0DkcWFoV0FvBkq/Zrh2cIKx5cgI9rT9toZ9qqYU73W4nD9x1YGwO bKxEjlR723wBt5hx0M5eynm+5Hn74vA0EEvL2dZL/BeiMe8byprZClE4TMffvkOInVeY Dt/n+KPdOj2lV4NyBIa0nUDcA/PUtVsCmCh5hwRbNsJ7XVuiQZ6GjTaepyzXDdg/2EKU a3R9RZoLKwR7XUgSBWrAr2TN6qB8hLH0zKZg2coEveD60kEYvi9uLSYKyMiWWDPsRI5T YIYg== X-Gm-Message-State: APt69E3U//1YeI6S5g05uREvbmu/5cfLumLNGo5KkqfIN2Rgk8EF0wv4 5MD6Il8afTawIyyMJPrQhe+38a6s X-Google-Smtp-Source: AAOMgpe2la1fvrRLKchD5KcXmdxGHDPlOVGjP3onnDrBOFi6Ib/sdwnSlIszandYkwB//sp83OnwyA== X-Received: by 2002:a50:b962:: with SMTP id m89-v6mr27566447ede.20.1530623734072; Tue, 03 Jul 2018 06:15:34 -0700 (PDT) Received: from [192.168.0.200] ([109.110.245.170]) by smtp.googlemail.com with ESMTPSA id m51-v6sm884894edc.94.2018.07.03.06.15.32 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 03 Jul 2018 06:15:33 -0700 (PDT) Subject: Re: bug#32029: PATCH: xref-find-definitions-at-mouse To: Tobias Gerdin , 32029@debbugs.gnu.org References: <9af0d021-361d-ccc6-a051-f102589bccb7@gmail.com> From: Dmitry Gutov Message-ID: Date: Tue, 3 Jul 2018 16:15:31 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.0 MIME-Version: 1.0 In-Reply-To: <9af0d021-361d-ccc6-a051-f102589bccb7@gmail.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: 32029 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.5 (/) On 7/2/18 2:18 AM, Tobias Gerdin wrote: > +;;;###autoload > +(defun xref-find-definitions-at-mouse (event) > +  "Find the definition of identifier around mouse click." > +  (interactive "e") > +  (let* ((backend (xref-find-backend)) > +     (identifier (save-excursion > +              (mouse-set-point event) > +              (xref-backend-identifier-at-point backend)))) > +    (if identifier > +    (xref--find-definitions identifier nil) > +      (user-error "No identifier here")))) You should call `mouse-set-point` before `xref-find-backend`, because the latter might conceivably depend on the value of point. I think this can be written much shorter (call mouse-set-point, then interactively call xref-find-definitions), but I'm not sure how. From debbugs-submit-bounces@debbugs.gnu.org Tue Jul 03 17:37:34 2018 Received: (at 32029) by debbugs.gnu.org; 3 Jul 2018 21:37:34 +0000 Received: from localhost ([127.0.0.1]:45706 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1faSzO-0002LW-BL for submit@debbugs.gnu.org; Tue, 03 Jul 2018 17:37:34 -0400 Received: from mail-lf0-f66.google.com ([209.85.215.66]:41687) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1faSzM-0002LK-N5 for 32029@debbugs.gnu.org; Tue, 03 Jul 2018 17:37:33 -0400 Received: by mail-lf0-f66.google.com with SMTP id y127-v6so2742555lfc.8 for <32029@debbugs.gnu.org>; Tue, 03 Jul 2018 14:37:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:subject:to:references:message-id:date:user-agent:mime-version :in-reply-to:content-transfer-encoding:content-language; bh=pGo4dhle74dx5cRTpFJH1F5GwkLUuY7yRaH3iec2Jeg=; b=U7DT1/4qM6lHkOmedNCf1E81emhA+idVfrZ4j7VsK6RbdRoxaYyDiML+ixE5Sv+Zuv x4ODjHKikV+mrpZx9ZjdXb6OsedQArqqjzzr7uy3l7GPbLBoXJrD2mqhW8Fe4oGNifON qv6C9164475D6PpdAqcZNbdVNPik7eXie7jp4RMr3h6433wGiJpJ5xXlu17m5R48haQ9 hBf+lGjKJOI/X9LEaB58A3Aze/DVUetGZBhnDbRiGhEdDxIJFbJz7BFHoGYP12jGaxNp Yzc0Gy1L4AUCtqIzPMPEFVc9OnedZ2pL2T4gnz76GPvckBXlrrP4+9qOwBrA4Q1VNu7+ Bm4Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:subject:to:references:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=pGo4dhle74dx5cRTpFJH1F5GwkLUuY7yRaH3iec2Jeg=; b=r1jcoKPwPrB9KzQT3nLIy9mNgvpW4fgpQPceoGyfRQh38gzu2RrzsxMsLUcp2LWFWy iv84p8v7qB6JUpzu7joBM0+/zQq4baZSNEnAnBATA38lV7zMuJxdxKumvflg9glkMLpY qL0iaFxipkamlpl5tDZS8MF849On8FwPRmoJ/cINiOpzEAJPnuuTDefocrVHx89BOo6D O9hFxreObwF1gSq+7cD8cdNFWJ2uqfMcpC+hJ/VYaNv0WCTHE6ZJYglpV/c485NvBU4F BxiX0+R2K8ceqAJNcC92boVKQ/5gxYpsQH6xLp6SBqNXHxaKAly1Mbv4mjbQvp5/a6vy OKlg== X-Gm-Message-State: APt69E2p9X4Ldca2e88nz4xYgS5pSKQann6zBEJYWoE7iiLnRIi+sLGw jLP/HghEolYvHNxyqfDdUAbFjEH5 X-Google-Smtp-Source: AAOMgpcKUBIBN3oFkhyOw4ohMPjNRO0N1B2CMEfoIMgOQ7eVmE6dL7VzZc7tscojnM3Rp0gJTb6LPQ== X-Received: by 2002:a19:4f58:: with SMTP id a24-v6mr18601273lfk.140.1530653846103; Tue, 03 Jul 2018 14:37:26 -0700 (PDT) Received: from Tobias-MBP.lan (h83-209-121-192.cust.se.alltele.net. [83.209.121.192]) by smtp.gmail.com with ESMTPSA id x9-v6sm436952lfb.46.2018.07.03.14.37.24 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 03 Jul 2018 14:37:24 -0700 (PDT) From: Tobias Gerdin Subject: Re: bug#32029: [PATCH] xref-find-definitions-at-mouse To: Dmitry Gutov , 32029@debbugs.gnu.org References: <9af0d021-361d-ccc6-a051-f102589bccb7@gmail.com> Message-ID: Date: Tue, 3 Jul 2018 23:37:23 +0200 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.13; rv:52.0) Gecko/20100101 Thunderbird/52.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 32029 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Den 2018-07-03 kl. 15:15, skrev Dmitry Gutov: > On 7/2/18 2:18 AM, Tobias Gerdin wrote: > >> +;;;###autoload >> +(defun xref-find-definitions-at-mouse (event) >> +  "Find the definition of identifier around mouse click." >> +  (interactive "e") >> +  (let* ((backend (xref-find-backend)) >> +     (identifier (save-excursion >> +              (mouse-set-point event) >> +              (xref-backend-identifier-at-point backend)))) >> +    (if identifier >> +    (xref--find-definitions identifier nil) >> +      (user-error "No identifier here")))) > > You should call `mouse-set-point` before `xref-find-backend`, because > the latter might conceivably depend on the value of point. > > I think this can be written much shorter (call mouse-set-point, then > interactively call xref-find-definitions), but I'm not sure how. A new version below. The initial version was modeled after `ffap-at-point`. Make using of call-interactively would be neat, but since we want to avoid making the call to xref-find-definitions inside the body of save-excursion I do not see how either (unless one woud actually move the point which I find a bit aggressive). I am not an overly experienced Elisp programmer so if you happen to come up with a way to do this I'm all ears. If not the below would do the job until then. diff --git a/lisp/progmodes/xref.el b/lisp/progmodes/xref.el index 9a437b6f69..befebbb426 100644 --- a/lisp/progmodes/xref.el +++ b/lisp/progmodes/xref.el @@ -873,6 +873,16 @@ With prefix argument, prompt for the identifier."    (interactive (list (xref--read-identifier "Find references of: ")))    (xref--find-xrefs identifier 'references identifier nil)) +;;;###autoload +(defun xref-find-definitions-at-mouse (event) +  "Find the definition of identifier around mouse click." +  (interactive "e") +  (if-let ((identifier (save-excursion +             (mouse-set-point event) +             (xref-backend-identifier-at-point (xref-find-backend))))) +      (xref-find-definitions identifier) +    (user-error "No identifier here"))) +  (declare-function apropos-parse-pattern "apropos" (pattern))  ;;;###autoload From debbugs-submit-bounces@debbugs.gnu.org Wed Jul 04 04:03:40 2018 Received: (at 32029) by debbugs.gnu.org; 4 Jul 2018 08:03:40 +0000 Received: from localhost ([127.0.0.1]:45828 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1faclI-0000N7-L6 for submit@debbugs.gnu.org; Wed, 04 Jul 2018 04:03:40 -0400 Received: from mail-lf0-f53.google.com ([209.85.215.53]:38883) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1faclH-0000Ms-0n for 32029@debbugs.gnu.org; Wed, 04 Jul 2018 04:03:39 -0400 Received: by mail-lf0-f53.google.com with SMTP id a4-v6so3660281lff.5 for <32029@debbugs.gnu.org>; Wed, 04 Jul 2018 01:03:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:from:to:references:message-id:date:user-agent:mime-version :in-reply-to:content-transfer-encoding:content-language; bh=4TdDEM9X5ynU3rryGphLbAj1zEQC0C3uCtTLoa2iHu0=; b=uZJq33U+oAXyb1Z8UQ7lewLQdQ9aEYbludBbLK+J2a/Ll+uGMixFxgp/qBT25Bpenw cqFsUhPTK2Q3AJF0BoIJtFGi0uAdW75LR9etKytrr2qFWy0cYT9nnexrY1mPPYuSHMwx MyC+dL+wk3KbNqJVv224fsn7TY34NWVM4bLznpg0KTN3HklhVKzSojB4GOhHTY5ig01q upo/e5Q/H/WykMwq/5TvMKzxw4rRjLtAfJ1RcPaci5d5+Ujto6TGrQXHDIVJVz7Jl4qW Z3eXVeDbQwxl1HmmZYBO0uegeUKo80VhDai9ub7XpjwUs4VaVV6eSseN/o3yn+xab9co XCtw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:from:to:references:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=4TdDEM9X5ynU3rryGphLbAj1zEQC0C3uCtTLoa2iHu0=; b=pC9YPJraqOtzXGNfmNMm8u64moyk6JlXuBycy3tT8yzeuLbg6lO180dAROTabNf48d 9depIb24Q2e7RqkgbBZt2EuxkypnaBcl4LAGGCfVCS+//wkZJZ1tIlmYWM6qHYkoGApW acIJcqq1Kg4zDW7TwqHzZZgz88Mgy1/5Ojx9n0MZ74DyjxDihGGWfephCVxjflnpp+pY QM/RS2iYzEHVV2pm2E16hqmIggopx2m9PtITUrCNV3lIbpR4ZO6QWE6cx5kryfuf0px8 fO62s6tzu14x0nsGuGZNpN6nWuFuZZYLEgyCVzvBoD4Vy2pWu17qNwA0+1K9GNrfJx3X ksyA== X-Gm-Message-State: APt69E1/D2lRbqBjSa3A4PlCGQFM72uRz7BfMgiSbnGLy4CjY46XHzBe K3KmqceYBlDx/9MY3Ek1y4baw+Wq X-Google-Smtp-Source: AAOMgpe8znRFBn7mmdzWOpTe5Y89BbNEUajGDU+xXD3oAGDFUUqTDzvzuLSBGcsBjVVTLjgLbPTnGg== X-Received: by 2002:a19:f015:: with SMTP id p21-v6mr805436lfc.77.1530691412598; Wed, 04 Jul 2018 01:03:32 -0700 (PDT) Received: from Tobias-MBP.lan (h83-209-121-192.cust.se.alltele.net. [83.209.121.192]) by smtp.gmail.com with ESMTPSA id n7-v6sm659862lfe.87.2018.07.04.01.03.31 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 04 Jul 2018 01:03:31 -0700 (PDT) Subject: Re: bug#32029: [PATCH] xref-find-definitions-at-mouse From: Tobias Gerdin To: Dmitry Gutov , 32029@debbugs.gnu.org References: <9af0d021-361d-ccc6-a051-f102589bccb7@gmail.com> Message-ID: <2524b8c0-41cc-863c-9a7f-c9681b11295d@gmail.com> Date: Wed, 4 Jul 2018 10:03:31 +0200 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.13; rv:52.0) Gecko/20100101 Thunderbird/52.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 32029 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Den 2018-07-03 kl. 15:15, skrev Dmitry Gutov: >> I think this can be written much shorter (call mouse-set-point, then >> interactively call xref-find-definitions), but I'm not sure how. Actually, since the mark will be saved before the jump if one could arrange for saving the mark before the call to mouse-set-point and not saving it again before jumping the call to save-excursion would not be needed and xref-find-definitions could be called interactively. It appears that pushing the mark is set all the way down in `xref--show-xrefs` though, so unless setting this is parameterized somehow it does not look straigthforward to me. And not worth it in this case IMO. From debbugs-submit-bounces@debbugs.gnu.org Wed Jul 04 08:24:38 2018 Received: (at 32029) by debbugs.gnu.org; 4 Jul 2018 12:24:38 +0000 Received: from localhost ([127.0.0.1]:45984 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fagpo-00020m-Ms for submit@debbugs.gnu.org; Wed, 04 Jul 2018 08:24:38 -0400 Received: from mail-wm0-f65.google.com ([74.125.82.65]:55435) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fagpm-00020Z-Dk for 32029@debbugs.gnu.org; Wed, 04 Jul 2018 08:24:34 -0400 Received: by mail-wm0-f65.google.com with SMTP id v16-v6so5615802wmv.5 for <32029@debbugs.gnu.org>; Wed, 04 Jul 2018 05:24:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=hel7/b7gpVcKjZW54mzO3G2C6axe8Q5J4YUyAvW/38U=; b=uLf6abSFcU2VWjMT5pK5WBLm0xCfLFL9Kdb0UHtJVfe8CEQRzNZUFXpzUIO5Jx57hg uYI/NyxTyUsrdd7JWu1gitJjF3IDZmhqrNPZQ0KERQJDYqKJ8gi/Hh/sJLujOtliMuHP einKzX2khgVu30HJt9qyUc+cGP26K3uifwPlsn0G/P/KsUk/glTJFv4+TnY1txyD5/ae dS1ijjs3lacJaPtZXJqbJs+ctpJMseEj7TsZPKMUUxcj1PqxEHl22scAzy+WW5tZmOp9 5rEcluQimbOfVq8LLTG396YRuaJrmO4NIW5G3rrGTEyLdFcdKJUu+ONApeWHB02tRzm+ b+kA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=hel7/b7gpVcKjZW54mzO3G2C6axe8Q5J4YUyAvW/38U=; b=HR2FCktN3GkgvFklFK3znQ1teuQws5xIpBX4cwbsSYvPOiJkgCCNSxfLU4bL/Zal0Y inpB/TpUIM5pcdQTIzdHQnpFKe7mU9EriUf+PX0O654ZtQJU0nCTDaQ39rW+FO35dHS7 TZWzh4o1HsKQL24h4KCwihpqg93FN5QZltG4JwbynNnjh4WbvsktsD+FDBFY3/rPbu1b y0YC8GLYFC5Y3s6HlLFaO2a3N78e/eCouwFS0yxem0YxGNn6MWYdmGAko8NA64iLqp+x 6z7J2KWBhfhVsZbdwkc0L07c0K0vLkaLYUvfDiTPg6tkKAFtaCS5TjtVuBdeQnZTBz4d BSlg== X-Gm-Message-State: APt69E3xKPa68nN6oaGOCSkZ+SBrYk1gkdxcOuZmcKGYZUT0Kajmg9wR vQcDZGgiqStemHzl5JG7hf2pspzV X-Google-Smtp-Source: AAOMgpdKyw3B1SDfcJJyUjumgBnB9tt3eaEYQzSqsQMyce8oddPij6BfxysBzPZLG4Mq/D72FFr+Yg== X-Received: by 2002:a1c:6d1c:: with SMTP id i28-v6mr1557552wmc.97.1530707068505; Wed, 04 Jul 2018 05:24:28 -0700 (PDT) Received: from [192.168.0.200] ([109.110.245.170]) by smtp.googlemail.com with ESMTPSA id s12-v6sm3915978wrr.43.2018.07.04.05.24.26 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 04 Jul 2018 05:24:27 -0700 (PDT) Subject: Re: bug#32029: [PATCH] xref-find-definitions-at-mouse To: Tobias Gerdin , 32029@debbugs.gnu.org References: <9af0d021-361d-ccc6-a051-f102589bccb7@gmail.com> <2524b8c0-41cc-863c-9a7f-c9681b11295d@gmail.com> From: Dmitry Gutov Message-ID: <6443125a-32a7-e0a3-cf3d-43481ee146bd@yandex.ru> Date: Wed, 4 Jul 2018 15:24:25 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.0 MIME-Version: 1.0 In-Reply-To: <2524b8c0-41cc-863c-9a7f-c9681b11295d@gmail.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: 32029 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.5 (/) On 7/4/18 11:03 AM, Tobias Gerdin wrote: > Den 2018-07-03 kl. 15:15, skrev Dmitry Gutov: >>> I think this can be written much shorter (call mouse-set-point, then >>> interactively call xref-find-definitions), but I'm not sure how. > Actually, since the mark will be saved before the jump if one could > arrange for saving the mark before the call to mouse-set-point and not > saving it again before jumping the call to save-excursion would not be > needed and xref-find-definitions could be called interactively. Would that really be a desired behavior, though? Regarding the patch, I'm fine with it, but I'd like someone else to confirm that the name of the new function makes sense. From debbugs-submit-bounces@debbugs.gnu.org Wed Jul 04 11:17:31 2018 Received: (at 32029) by debbugs.gnu.org; 4 Jul 2018 15:17:31 +0000 Received: from localhost ([127.0.0.1]:46850 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fajX8-0008Mq-Ti for submit@debbugs.gnu.org; Wed, 04 Jul 2018 11:17:31 -0400 Received: from eggs.gnu.org ([208.118.235.92]:33824) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fajX7-0008Me-99 for 32029@debbugs.gnu.org; Wed, 04 Jul 2018 11:17:29 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fajWx-0000Nr-7w for 32029@debbugs.gnu.org; Wed, 04 Jul 2018 11:17:24 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:39564) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fajWx-0000Nl-3M; Wed, 04 Jul 2018 11:17:19 -0400 Received: from [176.228.60.248] (port=3127 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1fajWw-0001XU-F7; Wed, 04 Jul 2018 11:17:18 -0400 Date: Wed, 04 Jul 2018 18:17:16 +0300 Message-Id: <83k1qbni83.fsf@gnu.org> From: Eli Zaretskii To: Dmitry Gutov In-reply-to: <6443125a-32a7-e0a3-cf3d-43481ee146bd@yandex.ru> (message from Dmitry Gutov on Wed, 4 Jul 2018 15:24:25 +0300) Subject: Re: bug#32029: [PATCH] xref-find-definitions-at-mouse References: <9af0d021-361d-ccc6-a051-f102589bccb7@gmail.com> <2524b8c0-41cc-863c-9a7f-c9681b11295d@gmail.com> <6443125a-32a7-e0a3-cf3d-43481ee146bd@yandex.ru> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 32029 Cc: tgerdin@gmail.com, 32029@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -6.0 (------) > From: Dmitry Gutov > Date: Wed, 4 Jul 2018 15:24:25 +0300 > > Regarding the patch, I'm fine with it, but I'd like someone else to > confirm that the name of the new function makes sense. Someone else here. We have already several functions called SOMETHING-at-mouse, so I think the proposed name does make sense. Thanks. From debbugs-submit-bounces@debbugs.gnu.org Fri Jul 06 04:55:53 2018 Received: (at 32029) by debbugs.gnu.org; 6 Jul 2018 08:55:53 +0000 Received: from localhost ([127.0.0.1]:48207 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fbMWt-0007YK-Oz for submit@debbugs.gnu.org; Fri, 06 Jul 2018 04:55:53 -0400 Received: from eggs.gnu.org ([208.118.235.92]:41841) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fbMWs-0007Y5-1p for 32029@debbugs.gnu.org; Fri, 06 Jul 2018 04:55:50 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fbMWi-0007Db-2G for 32029@debbugs.gnu.org; Fri, 06 Jul 2018 04:55:45 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:44426) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fbMWh-0007Cc-RV; Fri, 06 Jul 2018 04:55:39 -0400 Received: from [176.228.60.248] (port=2313 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1fbMWh-0006Yb-8b; Fri, 06 Jul 2018 04:55:39 -0400 Date: Fri, 06 Jul 2018 11:55:41 +0300 Message-Id: <8336wwn3oy.fsf@gnu.org> From: Eli Zaretskii To: Tobias Gerdin In-reply-to: (message from Tobias Gerdin on Tue, 3 Jul 2018 23:37:23 +0200) Subject: Re: bug#32029: [PATCH] xref-find-definitions-at-mouse References: <9af0d021-361d-ccc6-a051-f102589bccb7@gmail.com> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 32029 Cc: 32029@debbugs.gnu.org, dgutov@yandex.ru X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -6.0 (------) > From: Tobias Gerdin > Date: Tue, 3 Jul 2018 23:37:23 +0200 > > > You should call `mouse-set-point` before `xref-find-backend`, because > > the latter might conceivably depend on the value of point. > > > > I think this can be written much shorter (call mouse-set-point, then > > interactively call xref-find-definitions), but I'm not sure how. > A new version below. Dmitry, are you okay with having this on master? Or is there something else that should be done about this? Thanks. From debbugs-submit-bounces@debbugs.gnu.org Fri Jul 06 05:03:43 2018 Received: (at 32029) by debbugs.gnu.org; 6 Jul 2018 09:03:43 +0000 Received: from localhost ([127.0.0.1]:48216 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fbMeV-0007lH-Bq for submit@debbugs.gnu.org; Fri, 06 Jul 2018 05:03:43 -0400 Received: from mail-wm0-f47.google.com ([74.125.82.47]:52606) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fbMeT-0007l4-Qj for 32029@debbugs.gnu.org; Fri, 06 Jul 2018 05:03:42 -0400 Received: by mail-wm0-f47.google.com with SMTP id w16-v6so14064988wmc.2 for <32029@debbugs.gnu.org>; Fri, 06 Jul 2018 02:03:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=vQzjNG0EjoHQv8z766tePxZQHel5T0/FDeUoldzRicM=; b=qo6xB4EgvjFYR3NCopGIxKqQljXPNsP2uXrKeulGkf8+Gl0PjkzFpfnDoP6OzQ9GMM 5d5KGLf0WznASSEIdEkCMrBo3HrErtenO1KiROsrlvrPIrYnidBbvzG3V+CBY1Ir2cT8 MtyxULGxGn0XRs0WRalBjypcHnIN17xKEMoKodXALOP2EJMZD+IMZraeyiJejB0r6p6G 3cNgJ9FbO/ZZGTyATGGVkwVUzeQKJtHPOZrbDomWy5f0VXmh9FdHIyyR/ZqYy/wRXxVM Pvv1e4k3VMDZAW+OtLF2a3JdYIgA/8b9zlU/jQvM5e5v7QpD88fmZ7P24s7Lkvtu01K8 gtTg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=vQzjNG0EjoHQv8z766tePxZQHel5T0/FDeUoldzRicM=; b=uAW+Q0ISwPfhI2CNbQVqZpLsjt6kAxSIV3obhLhj2ZctIhOsvMBCLMdbQ+Tnd4CZ4f J1HQu00YoDCLPM3TTAOON0ui8ZSOtHTTl5Dq5LlzFaM7K2uk74e48Gt+zHKITZFOQGEr 5E+6pyw81Xtw779i13UWOgCbMG9Ec4g6Ru2BuIpAGXwqO+HrjtFw5ohkGSjQTR7YgtUh pawGhEKrnd82tNXE7qCtmjWoomN7+PyvQEOnlOsiietM945LSgB2+As1Lk4mAorid09q 8tZVITy5kPftYEKMXuXAqjVXlCTFJEuDhGt6qvEk1Q/8iS1PUQm1HSW7uNX8l3kMg9tD jTWg== X-Gm-Message-State: APt69E3O9ISwW7jZzZb9dSKXbvdsGsV2mw8Ow00p96uuid1wbwqPHC5U bzQTQq46XunI9XX//fIhbFDtx4HX X-Google-Smtp-Source: AAOMgpeXZcrAiyKUB2EjWfkjM1DoG4DvjIM7T7z/GSjK87Hb6vm01fcajhe8dqvWhCj5Wqw7JvLjww== X-Received: by 2002:a1c:69d2:: with SMTP id z79-v6mr6289550wmh.92.1530867815788; Fri, 06 Jul 2018 02:03:35 -0700 (PDT) Received: from [192.168.1.3] ([185.105.174.23]) by smtp.googlemail.com with ESMTPSA id u4-v6sm6046511wmc.1.2018.07.06.02.03.34 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 06 Jul 2018 02:03:34 -0700 (PDT) Subject: Re: bug#32029: [PATCH] xref-find-definitions-at-mouse To: Eli Zaretskii , Tobias Gerdin References: <9af0d021-361d-ccc6-a051-f102589bccb7@gmail.com> <8336wwn3oy.fsf@gnu.org> From: Dmitry Gutov Message-ID: <7872311f-83a6-5c72-f696-5fd452454d2b@yandex.ru> Date: Fri, 6 Jul 2018 12:03:33 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.0 MIME-Version: 1.0 In-Reply-To: <8336wwn3oy.fsf@gnu.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: 32029 Cc: 32029@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.5 (/) On 7/6/18 11:55 AM, Eli Zaretskii wrote: > Dmitry, are you okay with having this on master? Or is there > something else that should be done about this? Yes. A NEWS entry, I guess. I mistakenly sent my last reply to emacs-devel instead of this bug thread. From debbugs-submit-bounces@debbugs.gnu.org Fri Jul 06 16:23:29 2018 Received: (at 32029) by debbugs.gnu.org; 6 Jul 2018 20:23:29 +0000 Received: from localhost ([127.0.0.1]:48830 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fbXGL-0000UU-8y for submit@debbugs.gnu.org; Fri, 06 Jul 2018 16:23:29 -0400 Received: from mail-lj1-f175.google.com ([209.85.208.175]:35834) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fbXGJ-0000UD-J7 for 32029@debbugs.gnu.org; Fri, 06 Jul 2018 16:23:27 -0400 Received: by mail-lj1-f175.google.com with SMTP id p10-v6so4580992ljg.2 for <32029@debbugs.gnu.org>; Fri, 06 Jul 2018 13:23:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding:content-language; bh=Gp6i9HJsdSv1rSuw4FCni0kagnixo2P5QNzMKjXFErs=; b=Ygx5J99BF/nf/eteUHNQcr+dJVJaln6HAKv7D1N/aWmc4MlR70k2HiuOD+cmC8Hy/c nRWSaHUuzxd7NUJk70idBAwOJe34JdgiWv8FX+h/WtDNGbDzsORWSBO9ShcJR4L4upV2 /GGN81NsOzKEdOktPbntjlD0lQG7386UC2C64NGf4vLiNcrwFW0LSr0sbk07pqruPmCZ ntmABz3Ed+0xGuiIAY/aMWdAebaK8MEP5p1msGX01pFdSfvyqN2OaT+UJYSesiFFNLrH X81slyGtWWjETDyEQRt5gvNOncVGgwBGp4tfDc1iJQccCE6xpPitgzKT60QL7onpZbQb 0Ysw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=Gp6i9HJsdSv1rSuw4FCni0kagnixo2P5QNzMKjXFErs=; b=Ldh/VOGEVUWDFdd/e+7Z8PNnAxa1rUJje7nZyIjs086hU+aJDXQ13OrDWTjJ4ypDNa 8xyo7rmigDiVDB+kFtMUbluWDDa0ixqbuPy1etzPDdArH/p3DmwTQpwwXYWcweditxLO hKbRzkSO6I0Y0gKnNziIW+0PLHHF1h07MSE1wcdm0zIErQdUnpG8kxwZEHBdDRnCITuC +FKpgXaBrKVI4M2Jt8Y0I9kFJ1jcQEVCRlGsTqnzlfOZJCzlpl2rN01puDa4JajpFPW+ 8CO97E9bK3Q30EZnGCe4jWajPbk9RvnxJ90SWMUUv7q/b4l0vAgbmNsSUmcBIrBB+7SI G2tw== X-Gm-Message-State: APt69E2QqSwc4wfSxuQMGuIdbxG0DfOarPOKNljII4Y61EDX0e6I0W7k rHWEYZzHuh1a2KzLHg1GCFyDGgQv X-Google-Smtp-Source: AAOMgpfWgVkFKk3dfeXefyaOPdhurWqe/Sc/DeSj3XDCptPqsSn2gXeHRAR7xE0LnfV02vqsYmvTVA== X-Received: by 2002:a2e:96d8:: with SMTP id d24-v6mr7301000ljj.50.1530908601309; Fri, 06 Jul 2018 13:23:21 -0700 (PDT) Received: from Tobias-MacBook-Pro.local (host-217-214-150-82.mobileonline.telia.com. [217.214.150.82]) by smtp.gmail.com with ESMTPSA id h66-v6sm1397143ljf.65.2018.07.06.13.23.19 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 06 Jul 2018 13:23:20 -0700 (PDT) Subject: Re: bug#32029: [PATCH] xref-find-definitions-at-mouse To: Dmitry Gutov , Eli Zaretskii References: <9af0d021-361d-ccc6-a051-f102589bccb7@gmail.com> <8336wwn3oy.fsf@gnu.org> <7872311f-83a6-5c72-f696-5fd452454d2b@yandex.ru> From: Tobias Gerdin Message-ID: <28eb93b7-d3b9-06d2-93b1-569688126ad7@gmail.com> Date: Fri, 6 Jul 2018 22:23:19 +0200 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.13; rv:52.0) Gecko/20100101 Thunderbird/52.8.0 MIME-Version: 1.0 In-Reply-To: <7872311f-83a6-5c72-f696-5fd452454d2b@yandex.ru> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 32029 Cc: 32029@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Den 2018-07-06 kl. 11:03, skrev Dmitry Gutov: > On 7/6/18 11:55 AM, Eli Zaretskii wrote: > >> Dmitry, are you okay with having this on master?  Or is there >> something else that should be done about this? > > Yes. > > A NEWS entry, I guess. diff --git a/etc/NEWS b/etc/NEWS index c92ee6e680..2bfe884987 100644 --- a/etc/NEWS +++ b/etc/NEWS @@ -165,6 +165,12 @@ from a remote host.  This triggers to search the program on the remote host as indicated by  'default-directory'. ++++ +** New function 'xref-find-definitions-at-mouse'. +Allows jumping to a definition by clicking on the identifier. Needs to be +bound to a mouse event. See the node "Mouse Buttons" in the Emacs manual +for details. +    * Editing Changes in Emacs 27.1 From debbugs-submit-bounces@debbugs.gnu.org Sat Jul 07 05:02:50 2018 Received: (at 32029-done) by debbugs.gnu.org; 7 Jul 2018 09:02:51 +0000 Received: from localhost ([127.0.0.1]:49069 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fbj7B-00040s-Ve for submit@debbugs.gnu.org; Sat, 07 Jul 2018 05:02:50 -0400 Received: from eggs.gnu.org ([208.118.235.92]:34953) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fbj7A-00040e-GE for 32029-done@debbugs.gnu.org; Sat, 07 Jul 2018 05:02:48 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fbj72-00064B-62 for 32029-done@debbugs.gnu.org; Sat, 07 Jul 2018 05:02:43 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:50308) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fbj72-000647-2K; Sat, 07 Jul 2018 05:02:40 -0400 Received: from [176.228.60.248] (port=3606 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1fbj71-00015A-Ek; Sat, 07 Jul 2018 05:02:39 -0400 Date: Sat, 07 Jul 2018 12:02:43 +0300 Message-Id: <83k1q7ju4s.fsf@gnu.org> From: Eli Zaretskii To: Tobias Gerdin In-reply-to: (message from Tobias Gerdin on Tue, 3 Jul 2018 23:37:23 +0200) Subject: Re: bug#32029: [PATCH] xref-find-definitions-at-mouse References: <9af0d021-361d-ccc6-a051-f102589bccb7@gmail.com> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 32029-done Cc: 32029-done@debbugs.gnu.org, dgutov@yandex.ru X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -6.0 (------) > From: Tobias Gerdin > Date: Tue, 3 Jul 2018 23:37:23 +0200 > > A new version below. Thanks, pushed to the master branch. From debbugs-submit-bounces@debbugs.gnu.org Sat Jul 07 05:04:44 2018 Received: (at 32029) by debbugs.gnu.org; 7 Jul 2018 09:04:44 +0000 Received: from localhost ([127.0.0.1]:49075 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fbj92-000443-2p for submit@debbugs.gnu.org; Sat, 07 Jul 2018 05:04:44 -0400 Received: from eggs.gnu.org ([208.118.235.92]:35306) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fbj90-00043r-Kw for 32029@debbugs.gnu.org; Sat, 07 Jul 2018 05:04:42 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fbj8s-0007Jq-H6 for 32029@debbugs.gnu.org; Sat, 07 Jul 2018 05:04:37 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50 autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:50332) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fbj8s-0007Jk-Cr; Sat, 07 Jul 2018 05:04:34 -0400 Received: from [176.228.60.248] (port=3722 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1fbj8r-000348-Ss; Sat, 07 Jul 2018 05:04:34 -0400 Date: Sat, 07 Jul 2018 12:04:38 +0300 Message-Id: <83in5rju1l.fsf@gnu.org> From: Eli Zaretskii To: Tobias Gerdin In-reply-to: <28eb93b7-d3b9-06d2-93b1-569688126ad7@gmail.com> (message from Tobias Gerdin on Fri, 6 Jul 2018 22:23:19 +0200) Subject: Re: bug#32029: [PATCH] xref-find-definitions-at-mouse References: <9af0d021-361d-ccc6-a051-f102589bccb7@gmail.com> <8336wwn3oy.fsf@gnu.org> <7872311f-83a6-5c72-f696-5fd452454d2b@yandex.ru> <28eb93b7-d3b9-06d2-93b1-569688126ad7@gmail.com> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 32029 Cc: 32029@debbugs.gnu.org, dgutov@yandex.ru X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -6.0 (------) > Cc: 32029@debbugs.gnu.org > From: Tobias Gerdin > Date: Fri, 6 Jul 2018 22:23:19 +0200 > > Den 2018-07-06 kl. 11:03, skrev Dmitry Gutov: > > > On 7/6/18 11:55 AM, Eli Zaretskii wrote: > > > >> Dmitry, are you okay with having this on master?  Or is there > >> something else that should be done about this? > > > > Yes. > > > > A NEWS entry, I guess. > diff --git a/etc/NEWS b/etc/NEWS > index c92ee6e680..2bfe884987 100644 > --- a/etc/NEWS > +++ b/etc/NEWS > @@ -165,6 +165,12 @@ from a remote host. >  This triggers to search the program on the remote host as indicated by >  'default-directory'. > > ++++ > +** New function 'xref-find-definitions-at-mouse'. > +Allows jumping to a definition by clicking on the identifier. Needs to be > +bound to a mouse event. See the node "Mouse Buttons" in the Emacs manual > +for details. > + Thanks, I preferred to write the NEWS entry (and a suitable manual change) myself, so as not to exhaust the amount of changes we can accept from you without legal paperwork. Would you like to start the copyright assignment paperwork at this time, so that future contributions could be unlimited? From unknown Sat Sep 06 09:43:53 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sat, 04 Aug 2018 11:24:04 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator