GNU bug report logs - #32028
Fix thingatpt url's beginning-op

Previous Next

Full log

View this message in rfc822 format

From: Raimon Grau <raimonster <at> gmail.com>
To: 32028 <at> debbugs.gnu.org
Subject: bug#32028: Fix thingatpt url's beginning-op
Date: Sun, 01 Jul 2018 23:56:37 +0100

[Message part 1 (text/plain, inline)]

Hello,

I found a small bug in thingatpt.el. `beginning-op' for url's was using
an incorrect helper (end-of-thing) and changed it to the correct one.

This is my first time sending a patch to this list so I might be missing
something or doing something wrong wrt process.  If that's the case,
apologises in advance.  (My fsf papers are signed, so there's no problem
on that regard)

Cheers,

Raimon Grau

[0001-Fix-url-s-thing-at-point-beginning-op.patch (text/x-diff, inline)]

From e725d737ea4bc5bb8545a10866ac59986c450d12 Mon Sep 17 00:00:00 2001
From: Raimon Grau <raimonster <at> gmail.com>
Date: Sun, 1 Jul 2018 21:31:08 +0100
Subject: [PATCH] Fix url's thing-at-point beginning-op

* lisp/thingatpt.el (url): Fix beginning-op making.
---
 ChangeLog.3       | 6 ++++++
 lisp/thingatpt.el | 2 +-
 2 files changed, 7 insertions(+), 1 deletion(-)

diff --git a/ChangeLog.3 b/ChangeLog.3
index 6704d0d..8d0a5dd 100644
--- a/ChangeLog.3
+++ b/ChangeLog.3
@@ -1,3 +1,9 @@
+2018-07-01 Raimon Grau <raimonster <at> gmail.com>
+
+	Fix url's thing-at-point beginning-op
+
+	* lisp/thingatpt.el (url): Fix beginning-op making.
+
 2018-05-25  Noam Postavsky  <npostavs <at> gmail.com>
 
 	Note caveat for backward regexp searching in docstring (Bug#31584)
diff --git a/lisp/thingatpt.el b/lisp/thingatpt.el
index 4612e95..7fcb3bc 100644
--- a/lisp/thingatpt.el
+++ b/lisp/thingatpt.el
@@ -484,7 +484,7 @@ thing-at-point-newsgroup-p
 
 (put 'url 'end-op (lambda () (end-of-thing 'url)))
 
-(put 'url 'beginning-op (lambda () (end-of-thing 'url)))
+(put 'url 'beginning-op (lambda () (beginning-of-thing 'url)))
 
 ;; The normal thingatpt mechanism doesn't work for complex regexps.
 ;; This should work for almost any regexp wherever we are in the
-- 
2.7.4

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.