GNU bug report logs - #32024
27.0; [PATCH] `imenu--generic-function'

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#32024: closed (27.0; [PATCH] `imenu--generic-function')
Date: Sat, 07 Jul 2018 16:23:02 +0000

[Message part 1 (text/plain, inline)]

Your message dated Sat, 07 Jul 2018 19:22:17 +0300
with message-id <83muv3hv7q.fsf <at> gnu.org>
and subject line Re: bug#32024: 27.0; [PATCH] `imenu--generic-function'
has caused the debbugs.gnu.org bug report #32024,
regarding 27.0; [PATCH] `imenu--generic-function'
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
32024: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=32024
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Drew Adams <drew.adams <at> oracle.com>
To: bug-gnu-emacs <at> gnu.org
Subject: 27.0; [PATCH] `imenu--generic-function'
Date: Sat, 30 Jun 2018 15:53:22 -0700 (PDT)

[Message part 3 (text/plain, inline)]

Attached is a patch for two bugs in `imenu--generic-function'.  I ran
into them when using a function value for argument REGEXP, though
neither has to do particularly with that use case.  Instead, they both
have to do with the case where items are within comments or strings,
which might be skipped.

1. When checking whether the current item is inside a comment or string,
   it's necessary to first move point to position START.  Otherwise, the
   test is made at bol (which might not be within a comment or string,
   even though the START position is).

2. At the end, it's necessary to remove any empty menus that could have
   been added.  That can happen because of skipping things inside
   comments or strings.

In GNU Emacs 27.0.50 (build 3, x86_64-w64-mingw32)
 of 2018-03-21
Repository revision: e70d0c9e66d7a8609450b2889869d16aeb0363b5
Windowing system distributor `Microsoft Corp.', version 6.1.7601
Configured using:
 `configure --without-dbus --host=x86_64-w64-mingw32
 --without-compress-install -C 'CFLAGS=-O2 -static -g3''

[imenu-2018-06-30.patch (application/octet-stream, attachment)]

[Message part 5 (message/rfc822, inline)]

From: Eli Zaretskii <eliz <at> gnu.org>
To: Drew Adams <drew.adams <at> oracle.com>
Cc: 32024-done <at> debbugs.gnu.org
Subject: Re: bug#32024: 27.0; [PATCH] `imenu--generic-function'
Date: Sat, 07 Jul 2018 19:22:17 +0300

> Date: Sat, 7 Jul 2018 07:27:52 -0700 (PDT)
> From: Drew Adams <drew.adams <at> oracle.com>
> Cc: 32024 <at> debbugs.gnu.org
> 
> Sorry about that.  Can you please substitute the equivalent
> function from Emacs, `cl-delete-if-not' (in `cl-seq.el')?

Done, thanks.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.