Subject: Re: [bug#32023] [PATCH] gnu: emacs-browse-at-remote: Update to 0.10.0.

From: Oleg Pykhalov <[email-masked]>
Date: Sun, 01 Jul 2018 19:52:52 +0300

Hello Marius,

Thank you for review.

Marius Bakke <[email-masked]> writes:

> Oleg Pykhalov <[email-masked]> writes:
>
>> * gnu/packages/emacs.scm (emacs-browse-at-remote): Update to 0.10.0.
>> * gnu/packages/patches/emacs-browse-at-remote-cgit-gnu.patch: Delete file.
>> * gnu/local.mk (dist_patch_DATA): Remove it.

[…]

>> +    (arguments
>> +     `(#:tests? #t
>
> Is this not the default for emacs-build-system?  It was there from
> before, so not related to this patch.  Just curious :-)

No tests by default in ‘emacs-build-system’.

With ‘#:tests #t’
--8<---------------cut here---------------start------------->8---
starting phase `check'
Warning: Lisp directory '/tmp/guix-build-ert-runner-0.7.0.drv-0/ert-runner.el-0.7.0': No such file or directory
...

Ran 3 tests in 0.005 seconds
phase `check' succeeded after 0.1 seconds
--8<---------------cut here---------------end--------------->8---

Without ‘#:tests #t’:
--8<---------------cut here---------------start------------->8---
starting phase `check'
test suite not run
phase `check' succeeded after 0.0 seconds
--8<---------------cut here---------------end--------------->8---

Pushed as 960231873661365bb6228d62c5452e634d6da5d2

Oleg.