Subject: bug#32017: closed (Re: [bug#32017] import: elpa: Check if 'fetch-elpa-package' rest argument is null.)

From: [email-masked] (GNU bug Tracking System)
Date: Tue, 03 Jul 2018 04:24:03 +0000

Your bug report

#32017: import: elpa: Check if 'fetch-elpa-package' rest argument is null.

which was filed against the guix-patches package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to [email-masked].

-- 
32017: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=32017
GNU Bug Tracking System
Contact [email-masked] with problems

Subject: Re: [bug#32017] import: elpa: Check if 'fetch-elpa-package' rest argument is null.
From: Oleg Pykhalov <[email-masked]>
To: [email-masked] (Ludovic Courtès)
Cc: [email-masked], [email-masked]
Date: Tue, 03 Jul 2018 07:23:28 +0300
List-Id: <debbugs-submit.debbugs.gnu.org>

Hello Ludovic,

Thank you for review and improvements.

[email-masked] (Ludovic Courtès) writes:

> Oleg Pykhalov <[email-masked]> skribis:
>
>> From 5b06ab52ada54fc4c42c87400a7b635843cf1542 Mon Sep 17 00:00:00 2001
>> From: Oleg Pykhalov <[email-masked]>
>> Date: Sat, 30 Jun 2018 10:51:45 +0300
>> Subject: [PATCH] import: elpa: Check if 'fetch-elpa-package' rest argument is
>>  null.
>>
>> * guix/import/elpa.scm (fetch-elpa-package): Check if 'rest' is null.
>> ---
>>  guix/import/elpa.scm | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/guix/import/elpa.scm b/guix/import/elpa.scm
>> index 65e0be45a..869e70ee2 100644
>> --- a/guix/import/elpa.scm
>> +++ b/guix/import/elpa.scm
>> @@ -187,7 +187,7 @@ include VERSION."
>>               (url (package-source-url kind name ver repo)))
>>           (make-elpa-package name ver
>>                              (ensure-list reqs) synopsis kind
>> -                            (package-home-page (first rest))
>> +                            (package-home-page (if (null? rest) #f (first rest)))
>>                              (fetch-package-description kind name repo)
>
> As per our coding style guidelines (info "(guix) Data Types and Pattern
> Matching"), it would be best to write:
>
>   (match rest
>     (() #f)
>     ((one) one))
>
> Otherwise LGTM, thanks!

OK, pushed as ae6fa00af02399e2ffadccc81bd7718cc7c26f10

Oleg.

Subject: import: elpa: Check if 'fetch-elpa-package' rest argument is null.
From: Oleg Pykhalov <[email-masked]>
To: guix-patches <[email-masked]>
Date: Sat, 30 Jun 2018 10:55:05 +0300
List-Id: <debbugs-submit.debbugs.gnu.org>

Hello Guix,

This patch fixes the following error:
--8<---------------cut here---------------start------------->8---
$ guix import elpa -a melpa proc-net
Backtrace:
           6 (primitive-load "/home/natsu/.config/guix/current/bin/guix")
In guix/ui.scm:
  1570:12  5 (run-guix-command _ . _)
In guix/scripts/import.scm:
   114:11  4 (guix-import . _)
In guix/scripts/import/elpa.scm:
   108:23  3 (guix-import-elpa . _)
In guix/import/elpa.scm:
    247:2  2 (elpa->guix-package _ _)
   190:47  1 (fetch-elpa-package _ _)
In unknown file:
           0 (car ())

ERROR: In procedure car:
In procedure car: Wrong type (expecting pair): ()
--8<---------------cut here---------------end--------------->8---

From 5b06ab52ada54fc4c42c87400a7b635843cf1542 Mon Sep 17 00:00:00 2001
From: Oleg Pykhalov <[email-masked]>
Date: Sat, 30 Jun 2018 10:51:45 +0300
Subject: [PATCH] import: elpa: Check if 'fetch-elpa-package' rest argument is
 null.

* guix/import/elpa.scm (fetch-elpa-package): Check if 'rest' is null.
---
 guix/import/elpa.scm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/guix/import/elpa.scm b/guix/import/elpa.scm
index 65e0be45a..869e70ee2 100644
--- a/guix/import/elpa.scm
+++ b/guix/import/elpa.scm
@@ -187,7 +187,7 @@ include VERSION."
              (url (package-source-url kind name ver repo)))
          (make-elpa-package name ver
                             (ensure-list reqs) synopsis kind
-                            (package-home-page (first rest))
+                            (package-home-page (if (null? rest) #f (first rest)))
                             (fetch-package-description kind name repo)
                             url)))
       (_ #f))))
-- 
2.18.0

Thanks,
Oleg.