From unknown Fri Sep 12 01:12:31 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#32008] [PATCH] gnu: ledger: Skip failing test. Resent-From: Arun Isaac Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 29 Jun 2018 17:09:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 32008 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 32008@debbugs.gnu.org Cc: Arun Isaac X-Debbugs-Original-To: guix-patches@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.153029211326649 (code B ref -1); Fri, 29 Jun 2018 17:09:01 +0000 Received: (at submit) by debbugs.gnu.org; 29 Jun 2018 17:08:33 +0000 Received: from localhost ([127.0.0.1]:40045 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fYwsm-0006vg-TQ for submit@debbugs.gnu.org; Fri, 29 Jun 2018 13:08:33 -0400 Received: from eggs.gnu.org ([208.118.235.92]:48792) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fYwsl-0006vU-D3 for submit@debbugs.gnu.org; Fri, 29 Jun 2018 13:08:27 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fYwse-0002Lk-Rf for submit@debbugs.gnu.org; Fri, 29 Jun 2018 13:08:22 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,T_DKIM_INVALID autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:59976) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1fYwse-0002LX-Nv for submit@debbugs.gnu.org; Fri, 29 Jun 2018 13:08:20 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:39756) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fYwsd-0000bJ-Fa for guix-patches@gnu.org; Fri, 29 Jun 2018 13:08:20 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fYwsZ-0002Gr-Ar for guix-patches@gnu.org; Fri, 29 Jun 2018 13:08:19 -0400 Received: from [2001:19f0:5:274f:351:616f:fec3:2694] (port=55604 helo=vultr.systemreboot.net) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1fYwsY-00028Z-QI for guix-patches@gnu.org; Fri, 29 Jun 2018 13:08:15 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=systemreboot.net; s=default; h=Content-Transfer-Encoding:Content-Type: MIME-Version:Message-Id:Date:Subject:Cc:To:From:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=RFNzB0QlEpkrQW30IiQDhv1HHgbGpzYpTOfnq6qst34=; b=aOm5W7C4Bpjly1wWXfCNKj4caY lf8kBoNMSDu7JRmpW3EyVaMoWhFAiTSs7Xle8M7w6hUKIi44CPjBiPSB3RT2Dtt1XTGUUQhDZKtNU shvUaMzpTa7HgzqzyBNXl33hj8/djpnwMh7iuv9lE1SM9UVzzSDFZi1SgSD6jOZnxTQQ=; Received: from [117.192.109.237] (helo=localhost.localdomain) by systemreboot.net with esmtpsa (TLSv1.2:ECDHE-RSA-AES128-GCM-SHA256:128) (Exim 4.91) (envelope-from ) id 1fYwpV-0002Tf-LQ; Fri, 29 Jun 2018 22:35:05 +0530 From: Arun Isaac Date: Fri, 29 Jun 2018 22:37:49 +0530 Message-Id: <20180629170749.4211-1-arunisaac@systemreboot.net> X-Mailer: git-send-email 2.15.1 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.1 (----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.1 (-----) * gnu/packages/finance.scm (ledger)[arguments]: Set #:make-flags to skip failing test BaselineTest_cmd-org. Replace check phase with the check phase from gnu-build-system. Replace system* with invoke in build-doc phase. Remove #t return from relocate-elisp phase since emacs-generate-autoloads already returns #t. [home-page]: Switch to HTTPS URI. --- gnu/packages/finance.scm | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/gnu/packages/finance.scm b/gnu/packages/finance.scm index c93f64193..e7fbfe17d 100644 --- a/gnu/packages/finance.scm +++ b/gnu/packages/finance.scm @@ -9,6 +9,7 @@ ;;; Copyright © 2017 Tobias Geerinckx-Rice ;;; Copyright © 2018 Eric Bavier ;;; Copyright © 2018 Adriano Peluso +;;; Copyright © 2018 Arun Isaac ;;; ;;; This file is part of GNU Guix. ;;; @@ -140,6 +141,7 @@ line client and a client based on Qt.") (build-system cmake-build-system) (arguments `(#:modules ((guix build cmake-build-system) + ((guix build gnu-build-system) #:prefix gnu:) (guix build utils) (guix build emacs-utils)) #:imported-modules (,@%cmake-build-system-modules @@ -153,6 +155,8 @@ line client and a client based on Qt.") ,(string-append "-DUTFCPP_INCLUDE_DIR:PATH=" (assoc-ref %build-inputs "utfcpp") "/include")) + ;; Skip failing tests during the check phase. + #:make-flags (list "ARGS=-E BaselineTest_cmd-org") #:phases (modify-phases %standard-phases (add-before 'configure 'install-examples @@ -163,7 +167,7 @@ line client and a client based on Qt.") (install-file "test/input/demo.ledger" examples)) #t)) (add-after 'build 'build-doc - (lambda _ (zero? (system* "make" "doc")))) + (lambda _ (invoke "make" "doc"))) (add-before 'check 'check-setup ;; One test fails if it can't set the timezone. (lambda* (#:key inputs #:allow-other-keys) @@ -171,6 +175,7 @@ line client and a client based on Qt.") (string-append (assoc-ref inputs "tzdata") "/share/zoneinfo")) #t)) + (replace 'check (assoc-ref gnu:%standard-phases 'check)) (add-after 'install 'relocate-elisp (lambda* (#:key outputs #:allow-other-keys) (let* ((site-dir (string-append (assoc-ref outputs "out") @@ -180,8 +185,7 @@ line client and a client based on Qt.") (dest-dir (string-append guix-dir "/ledger-mode"))) (mkdir-p guix-dir) (rename-file orig-dir dest-dir) - (emacs-generate-autoloads ,name dest-dir)) - #t))))) + (emacs-generate-autoloads ,name dest-dir))))))) (inputs `(("boost" ,boost) ("gmp" ,gmp) @@ -194,7 +198,7 @@ line client and a client based on Qt.") `(("emacs" ,emacs-minimal) ("groff" ,groff) ("texinfo" ,texinfo))) - (home-page "http://ledger-cli.org/") + (home-page "https://ledger-cli.org/") (synopsis "Command-line double-entry accounting program") (description "Ledger is a powerful, double-entry accounting system that is -- 2.15.1 From unknown Fri Sep 12 01:12:31 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#32008] [PATCH] gnu: ledger: Skip failing test. Resent-From: ludo@gnu.org (Ludovic =?UTF-8?Q?Court=C3=A8s?=) Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 02 Jul 2018 15:39:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 32008 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Arun Isaac Cc: 32008@debbugs.gnu.org Received: via spool by 32008-submit@debbugs.gnu.org id=B32008.153054592125568 (code B ref 32008); Mon, 02 Jul 2018 15:39:01 +0000 Received: (at 32008) by debbugs.gnu.org; 2 Jul 2018 15:38:41 +0000 Received: from localhost ([127.0.0.1]:43774 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fa0uX-0006eK-Hn for submit@debbugs.gnu.org; Mon, 02 Jul 2018 11:38:41 -0400 Received: from eggs.gnu.org ([208.118.235.92]:37726) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fa0uV-0006e8-OP for 32008@debbugs.gnu.org; Mon, 02 Jul 2018 11:38:39 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fa0uP-0004BR-Po for 32008@debbugs.gnu.org; Mon, 02 Jul 2018 11:38:34 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:59831) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fa0uP-0004B9-M5; Mon, 02 Jul 2018 11:38:33 -0400 Received: from [193.50.110.150] (port=59352 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1fa0uP-0003gh-38; Mon, 02 Jul 2018 11:38:33 -0400 From: ludo@gnu.org (Ludovic =?UTF-8?Q?Court=C3=A8s?=) References: <20180629170749.4211-1-arunisaac@systemreboot.net> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: 14 Messidor an 226 de la =?UTF-8?Q?R=C3=A9volution?= X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-pc-linux-gnu Date: Mon, 02 Jul 2018 17:38:31 +0200 In-Reply-To: <20180629170749.4211-1-arunisaac@systemreboot.net> (Arun Isaac's message of "Fri, 29 Jun 2018 22:37:49 +0530") Message-ID: <87r2klejgo.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -6.0 (------) Hello, Arun Isaac skribis: > * gnu/packages/finance.scm (ledger)[arguments]: Set #:make-flags to skip > failing test BaselineTest_cmd-org. Replace check phase with the check pha= se > from gnu-build-system. > Replace system* with invoke in build-doc phase. > Remove #t return from relocate-elisp phase since emacs-generate-autoloads > already returns #t. > [home-page]: Switch to HTTPS URI. It would be nice to make separate patches for unrelated things (for instance invoke and phase returns have nothing to do with skipping the test), but otherwise LGTM. > + ;; Skip failing tests during the check phase. > + #:make-flags (list "ARGS=3D-E BaselineTest_cmd-org") Do you have more info about the test or an upstream bug report? Thank you! Ludo=E2=80=99. From unknown Fri Sep 12 01:12:31 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#32008] [PATCH] gnu: ledger: Skip failing test. Resent-From: ludo@gnu.org (Ludovic =?UTF-8?Q?Court=C3=A8s?=) Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 03 Jul 2018 19:23:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 32008 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Arun Isaac Cc: 32008@debbugs.gnu.org Received: via spool by 32008-submit@debbugs.gnu.org id=B32008.153064577628791 (code B ref 32008); Tue, 03 Jul 2018 19:23:02 +0000 Received: (at 32008) by debbugs.gnu.org; 3 Jul 2018 19:22:56 +0000 Received: from localhost ([127.0.0.1]:45673 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1faQt6-0007UI-7h for submit@debbugs.gnu.org; Tue, 03 Jul 2018 15:22:56 -0400 Received: from eggs.gnu.org ([208.118.235.92]:34898) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1faQt5-0007U5-4l for 32008@debbugs.gnu.org; Tue, 03 Jul 2018 15:22:55 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1faQsz-0004Ft-2h for 32008@debbugs.gnu.org; Tue, 03 Jul 2018 15:22:50 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:54053) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1faQsy-0004Fp-Ue; Tue, 03 Jul 2018 15:22:48 -0400 Received: from [2a01:e0a:1d:7270:af76:b9b:ca24:c465] (port=59496 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1faQsy-0006Mj-FO; Tue, 03 Jul 2018 15:22:48 -0400 From: ludo@gnu.org (Ludovic =?UTF-8?Q?Court=C3=A8s?=) References: <20180629170749.4211-1-arunisaac@systemreboot.net> <87r2klejgo.fsf@gnu.org> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: 15 Messidor an 226 de la =?UTF-8?Q?R=C3=A9volution?= X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-pc-linux-gnu Date: Tue, 03 Jul 2018 21:22:46 +0200 In-Reply-To: (Arun Isaac's message of "Tue, 03 Jul 2018 14:26:30 +0530") Message-ID: <87r2kkgm49.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -6.0 (------) Arun Isaac skribis: > Ludovic Court=C3=A8s writes: > >> It would be nice to make separate patches for unrelated things (for >> instance invoke and phase returns have nothing to do with skipping the >> test), but otherwise LGTM. > > I bunched these together because the invoke change and home-page change > were fairly minor things. But, if you insist, I'll push these as three > separate commits (one for skipping the test, one for invoke/phase > returns, and one for the home-page change). Honestly it doesn=E2=80=99t matter much here, but what I like about one-patch-for-one-thing is that it makes review and bug hunting (when you later run =E2=80=98git annotate=E2=80=99 to understand what happened) e= asier. >>> + ;; Skip failing tests during the check phase. >>> + #:make-flags (list "ARGS=3D-E BaselineTest_cmd-org") >> >> Do you have more info about the test or an upstream bug report? > > Yes, this is a known upstream bug. It exists even in the latest git > checkout. > > https://github.com/ledger/ledger/issues/550 > > I also posted to this bug report mentioning our problem in GuixSD. I > will leave the URI to this bug report in the comments before > #:make-flags. Perfect. > Shall I push with the above mentioned changes? Sure! Thank you, Ludo=E2=80=99. From unknown Fri Sep 12 01:12:31 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Arun Isaac Subject: bug#32008: closed (Re: [bug#32008] [PATCH] gnu: ledger: Skip failing test.) Message-ID: References: <20180629170749.4211-1-arunisaac@systemreboot.net> X-Gnu-PR-Message: they-closed 32008 X-Gnu-PR-Package: guix-patches X-Gnu-PR-Keywords: patch Reply-To: 32008@debbugs.gnu.org Date: Wed, 04 Jul 2018 12:56:02 +0000 Content-Type: multipart/mixed; boundary="----------=_1530708962-18400-1" This is a multi-part message in MIME format... ------------=_1530708962-18400-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #32008: [PATCH] gnu: ledger: Skip failing test. which was filed against the guix-patches package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 32008@debbugs.gnu.org. --=20 32008: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D32008 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1530708962-18400-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 32008-done) by debbugs.gnu.org; 4 Jul 2018 12:55:05 +0000 Received: from localhost ([127.0.0.1]:46001 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fahJJ-0004lP-Hc for submit@debbugs.gnu.org; Wed, 04 Jul 2018 08:55:05 -0400 Received: from vultr.systemreboot.net ([45.77.148.100]:55806) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fahJE-0004ku-Ur for 32008-done@debbugs.gnu.org; Wed, 04 Jul 2018 08:55:01 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=systemreboot.net; s=default; h=Content-Transfer-Encoding:Content-Type: MIME-Version:Message-ID:Date:References:In-Reply-To:Subject:Cc:To:From:Sender :Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help: List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=BGWa4Efw5cWONK1ZJRN3MyTbJlHkoccyD3b7oV1/Iuw=; b=Txn0xwIMhBZZW943FecEj559ui SHq8BmSacuOY0vEzWXPwrKjS/t0CSHMPO/ogKjtKpeF6R8tgfUmBSVmQSlvtq4Tyy1QvMwN3ri+vj T+ufyeHQEzjuFJKwcXc6be8F4Eus2zSyiQWmzc7GEfN3bsbqMwvJv0U21xfUUveQqwE4=; Received: from [117.192.100.253] (helo=steel) by systemreboot.net with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.91) (envelope-from ) id 1fahFy-0004d3-Ba; Wed, 04 Jul 2018 18:21:38 +0530 From: Arun Isaac To: Ludovic =?utf-8?Q?Court=C3=A8s?= Subject: Re: [bug#32008] [PATCH] gnu: ledger: Skip failing test. In-Reply-To: <87r2kkgm49.fsf@gnu.org> References: <20180629170749.4211-1-arunisaac@systemreboot.net> <87r2klejgo.fsf@gnu.org> <87r2kkgm49.fsf@gnu.org> Date: Wed, 04 Jul 2018 18:24:42 +0530 Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 32008-done Cc: 32008-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) >>> It would be nice to make separate patches for unrelated things (for >>> instance invoke and phase returns have nothing to do with skipping the >>> test), but otherwise LGTM. >> > Honestly it doesn=E2=80=99t matter much here, but what I like about > one-patch-for-one-thing is that it makes review and bug hunting (when > you later run =E2=80=98git annotate=E2=80=99 to understand what happened)= easier. I understand the concerns. I used to split commits a lot. But, then I saw others using more bunched commits. So, I thought I was overdoing the splitting. >> Shall I push with the above mentioned changes? > > Sure! Pushed as three separate commits! Thank you for the review! ------------=_1530708962-18400-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 29 Jun 2018 17:08:33 +0000 Received: from localhost ([127.0.0.1]:40045 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fYwsm-0006vg-TQ for submit@debbugs.gnu.org; Fri, 29 Jun 2018 13:08:33 -0400 Received: from eggs.gnu.org ([208.118.235.92]:48792) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fYwsl-0006vU-D3 for submit@debbugs.gnu.org; Fri, 29 Jun 2018 13:08:27 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fYwse-0002Lk-Rf for submit@debbugs.gnu.org; Fri, 29 Jun 2018 13:08:22 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,T_DKIM_INVALID autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:59976) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1fYwse-0002LX-Nv for submit@debbugs.gnu.org; Fri, 29 Jun 2018 13:08:20 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:39756) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fYwsd-0000bJ-Fa for guix-patches@gnu.org; Fri, 29 Jun 2018 13:08:20 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fYwsZ-0002Gr-Ar for guix-patches@gnu.org; Fri, 29 Jun 2018 13:08:19 -0400 Received: from [2001:19f0:5:274f:351:616f:fec3:2694] (port=55604 helo=vultr.systemreboot.net) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1fYwsY-00028Z-QI for guix-patches@gnu.org; Fri, 29 Jun 2018 13:08:15 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=systemreboot.net; s=default; h=Content-Transfer-Encoding:Content-Type: MIME-Version:Message-Id:Date:Subject:Cc:To:From:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=RFNzB0QlEpkrQW30IiQDhv1HHgbGpzYpTOfnq6qst34=; b=aOm5W7C4Bpjly1wWXfCNKj4caY lf8kBoNMSDu7JRmpW3EyVaMoWhFAiTSs7Xle8M7w6hUKIi44CPjBiPSB3RT2Dtt1XTGUUQhDZKtNU shvUaMzpTa7HgzqzyBNXl33hj8/djpnwMh7iuv9lE1SM9UVzzSDFZi1SgSD6jOZnxTQQ=; Received: from [117.192.109.237] (helo=localhost.localdomain) by systemreboot.net with esmtpsa (TLSv1.2:ECDHE-RSA-AES128-GCM-SHA256:128) (Exim 4.91) (envelope-from ) id 1fYwpV-0002Tf-LQ; Fri, 29 Jun 2018 22:35:05 +0530 From: Arun Isaac To: guix-patches@gnu.org Subject: [PATCH] gnu: ledger: Skip failing test. Date: Fri, 29 Jun 2018 22:37:49 +0530 Message-Id: <20180629170749.4211-1-arunisaac@systemreboot.net> X-Mailer: git-send-email 2.15.1 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.1 (----) X-Debbugs-Envelope-To: submit Cc: Arun Isaac X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.1 (-----) * gnu/packages/finance.scm (ledger)[arguments]: Set #:make-flags to skip failing test BaselineTest_cmd-org. Replace check phase with the check phase from gnu-build-system. Replace system* with invoke in build-doc phase. Remove #t return from relocate-elisp phase since emacs-generate-autoloads already returns #t. [home-page]: Switch to HTTPS URI. --- gnu/packages/finance.scm | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/gnu/packages/finance.scm b/gnu/packages/finance.scm index c93f64193..e7fbfe17d 100644 --- a/gnu/packages/finance.scm +++ b/gnu/packages/finance.scm @@ -9,6 +9,7 @@ ;;; Copyright © 2017 Tobias Geerinckx-Rice ;;; Copyright © 2018 Eric Bavier ;;; Copyright © 2018 Adriano Peluso +;;; Copyright © 2018 Arun Isaac ;;; ;;; This file is part of GNU Guix. ;;; @@ -140,6 +141,7 @@ line client and a client based on Qt.") (build-system cmake-build-system) (arguments `(#:modules ((guix build cmake-build-system) + ((guix build gnu-build-system) #:prefix gnu:) (guix build utils) (guix build emacs-utils)) #:imported-modules (,@%cmake-build-system-modules @@ -153,6 +155,8 @@ line client and a client based on Qt.") ,(string-append "-DUTFCPP_INCLUDE_DIR:PATH=" (assoc-ref %build-inputs "utfcpp") "/include")) + ;; Skip failing tests during the check phase. + #:make-flags (list "ARGS=-E BaselineTest_cmd-org") #:phases (modify-phases %standard-phases (add-before 'configure 'install-examples @@ -163,7 +167,7 @@ line client and a client based on Qt.") (install-file "test/input/demo.ledger" examples)) #t)) (add-after 'build 'build-doc - (lambda _ (zero? (system* "make" "doc")))) + (lambda _ (invoke "make" "doc"))) (add-before 'check 'check-setup ;; One test fails if it can't set the timezone. (lambda* (#:key inputs #:allow-other-keys) @@ -171,6 +175,7 @@ line client and a client based on Qt.") (string-append (assoc-ref inputs "tzdata") "/share/zoneinfo")) #t)) + (replace 'check (assoc-ref gnu:%standard-phases 'check)) (add-after 'install 'relocate-elisp (lambda* (#:key outputs #:allow-other-keys) (let* ((site-dir (string-append (assoc-ref outputs "out") @@ -180,8 +185,7 @@ line client and a client based on Qt.") (dest-dir (string-append guix-dir "/ledger-mode"))) (mkdir-p guix-dir) (rename-file orig-dir dest-dir) - (emacs-generate-autoloads ,name dest-dir)) - #t))))) + (emacs-generate-autoloads ,name dest-dir))))))) (inputs `(("boost" ,boost) ("gmp" ,gmp) @@ -194,7 +198,7 @@ line client and a client based on Qt.") `(("emacs" ,emacs-minimal) ("groff" ,groff) ("texinfo" ,texinfo))) - (home-page "http://ledger-cli.org/") + (home-page "https://ledger-cli.org/") (synopsis "Command-line double-entry accounting program") (description "Ledger is a powerful, double-entry accounting system that is -- 2.15.1 ------------=_1530708962-18400-1--