From unknown Mon Aug 18 14:23:55 2025 X-Loop: don@donarmstrong.com Subject: bug#32: Bug in etags ".." code Reply-To: Tom Tromey , 32@debbugs.gnu.org Resent-From: Tom Tromey Original-Sender: bug-gnu-emacs-bounces+monnier=iro.umontreal.ca@gnu.org Resent-To: bug-submit-list@lists.donarmstrong.com Resent-CC: Emacs Bugs Resent-Date: Mon, 03 Mar 2008 03:20:04 +0000 Resent-Message-ID: Resent-Sender: don@donarmstrong.com X-Emacs-PR-Message: report 32 X-Emacs-PR-Package: emacs X-Emacs-PR-Keywords: Received: via spool by submit@emacsbugs.donarmstrong.com id=B.120451383526211 (code B ref -1); Mon, 03 Mar 2008 03:20:04 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.3-bugs.debian.org_2005_01_02 (2007-08-08) on rzlab.ucr.edu X-Spam-Level: * X-Spam-Status: No, score=1.3 required=4.0 tests=FOURLA,IMPRONONCABLE_1, MURPHY_DRUGS_REL8,MURPHY_WRONG_WORD2 autolearn=no version=3.2.3-bugs.debian.org_2005_01_02 Received: (at submit) by emacsbugs.donarmstrong.com; 3 Mar 2008 03:10:35 +0000 Received: from ironport2-out.pppoe.ca (ironport2-out.pppoe.ca [206.248.154.182]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id m233ATeo026201 for ; Sun, 2 Mar 2008 19:10:30 -0800 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: Ao8CABL7ykfO+LKX/2dsb2JhbACRd5lsgQA X-IronPort-AV: E=Sophos;i="4.25,435,1199682000"; d="scan'208";a="15471115" Received: from smtp.pppoe.ca ([65.39.196.238]) by ironport2-out.pppoe.ca with ESMTP; 02 Mar 2008 22:10:15 -0500 Received: from pastel.home ([206.248.178.151]) by smtp.pppoe.ca (Internet Mail Server v1.0) with ESMTP id JGN47615 for ; Sun, 02 Mar 2008 22:10:15 -0500 Received: by pastel.home (Postfix, from userid 20848) id 5096E8279; Sun, 2 Mar 2008 22:10:15 -0500 (EST) Resent-Message-ID: Resent-To: submit@debbugs.gnu.org Resent-From: Stefan Monnier Resent-Date: Sun, 02 Mar 2008 22:10:15 -0500 X-Original-To: monnier@iro.umontreal.ca Delivered-To: monnier@iro.umontreal.ca Received: from perlin.iro.umontreal.ca (perlin.iro.umontreal.ca [132.204.24.51]) by mercure.iro.umontreal.ca (Postfix) with ESMTP id A8F5E2CF86E for ; Sun, 2 Mar 2008 21:47:54 -0500 (EST) Received: from lists.gnu.org (lists.gnu.org [199.232.76.165]) by perlin.iro.umontreal.ca (Postfix) with ESMTP id 77A1C14821C for ; Sun, 2 Mar 2008 21:47:48 -0500 (EST) Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1JW0iS-0004tB-9u for monnier@iro.umontreal.ca; Sun, 02 Mar 2008 21:47:48 -0500 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1JVyvx-000481-Pt for bug-gnu-emacs@gnu.org; Sun, 02 Mar 2008 19:53:37 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1JVyvv-00047p-0r for bug-gnu-emacs@gnu.org; Sun, 02 Mar 2008 19:53:36 -0500 Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1JVyvu-00047m-SE for bug-gnu-emacs@gnu.org; Sun, 02 Mar 2008 19:53:34 -0500 Received: from mx1.redhat.com ([66.187.233.31]) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1JVyvu-0000aD-Ex for bug-gnu-emacs@gnu.org; Sun, 02 Mar 2008 19:53:34 -0500 Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id m230rS0O006677 for ; Sun, 2 Mar 2008 19:53:28 -0500 Received: from pobox.corp.redhat.com (pobox.corp.redhat.com [10.11.255.20]) by int-mx1.corp.redhat.com (8.13.1/8.13.1) with ESMTP id m230rRWM027123 for ; Sun, 2 Mar 2008 19:53:27 -0500 Received: from opsy.redhat.com (vpn-14-59.rdu.redhat.com [10.11.14.59]) by pobox.corp.redhat.com (8.13.1/8.13.1) with ESMTP id m230rRSs023113; Sun, 2 Mar 2008 19:53:27 -0500 Received: by opsy.redhat.com (Postfix, from userid 500) id ED13737811A; Sun, 2 Mar 2008 17:02:48 -0700 (MST) To: bug-gnu-emacs@gnu.org From: Tom Tromey X-Attribution: Tom Date: Sun, 02 Mar 2008 17:02:48 -0700 Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Scanned-By: MIMEDefang 2.58 on 172.16.52.254 X-detected-kernel: by monty-python.gnu.org: Linux 2.6 (newer, 3) X-Mailman-Approved-At: Sun, 02 Mar 2008 21:47:40 -0500 X-BeenThere: bug-gnu-emacs@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: bug-gnu-emacs-bounces+monnier=iro.umontreal.ca@gnu.org Errors-To: bug-gnu-emacs-bounces+monnier=iro.umontreal.ca@gnu.org X-DIRO-MailScanner-Information: Please contact the ISP for more information X-DIRO-MailScanner: Found to be clean X-DIRO-MailScanner-SpamCheck: n'est pas un polluriel, SpamAssassin (score=-1.94, requis 5, BAYES_00 -2.60, RECEIVED_FROM_NOUNK 0.66, SPF_HELO_PASS -0.00) X-DIRO-MailScanner-From: bug-gnu-emacs-bounces+monnier=iro.umontreal.ca@gnu.org I ran etags like this: etags ./eval.c -o $(pwd)//.retags.d/Q Note the double "/". The resulting tags file contains this line: ../../eval.c,567 But this is wrong, there should be only a single "..". I think relative_filename needs to handle the situation where multiple "/"s appear consecutively. The appended patch worked for me. Tom *** etags.c 07 Feb 2008 19:34:52 -0700 3.82 --- etags.c 02 Mar 2008 17:01:30 -0700 *************** *** 6792,6799 **** /* Build a sequence of "../" strings for the resulting relative file name. */ i = 0; while ((dp = etags_strchr (dp + 1, '/')) != NULL) ! i += 1; res = xnew (3*i + strlen (fp + 1) + 1, char); res[0] = '\0'; while (i-- > 0) --- 6792,6805 ---- /* Build a sequence of "../" strings for the resulting relative file name. */ i = 0; + while (*dp == '/') + ++dp; while ((dp = etags_strchr (dp + 1, '/')) != NULL) ! { ! i += 1; ! while (*dp == '/') ! ++dp; ! } res = xnew (3*i + strlen (fp + 1) + 1, char); res[0] = '\0'; while (i-- > 0) From unknown Mon Aug 18 14:23:55 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.420 (Entity 5.420) X-Loop: don@donarmstrong.com From: help-debbugs@gnu.org (Emacs bug Tracking System) To: Tom Tromey Subject: bug#32 closed by Stefan Monnier (Re: Bug in etags ".." code) Message-ID: References: X-Emacs-PR-Message: they-closed 32 X-Emacs-PR-Package: emacs X-Emacs-PR-Keywords: patch Reply-To: 32@debbugs.gnu.org Content-Type: multipart/mixed; boundary="----------=_1212092706-3440-1" This is a multi-part message in MIME format... ------------=_1212092706-3440-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" This is an automatic notification regarding your bug report which was filed against the emacs package: #32: Bug in etags ".." code It has been closed by Stefan Monnier . Their explanation is attached below along with your original report. If this explanation is unsatisfactory and you have not received a better one in a separate message then please contact Stefan Monnier by replying to this email. --=20 32: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D32 Emacs Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1212092706-3440-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit >From monnier@iro.umontreal.ca Thu May 29 13:18:52 2008 X-Spam-Checker-Version: SpamAssassin 3.2.3-bugs.debian.org_2005_01_02 (2007-08-08) on rzlab.ucr.edu X-Spam-Level: X-Spam-Status: No, score=0.7 required=4.0 tests=AWL,BAYES_00,FAKE_REPLY_C, HELO_LH_HOME,RDNS_DYNAMIC autolearn=no version=3.2.3-bugs.debian.org_2005_01_02 Received: (at 32-done) by emacsbugs.donarmstrong.com; 29 May 2008 20:18:52 +0000 Received: from ceviche.home (206-248-174-248.dsl.teksavvy.com [206.248.174.248]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id m4TKIn5q002177 for <32-done@emacsbugs.donarmstrong.com>; Thu, 29 May 2008 13:18:50 -0700 Received: by ceviche.home (Postfix, from userid 20848) id 90744B41E2; Thu, 29 May 2008 16:18:48 -0400 (EDT) From: Stefan Monnier To: 32-done@debbugs.gnu.org Subject: Re: Bug in etags ".." code Message-ID: Date: Thu, 29 May 2008 16:18:48 -0400 User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.0.60 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Thanks, installed, Stefan ------------=_1212092706-3440-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit >From monnier@iro.umontreal.ca Sun Mar 2 19:10:35 2008 X-Spam-Checker-Version: SpamAssassin 3.2.3-bugs.debian.org_2005_01_02 (2007-08-08) on rzlab.ucr.edu X-Spam-Level: * X-Spam-Status: No, score=1.3 required=4.0 tests=FOURLA,IMPRONONCABLE_1, MURPHY_DRUGS_REL8,MURPHY_WRONG_WORD2 autolearn=no version=3.2.3-bugs.debian.org_2005_01_02 Received: (at submit) by emacsbugs.donarmstrong.com; 3 Mar 2008 03:10:35 +0000 Received: from ironport2-out.pppoe.ca (ironport2-out.pppoe.ca [206.248.154.182]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id m233ATeo026201 for ; Sun, 2 Mar 2008 19:10:30 -0800 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: Ao8CABL7ykfO+LKX/2dsb2JhbACRd5lsgQA X-IronPort-AV: E=Sophos;i="4.25,435,1199682000"; d="scan'208";a="15471115" Received: from smtp.pppoe.ca ([65.39.196.238]) by ironport2-out.pppoe.ca with ESMTP; 02 Mar 2008 22:10:15 -0500 Received: from pastel.home ([206.248.178.151]) by smtp.pppoe.ca (Internet Mail Server v1.0) with ESMTP id JGN47615 for ; Sun, 02 Mar 2008 22:10:15 -0500 Received: by pastel.home (Postfix, from userid 20848) id 5096E8279; Sun, 2 Mar 2008 22:10:15 -0500 (EST) Resent-Message-ID: Resent-To: submit@debbugs.gnu.org Resent-From: Stefan Monnier Resent-Date: Sun, 02 Mar 2008 22:10:15 -0500 X-Original-To: monnier@iro.umontreal.ca Delivered-To: monnier@iro.umontreal.ca Received: from perlin.iro.umontreal.ca (perlin.iro.umontreal.ca [132.204.24.51]) by mercure.iro.umontreal.ca (Postfix) with ESMTP id A8F5E2CF86E for ; Sun, 2 Mar 2008 21:47:54 -0500 (EST) Received: from lists.gnu.org (lists.gnu.org [199.232.76.165]) by perlin.iro.umontreal.ca (Postfix) with ESMTP id 77A1C14821C for ; Sun, 2 Mar 2008 21:47:48 -0500 (EST) Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1JW0iS-0004tB-9u for monnier@iro.umontreal.ca; Sun, 02 Mar 2008 21:47:48 -0500 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1JVyvx-000481-Pt for bug-gnu-emacs@gnu.org; Sun, 02 Mar 2008 19:53:37 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1JVyvv-00047p-0r for bug-gnu-emacs@gnu.org; Sun, 02 Mar 2008 19:53:36 -0500 Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1JVyvu-00047m-SE for bug-gnu-emacs@gnu.org; Sun, 02 Mar 2008 19:53:34 -0500 Received: from mx1.redhat.com ([66.187.233.31]) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1JVyvu-0000aD-Ex for bug-gnu-emacs@gnu.org; Sun, 02 Mar 2008 19:53:34 -0500 Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id m230rS0O006677 for ; Sun, 2 Mar 2008 19:53:28 -0500 Received: from pobox.corp.redhat.com (pobox.corp.redhat.com [10.11.255.20]) by int-mx1.corp.redhat.com (8.13.1/8.13.1) with ESMTP id m230rRWM027123 for ; Sun, 2 Mar 2008 19:53:27 -0500 Received: from opsy.redhat.com (vpn-14-59.rdu.redhat.com [10.11.14.59]) by pobox.corp.redhat.com (8.13.1/8.13.1) with ESMTP id m230rRSs023113; Sun, 2 Mar 2008 19:53:27 -0500 Received: by opsy.redhat.com (Postfix, from userid 500) id ED13737811A; Sun, 2 Mar 2008 17:02:48 -0700 (MST) To: bug-gnu-emacs@gnu.org From: Tom Tromey X-Attribution: Tom Date: Sun, 02 Mar 2008 17:02:48 -0700 Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Scanned-By: MIMEDefang 2.58 on 172.16.52.254 X-detected-kernel: by monty-python.gnu.org: Linux 2.6 (newer, 3) X-Mailman-Approved-At: Sun, 02 Mar 2008 21:47:40 -0500 Subject: Bug in etags ".." code X-BeenThere: bug-gnu-emacs@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: Tom Tromey List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: bug-gnu-emacs-bounces+monnier=iro.umontreal.ca@gnu.org Errors-To: bug-gnu-emacs-bounces+monnier=iro.umontreal.ca@gnu.org X-DIRO-MailScanner-Information: Please contact the ISP for more information X-DIRO-MailScanner: Found to be clean X-DIRO-MailScanner-SpamCheck: n'est pas un polluriel, SpamAssassin (score=-1.94, requis 5, BAYES_00 -2.60, RECEIVED_FROM_NOUNK 0.66, SPF_HELO_PASS -0.00) X-DIRO-MailScanner-From: bug-gnu-emacs-bounces+monnier=iro.umontreal.ca@gnu.org I ran etags like this: etags ./eval.c -o $(pwd)//.retags.d/Q Note the double "/". The resulting tags file contains this line: ../../eval.c,567 But this is wrong, there should be only a single "..". I think relative_filename needs to handle the situation where multiple "/"s appear consecutively. The appended patch worked for me. Tom *** etags.c 07 Feb 2008 19:34:52 -0700 3.82 --- etags.c 02 Mar 2008 17:01:30 -0700 *************** *** 6792,6799 **** /* Build a sequence of "../" strings for the resulting relative file name. */ i = 0; while ((dp = etags_strchr (dp + 1, '/')) != NULL) ! i += 1; res = xnew (3*i + strlen (fp + 1) + 1, char); res[0] = '\0'; while (i-- > 0) --- 6792,6805 ---- /* Build a sequence of "../" strings for the resulting relative file name. */ i = 0; + while (*dp == '/') + ++dp; while ((dp = etags_strchr (dp + 1, '/')) != NULL) ! { ! i += 1; ! while (*dp == '/') ! ++dp; ! } res = xnew (3*i + strlen (fp + 1) + 1, char); res[0] = '\0'; while (i-- > 0) ------------=_1212092706-3440-1-- From debbugs-submit-bounces@debbugs.gnu.org Wed Jan 20 17:48:05 2010 Received: (at control) by debbugs.gnu.org; 20 Jan 2010 22:48:05 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1NXjLH-0007ov-Tu for submit@debbugs.gnu.org; Wed, 20 Jan 2010 17:48:04 -0500 Received: from fencepost.gnu.org ([140.186.70.10]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1NXjLG-0007oY-23 for control@debbugs.gnu.org; Wed, 20 Jan 2010 17:48:02 -0500 Received: from rgm by fencepost.gnu.org with local (Exim 4.69) (envelope-from ) id 1NXjLB-0002dr-0Q; Wed, 20 Jan 2010 17:47:57 -0500 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <19287.34844.948827.799811@gargle.gargle.HOWL> Date: Wed, 20 Jan 2010 17:47:56 -0500 From: Glenn Morris To: control Subject: control X-Attribution: GM X-Mailer: VM (www.wonderworks.com/vm), GNU Emacs (www.gnu.org/software/emacs) X-Hue: red X-Ran: :g+-gP'om@%-'rcS>-H`pc:qLaD.UQ,9Ar^xdH1(L/Y<>Irs(|<7S"xBr7l\@UgG3V List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -5.0 (-----) tags 701 patch reassign 718 emacs,hpux unarchive 32 unarchive 735 merge 32 735 From debbugs-submit-bounces@debbugs.gnu.org Wed Jan 20 17:51:19 2010 Received: (at control) by debbugs.gnu.org; 20 Jan 2010 22:51:19 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1NXjOQ-0007qm-Ld for submit@debbugs.gnu.org; Wed, 20 Jan 2010 17:51:19 -0500 Received: from fencepost.gnu.org ([140.186.70.10]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1NXjOO-0007qh-6T for control@debbugs.gnu.org; Wed, 20 Jan 2010 17:51:16 -0500 Received: from rgm by fencepost.gnu.org with local (Exim 4.69) (envelope-from ) id 1NXjOK-0002vg-3w; Wed, 20 Jan 2010 17:51:12 -0500 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <19287.35040.41750.967167@gargle.gargle.HOWL> Date: Wed, 20 Jan 2010 17:51:12 -0500 From: Glenn Morris To: control Subject: control X-Attribution: GM X-Mailer: VM (www.wonderworks.com/vm), GNU Emacs (www.gnu.org/software/emacs) X-Hue: magenta X-Ran: M1-x&}Jd{=7SZd%J!d]7jD>%/7Y+q,4H1AjRmj~F1SH~L1`se`n'+ia8m\IPfV:;aP//ID X-Debbugs-No-Ack: yes X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -5.0 (-----) noowner 32 merge 32 735