GNU bug report logs - #31999
[PATCH 1/7] gnu: Add volume-key.

Previous Next

Full log

Message #83 received at 31999 <at> debbugs.gnu.org (full text, mbox):

From: Marius Bakke <mbakke <at> fastmail.com>
To: Pierre Neidhardt <ambrevar <at> gmail.com>, 31999 <at> debbugs.gnu.org
Subject: Re: [bug#31999] [PATCH 4/7] gnu: lvm2: Add device-mapper-event
 support.
Date: Mon, 30 Jul 2018 00:33:34 +0200

[Message part 1 (text/plain, inline)]

Pierre Neidhardt <ambrevar <at> gmail.com> writes:

> * GNU/packages/linux.scm (lvm2)[configure-flags]: Build device-mapper-event.

This changes more than just configure-flags, can you update the commit
message accordingly?

[...]

> diff --git a/gnu/packages/linux.scm b/gnu/packages/linux.scm
> index 70615df93..e27c9b475 100644
> --- a/gnu/packages/linux.scm
> +++ b/gnu/packages/linux.scm
> @@ -2127,12 +2127,24 @@ time.")
>                                 "--enable-udev_sync"
>                                 "--enable-udev_rules"
>                                 "--enable-pkgconfig"
> +                               "--enable-cmdlib"
> +                               "--enable-dmeventd" ; Requires '--enable-cmdlib'.
>  
>                                 ;; Make sure programs such as 'dmsetup' can
>                                 ;; find libdevmapper.so.
>                                 (string-append "LDFLAGS=-Wl,-rpath="
>                                                (assoc-ref %outputs "out")
> -                                              "/lib"))
> +                                              "/lib,-rpath="
> +                                              (assoc-ref %outputs "out")
> +                                              "/lib/device-mapper")
> +                               ;; TODO: Patch make.tmpl.in to take LDFLAGS
> +                               ;; into account so that we don't need to also
> +                               ;; set CLDFLAGS.
> +                               (string-append "CLDFLAGS=-Wl,-rpath="
> +                                              (assoc-ref %outputs "out")
> +                                              "/lib,-rpath="
> +                                              (assoc-ref %outputs "out")
> +                                              "/lib/device-mapper"))

Did you try patching the Make template?

I suppose this is okay, though I'm curious about the LDFLAGS/CLDFLAGS
distinction.

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.