GNU bug report logs - #31999
[PATCH 1/7] gnu: Add volume-key.

Previous Next

Full log

Message #38 received at 31999 <at> debbugs.gnu.org (full text, mbox):

From: Marius Bakke <mbakke <at> fastmail.com>
To: Pierre Neidhardt <ambrevar <at> gmail.com>, 31999 <at> debbugs.gnu.org
Subject: Re: [bug#31999] [PATCH 6/7] gnu: Add libblockdev.
Date: Thu, 12 Jul 2018 22:24:11 +0200

[Message part 1 (text/plain, inline)]

Pierre Neidhardt <ambrevar <at> gmail.com> writes:

> * gnu/package/disk.scm (libblockdev): New variable.

[...]

> +(define-public libblockdev
> +  (package
> +    (name "libblockdev")
> +    (version "2.17")
> +    (source (origin
> +              (method git-fetch)
> +              (uri (git-reference
> +                    (url "https://github.com/rhinstaller/libblockdev")
> +                    (commit (string-append version "-1"))))
> +              (file-name (string-append name "-" version "-checkout"))
> +              (sha256
> +               (base32
> +                "14f52cj2qcnm8i2zb57qfpdk3kij2gb3xgqkbvidmf6sjicq84z2"))))


Note that this project provides uploaded releases, which are preferrable
to git checkouts, and won't suddenly change.  Could you change to that?

Otherwise LGTM, provided `guix lint` is happy :-)

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.