Subject: [bug#31999] [PATCH 1/7] gnu: Add volume-key.

From: Marius Bakke <[email-masked]>
Date: Thu, 12 Jul 2018 22:04:38 +0200

Hello!

I realize this patch set is incomplete, but will offer some feedback for
the next version :-)

Pierre Neidhardt <[email-masked]> writes:

> * gnu/package/disk.scm (volume-key): New variable.

[...]

> +    (arguments
> +     `(#:tests? #f ; Not sure how tests are supposed to pass, even when run manually.

Heh.  I tried adding the "bin" output of NSS to get "certutil", but then
it failed with:

Error creating passphrase-encrypted packet: GPGME: Invalid crypto engine                          

Don't know what's up with that.  Perhaps our GPGME package is broken?

> +       #:phases
> +       (modify-phases %standard-phases
> +         (add-before 'configure 'patch-python.h-path
> +           (lambda _
> +             (let ((python (assoc-ref %build-inputs "python")))

Rather:

           (lambda* (#:key inputs #:allow-other-keys)
             (let ((python (assoc-ref inputs "python")))

> +               (substitute* "Makefile.in"
> +                 (("/usr/include/python") (string-append python "/include/python")))
> +               #t))))))
> +    (home-page "https://pagure.io/volume_key")
> +    (synopsis "Manipulate storage volume encryption keys")
> +    (description
> +     "A library for manipulating storage volume encryption keys and storing
> +them separately from volumes to handle forgotten passphrases.")

Please use complete sentences, e.g. "This package provides a ...".

> +    (license license:gpl2+)))

This is actually GPL2 only, since the source headers specify it without
the "or later" clause.