From debbugs-submit-bounces@debbugs.gnu.org Thu Jun 28 15:10:42 2018 Received: (at submit) by debbugs.gnu.org; 28 Jun 2018 19:10:42 +0000 Received: from localhost ([127.0.0.1]:38857 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fYcJW-0001yE-CG for submit@debbugs.gnu.org; Thu, 28 Jun 2018 15:10:42 -0400 Received: from eggs.gnu.org ([208.118.235.92]:34992) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fYcJU-0001y0-SX for submit@debbugs.gnu.org; Thu, 28 Jun 2018 15:10:41 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fYcJO-0005Y9-Hh for submit@debbugs.gnu.org; Thu, 28 Jun 2018 15:10:35 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,FREEMAIL_FROM, T_DKIM_INVALID autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:34566) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1fYcJO-0005Xe-Cf for submit@debbugs.gnu.org; Thu, 28 Jun 2018 15:10:34 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:54143) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fYcJN-00042z-8I for bug-gnu-emacs@gnu.org; Thu, 28 Jun 2018 15:10:34 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fYcJM-0005TK-9S for bug-gnu-emacs@gnu.org; Thu, 28 Jun 2018 15:10:33 -0400 Received: from mail-ot0-x22d.google.com ([2607:f8b0:4003:c0f::22d]:34585) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fYcJM-0005S6-3O for bug-gnu-emacs@gnu.org; Thu, 28 Jun 2018 15:10:32 -0400 Received: by mail-ot0-x22d.google.com with SMTP id i17-v6so7351510otl.1 for ; Thu, 28 Jun 2018 12:10:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:from:date:message-id:subject:to; bh=LZ3H40ZoRJx96aXXl4wV3s3SHTbiRFFGmGPjZxSFCL8=; b=dQoNTlcTP0KYtZntY2lM8VUxvVp2d4YC8eFqghUW0uNIBLHkUAB9OxodFuvCS+Ea/6 pIWR6wNc+Nfa9sGcOIzfWlCglJXB+a9sGdmrRXUJ7x8y7skb7uWJSD3ysd4s7x+6hxiI kHZLxL3qQSm6d4DwSJ1QxOKiVsRyJn2bp8Yq/OJObSh7IVDYeEGLhdgWQGl6MMB1Uvy5 Q2oK6RS2z9yEKkr3cWLEQi7utDRqVbgpyWwfYO+tZbfy1TWtbkP5mZ5+4av2xP3hqIWU Llf6YIis2uE6R0rWDmWvTj6E03gp8W6jX2fFxFjRSA5pWU0Oji9ysfmhjsAHhpv+xqii Z9TQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=LZ3H40ZoRJx96aXXl4wV3s3SHTbiRFFGmGPjZxSFCL8=; b=PUj+nT63BaxiBqwU6Wg5HqeVJLTGoClcxKll/REe+8W/MRM3ZwQImAvA7olrhW02O5 0iK051XnIdumlzGNBPFGJHGCwgerhQ42rqH8KXLZZ0l4AJ6++mx1+DQ8JNKcPrdi7uHp OYV15nwi0dHIuv2D17suqQCEE5ADmRSegK8SevcWSoGgGu15QePs52rMDAFKhihy1XX6 tY/o5JWsZjqz1s/HsU4WaXHHDIBCJk7Zd5dFktX6ifFsKeUsJF8sVF9dz9XEeRDUVTY4 baJ+0+Zv9MEPymk2O/qBnQV2WJiIRgdstn0k98zvsxLxeWbZx8w5lEB8WpAzoXeUZiSR csOw== X-Gm-Message-State: APt69E3qTTk6r2uav0RN36hSmlFmZTJUZC0N5/sI5oe5PlThTxXb2KCq o8UC3DkMIh/cMaq9eso4JCrtj3UZw3NVb2Z6KVg= X-Google-Smtp-Source: AAOMgpcNceVBK+2oi3qjAnMQen7it+EVirn0OfFKMzr8j8JtUnaIjwgE7yIt9BfM0LeL28cyoQCSxSM6RtnXD12Jbo8= X-Received: by 2002:a9d:20e3:: with SMTP id x90-v6mr7138291ota.338.1530213031277; Thu, 28 Jun 2018 12:10:31 -0700 (PDT) MIME-Version: 1.0 Received: by 2002:a4a:3b8d:0:0:0:0:0 with HTTP; Thu, 28 Jun 2018 12:10:30 -0700 (PDT) From: Noam Postavsky Date: Thu, 28 Jun 2018 15:10:30 -0400 Message-ID: Subject: 27.0.50; [w32] while dumping: assertion failed: specpdl_ptr->kind == SPECPDL_UNWIND_PTR && specpdl_ptr->unwind_ptr.func == xfree To: bug-gnu-emacs@gnu.org Content-Type: multipart/mixed; boundary="000000000000291d58056fb87c67" X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.0 (----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) --000000000000291d58056fb87c67 Content-Type: text/plain; charset="UTF-8" X-Debbugs-CC: Paul Eggert gdb --args ./temacs --batch --load loadup bootstrap (gdb) p specpdl_ptr->kind $1 = SPECPDL_UNWIND_ARRAY (gdb) p specpdl_ptr->unwind_ptr.func $2 = (void (*)(void *)) 0x53898 (gdb) p specpdl_ptr->unwind_array.func $3 = (void (*)(Lisp_Object)) 0x53898 I guess it's related to the #31750 changes. The problem doesn't seem especially platform-specific, but I've haven't seen this on my GNU/Linux box. The attached patch fixes it, though I'm not sure if it's entirely correct. --000000000000291d58056fb87c67 Content-Type: application/octet-stream; name="unwind-array.diff" Content-Disposition: attachment; filename="unwind-array.diff" Content-Transfer-Encoding: base64 X-Attachment-Id: f_jiyxbfbv0 LS0tIGkvc3JjL2xpc3AuaA0KKysrIHcvc3JjL2xpc3AuaA0KQEAgLTQ1NDMsNyArNDU0Myw4IEBA IHNhZmVfZnJlZSAocHRyZGlmZl90IHNhX2NvdW50KQ0KICAgd2hpbGUgKHNwZWNwZGxfcHRyICE9 IHNwZWNwZGwgKyBzYV9jb3VudCkNCiAgICAgew0KICAgICAgIHNwZWNwZGxfcHRyLS07DQotICAg ICAgZWFzc2VydCAoKHNwZWNwZGxfcHRyLT5raW5kID09IFNQRUNQRExfVU5XSU5EX1BUUiB8fCBz cGVjcGRsX3B0ci0+a2luZCA9PSBTUEVDUERMX1VOV0lORF9BUlJBWSkNCisgICAgICBlYXNzZXJ0 ICgoc3BlY3BkbF9wdHItPmtpbmQgPT0gU1BFQ1BETF9VTldJTkRfUFRSDQorICAgICAgICAgICAg ICAgIHx8IHNwZWNwZGxfcHRyLT5raW5kID09IFNQRUNQRExfVU5XSU5EX0FSUkFZKQ0KIAkgICAg ICAgJiYgc3BlY3BkbF9wdHItPnVud2luZF9wdHIuZnVuYyA9PSB4ZnJlZSk7DQogICAgICAgeGZy ZWUgKHNwZWNwZGxfcHRyLT51bndpbmRfcHRyLmFyZyk7DQogICAgIH0NCmRpZmYgLS1naXQgaS9z cmMvdzMyZm5zLmMgdy9zcmMvdzMyZm5zLmMNCmluZGV4IDNiZDMyMDkuLjU5ZWRiMzEgMTAwNjQ0 DQotLS0gaS9zcmMvdzMyZm5zLmMNCisrKyB3L3NyYy93MzJmbnMuYw0KQEAgLTQ1NTEsNyArNDU1 MSw3IEBAIHczMl93bmRfcHJvYyAoSFdORCBod25kLCBVSU5UIG1zZywgV1BBUkFNIHdQYXJhbSwg TFBBUkFNIGxQYXJhbSkNCiAJIGRpYWxvZyBib3hlcywgc3VjaCBhcyB0aGUgZmlsZSBzZWxlY3Rp b24gZGlhbG9nIG9yIGZvbnQNCiAJIHNlbGVjdGlvbiBkaWFsb2cuICBTbyBzb21ldGhpbmcgZWxz ZSBpcyBuZWVkZWQgdG8gZml4IHRoZQ0KIAkgZm9ybWVyIHdpdGhvdXQgYnJlYWtpbmcgdGhlIGxh dHRlci4gIFNlZSBidWcjMTE3MzIuICAqLw0KLSAgICAgIGJyZWFrOw0KKyAgICAgIGdvdG8gZGZs dDsNCiANCiAgICAgY2FzZSBXTV9JTUVfRU5EQ09NUE9TSVRJT046DQogICAgICAgaWdub3JlX2lt ZV9jaGFyID0gMDsNCg0KDQo= --000000000000291d58056fb87c67-- From debbugs-submit-bounces@debbugs.gnu.org Thu Jun 28 15:18:26 2018 Received: (at 31996) by debbugs.gnu.org; 28 Jun 2018 19:18:26 +0000 Received: from localhost ([127.0.0.1]:38867 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fYcR0-0002BU-E0 for submit@debbugs.gnu.org; Thu, 28 Jun 2018 15:18:26 -0400 Received: from eggs.gnu.org ([208.118.235.92]:37474) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fYcQz-0002BG-9V for 31996@debbugs.gnu.org; Thu, 28 Jun 2018 15:18:25 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fYcQt-0000JP-CD for 31996@debbugs.gnu.org; Thu, 28 Jun 2018 15:18:20 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:44853) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fYcQn-0000A9-R4; Thu, 28 Jun 2018 15:18:13 -0400 Received: from [176.228.60.248] (port=2663 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1fYcQn-0001hi-3x; Thu, 28 Jun 2018 15:18:13 -0400 Date: Thu, 28 Jun 2018 22:18:19 +0300 Message-Id: <83vaa2oh38.fsf@gnu.org> From: Eli Zaretskii To: Noam Postavsky In-reply-to: (message from Noam Postavsky on Thu, 28 Jun 2018 15:10:30 -0400) Subject: Re: bug#31996: 27.0.50; [w32] while dumping: assertion failed: specpdl_ptr->kind == SPECPDL_UNWIND_PTR && specpdl_ptr->unwind_ptr.func == xfree References: X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 31996 Cc: eggert@cs.ucla.edu, 31996@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -6.0 (------) > From: Noam Postavsky > Date: Thu, 28 Jun 2018 15:10:30 -0400 > Cc: paul eggert > > The attached patch fixes it, though I'm not sure if it's > entirely correct. The second part seems unrelated, yes? From debbugs-submit-bounces@debbugs.gnu.org Thu Jun 28 15:20:52 2018 Received: (at 31996) by debbugs.gnu.org; 28 Jun 2018 19:20:52 +0000 Received: from localhost ([127.0.0.1]:38871 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fYcTL-0002FQ-SI for submit@debbugs.gnu.org; Thu, 28 Jun 2018 15:20:52 -0400 Received: from mail-ot0-f171.google.com ([74.125.82.171]:45821) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fYcTJ-0002F9-Jo for 31996@debbugs.gnu.org; Thu, 28 Jun 2018 15:20:49 -0400 Received: by mail-ot0-f171.google.com with SMTP id k3-v6so7359304otl.12 for <31996@debbugs.gnu.org>; Thu, 28 Jun 2018 12:20:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=D+gERvPZtdX23SCSbz0X2A0OCfQm4EsXHrYOGe5vMyg=; b=ZA6AlRjDv9vF4n5nFnvelXVEnDn4f3CXlwOT1TOi7ASzQvNag165J4C24ncmJGRlKr nnHlN1MPbDDTHUDQ1ZxG39PbpQpd2yI0KxF5BvlVZZvLwaPzBejPszRViFTBqpYeZKsB 7klgVhn7gFfxFAkohnkzZp9U/Xdp9cjGklbbb6dHTfENzO2EOmkAAKV7PFN5vhlwwxxT l/3hR0PrQlHrH3wlax2iJs+B0GKJvoSg9/b6UDu1UzT8YX0HH3ooBjV/O91pAWR8dKQk oJev7aGEnBDpwESZF7XJuvd3PU2b0J3F+RAbVduHX/yPefRIqgEUmk60sNveH1FbZcDS cGRQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=D+gERvPZtdX23SCSbz0X2A0OCfQm4EsXHrYOGe5vMyg=; b=e12yHopM4z+D8llursqjaiOeQRjuOe5tYgYgCgqgD13cgYDUdsydwTOwsoLBNHeacJ XJUqkLZfhzxcEXMojp0LlMdv3katcvHz6X9zQ8Qe4PaBzcPfyyzKGQ3SWhSU0FhmAaZy m9GS4uICmD9ZKY+bxkDXO4aQSHgWtf3KX+OVBiI0uHJpzPpHnd2BwjhV7FrdcqouHq+t 2vkSTf8sKfwm0Fuy5HMz2beuqaOfuSncIEMjBDtX3HyhXNdG9KmMnz57dvjgghS4vu53 /BU19U3HGkRQ+EawVIcyxz+7Vv2vAkoXj1JHCFEgVOJVP9XF0TI2/FmZgMPjzgBagkuN 5P4w== X-Gm-Message-State: APt69E0LGmAOoAI8DyYZwfcLOKXf5XlsjaKfgNHu/B4uBCKcmgFncZmL mRZGAtNYMtXzC92YZ9SOi9M68PNmYAuMUlLBgXk= X-Google-Smtp-Source: AAOMgpcC5HLYljHOfhn2MgOuDJjVZblDnRCaZxRW7Woko0IcKbx9WQ4blwPMsafmm7AVVmSXniA6MuB3H2suz1bxSno= X-Received: by 2002:a9d:50a2:: with SMTP id b34-v6mr6212554oth.239.1530213643923; Thu, 28 Jun 2018 12:20:43 -0700 (PDT) MIME-Version: 1.0 Received: by 2002:a4a:3b8d:0:0:0:0:0 with HTTP; Thu, 28 Jun 2018 12:20:43 -0700 (PDT) In-Reply-To: <83vaa2oh38.fsf@gnu.org> References: <83vaa2oh38.fsf@gnu.org> From: Noam Postavsky Date: Thu, 28 Jun 2018 15:20:43 -0400 Message-ID: Subject: Re: bug#31996: 27.0.50; [w32] while dumping: assertion failed: specpdl_ptr->kind == SPECPDL_UNWIND_PTR && specpdl_ptr->unwind_ptr.func == xfree To: Eli Zaretskii Content-Type: multipart/mixed; boundary="000000000000ad566b056fb8a0b8" X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 31996 Cc: Paul Eggert , 31996@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --000000000000ad566b056fb8a0b8 Content-Type: text/plain; charset="UTF-8" On 28 June 2018 at 15:18, Eli Zaretskii wrote: >> From: Noam Postavsky >> Date: Thu, 28 Jun 2018 15:10:30 -0400 >> Cc: paul eggert >> >> The attached patch fixes it, though I'm not sure if it's >> entirely correct. > > The second part seems unrelated, yes? Oops, that patch is mixed up, here's what I meant instead. --000000000000ad566b056fb8a0b8 Content-Type: application/octet-stream; name="unwind-array.diff" Content-Disposition: attachment; filename="unwind-array.diff" Content-Transfer-Encoding: base64 X-Attachment-Id: f_jiyxonm90 LS0tIGMvc3JjL2V2YWwuYw0KKysrIGkvc3JjL2V2YWwuYw0KQEAgLTM0MTEsNiArMzQxMSw3IEBA IHZvaWQNCiByZWNvcmRfdW53aW5kX3Byb3RlY3RfYXJyYXkgKExpc3BfT2JqZWN0ICphcnJheSwg cHRyZGlmZl90IG5lbHRzKQ0KIHsNCiAgIHNwZWNwZGxfcHRyLT51bndpbmRfYXJyYXkua2luZCA9 IFNQRUNQRExfVU5XSU5EX0FSUkFZOw0KKyAgc3BlY3BkbF9wdHItPnVud2luZF9hcnJheS5mdW5j ID0geGZyZWU7DQogICBzcGVjcGRsX3B0ci0+dW53aW5kX2FycmF5LmFycmF5ID0gYXJyYXk7DQog ICBzcGVjcGRsX3B0ci0+dW53aW5kX2FycmF5Lm5lbHRzID0gbmVsdHM7DQogICBncm93X3NwZWNw ZGwgKCk7DQpkaWZmIC0tZ2l0IGMvc3JjL2xpc3AuaCBpL3NyYy9saXNwLmgNCmluZGV4IGI1NDRk ODEuLjhjYjU0M2QgMTAwNjQ0DQotLS0gYy9zcmMvbGlzcC5oDQorKysgaS9zcmMvbGlzcC5oDQpA QCAtMzA1OCw3ICszMDU4LDcgQEAgdW5pb24gc3BlY2JpbmRpbmcNCiAgICAgfSB1bndpbmQ7DQog ICAgIHN0cnVjdCB7DQogICAgICAgRU5VTV9CRiAoc3BlY2JpbmRfdGFnKSBraW5kIDogQ0hBUl9C SVQ7DQotICAgICAgdm9pZCAoKmZ1bmMpIChMaXNwX09iamVjdCk7DQorICAgICAgdm9pZCAoKmZ1 bmMpICh2b2lkICopOw0KICAgICAgIExpc3BfT2JqZWN0ICphcnJheTsNCiAgICAgICBwdHJkaWZm X3QgbmVsdHM7DQogICAgIH0gdW53aW5kX2FycmF5Ow0KQEAgLTQ1NDMsNyArNDU0Myw4IEBAIHNh ZmVfZnJlZSAocHRyZGlmZl90IHNhX2NvdW50KQ0KICAgd2hpbGUgKHNwZWNwZGxfcHRyICE9IHNw ZWNwZGwgKyBzYV9jb3VudCkNCiAgICAgew0KICAgICAgIHNwZWNwZGxfcHRyLS07DQotICAgICAg ZWFzc2VydCAoc3BlY3BkbF9wdHItPmtpbmQgPT0gU1BFQ1BETF9VTldJTkRfUFRSDQorICAgICAg ZWFzc2VydCAoKHNwZWNwZGxfcHRyLT5raW5kID09IFNQRUNQRExfVU5XSU5EX1BUUg0KKyAgICAg ICAgICAgICAgICB8fCBzcGVjcGRsX3B0ci0+a2luZCA9PSBTUEVDUERMX1VOV0lORF9BUlJBWSkN CiAJICAgICAgICYmIHNwZWNwZGxfcHRyLT51bndpbmRfcHRyLmZ1bmMgPT0geGZyZWUpOw0KICAg ICAgIHhmcmVlIChzcGVjcGRsX3B0ci0+dW53aW5kX3B0ci5hcmcpOw0KICAgICB9DQoNCg0K --000000000000ad566b056fb8a0b8-- From debbugs-submit-bounces@debbugs.gnu.org Thu Jun 28 16:29:50 2018 Received: (at submit) by debbugs.gnu.org; 28 Jun 2018 20:29:50 +0000 Received: from localhost ([127.0.0.1]:38919 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fYdY6-0003sj-6f for submit@debbugs.gnu.org; Thu, 28 Jun 2018 16:29:50 -0400 Received: from eggs.gnu.org ([208.118.235.92]:53094) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fYdY4-0003sS-Eg for submit@debbugs.gnu.org; Thu, 28 Jun 2018 16:29:48 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fYdXy-0000ym-HP for submit@debbugs.gnu.org; Thu, 28 Jun 2018 16:29:43 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,FREEMAIL_FROM autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:45117) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1fYdXy-0000ya-Dx for submit@debbugs.gnu.org; Thu, 28 Jun 2018 16:29:42 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:44060) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fYdXx-0002Zb-8Y for bug-gnu-emacs@gnu.org; Thu, 28 Jun 2018 16:29:42 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fYdXu-0000re-5Z for bug-gnu-emacs@gnu.org; Thu, 28 Jun 2018 16:29:41 -0400 Received: from [195.159.176.226] (port=38109 helo=blaine.gmane.org) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fYdXt-0000nU-TK for bug-gnu-emacs@gnu.org; Thu, 28 Jun 2018 16:29:38 -0400 Received: from list by blaine.gmane.org with local (Exim 4.84_2) (envelope-from ) id 1fYdVf-0007Cu-4f for bug-gnu-emacs@gnu.org; Thu, 28 Jun 2018 22:27:19 +0200 X-Injected-Via-Gmane: http://gmane.org/ To: bug-gnu-emacs@gnu.org From: Andy Moreton Subject: Re: bug#31996: 27.0.50; [w32] while dumping: assertion failed: specpdl_ptr->kind == SPECPDL_UNWIND_PTR && specpdl_ptr->unwind_ptr.func == xfree Date: Thu, 28 Jun 2018 21:29:21 +0100 Lines: 18 Message-ID: <86zhzeac4e.fsf@gmail.com> References: <83vaa2oh38.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain X-Complaints-To: usenet@blaine.gmane.org User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1.50 (windows-nt) Cancel-Lock: sha1:qXJYxnSCKw/TTJqygQ3UzM+z4J0= X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.5 (----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.5 (-----) On Thu 28 Jun 2018, Noam Postavsky wrote: > On 28 June 2018 at 15:18, Eli Zaretskii wrote: >>> From: Noam Postavsky >>> Date: Thu, 28 Jun 2018 15:10:30 -0400 >>> Cc: paul eggert >>> >>> The attached patch fixes it, though I'm not sure if it's >>> entirely correct. >> >> The second part seems unrelated, yes? > > Oops, that patch is mixed up, here's what I meant instead. Applying the fixed patch bootstraps cleanly for me with 64bit mingw64 on Windows (MSYS2). AndyM From debbugs-submit-bounces@debbugs.gnu.org Thu Jun 28 16:56:01 2018 Received: (at 31996-done) by debbugs.gnu.org; 28 Jun 2018 20:56:01 +0000 Received: from localhost ([127.0.0.1]:38928 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fYdxR-0004oI-Ah for submit@debbugs.gnu.org; Thu, 28 Jun 2018 16:56:01 -0400 Received: from zimbra.cs.ucla.edu ([131.179.128.68]:44984) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fYdxO-0004o4-MB for 31996-done@debbugs.gnu.org; Thu, 28 Jun 2018 16:55:59 -0400 Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id B4B711607BA; Thu, 28 Jun 2018 13:55:52 -0700 (PDT) Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id 0fUVyW-ri6BG; Thu, 28 Jun 2018 13:55:51 -0700 (PDT) Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id E40A7160780; Thu, 28 Jun 2018 13:55:51 -0700 (PDT) X-Virus-Scanned: amavisd-new at zimbra.cs.ucla.edu Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id YnHK_e7kZFWL; Thu, 28 Jun 2018 13:55:51 -0700 (PDT) Received: from [192.168.1.9] (unknown [47.154.30.119]) by zimbra.cs.ucla.edu (Postfix) with ESMTPSA id 8EADA1607BA; Thu, 28 Jun 2018 13:55:51 -0700 (PDT) To: Noam Postavsky From: Paul Eggert Subject: Re: bug#31996: 27.0.50; [w32] while dumping: assertion failed: specpdl_ptr->kind == SPECPDL_UNWIND_PTR && specpdl_ptr->unwind_ptr.func == xfree Openpgp: preference=signencrypt Autocrypt: addr=eggert@cs.ucla.edu; prefer-encrypt=mutual; keydata= xsFNBEyAcmQBEADAAyH2xoTu7ppG5D3a8FMZEon74dCvc4+q1XA2J2tBy2pwaTqfhpxxdGA9 Jj50UJ3PD4bSUEgN8tLZ0san47l5XTAFLi2456ciSl5m8sKaHlGdt9XmAAtmXqeZVIYX/UFS 96fDzf4xhEmm/y7LbYEPQdUdxu47xA5KhTYp5bltF3WYDz1Ygd7gx07Auwp7iw7eNvnoDTAl KAl8KYDZzbDNCQGEbpY3efZIvPdeI+FWQN4W+kghy+P6au6PrIIhYraeua7XDdb2LS1en3Ss mE3QjqfRqI/A2ue8JMwsvXe/WK38Ezs6x74iTaqI3AFH6ilAhDqpMnd/msSESNFt76DiO1ZK QMr9amVPknjfPmJISqdhgB1DlEdw34sROf6V8mZw0xfqT6PKE46LcFefzs0kbg4GORf8vjG2 Sf1tk5eU8MBiyN/bZ03bKNjNYMpODDQQwuP84kYLkX2wBxxMAhBxwbDVZudzxDZJ1C2VXujC OJVxq2kljBM9ETYuUGqd75AW2LXrLw6+MuIsHFAYAgRr7+KcwDgBAfwhPBYX34nSSiHlmLC+ KaHLeCLF5ZI2vKm3HEeCTtlOg7xZEONgwzL+fdKo+D6SoC8RRxJKs8a3sVfI4t6CnrQzvJbB n6gxdgCu5i29J1QCYrCYvql2UyFPAK+do99/1jOXT4m2836j1wARAQABzSBQYXVsIEVnZ2Vy dCA8ZWdnZXJ0QGNzLnVjbGEuZWR1PsLBfgQTAQIAKAUCTIByZAIbAwUJEswDAAYLCQgHAwIG FQgCCQoLBBYCAwECHgECF4AACgkQ7ZfpDmKqfjRRGw/+Ij03dhYfYl/gXVRiuzV1gGrbHk+t nfrI/C7fAeoFzQ5tVgVinShaPkZo0HTPf18x6IDEdAiO8Mqo1yp0CtHmzGMCJ50o4Grgfjlr 6g/+vtEOKbhleszN2XpJvpwM2QgGvn/laTLUu8PH9aRWTs7qJJZKKKAb4sxYc92FehPu6FOD 0dDiyhlDAq4lOV2mdBpzQbiojoZzQLMQwjpgCTK2572eK9EOEQySUThXrSIz6ASenp4NYTFH s9tuJQvXk9gZDdPSl3bp+47dGxlxEWLpBIM7zIONw4ks4azgT8nvDZxA5IZHtvqBlJLBObYY 0Le61Wp0y3TlBDh2qdK8eYL426W4scEMSuig5gb8OAtQiBW6k2sGUxxeiv8ovWu8YAZgKJfu oWI+uRnMEddruY8JsoM54KaKvZikkKs2bg1ndtLVzHpJ6qFZC7QVjeHUh6/BmgvdjWPZYFTt N+KA9CWX3GQKKgN3uu988yznD7LnB98T4EUH1HA/GnfBqMV1gpzTvPc4qVQinCmIkEFp83zl +G5fCjJJ3W7ivzCnYo4KhKLpFUm97okTKR2LW3xZzEW4cLSWO387MTK3CzDOx5qe6s4a91Zu ZM/j/TQdTLDaqNn83kA4Hq48UHXYxcIh+Nd8k/3w6lFuoK0wrOFiywjLx+0ur5jmmbecBGHc 1xdhAFHOwU0ETIByZAEQAKaF678T9wyH4wjTrV1Pz3cDEoSnV/0ZUrOT37p1dcGyj/IXq1x6 70HRVahAmk0sZpYc25PF9D5GPYHFWlNjuPU96rDndXB3hedmBRhLdC4bAXjI4DV+bmdVe+q/ IMnlZRaVlm9EiMCVAR6w13sReu7qXkW9r3RwY2AzXskp/tAe4BRKr1Zmbvi2nbnQ6epEC42r Rbx0B1EhjbIQZ5JHGk24iPT7LdBgnNmos5wYjzwNlkMQD5T0Ydzhk7J+UxwA5m46mOhRDC2r FV/A0gm5TLy8DXjv/Esc4gYnYai6SQqnUEVh5LuV8YCJBnijs+Tiw71x1icmn6xGI45EugJO gec+rLypYgpVp4x0HI5T88qBRYCkxH3Kg8Qo+EWNA9A4LRQ9DX8njona0gf0s03tocK8kBN6 6UoqqPtHBnc4eMgBymCflK12eKfd2YYxnyg9cZazWA5VslvTxpm76hbg5oiAEH/Vg/8MxHyA nPhfrgwyPrmJEcVBafdspJnYQxBYNco2LFPIhlOvWh8r4at+s+M3Lb26oUTczlgdW1Sf3SDA 77BMRnF0FQyE+7AzV79MBN4ykiqaezQxtaF1Fy/tvkhffSo8u+dwG0EgJh+te38gTcISVr0G IPplLz6YhjrbHrPRF1CN5UuL9DBGjxuN35RLNVEfta6RUFlR6NctTjvrABEBAAHCwWUEGAEC AA8FAkyAcmQCGwwFCRLMAwAACgkQ7ZfpDmKqfjSrHA/+KzAKvTxRhA9MWNLxIyJ7S5uJ16gs T3oCjZrBKGEhKMOGX4O0GA6VOEryO7QRCCYah3oxSG38IAnNeiwJXgU9Bzkk85UGbPEd7HGF /VSeHCQwWou6jqUDTSDvn9YhNTdG0KXPM74aC+xr2Zow1O2mhXihgWKD0Dw+0LYPnUOsQ0KO FxHXXYHmRrS1OZPU59BLvc+TRhIhafSHKLwbXK+6ckkxBx6h8z5ccpG0Qs4bFhdFYnFrEieD LoGmnE2YLhdV6swJ9VNCS6pLiEohT3fm7aXm15tZOIyzMZhHRSAPblXxQ0ZSWjq8oRrcYNFx c4W1URpAkBCOYJoXvQfD5L3lqAl8TCqDUzYxhH/tJhbDdHrqHH767jaDaTB1+Talp/2AMKwc XNOdiklGxbmHVG6YGl6g8Lrbsu9NZEI4yLlHzuikthJWgz+3vZhVGyNlt+HNIoF6CjDL2omu 5cEq4RDHM44QqPk6l7O0pUvN1mT4B+S1b08RKpqm/ff015E37HNV/piIvJlxGAYz8PSfuGCB 1thMYqlmgdhd9/BabGFbGGYHA6U4/T5zqU+f6xHy1SsAQZ1MSKlLwekBIT+4/cLRGqCHjnV0 q5H/T6a7t5mPkbzSrOLSo4puj+IToNjYyYIDBWzhlA19avOa+rvUjmHtD3sFN7cXWtkGoi8b uNcby4U= Organization: UCLA Computer Science Department Message-ID: Date: Thu, 28 Jun 2018 13:55:50 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0 MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="------------4D18CF706225B6A373820E83" Content-Language: en-US X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 31996-done Cc: 31996-done@debbugs.gnu.org, Andy Moreton X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) This is a multi-part message in MIME format. --------------4D18CF706225B6A373820E83 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Thanks for reporting that. I didn't observe the problem on Fedora 28. Anyway, I installed the attached patch, which should fix it. --------------4D18CF706225B6A373820E83 Content-Type: text/x-patch; name="0001-Fix-recently-introduced-SAFE_FREE-bug.patch" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="0001-Fix-recently-introduced-SAFE_FREE-bug.patch" >From ddc4371a89e5500e0203bed4b0ad453925b1c74f Mon Sep 17 00:00:00 2001 From: Paul Eggert Date: Thu, 28 Jun 2018 13:49:48 -0700 Subject: [PATCH] Fix recently-introduced SAFE_FREE bug Problem reported by Andy Moreton (Bug#31996). * src/lisp.h (union specbinding.unwind_array): Remove unused member func. Move array after nelts, as this is likely to generate more efficient code in safe_free, which can call xfree with the same value either way. (safe_free): Also handle SPECPDL_UNWIND_AWAY. --- src/lisp.h | 16 +++++++++++----- 1 file changed, 11 insertions(+), 5 deletions(-) diff --git a/src/lisp.h b/src/lisp.h index b544d81..cf7b8c0 100644 --- a/src/lisp.h +++ b/src/lisp.h @@ -3058,9 +3058,8 @@ union specbinding } unwind; struct { ENUM_BF (specbind_tag) kind : CHAR_BIT; - void (*func) (Lisp_Object); - Lisp_Object *array; ptrdiff_t nelts; + Lisp_Object *array; } unwind_array; struct { ENUM_BF (specbind_tag) kind : CHAR_BIT; @@ -4543,9 +4542,16 @@ safe_free (ptrdiff_t sa_count) while (specpdl_ptr != specpdl + sa_count) { specpdl_ptr--; - eassert (specpdl_ptr->kind == SPECPDL_UNWIND_PTR - && specpdl_ptr->unwind_ptr.func == xfree); - xfree (specpdl_ptr->unwind_ptr.arg); + if (specpdl_ptr->kind == SPECPDL_UNWIND_PTR) + { + eassert (specpdl_ptr->unwind_ptr.func == xfree); + xfree (specpdl_ptr->unwind_ptr.arg); + } + else + { + eassert (specpdl_ptr->kind == SPECPDL_UNWIND_ARRAY); + xfree (specpdl_ptr->unwind_array.array); + } } } -- 2.7.4 --------------4D18CF706225B6A373820E83-- From debbugs-submit-bounces@debbugs.gnu.org Thu Jun 28 17:05:48 2018 Received: (at 31996) by debbugs.gnu.org; 28 Jun 2018 21:05:48 +0000 Received: from localhost ([127.0.0.1]:38936 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fYe6s-0005Cu-AD for submit@debbugs.gnu.org; Thu, 28 Jun 2018 17:05:48 -0400 Received: from mail-oi0-f44.google.com ([209.85.218.44]:44877) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fYe6p-0005CU-Os for 31996@debbugs.gnu.org; Thu, 28 Jun 2018 17:05:44 -0400 Received: by mail-oi0-f44.google.com with SMTP id s198-v6so2645769oih.11 for <31996@debbugs.gnu.org>; Thu, 28 Jun 2018 14:05:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=YnA/D/G41+8Eya8aMSmlHMuOcz12THcKNZ1eSCmSMYc=; b=iYjtZSGOybn/VZ3iM0qTWc6U3PIvRyER30ZwkzqlPSH/v8TlC1f749Na5gf8UzO7Cv hyng1Ct1wzHtyXClSrUmTqSQN6Vo/3QrHYMWKKymneHMAXHJaVb6MuVa/Mx74DAZHuAe RfiRWmJ/6zgqugXwE+yjrNALVBSOokiAlXzeGgQhU7Vrhvl8hlHjvU/NPr4dfZH6QjMs Ekwvs/GDZb+IwkuwE4cAnbLvadmfGQWDJuHqGCrMgdEpnOkGrpL7jsi/fwrmhS9ywJ10 I/Jr2Iww/RsXEtnlyjMqd0YNqHaVnAw3mSRcsmNkGbXLq3fIlZybIalQ8jbjTwGCGa+p atZQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=YnA/D/G41+8Eya8aMSmlHMuOcz12THcKNZ1eSCmSMYc=; b=Px++W8QMrqNs/VBvS8bs+0fvs0gfEb7o1+pPbTiKL0tsFJ5WqtybBlXgbkcG13eMBs aRb40IZP9mJOOpd2TM1G/qnf/tsuvqxF+KVz4yq8/amqsdgaRgI8BGx4SYO6ScR7XVWs 5SA4wrL9E/0DS9sAxbamsV/XgB1tmHEA/I+kCWe2Qgpg/8QtKtHhSNdzosjQ39AS2td1 A9K/aFM0ltTqQ0UDWFOA51FDEYGqH9xW2FSHeVlAL60fiz7xnuQtqmnulXMZErc2c9YF EVIPiltWywyXuJeMx4o2Hs3rtd3ldOLcp92d4VxHinw1ajxuOg7Et8g4h49YqusS3dYD 7z/g== X-Gm-Message-State: APt69E3lwSkfCEjpQUjTWi82g2tTSlegMG14kvq7d5vLyc+OkHoUWhPi 2T4iixdJ0PmtIxPYDOVX6aubpvBsQDOkDT+S0nA= X-Google-Smtp-Source: AAOMgpeC0yu5FKkSJBdPNhMTg9ypKI7/1uFKDlqyz2DpRWmeHNgPycRijlIGRQWBIWtE1zwig2i+F6oZ6xCz3YZfpr8= X-Received: by 2002:aca:5c46:: with SMTP id q67-v6mr6372446oib.17.1530219938265; Thu, 28 Jun 2018 14:05:38 -0700 (PDT) MIME-Version: 1.0 Received: by 2002:a4a:3b8d:0:0:0:0:0 with HTTP; Thu, 28 Jun 2018 14:05:37 -0700 (PDT) In-Reply-To: References: From: Noam Postavsky Date: Thu, 28 Jun 2018 17:05:37 -0400 Message-ID: Subject: Re: bug#31996: 27.0.50; [w32] while dumping: assertion failed: specpdl_ptr->kind == SPECPDL_UNWIND_PTR && specpdl_ptr->unwind_ptr.func == xfree To: Paul Eggert Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 31996 Cc: Andy Moreton , 31996@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On 28 June 2018 at 16:55, Paul Eggert wrote: > Thanks for reporting that. I didn't observe the problem on Fedora 28. > Anyway, I installed the attached patch, which should fix it. Thanks, works for me. > Move array after nelts, as this is likely to generate more efficient > code in safe_free, which can call xfree with the same value either > way. Maybe that kind of trick deserves a code comment? From debbugs-submit-bounces@debbugs.gnu.org Thu Jun 28 18:57:56 2018 Received: (at 31996) by debbugs.gnu.org; 28 Jun 2018 22:57:56 +0000 Received: from localhost ([127.0.0.1]:39005 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fYfrQ-00007K-4d for submit@debbugs.gnu.org; Thu, 28 Jun 2018 18:57:56 -0400 Received: from zimbra.cs.ucla.edu ([131.179.128.68]:59252) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fYfrO-00006v-3R for 31996@debbugs.gnu.org; Thu, 28 Jun 2018 18:57:54 -0400 Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 2A1DB160780; Thu, 28 Jun 2018 15:57:48 -0700 (PDT) Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id O-JvYE1z2CJO; Thu, 28 Jun 2018 15:57:47 -0700 (PDT) Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 66CAC1607BA; Thu, 28 Jun 2018 15:57:47 -0700 (PDT) X-Virus-Scanned: amavisd-new at zimbra.cs.ucla.edu Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id Qk2OaqmvE1JK; Thu, 28 Jun 2018 15:57:47 -0700 (PDT) Received: from [192.168.1.9] (unknown [47.154.30.119]) by zimbra.cs.ucla.edu (Postfix) with ESMTPSA id 22C1E160780; Thu, 28 Jun 2018 15:57:47 -0700 (PDT) Subject: Re: bug#31996: 27.0.50; [w32] while dumping: assertion failed: specpdl_ptr->kind == SPECPDL_UNWIND_PTR && specpdl_ptr->unwind_ptr.func == xfree To: Noam Postavsky References: From: Paul Eggert Openpgp: preference=signencrypt Autocrypt: addr=eggert@cs.ucla.edu; prefer-encrypt=mutual; keydata= xsFNBEyAcmQBEADAAyH2xoTu7ppG5D3a8FMZEon74dCvc4+q1XA2J2tBy2pwaTqfhpxxdGA9 Jj50UJ3PD4bSUEgN8tLZ0san47l5XTAFLi2456ciSl5m8sKaHlGdt9XmAAtmXqeZVIYX/UFS 96fDzf4xhEmm/y7LbYEPQdUdxu47xA5KhTYp5bltF3WYDz1Ygd7gx07Auwp7iw7eNvnoDTAl KAl8KYDZzbDNCQGEbpY3efZIvPdeI+FWQN4W+kghy+P6au6PrIIhYraeua7XDdb2LS1en3Ss mE3QjqfRqI/A2ue8JMwsvXe/WK38Ezs6x74iTaqI3AFH6ilAhDqpMnd/msSESNFt76DiO1ZK QMr9amVPknjfPmJISqdhgB1DlEdw34sROf6V8mZw0xfqT6PKE46LcFefzs0kbg4GORf8vjG2 Sf1tk5eU8MBiyN/bZ03bKNjNYMpODDQQwuP84kYLkX2wBxxMAhBxwbDVZudzxDZJ1C2VXujC OJVxq2kljBM9ETYuUGqd75AW2LXrLw6+MuIsHFAYAgRr7+KcwDgBAfwhPBYX34nSSiHlmLC+ KaHLeCLF5ZI2vKm3HEeCTtlOg7xZEONgwzL+fdKo+D6SoC8RRxJKs8a3sVfI4t6CnrQzvJbB n6gxdgCu5i29J1QCYrCYvql2UyFPAK+do99/1jOXT4m2836j1wARAQABzSBQYXVsIEVnZ2Vy dCA8ZWdnZXJ0QGNzLnVjbGEuZWR1PsLBfgQTAQIAKAUCTIByZAIbAwUJEswDAAYLCQgHAwIG FQgCCQoLBBYCAwECHgECF4AACgkQ7ZfpDmKqfjRRGw/+Ij03dhYfYl/gXVRiuzV1gGrbHk+t nfrI/C7fAeoFzQ5tVgVinShaPkZo0HTPf18x6IDEdAiO8Mqo1yp0CtHmzGMCJ50o4Grgfjlr 6g/+vtEOKbhleszN2XpJvpwM2QgGvn/laTLUu8PH9aRWTs7qJJZKKKAb4sxYc92FehPu6FOD 0dDiyhlDAq4lOV2mdBpzQbiojoZzQLMQwjpgCTK2572eK9EOEQySUThXrSIz6ASenp4NYTFH s9tuJQvXk9gZDdPSl3bp+47dGxlxEWLpBIM7zIONw4ks4azgT8nvDZxA5IZHtvqBlJLBObYY 0Le61Wp0y3TlBDh2qdK8eYL426W4scEMSuig5gb8OAtQiBW6k2sGUxxeiv8ovWu8YAZgKJfu oWI+uRnMEddruY8JsoM54KaKvZikkKs2bg1ndtLVzHpJ6qFZC7QVjeHUh6/BmgvdjWPZYFTt N+KA9CWX3GQKKgN3uu988yznD7LnB98T4EUH1HA/GnfBqMV1gpzTvPc4qVQinCmIkEFp83zl +G5fCjJJ3W7ivzCnYo4KhKLpFUm97okTKR2LW3xZzEW4cLSWO387MTK3CzDOx5qe6s4a91Zu ZM/j/TQdTLDaqNn83kA4Hq48UHXYxcIh+Nd8k/3w6lFuoK0wrOFiywjLx+0ur5jmmbecBGHc 1xdhAFHOwU0ETIByZAEQAKaF678T9wyH4wjTrV1Pz3cDEoSnV/0ZUrOT37p1dcGyj/IXq1x6 70HRVahAmk0sZpYc25PF9D5GPYHFWlNjuPU96rDndXB3hedmBRhLdC4bAXjI4DV+bmdVe+q/ IMnlZRaVlm9EiMCVAR6w13sReu7qXkW9r3RwY2AzXskp/tAe4BRKr1Zmbvi2nbnQ6epEC42r Rbx0B1EhjbIQZ5JHGk24iPT7LdBgnNmos5wYjzwNlkMQD5T0Ydzhk7J+UxwA5m46mOhRDC2r FV/A0gm5TLy8DXjv/Esc4gYnYai6SQqnUEVh5LuV8YCJBnijs+Tiw71x1icmn6xGI45EugJO gec+rLypYgpVp4x0HI5T88qBRYCkxH3Kg8Qo+EWNA9A4LRQ9DX8njona0gf0s03tocK8kBN6 6UoqqPtHBnc4eMgBymCflK12eKfd2YYxnyg9cZazWA5VslvTxpm76hbg5oiAEH/Vg/8MxHyA nPhfrgwyPrmJEcVBafdspJnYQxBYNco2LFPIhlOvWh8r4at+s+M3Lb26oUTczlgdW1Sf3SDA 77BMRnF0FQyE+7AzV79MBN4ykiqaezQxtaF1Fy/tvkhffSo8u+dwG0EgJh+te38gTcISVr0G IPplLz6YhjrbHrPRF1CN5UuL9DBGjxuN35RLNVEfta6RUFlR6NctTjvrABEBAAHCwWUEGAEC AA8FAkyAcmQCGwwFCRLMAwAACgkQ7ZfpDmKqfjSrHA/+KzAKvTxRhA9MWNLxIyJ7S5uJ16gs T3oCjZrBKGEhKMOGX4O0GA6VOEryO7QRCCYah3oxSG38IAnNeiwJXgU9Bzkk85UGbPEd7HGF /VSeHCQwWou6jqUDTSDvn9YhNTdG0KXPM74aC+xr2Zow1O2mhXihgWKD0Dw+0LYPnUOsQ0KO FxHXXYHmRrS1OZPU59BLvc+TRhIhafSHKLwbXK+6ckkxBx6h8z5ccpG0Qs4bFhdFYnFrEieD LoGmnE2YLhdV6swJ9VNCS6pLiEohT3fm7aXm15tZOIyzMZhHRSAPblXxQ0ZSWjq8oRrcYNFx c4W1URpAkBCOYJoXvQfD5L3lqAl8TCqDUzYxhH/tJhbDdHrqHH767jaDaTB1+Talp/2AMKwc XNOdiklGxbmHVG6YGl6g8Lrbsu9NZEI4yLlHzuikthJWgz+3vZhVGyNlt+HNIoF6CjDL2omu 5cEq4RDHM44QqPk6l7O0pUvN1mT4B+S1b08RKpqm/ff015E37HNV/piIvJlxGAYz8PSfuGCB 1thMYqlmgdhd9/BabGFbGGYHA6U4/T5zqU+f6xHy1SsAQZ1MSKlLwekBIT+4/cLRGqCHjnV0 q5H/T6a7t5mPkbzSrOLSo4puj+IToNjYyYIDBWzhlA19avOa+rvUjmHtD3sFN7cXWtkGoi8b uNcby4U= Organization: UCLA Computer Science Department Message-ID: <07595dcd-46c9-53b4-fd5d-e47a2e6e8e8d@cs.ucla.edu> Date: Thu, 28 Jun 2018 15:57:46 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 31996 Cc: 31996@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Noam Postavsky wrote: > Maybe that kind of trick deserves a code comment? I thought about doing that, but it seemed like the maintenance cost of having the comment there indefinitely wasn't worth the minor performance benefit (a benefit that applies only to typical platforms and when optimization is enabled, facts that'd also probably need to be in the comment). For what it's worth, this stuff is now documented in the bug report.... From debbugs-submit-bounces@debbugs.gnu.org Fri Jun 29 02:13:50 2018 Received: (at 31996) by debbugs.gnu.org; 29 Jun 2018 06:13:50 +0000 Received: from localhost ([127.0.0.1]:39174 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fYmfG-00043R-Hf for submit@debbugs.gnu.org; Fri, 29 Jun 2018 02:13:50 -0400 Received: from eggs.gnu.org ([208.118.235.92]:45495) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fYmfE-00043D-9g for 31996@debbugs.gnu.org; Fri, 29 Jun 2018 02:13:48 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fYmf5-00025h-Ok for 31996@debbugs.gnu.org; Fri, 29 Jun 2018 02:13:42 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-0.0 required=5.0 tests=BAYES_20 autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:51841) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fYmf5-00025S-Ka; Fri, 29 Jun 2018 02:13:39 -0400 Received: from [176.228.60.248] (port=2934 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1fYmf4-00031P-QU; Fri, 29 Jun 2018 02:13:39 -0400 Date: Fri, 29 Jun 2018 09:13:46 +0300 Message-Id: <83sh56nmqt.fsf@gnu.org> From: Eli Zaretskii To: Paul Eggert In-reply-to: <07595dcd-46c9-53b4-fd5d-e47a2e6e8e8d@cs.ucla.edu> (message from Paul Eggert on Thu, 28 Jun 2018 15:57:46 -0700) Subject: Re: bug#31996: 27.0.50; [w32] while dumping: assertion failed: specpdl_ptr->kind == SPECPDL_UNWIND_PTR && specpdl_ptr->unwind_ptr.func == xfree References: <07595dcd-46c9-53b4-fd5d-e47a2e6e8e8d@cs.ucla.edu> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 31996 Cc: npostavs@gmail.com, 31996@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -6.0 (------) > From: Paul Eggert > Date: Thu, 28 Jun 2018 15:57:46 -0700 > Cc: 31996@debbugs.gnu.org > > Noam Postavsky wrote: > > Maybe that kind of trick deserves a code comment? > > I thought about doing that, but it seemed like the maintenance cost of having > the comment there indefinitely wasn't worth the minor performance benefit (a > benefit that applies only to typical platforms and when optimization is enabled, > facts that'd also probably need to be in the comment). For what it's worth, this > stuff is now documented in the bug report.... But maybe a comment explaining why the order might matter in general could be of more value, and require less maintenance. From debbugs-submit-bounces@debbugs.gnu.org Fri Jun 29 03:30:44 2018 Received: (at 31996) by debbugs.gnu.org; 29 Jun 2018 07:30:44 +0000 Received: from localhost ([127.0.0.1]:39189 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fYnrg-0005uC-0J for submit@debbugs.gnu.org; Fri, 29 Jun 2018 03:30:44 -0400 Received: from zimbra.cs.ucla.edu ([131.179.128.68]:41120) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fYnrd-0005tx-L0 for 31996@debbugs.gnu.org; Fri, 29 Jun 2018 03:30:42 -0400 Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 66EF41606CA; Fri, 29 Jun 2018 00:30:35 -0700 (PDT) Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id r7JK8P939-EX; Fri, 29 Jun 2018 00:30:34 -0700 (PDT) Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 955211607BA; Fri, 29 Jun 2018 00:30:34 -0700 (PDT) X-Virus-Scanned: amavisd-new at zimbra.cs.ucla.edu Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id Z5XgScCpjqpi; Fri, 29 Jun 2018 00:30:34 -0700 (PDT) Received: from [192.168.1.9] (unknown [47.154.30.119]) by zimbra.cs.ucla.edu (Postfix) with ESMTPSA id 4606C1606CA; Fri, 29 Jun 2018 00:30:34 -0700 (PDT) Subject: Re: bug#31996: 27.0.50; [w32] while dumping: assertion failed: specpdl_ptr->kind == SPECPDL_UNWIND_PTR && specpdl_ptr->unwind_ptr.func == xfree To: Eli Zaretskii References: <07595dcd-46c9-53b4-fd5d-e47a2e6e8e8d@cs.ucla.edu> <83sh56nmqt.fsf@gnu.org> From: Paul Eggert Openpgp: preference=signencrypt Autocrypt: addr=eggert@cs.ucla.edu; prefer-encrypt=mutual; keydata= xsFNBEyAcmQBEADAAyH2xoTu7ppG5D3a8FMZEon74dCvc4+q1XA2J2tBy2pwaTqfhpxxdGA9 Jj50UJ3PD4bSUEgN8tLZ0san47l5XTAFLi2456ciSl5m8sKaHlGdt9XmAAtmXqeZVIYX/UFS 96fDzf4xhEmm/y7LbYEPQdUdxu47xA5KhTYp5bltF3WYDz1Ygd7gx07Auwp7iw7eNvnoDTAl KAl8KYDZzbDNCQGEbpY3efZIvPdeI+FWQN4W+kghy+P6au6PrIIhYraeua7XDdb2LS1en3Ss mE3QjqfRqI/A2ue8JMwsvXe/WK38Ezs6x74iTaqI3AFH6ilAhDqpMnd/msSESNFt76DiO1ZK QMr9amVPknjfPmJISqdhgB1DlEdw34sROf6V8mZw0xfqT6PKE46LcFefzs0kbg4GORf8vjG2 Sf1tk5eU8MBiyN/bZ03bKNjNYMpODDQQwuP84kYLkX2wBxxMAhBxwbDVZudzxDZJ1C2VXujC OJVxq2kljBM9ETYuUGqd75AW2LXrLw6+MuIsHFAYAgRr7+KcwDgBAfwhPBYX34nSSiHlmLC+ KaHLeCLF5ZI2vKm3HEeCTtlOg7xZEONgwzL+fdKo+D6SoC8RRxJKs8a3sVfI4t6CnrQzvJbB n6gxdgCu5i29J1QCYrCYvql2UyFPAK+do99/1jOXT4m2836j1wARAQABzSBQYXVsIEVnZ2Vy dCA8ZWdnZXJ0QGNzLnVjbGEuZWR1PsLBfgQTAQIAKAUCTIByZAIbAwUJEswDAAYLCQgHAwIG FQgCCQoLBBYCAwECHgECF4AACgkQ7ZfpDmKqfjRRGw/+Ij03dhYfYl/gXVRiuzV1gGrbHk+t nfrI/C7fAeoFzQ5tVgVinShaPkZo0HTPf18x6IDEdAiO8Mqo1yp0CtHmzGMCJ50o4Grgfjlr 6g/+vtEOKbhleszN2XpJvpwM2QgGvn/laTLUu8PH9aRWTs7qJJZKKKAb4sxYc92FehPu6FOD 0dDiyhlDAq4lOV2mdBpzQbiojoZzQLMQwjpgCTK2572eK9EOEQySUThXrSIz6ASenp4NYTFH s9tuJQvXk9gZDdPSl3bp+47dGxlxEWLpBIM7zIONw4ks4azgT8nvDZxA5IZHtvqBlJLBObYY 0Le61Wp0y3TlBDh2qdK8eYL426W4scEMSuig5gb8OAtQiBW6k2sGUxxeiv8ovWu8YAZgKJfu oWI+uRnMEddruY8JsoM54KaKvZikkKs2bg1ndtLVzHpJ6qFZC7QVjeHUh6/BmgvdjWPZYFTt N+KA9CWX3GQKKgN3uu988yznD7LnB98T4EUH1HA/GnfBqMV1gpzTvPc4qVQinCmIkEFp83zl +G5fCjJJ3W7ivzCnYo4KhKLpFUm97okTKR2LW3xZzEW4cLSWO387MTK3CzDOx5qe6s4a91Zu ZM/j/TQdTLDaqNn83kA4Hq48UHXYxcIh+Nd8k/3w6lFuoK0wrOFiywjLx+0ur5jmmbecBGHc 1xdhAFHOwU0ETIByZAEQAKaF678T9wyH4wjTrV1Pz3cDEoSnV/0ZUrOT37p1dcGyj/IXq1x6 70HRVahAmk0sZpYc25PF9D5GPYHFWlNjuPU96rDndXB3hedmBRhLdC4bAXjI4DV+bmdVe+q/ IMnlZRaVlm9EiMCVAR6w13sReu7qXkW9r3RwY2AzXskp/tAe4BRKr1Zmbvi2nbnQ6epEC42r Rbx0B1EhjbIQZ5JHGk24iPT7LdBgnNmos5wYjzwNlkMQD5T0Ydzhk7J+UxwA5m46mOhRDC2r FV/A0gm5TLy8DXjv/Esc4gYnYai6SQqnUEVh5LuV8YCJBnijs+Tiw71x1icmn6xGI45EugJO gec+rLypYgpVp4x0HI5T88qBRYCkxH3Kg8Qo+EWNA9A4LRQ9DX8njona0gf0s03tocK8kBN6 6UoqqPtHBnc4eMgBymCflK12eKfd2YYxnyg9cZazWA5VslvTxpm76hbg5oiAEH/Vg/8MxHyA nPhfrgwyPrmJEcVBafdspJnYQxBYNco2LFPIhlOvWh8r4at+s+M3Lb26oUTczlgdW1Sf3SDA 77BMRnF0FQyE+7AzV79MBN4ykiqaezQxtaF1Fy/tvkhffSo8u+dwG0EgJh+te38gTcISVr0G IPplLz6YhjrbHrPRF1CN5UuL9DBGjxuN35RLNVEfta6RUFlR6NctTjvrABEBAAHCwWUEGAEC AA8FAkyAcmQCGwwFCRLMAwAACgkQ7ZfpDmKqfjSrHA/+KzAKvTxRhA9MWNLxIyJ7S5uJ16gs T3oCjZrBKGEhKMOGX4O0GA6VOEryO7QRCCYah3oxSG38IAnNeiwJXgU9Bzkk85UGbPEd7HGF /VSeHCQwWou6jqUDTSDvn9YhNTdG0KXPM74aC+xr2Zow1O2mhXihgWKD0Dw+0LYPnUOsQ0KO FxHXXYHmRrS1OZPU59BLvc+TRhIhafSHKLwbXK+6ckkxBx6h8z5ccpG0Qs4bFhdFYnFrEieD LoGmnE2YLhdV6swJ9VNCS6pLiEohT3fm7aXm15tZOIyzMZhHRSAPblXxQ0ZSWjq8oRrcYNFx c4W1URpAkBCOYJoXvQfD5L3lqAl8TCqDUzYxhH/tJhbDdHrqHH767jaDaTB1+Talp/2AMKwc XNOdiklGxbmHVG6YGl6g8Lrbsu9NZEI4yLlHzuikthJWgz+3vZhVGyNlt+HNIoF6CjDL2omu 5cEq4RDHM44QqPk6l7O0pUvN1mT4B+S1b08RKpqm/ff015E37HNV/piIvJlxGAYz8PSfuGCB 1thMYqlmgdhd9/BabGFbGGYHA6U4/T5zqU+f6xHy1SsAQZ1MSKlLwekBIT+4/cLRGqCHjnV0 q5H/T6a7t5mPkbzSrOLSo4puj+IToNjYyYIDBWzhlA19avOa+rvUjmHtD3sFN7cXWtkGoi8b uNcby4U= Organization: UCLA Computer Science Department Message-ID: Date: Fri, 29 Jun 2018 00:30:33 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0 MIME-Version: 1.0 In-Reply-To: <83sh56nmqt.fsf@gnu.org> Content-Type: multipart/mixed; boundary="------------FDEE245B87EE113D357AEEDB" Content-Language: en-US X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 31996 Cc: npostavs@gmail.com, 31996@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) This is a multi-part message in MIME format. --------------FDEE245B87EE113D357AEEDB Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Eli Zaretskii wrote: > maybe a comment explaining why the order might matter in general > could be of more value, and require less maintenance. I gave that a shot by installing the attached. --------------FDEE245B87EE113D357AEEDB Content-Type: text/x-patch; name="0001-src-lisp.h-Add-comment-Bug-31996-25.patch" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="0001-src-lisp.h-Add-comment-Bug-31996-25.patch" >From 9ffc9ec7a70c2e971b616146cb49b084981b74a9 Mon Sep 17 00:00:00 2001 From: Paul Eggert Date: Fri, 29 Jun 2018 00:29:13 -0700 Subject: [PATCH] * src/lisp.h: Add comment (Bug#31996#25). --- src/lisp.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/lisp.h b/src/lisp.h index cf7b8c0..6203a74 100644 --- a/src/lisp.h +++ b/src/lisp.h @@ -3050,6 +3050,8 @@ enum specbind_tag { union specbinding { + /* Aligning similar members consistently might help efficiency slightly + (Bug#31996#25). */ ENUM_BF (specbind_tag) kind : CHAR_BIT; struct { ENUM_BF (specbind_tag) kind : CHAR_BIT; -- 2.7.4 --------------FDEE245B87EE113D357AEEDB-- From debbugs-submit-bounces@debbugs.gnu.org Fri Jun 29 04:52:09 2018 Received: (at 31996) by debbugs.gnu.org; 29 Jun 2018 08:52:09 +0000 Received: from localhost ([127.0.0.1]:39234 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fYp8T-0001fY-DY for submit@debbugs.gnu.org; Fri, 29 Jun 2018 04:52:09 -0400 Received: from eggs.gnu.org ([208.118.235.92]:45027) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fYp8R-0001fJ-Hz for 31996@debbugs.gnu.org; Fri, 29 Jun 2018 04:52:07 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fYp8J-0000n7-8s for 31996@debbugs.gnu.org; Fri, 29 Jun 2018 04:52:02 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:53500) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fYp8J-0000mx-3x; Fri, 29 Jun 2018 04:51:59 -0400 Received: from [176.228.60.248] (port=4944 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1fYp8I-0002mz-Ie; Fri, 29 Jun 2018 04:51:58 -0400 Date: Fri, 29 Jun 2018 11:52:06 +0300 Message-Id: <83lgaynfex.fsf@gnu.org> From: Eli Zaretskii To: Paul Eggert In-reply-to: (message from Paul Eggert on Fri, 29 Jun 2018 00:30:33 -0700) Subject: Re: bug#31996: 27.0.50; [w32] while dumping: assertion failed: specpdl_ptr->kind == SPECPDL_UNWIND_PTR && specpdl_ptr->unwind_ptr.func == xfree References: <07595dcd-46c9-53b4-fd5d-e47a2e6e8e8d@cs.ucla.edu> <83sh56nmqt.fsf@gnu.org> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 31996 Cc: npostavs@gmail.com, 31996@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -6.0 (------) > Cc: npostavs@gmail.com, 31996@debbugs.gnu.org > From: Paul Eggert > Date: Fri, 29 Jun 2018 00:30:33 -0700 > > Eli Zaretskii wrote: > > maybe a comment explaining why the order might matter in general > > could be of more value, and require less maintenance. > > I gave that a shot by installing the attached. Thanks. From debbugs-submit-bounces@debbugs.gnu.org Fri Jun 29 08:31:02 2018 Received: (at 31996) by debbugs.gnu.org; 29 Jun 2018 12:31:02 +0000 Received: from localhost ([127.0.0.1]:39333 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fYsYH-0000MZ-SC for submit@debbugs.gnu.org; Fri, 29 Jun 2018 08:31:02 -0400 Received: from mail-it0-f46.google.com ([209.85.214.46]:38577) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fYsYE-0000M4-Nh for 31996@debbugs.gnu.org; Fri, 29 Jun 2018 08:31:00 -0400 Received: by mail-it0-f46.google.com with SMTP id v83-v6so2615601itc.3 for <31996@debbugs.gnu.org>; Fri, 29 Jun 2018 05:30:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-transfer-encoding; bh=CvdAKx3eKc9tW5P61KKacL6biGzUAyt60frqFeop8Sg=; b=oH2h5Oi6xjPbhDud7FG07XHswgI1+lIK/YF7a8ARfUTxViyU6jDQBQ0QhhyAvi2m1Y mQYt7lVCEreNorexe+Uvo5UGBu5IrVHeG9CeD+ZYFvM7d9/AwsNAGe0lBT7mNk2qqx4S n0tw+GJw8g7rNKqmbgZfoHXaQBJRElXRo9u+hXSkMqV61nPKDDCYm3pC/FNp8iUipFeG kO0KEf/ajBIcGdZ7QkFJ9XMLcjkqMir3sNl+rlijdXMRJmmNhY0G5QSyeMT1IAtm3cjf /09uZ708EeENZvVIPLLgVJ39OaimANimqsb+5/D6ETK7OkbCXZ+3xd7tPS84PCodzjzx 0VSA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=CvdAKx3eKc9tW5P61KKacL6biGzUAyt60frqFeop8Sg=; b=CXH9wJMB6AICOJyGzHPztGmLWxcflWcD0BkZgxsL41gtAw9vRpECV1+HD4AOiBMi7y Fn39Vl3xfyzU6fjwvG/DLOr1vZoec7hhuETYUVenVOfFDPq/YTxRlFAARLTUY4OmeZnh /a5HgjDNgFw/dsviC9vPRK+DNO7s+5GG+VG9uJ6m8jG8bQSxMwm0mD8Vj71uNh92lvYY bFa2I4JSChxHv0KlXi/3+UpK67KVCbidbNOCk6QEnQ5C/0WHEc3aeWQV8gNBoHFKwnZo ld3VnpYd6tkN8zRm5FhbMGDPGl3WDGjlEBldiQ/q3b7M7HB7NNUIJsQwAzFRte8APQ6k SqbA== X-Gm-Message-State: APt69E2MqVTstcBhGAEr5JkGEIeTjrpikfQJPt8auum7Jdj0NBi809oU aSdW57q630mBj8Vk/DUmQvkEjQ== X-Google-Smtp-Source: AAOMgpeK+9+tL7RCkisJ7aKabtBJak05ItBvfSdDYv4fx3NWtKS5gSQQF0en90khlLjnIpaYoW9YZg== X-Received: by 2002:a24:c054:: with SMTP id u81-v6mr1499907itf.94.1530275452921; Fri, 29 Jun 2018 05:30:52 -0700 (PDT) Received: from zebian (cbl-45-2-119-34.yyz.frontiernetworks.ca. [45.2.119.34]) by smtp.googlemail.com with ESMTPSA id d130-v6sm4487263iog.84.2018.06.29.05.30.52 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 29 Jun 2018 05:30:52 -0700 (PDT) From: Noam Postavsky To: Paul Eggert Subject: Re: bug#31996: 27.0.50; [w32] while dumping: assertion failed: specpdl_ptr->kind == SPECPDL_UNWIND_PTR && specpdl_ptr->unwind_ptr.func == xfree References: <07595dcd-46c9-53b4-fd5d-e47a2e6e8e8d@cs.ucla.edu> Date: Fri, 29 Jun 2018 08:30:51 -0400 In-Reply-To: <07595dcd-46c9-53b4-fd5d-e47a2e6e8e8d@cs.ucla.edu> (Paul Eggert's message of "Thu, 28 Jun 2018 15:57:46 -0700") Message-ID: <878t6xojus.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 31996 Cc: 31996@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Paul Eggert writes: > I thought about doing that, but it seemed like the maintenance cost of > having the comment Oh, this talk about comment maintenance reminds me, there's this comment in lisp.h just above the enum specbind_tag: /* Elisp uses several stacks: - the C stack. - the bytecode stack: used internally by the bytecode interpreter. Allocated from the C stack. - The specpdl stack:[...] You removed the bytecode stack in [1: a815e5f195], right? [1: a815e5f195]: 2016-12-23 21:46:53 -0800 Remove interpreter=E2=80=99s byte stack https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=3Da815e5f19581344a= f5e143636039064a7fbe83ed From debbugs-submit-bounces@debbugs.gnu.org Fri Jun 29 14:18:52 2018 Received: (at 31996) by debbugs.gnu.org; 29 Jun 2018 18:18:52 +0000 Received: from localhost ([127.0.0.1]:40067 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fYxyu-00008x-4f for submit@debbugs.gnu.org; Fri, 29 Jun 2018 14:18:52 -0400 Received: from zimbra.cs.ucla.edu ([131.179.128.68]:54284) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fYxyq-00008e-E6 for 31996@debbugs.gnu.org; Fri, 29 Jun 2018 14:18:49 -0400 Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id A5A17160812; Fri, 29 Jun 2018 11:18:42 -0700 (PDT) Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id 6sgZMKV-kdvX; Fri, 29 Jun 2018 11:18:41 -0700 (PDT) Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id C820D160819; Fri, 29 Jun 2018 11:18:41 -0700 (PDT) X-Virus-Scanned: amavisd-new at zimbra.cs.ucla.edu Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id PH5uOqcMaqAr; Fri, 29 Jun 2018 11:18:41 -0700 (PDT) Received: from Penguin.CS.UCLA.EDU (Penguin.CS.UCLA.EDU [131.179.64.200]) by zimbra.cs.ucla.edu (Postfix) with ESMTPSA id AE1FC160812; Fri, 29 Jun 2018 11:18:41 -0700 (PDT) Subject: Re: bug#31996: 27.0.50; [w32] while dumping: assertion failed: specpdl_ptr->kind == SPECPDL_UNWIND_PTR && specpdl_ptr->unwind_ptr.func == xfree To: Noam Postavsky References: <07595dcd-46c9-53b4-fd5d-e47a2e6e8e8d@cs.ucla.edu> <878t6xojus.fsf@gmail.com> From: Paul Eggert Openpgp: preference=signencrypt Autocrypt: addr=eggert@cs.ucla.edu; prefer-encrypt=mutual; keydata= xsFNBEyAcmQBEADAAyH2xoTu7ppG5D3a8FMZEon74dCvc4+q1XA2J2tBy2pwaTqfhpxxdGA9 Jj50UJ3PD4bSUEgN8tLZ0san47l5XTAFLi2456ciSl5m8sKaHlGdt9XmAAtmXqeZVIYX/UFS 96fDzf4xhEmm/y7LbYEPQdUdxu47xA5KhTYp5bltF3WYDz1Ygd7gx07Auwp7iw7eNvnoDTAl KAl8KYDZzbDNCQGEbpY3efZIvPdeI+FWQN4W+kghy+P6au6PrIIhYraeua7XDdb2LS1en3Ss mE3QjqfRqI/A2ue8JMwsvXe/WK38Ezs6x74iTaqI3AFH6ilAhDqpMnd/msSESNFt76DiO1ZK QMr9amVPknjfPmJISqdhgB1DlEdw34sROf6V8mZw0xfqT6PKE46LcFefzs0kbg4GORf8vjG2 Sf1tk5eU8MBiyN/bZ03bKNjNYMpODDQQwuP84kYLkX2wBxxMAhBxwbDVZudzxDZJ1C2VXujC OJVxq2kljBM9ETYuUGqd75AW2LXrLw6+MuIsHFAYAgRr7+KcwDgBAfwhPBYX34nSSiHlmLC+ KaHLeCLF5ZI2vKm3HEeCTtlOg7xZEONgwzL+fdKo+D6SoC8RRxJKs8a3sVfI4t6CnrQzvJbB n6gxdgCu5i29J1QCYrCYvql2UyFPAK+do99/1jOXT4m2836j1wARAQABzSBQYXVsIEVnZ2Vy dCA8ZWdnZXJ0QGNzLnVjbGEuZWR1PsLBfgQTAQIAKAUCTIByZAIbAwUJEswDAAYLCQgHAwIG FQgCCQoLBBYCAwECHgECF4AACgkQ7ZfpDmKqfjRRGw/+Ij03dhYfYl/gXVRiuzV1gGrbHk+t nfrI/C7fAeoFzQ5tVgVinShaPkZo0HTPf18x6IDEdAiO8Mqo1yp0CtHmzGMCJ50o4Grgfjlr 6g/+vtEOKbhleszN2XpJvpwM2QgGvn/laTLUu8PH9aRWTs7qJJZKKKAb4sxYc92FehPu6FOD 0dDiyhlDAq4lOV2mdBpzQbiojoZzQLMQwjpgCTK2572eK9EOEQySUThXrSIz6ASenp4NYTFH s9tuJQvXk9gZDdPSl3bp+47dGxlxEWLpBIM7zIONw4ks4azgT8nvDZxA5IZHtvqBlJLBObYY 0Le61Wp0y3TlBDh2qdK8eYL426W4scEMSuig5gb8OAtQiBW6k2sGUxxeiv8ovWu8YAZgKJfu oWI+uRnMEddruY8JsoM54KaKvZikkKs2bg1ndtLVzHpJ6qFZC7QVjeHUh6/BmgvdjWPZYFTt N+KA9CWX3GQKKgN3uu988yznD7LnB98T4EUH1HA/GnfBqMV1gpzTvPc4qVQinCmIkEFp83zl +G5fCjJJ3W7ivzCnYo4KhKLpFUm97okTKR2LW3xZzEW4cLSWO387MTK3CzDOx5qe6s4a91Zu ZM/j/TQdTLDaqNn83kA4Hq48UHXYxcIh+Nd8k/3w6lFuoK0wrOFiywjLx+0ur5jmmbecBGHc 1xdhAFHOwU0ETIByZAEQAKaF678T9wyH4wjTrV1Pz3cDEoSnV/0ZUrOT37p1dcGyj/IXq1x6 70HRVahAmk0sZpYc25PF9D5GPYHFWlNjuPU96rDndXB3hedmBRhLdC4bAXjI4DV+bmdVe+q/ IMnlZRaVlm9EiMCVAR6w13sReu7qXkW9r3RwY2AzXskp/tAe4BRKr1Zmbvi2nbnQ6epEC42r Rbx0B1EhjbIQZ5JHGk24iPT7LdBgnNmos5wYjzwNlkMQD5T0Ydzhk7J+UxwA5m46mOhRDC2r FV/A0gm5TLy8DXjv/Esc4gYnYai6SQqnUEVh5LuV8YCJBnijs+Tiw71x1icmn6xGI45EugJO gec+rLypYgpVp4x0HI5T88qBRYCkxH3Kg8Qo+EWNA9A4LRQ9DX8njona0gf0s03tocK8kBN6 6UoqqPtHBnc4eMgBymCflK12eKfd2YYxnyg9cZazWA5VslvTxpm76hbg5oiAEH/Vg/8MxHyA nPhfrgwyPrmJEcVBafdspJnYQxBYNco2LFPIhlOvWh8r4at+s+M3Lb26oUTczlgdW1Sf3SDA 77BMRnF0FQyE+7AzV79MBN4ykiqaezQxtaF1Fy/tvkhffSo8u+dwG0EgJh+te38gTcISVr0G IPplLz6YhjrbHrPRF1CN5UuL9DBGjxuN35RLNVEfta6RUFlR6NctTjvrABEBAAHCwWUEGAEC AA8FAkyAcmQCGwwFCRLMAwAACgkQ7ZfpDmKqfjSrHA/+KzAKvTxRhA9MWNLxIyJ7S5uJ16gs T3oCjZrBKGEhKMOGX4O0GA6VOEryO7QRCCYah3oxSG38IAnNeiwJXgU9Bzkk85UGbPEd7HGF /VSeHCQwWou6jqUDTSDvn9YhNTdG0KXPM74aC+xr2Zow1O2mhXihgWKD0Dw+0LYPnUOsQ0KO FxHXXYHmRrS1OZPU59BLvc+TRhIhafSHKLwbXK+6ckkxBx6h8z5ccpG0Qs4bFhdFYnFrEieD LoGmnE2YLhdV6swJ9VNCS6pLiEohT3fm7aXm15tZOIyzMZhHRSAPblXxQ0ZSWjq8oRrcYNFx c4W1URpAkBCOYJoXvQfD5L3lqAl8TCqDUzYxhH/tJhbDdHrqHH767jaDaTB1+Talp/2AMKwc XNOdiklGxbmHVG6YGl6g8Lrbsu9NZEI4yLlHzuikthJWgz+3vZhVGyNlt+HNIoF6CjDL2omu 5cEq4RDHM44QqPk6l7O0pUvN1mT4B+S1b08RKpqm/ff015E37HNV/piIvJlxGAYz8PSfuGCB 1thMYqlmgdhd9/BabGFbGGYHA6U4/T5zqU+f6xHy1SsAQZ1MSKlLwekBIT+4/cLRGqCHjnV0 q5H/T6a7t5mPkbzSrOLSo4puj+IToNjYyYIDBWzhlA19avOa+rvUjmHtD3sFN7cXWtkGoi8b uNcby4U= Organization: UCLA Computer Science Department Message-ID: Date: Fri, 29 Jun 2018 11:18:31 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0 MIME-Version: 1.0 In-Reply-To: <878t6xojus.fsf@gmail.com> Content-Type: multipart/mixed; boundary="------------75813B06FF07E57F6FCD1493" Content-Language: en-US X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 31996 Cc: 31996@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) This is a multi-part message in MIME format. --------------75813B06FF07E57F6FCD1493 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit On 06/29/2018 05:30 AM, Noam Postavsky wrote: > You removed the bytecode stack in [1: a815e5f195], right? Yes I did. Thanks for catching that. I fixed the comment by installing the attached into the emacs-26 branch. --------------75813B06FF07E57F6FCD1493 Content-Type: text/x-patch; name="0001-src-lisp.h-Omit-obsolete-comment-re-bytecode-stack.patch" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename*0="0001-src-lisp.h-Omit-obsolete-comment-re-bytecode-stack.patc"; filename*1="h" >From e6be48a508c4d25c8f8973dc23708c924b403927 Mon Sep 17 00:00:00 2001 From: Paul Eggert Date: Fri, 29 Jun 2018 11:14:36 -0700 Subject: [PATCH] * src/lisp.h: Omit obsolete comment re bytecode stack. --- src/lisp.h | 18 ++++++++---------- 1 file changed, 8 insertions(+), 10 deletions(-) diff --git a/src/lisp.h b/src/lisp.h index 56ad8b814b..b2449cb87d 100644 --- a/src/lisp.h +++ b/src/lisp.h @@ -3044,15 +3044,13 @@ extern void defvar_kboard (struct Lisp_Kboard_Objfwd *, const char *, int); } while (false) -/* Elisp uses several stacks: - - the C stack. - - the bytecode stack: used internally by the bytecode interpreter. - Allocated from the C stack. - - The specpdl stack: keeps track of active unwind-protect and - dynamic-let-bindings. Allocated from the `specpdl' array, a manually - managed stack. - - The handler stack: keeps track of active catch tags and condition-case - handlers. Allocated in a manually managed stack implemented by a +/* Elisp uses multiple stacks: + - The C stack. + - The specpdl stack keeps track of backtraces, unwind-protects and + dynamic let-bindings. It is allocated from the 'specpdl' array, + a manually managed stack. + - The handler stack keeps track of active catch tags and condition-case + handlers. It is allocated in a manually managed stack implemented by a doubly-linked list allocated via xmalloc and never freed. */ /* Structure for recording Lisp call stack for backtrace purposes. */ @@ -3131,7 +3129,7 @@ SPECPDL_INDEX (void) control structures. A struct handler contains all the information needed to restore the state of the interpreter after a non-local jump. - handler structures are chained together in a doubly linked list; the `next' + Handler structures are chained together in a doubly linked list; the `next' member points to the next outer catchtag and the `nextfree' member points in the other direction to the next inner element (which is typically the next free element since we mostly use it on the deepest handler). -- 2.17.1 --------------75813B06FF07E57F6FCD1493-- From unknown Thu Jun 19 14:15:29 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sat, 28 Jul 2018 11:24:04 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator