From unknown Wed Jun 18 23:17:08 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#31988 <31988@debbugs.gnu.org> To: bug#31988 <31988@debbugs.gnu.org> Subject: Status: scroll-other-window broken on master Reply-To: bug#31988 <31988@debbugs.gnu.org> Date: Thu, 19 Jun 2025 06:17:08 +0000 retitle 31988 scroll-other-window broken on master reassign 31988 emacs submitter 31988 "Daniel Colascione" severity 31988 normal tag 31988 patch thanks From debbugs-submit-bounces@debbugs.gnu.org Wed Jun 27 15:54:25 2018 Received: (at submit) by debbugs.gnu.org; 27 Jun 2018 19:54:25 +0000 Received: from localhost ([127.0.0.1]:37875 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fYGWG-0007rd-C5 for submit@debbugs.gnu.org; Wed, 27 Jun 2018 15:54:25 -0400 Received: from eggs.gnu.org ([208.118.235.92]:55397) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fYGWE-0007rR-F9 for submit@debbugs.gnu.org; Wed, 27 Jun 2018 15:54:23 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fYGW8-0003Og-JU for submit@debbugs.gnu.org; Wed, 27 Jun 2018 15:54:17 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,T_DKIM_INVALID autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:60724) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1fYGW8-0003ON-GO for submit@debbugs.gnu.org; Wed, 27 Jun 2018 15:54:16 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:46285) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fYGW3-0005Ae-M9 for bug-gnu-emacs@gnu.org; Wed, 27 Jun 2018 15:54:16 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fYGW2-0003I6-Vw for bug-gnu-emacs@gnu.org; Wed, 27 Jun 2018 15:54:11 -0400 Received: from dancol.org ([2600:3c01::f03c:91ff:fedf:adf3]:42500) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fYGW2-000384-LJ for bug-gnu-emacs@gnu.org; Wed, 27 Jun 2018 15:54:10 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=dancol.org; s=x; h=Content-Transfer-Encoding:Content-Type:MIME-Version:To:From:Subject:Date:Message-ID; bh=TljB5GI2mfgHVvLGXn4iuBoAia+97QyfU0wJXLtBnrk=; b=koJq8h6EIU5oXHaBhaEHRo57Wdv/BRmouzBbHx+DzLDLTSR1CDEfRqBoieRvhyK11OmxLvFFigUKrn0k9ej9JDmIT/2AfnofA1S5hcZh1woWtt/cDV5m258XhjbdMNfEVIohI0e1SMm44VkMCWOk/MIOIcb+aO3bx+JEyrMJtSC6VCqZ6/3AxYEwxoA61GxuHGMkhmiU2W3qXzQ8HxetFPdYl6y3HevOhV9DniFFztr6ZS/pKWzerssH9PmZZEOwfoSCV1CEuf4K6JB1Ut+pQl1wnavpZdMtHIyONkPk6c5sgEEIxcnOtlDRNw1u0QRqDPc6XhaZMgOyiq6SQJPTOA==; Received: from localhost ([127.0.0.1] helo=dancol.org) by dancol.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fYGVv-0005YN-2j for bug-gnu-emacs@gnu.org; Wed, 27 Jun 2018 12:54:03 -0700 Received: from 127.0.0.1 (SquirrelMail authenticated user dancol) by dancol.org with HTTP; Wed, 27 Jun 2018 12:54:03 -0700 Message-ID: Date: Wed, 27 Jun 2018 12:54:03 -0700 Subject: scroll-other-window broken on master From: "Daniel Colascione" To: bug-gnu-emacs@gnu.org User-Agent: SquirrelMail/1.4.23 [SVN] MIME-Version: 1.0 Content-Type: text/plain;charset=iso-8859-1 Content-Transfer-Encoding: 8bit X-Priority: 3 (Normal) Importance: Normal X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -0.5 (/) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.5 (-) scroll-other-window scrolls the current window _and_ the other window. To repro, visit a big file, C-x 2, and mash C-M-v. Only the other window should scroll. Now, both windows scroll. From debbugs-submit-bounces@debbugs.gnu.org Wed Jun 27 16:44:52 2018 Received: (at 31988) by debbugs.gnu.org; 27 Jun 2018 20:44:52 +0000 Received: from localhost ([127.0.0.1]:37909 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fYHJ5-0000ef-TM for submit@debbugs.gnu.org; Wed, 27 Jun 2018 16:44:52 -0400 Received: from dancol.org ([96.126.100.184]:51998) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fYHJ4-0000eX-2I for 31988@debbugs.gnu.org; Wed, 27 Jun 2018 16:44:50 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=dancol.org; s=x; h=Content-Transfer-Encoding:Content-Type:MIME-Version:Cc:To:From:Subject:Date:References:In-Reply-To:Message-ID; bh=ThIOxvtxbPMLIvpop8qi7TZqgbqmCef0sNfhPOwsKjk=; b=AW0REqMVhzVeQU8KwCaa+BWIevrbrtKnCdhHmGVgX1+VmBahJ1JnAq2g7gFPkEX7Ku+KSox/C+WQvxMsJvVjRDnOr+k6geLV+JNwnT+f12u6tcnq0Caw1mMvw5cI1LNCjpNUDEpagz/5ROnyo0++2GdwMOO7MAeuxBdilR6auMJ//qgRSYzvb8U7F774JprLPQOMlYgOTGlInL6uYqeKyB+Zc6lupaacQ51z+vBreX7BMLeibIPiG4tiSMfJ6LdExD6KXL5lQ7xVGPJ8C0/wH3igsT2+R6DEz5Z1xf//n/usH0sUJoCYs02ti8sIB8NAAtYxNlf12F3dVJjaTOYykA==; Received: from localhost ([127.0.0.1] helo=dancol.org) by dancol.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fYHJ1-0005mA-3v; Wed, 27 Jun 2018 13:44:47 -0700 Received: from 127.0.0.1 (SquirrelMail authenticated user dancol) by dancol.org with HTTP; Wed, 27 Jun 2018 13:44:47 -0700 Message-ID: In-Reply-To: References: Date: Wed, 27 Jun 2018 13:44:47 -0700 Subject: Re: bug#31988: scroll-other-window broken on master From: "Daniel Colascione" To: "Daniel Colascione" , "Basil L. Contovounesios" User-Agent: SquirrelMail/1.4.23 [SVN] MIME-Version: 1.0 Content-Type: text/plain;charset=iso-8859-1 Content-Transfer-Encoding: 8bit X-Priority: 3 (Normal) Importance: Normal X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 31988 Cc: 31988@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Basil, it looks like you recently rewrote a big chunk of the window scrolling code. Can you please take a look? Thanks. > scroll-other-window scrolls the current window _and_ the other window. To > repro, visit a big file, C-x 2, and mash C-M-v. Only the other window > should scroll. Now, both windows scroll. From debbugs-submit-bounces@debbugs.gnu.org Wed Jun 27 17:26:51 2018 Received: (at 31988) by debbugs.gnu.org; 27 Jun 2018 21:26:51 +0000 Received: from localhost ([127.0.0.1]:37936 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fYHxj-0003ek-H4 for submit@debbugs.gnu.org; Wed, 27 Jun 2018 17:26:51 -0400 Received: from mail-wr0-f178.google.com ([209.85.128.178]:38181) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fYHxf-0003eG-5o for 31988@debbugs.gnu.org; Wed, 27 Jun 2018 17:26:47 -0400 Received: by mail-wr0-f178.google.com with SMTP id e18-v6so3396887wrs.5 for <31988@debbugs.gnu.org>; Wed, 27 Jun 2018 14:26:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tcd-ie.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=AlUrdf2RMNAXE/yZwRg+s7OV6TLrL28u82MU8cSwRwo=; b=h3y9LaVmADUQnEOhAa/8nVbwgvBbiH4rwZlp9gX3WLnvtEvkumAPruuHO5uH2V9LWv FXP9/ja54IpdQZd1Ltof1j+IxrmfcXjfg0PtdaR+jFNM4Dpbx5AEFjEavHOIR+Ckl5a7 kkNv2bOdD2wrVFVjPWNAur2UHXSH0UUmwQANo+QGB3HkxxHLmH0mnK0SQ6SlGWcf1N9F 76SBU1WHuQQ1c1B5tUSomfIucEuIN1VztvbG6jSN4RTCKDoN5CWYy/KjP+BBx7vDhYKe 3AcY8Di/cDlG1YVGVluUlrO9wGHVX5iKYgNJJ4/oq2zbKeYhVhJmMxgzX8ZzCx6zJhUF +weA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=AlUrdf2RMNAXE/yZwRg+s7OV6TLrL28u82MU8cSwRwo=; b=Na60qZ/By+lEpSpvNEb9xa0OBVfQ/b7M+7kHZ6rLlcbxsL8GOuJW9kr58J0S1Ikazv yh6orJ80QCaFYqePPYyWCt85f1IuW+mMxOA395zGfUNP3gzXVOPpIClVFPVHhxBU55Ix yXcJb3YqmQZIxm4uZWfcyrsHp5/k9GO/4Whyq2d0jxtrPPW+dWQM9lqPqrSZ8BnRlWI8 AZxNOG7559F0jEzCzpxqhcsZ/8jmV/dITM5y3+znw0vZQu5tV0dV1/OhbXTR3S4yB46f LBcJphg50/qt0u8+DjDIzaLjOEK/42rHnilhJYQiPDplol4+BD/hbe47SjH1g5WMEDWw ouJg== X-Gm-Message-State: APt69E38nOcQXHjh097ZGcS71RzyQZ4jTcGaUWrKAnkpK1pIyGt7vDoV BRRbN4fdbU/+aAwpQBXc3FjRBOf/ X-Google-Smtp-Source: AAOMgpfloYW8BUiRHYQnxyb3FLErIFAqLsrGsz0UJn7ZPj6K9Ekrzt59OBa7IJOwy5beJoJQj9D6QQ== X-Received: by 2002:adf:9ed0:: with SMTP id b16-v6mr3673309wrf.170.1530134801324; Wed, 27 Jun 2018 14:26:41 -0700 (PDT) Received: from localhost (adsl-96.91.140.91.tellas.gr. [91.140.91.96]) by smtp.gmail.com with ESMTPSA id u6-v6sm6136070wrm.60.2018.06.27.14.26.40 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 27 Jun 2018 14:26:40 -0700 (PDT) From: "Basil L. Contovounesios" To: "Daniel Colascione" Subject: Re: bug#31988: scroll-other-window broken on master References: Date: Thu, 28 Jun 2018 00:26:33 +0300 In-Reply-To: (Daniel Colascione's message of "Wed, 27 Jun 2018 13:44:47 -0700") Message-ID: <87sh57ncom.fsf@tcd.ie> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 31988 Cc: 31988@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-=-= Content-Type: text/plain tags 31988 patch quit "Daniel Colascione" writes: > Basil, it looks like you recently rewrote a big chunk of the window > scrolling code. Can you please take a look? > > Thanks. > >> scroll-other-window scrolls the current window _and_ the other window. To >> repro, visit a big file, C-x 2, and mash C-M-v. Only the other window >> should scroll. Now, both windows scroll. This bug was indeed introduced by my recent refactor. Does the following patch fix it? --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=0001-Fix-other-window-scroll-when-showing-same-buffer.patch >From 026b6befc40795d8597e036f930f634b2a17e4f3 Mon Sep 17 00:00:00 2001 From: "Basil L. Contovounesios" Date: Thu, 28 Jun 2018 00:13:07 +0300 Subject: [PATCH] Fix other window scroll when showing same buffer src/window.c (scroll_command): Make other window's buffer current before scrolling, even when displaying the same buffer. (bug#31988) --- src/window.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/window.c b/src/window.c index 81fd7f2b47..42b9522862 100644 --- a/src/window.c +++ b/src/window.c @@ -5654,7 +5654,7 @@ scroll_command (Lisp_Object window, Lisp_Object n, int direction) /* If given window's buffer isn't current, make it current for the moment. But don't screw up if window_scroll gets an error. */ - if (XBUFFER (w->contents) != current_buffer) + if (other_window || XBUFFER (w->contents) != current_buffer) { record_unwind_protect_excursion (); Fset_buffer (w->contents); -- 2.18.0 --=-=-= Content-Type: text/plain Thanks, -- Basil --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Fri Jul 06 11:18:19 2018 Received: (at 31988) by debbugs.gnu.org; 6 Jul 2018 15:18:19 +0000 Received: from localhost ([127.0.0.1]:48771 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fbSV1-0001hK-2k for submit@debbugs.gnu.org; Fri, 06 Jul 2018 11:18:19 -0400 Received: from dancol.org ([96.126.100.184]:37226) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fbSUz-0001hC-0C for 31988@debbugs.gnu.org; Fri, 06 Jul 2018 11:18:17 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=dancol.org; s=x; h=Content-Transfer-Encoding:Content-Type:MIME-Version:Cc:To:From:Subject:Date:References:In-Reply-To:Message-ID; bh=1IFWi4VtFkYm4Q8ggL2n/t0PnOuJCGS6QZGwIwab06Q=; b=U1gGzO59+PQ8OqKAi4AwsccOGQIi18hxPpDkOUtrZfYztYoNxs4Vh8XKY3IfgOEwuDTB7T2/n2/uC1zM6dGf5gFfMZBoo+HTqZ8ymBDB7WKV40H9cE668uZPal1hwPHN2LFMQN4d27NKLZtGqH4rD4uk1UzgVJU7Yh3SmOHTNSohsgdI1ESVnBx+vKgruADr7pCbT/MziSycSWDP8FZQIN717BNH7466nEJmp1rX7UVXaqGuDyvZ4oMhHdLZYH8A4MnUUFJiMMIWYKHHuH7u8oG4XOzKJ3xIyxo4OpZ6tGADG0D/U5GDi/FZBQ14nHkDjHwf9ZKnXmuUKzbEpVRlVg==; Received: from localhost ([127.0.0.1] helo=dancol.org) by dancol.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fbSUw-000784-5n; Fri, 06 Jul 2018 08:18:14 -0700 Received: from 127.0.0.1 (SquirrelMail authenticated user dancol) by dancol.org with HTTP; Fri, 6 Jul 2018 08:18:14 -0700 Message-ID: <18f5ace80f052837c724d942d832a146.squirrel@dancol.org> In-Reply-To: <87sh57ncom.fsf@tcd.ie> References: <87sh57ncom.fsf@tcd.ie> Date: Fri, 6 Jul 2018 08:18:14 -0700 Subject: Re: bug#31988: scroll-other-window broken on master From: "Daniel Colascione" To: "Basil L. Contovounesios" User-Agent: SquirrelMail/1.4.23 [SVN] MIME-Version: 1.0 Content-Type: text/plain;charset=iso-8859-1 Content-Transfer-Encoding: 8bit X-Priority: 3 (Normal) Importance: Normal X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 31988 Cc: Daniel Colascione , 31988@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) > "Daniel Colascione" writes: > >> Basil, it looks like you recently rewrote a big chunk of the window >> scrolling code. Can you please take a look? >> >> Thanks. >> >>> scroll-other-window scrolls the current window _and_ the other window. >>> To >>> repro, visit a big file, C-x 2, and mash C-M-v. Only the other window >>> should scroll. Now, both windows scroll. > > This bug was indeed introduced by my recent refactor. > Does the following patch fix it? That works. Thanks! Do you want to apply the patch? From debbugs-submit-bounces@debbugs.gnu.org Fri Jul 06 18:21:06 2018 Received: (at 31988) by debbugs.gnu.org; 6 Jul 2018 22:21:06 +0000 Received: from localhost ([127.0.0.1]:48883 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fbZ6A-0003iJ-6z for submit@debbugs.gnu.org; Fri, 06 Jul 2018 18:21:06 -0400 Received: from mail-wm0-f46.google.com ([74.125.82.46]:36532) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fbZ68-0003hV-Sp for 31988@debbugs.gnu.org; Fri, 06 Jul 2018 18:21:05 -0400 Received: by mail-wm0-f46.google.com with SMTP id s14-v6so15677509wmc.1 for <31988@debbugs.gnu.org>; Fri, 06 Jul 2018 15:21:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tcd-ie.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=NQSJQySdKyZehExCWI0RplXHo5mkYEs0QEAPf7q1aEo=; b=GaZ/chut2CklG6h+doxuy1/NmkwpPILFoYD/pSIiMZmx5HY2bJ7pXVLbtq1QfHH9S0 2TGbwIOyjRvJR+b87iOTYxJ3bMcj4lw/gsgTrWVcl+ix5Ww3DIZvFFI47rDrkhCwg+Md pt2fXU9K+dehvstkjglpkOXR6h7R06dhcb2epyNurlnXtV6Gu4Ia1x5NCM7VEPtOW++/ Px+qOYZ0aUmcNDcs62O9V70LVaQIWxa974s+qg8TQm0fWUHnQ6M9YiDTY16qEjlZxxQt lv550LCRlMGyyhMfw3CkD8Vve/MG3sGi5wgwKNDODaI7eRz963nyS08hDKUS/JghpThM DCfQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=NQSJQySdKyZehExCWI0RplXHo5mkYEs0QEAPf7q1aEo=; b=X4sAmrT96fV/SuOfIErkCmbwYkGorDr17cVLugiSZXqL+Nmbps8IXIL+lItGvKzagI bRet97/RMBpPAntGBUgK09I5Oxef5hDD0P2xvX3k3k8UGiChesMf+OecW1clCTeF75ni Q14Do+wxoZXjdU3XuZD5zBdhpN4jwT7j7jWpxhS2NaxE4gW0tvE1Ay3BwGbIXzbHFQTG 0L6Nndx3Ma7gyvr56ByEzww7CXAY4TcrhEGkWZENJoMPLugoE9uyI1cecA76m8ujCPtj GiQABLRjkEXiDS6bxgNFN1fs+yj4M/x8Rlz7FDQBrZzTLeLrhTWzjck2UZjt7WtmFycD CX6w== X-Gm-Message-State: APt69E2msxLuHBMHSXaar/kzNRU+00upezS3QMYWUcMMnu4K3g8KIHFm Rdy1SAJ69yXTAioRiu9Xokp0ial/ X-Google-Smtp-Source: AAOMgpcTXTS2bl6pvufozu4bd5exo9ofNfn7Vm5p5uuJUb68cVAPYUs2Vk1GwiqT43S+LnIWSfj/BQ== X-Received: by 2002:a1c:3662:: with SMTP id d95-v6mr7038312wma.147.1530915658981; Fri, 06 Jul 2018 15:20:58 -0700 (PDT) Received: from localhost (adsl-160.91.140.88.tellas.gr. [91.140.88.160]) by smtp.gmail.com with ESMTPSA id r140-v6sm18320722wmd.27.2018.07.06.15.20.57 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 06 Jul 2018 15:20:58 -0700 (PDT) From: "Basil L. Contovounesios" To: "Daniel Colascione" Subject: Re: bug#31988: scroll-other-window broken on master References: <87sh57ncom.fsf@tcd.ie> <18f5ace80f052837c724d942d832a146.squirrel@dancol.org> Date: Sat, 07 Jul 2018 01:20:54 +0300 In-Reply-To: <18f5ace80f052837c724d942d832a146.squirrel@dancol.org> (Daniel Colascione's message of "Fri, 6 Jul 2018 08:18:14 -0700") Message-ID: <874lhc9fax.fsf@tcd.ie> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 31988 Cc: 31988@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) "Daniel Colascione" writes: >> "Daniel Colascione" writes: >> >>> Basil, it looks like you recently rewrote a big chunk of the window >>> scrolling code. Can you please take a look? >>> >>> Thanks. >>> >>>> scroll-other-window scrolls the current window _and_ the other window. >>>> To >>>> repro, visit a big file, C-x 2, and mash C-M-v. Only the other window >>>> should scroll. Now, both windows scroll. >> >> This bug was indeed introduced by my recent refactor. >> Does the following patch fix it? > > That works. Thanks! Do you want to apply the patch? I don't have push access, so someone else will have to apply the patch for me if there are no objections to it. Thanks, -- Basil From debbugs-submit-bounces@debbugs.gnu.org Fri Jul 06 19:31:27 2018 Received: (at 31988) by debbugs.gnu.org; 6 Jul 2018 23:31:27 +0000 Received: from localhost ([127.0.0.1]:48913 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fbaCF-0005i6-IS for submit@debbugs.gnu.org; Fri, 06 Jul 2018 19:31:27 -0400 Received: from dancol.org ([96.126.100.184]:44368) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fbaCD-0005hx-Um for 31988@debbugs.gnu.org; Fri, 06 Jul 2018 19:31:26 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=dancol.org; s=x; h=Content-Transfer-Encoding:Content-Type:MIME-Version:Cc:To:From:Subject:Date:References:In-Reply-To:Message-ID; bh=5FFTNXEjk2XQqilLVFh5zhR3RgX3k0Urzn+Hw4CNk38=; b=L7VyRzuxucly/tDn9kPlIj46TRC+XgD3YDrPbE+NUEpOLWm0xRmDsx+pkuXxb2n0EO7AMWsT4+Zlx6AvpYSTlxWTjF+LKffvhNchRfcDYNYyleBf8m7q0ExZWClUG6vWArasRVaFpUh3bjr5iMfkS4I3jfnsGCT+1UkTaIVCDJZsuwaX3fSzkkXSEzDX9JnFU6gJb5KhfcAyUGia+3lO2Jzi86HF6tpW8zi1Q0EjSCi1Hm061qqj6JeNWF6FZ+QpkXIZhCDROVCBxpZ0O30ujSju93SQnK4c1kWg5cL+VZj6Aw8W3EnpwReVFW16GV0aVVMvnnb4vbOTTC/NwsSnoA==; Received: from localhost ([127.0.0.1] helo=dancol.org) by dancol.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fbaCC-0000d7-94; Fri, 06 Jul 2018 16:31:24 -0700 Received: from 127.0.0.1 (SquirrelMail authenticated user dancol) by dancol.org with HTTP; Fri, 6 Jul 2018 16:31:24 -0700 Message-ID: <7e1589a2b0bdd4a07d6826b594a96ab5.squirrel@dancol.org> In-Reply-To: <874lhc9fax.fsf@tcd.ie> References: <87sh57ncom.fsf@tcd.ie> <18f5ace80f052837c724d942d832a146.squirrel@dancol.org> <874lhc9fax.fsf@tcd.ie> Date: Fri, 6 Jul 2018 16:31:24 -0700 Subject: Re: bug#31988: scroll-other-window broken on master From: "Daniel Colascione" To: "Basil L. Contovounesios" User-Agent: SquirrelMail/1.4.23 [SVN] MIME-Version: 1.0 Content-Type: text/plain;charset=iso-8859-1 Content-Transfer-Encoding: 8bit X-Priority: 3 (Normal) Importance: Normal X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 31988 Cc: Daniel Colascione , 31988@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) close 31988 quit > "Daniel Colascione" writes: > >>> "Daniel Colascione" writes: >>> >>>> Basil, it looks like you recently rewrote a big chunk of the window >>>> scrolling code. Can you please take a look? >>>> >>>> Thanks. >>>> >>>>> scroll-other-window scrolls the current window _and_ the other >>>>> window. >>>>> To >>>>> repro, visit a big file, C-x 2, and mash C-M-v. Only the other window >>>>> should scroll. Now, both windows scroll. >>> >>> This bug was indeed introduced by my recent refactor. >>> Does the following patch fix it? >> >> That works. Thanks! Do you want to apply the patch? > > I don't have push access, so someone else will have to apply the patch > for me if there are no objections to it. I just applied it. Thanks! From debbugs-submit-bounces@debbugs.gnu.org Sat Jul 07 03:48:13 2018 Received: (at 31988) by debbugs.gnu.org; 7 Jul 2018 07:48:14 +0000 Received: from localhost ([127.0.0.1]:49048 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fbhwz-000206-NX for submit@debbugs.gnu.org; Sat, 07 Jul 2018 03:48:13 -0400 Received: from eggs.gnu.org ([208.118.235.92]:55103) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fbhwy-0001zr-C8 for 31988@debbugs.gnu.org; Sat, 07 Jul 2018 03:48:12 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fbhwp-0000Gq-78 for 31988@debbugs.gnu.org; Sat, 07 Jul 2018 03:48:07 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:49507) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fbhwp-0000Gl-3T; Sat, 07 Jul 2018 03:48:03 -0400 Received: from [176.228.60.248] (port=3005 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1fbhwo-0002qb-I2; Sat, 07 Jul 2018 03:48:02 -0400 Date: Sat, 07 Jul 2018 10:48:06 +0300 Message-Id: <83pnzzjxl5.fsf@gnu.org> From: Eli Zaretskii To: "Daniel Colascione" In-reply-to: <7e1589a2b0bdd4a07d6826b594a96ab5.squirrel@dancol.org> Subject: Re: bug#31988: scroll-other-window broken on master References: <87sh57ncom.fsf@tcd.ie> <18f5ace80f052837c724d942d832a146.squirrel@dancol.org> <874lhc9fax.fsf@tcd.ie> <7e1589a2b0bdd4a07d6826b594a96ab5.squirrel@dancol.org> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 31988 Cc: contovob@tcd.ie, 31988@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -6.0 (------) > Date: Fri, 6 Jul 2018 16:31:24 -0700 > From: "Daniel Colascione" > Cc: 31988@debbugs.gnu.org > > > I don't have push access, so someone else will have to apply the patch > > for me if there are no objections to it. > > I just applied it. Thanks! Thanks, but why didn't you use the commit log Basil provided? (It was somewhat inaccurate, but more informative than what you used, IMO.) From debbugs-submit-bounces@debbugs.gnu.org Sat Jul 07 09:40:33 2018 Received: (at 31988) by debbugs.gnu.org; 7 Jul 2018 13:40:33 +0000 Received: from localhost ([127.0.0.1]:49237 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fbnRx-0004Al-Hr for submit@debbugs.gnu.org; Sat, 07 Jul 2018 09:40:33 -0400 Received: from mail-wr1-f41.google.com ([209.85.221.41]:33857) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fbnRu-0004AL-Jd for 31988@debbugs.gnu.org; Sat, 07 Jul 2018 09:40:31 -0400 Received: by mail-wr1-f41.google.com with SMTP id c13-v6so6584799wrt.1 for <31988@debbugs.gnu.org>; Sat, 07 Jul 2018 06:40:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tcd-ie.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=Rmp1yqLn+WQdhJmXhsJjITlYvGU5krkcT6OphJv4y9I=; b=YoPq0x9pX5fFCjnwUAlWVbn5BNoiN/DVo2dxXR/Ejvi0gpBXbf6Xufh60x04P4Qv1C wLuOtTwh+Hqsywcel1kxIpnGjLASKhLKnx290287V9fruYEwCig5Uafmb352mIQIGlfd FY6l/RA0o3w/s+W+aHYkg/tYe7VjIrV47U5zBeuH5LhpXNT2t7q0HC1jZrVx7KS/pvR2 XeImr//SaobcEwibWoFyRxb3yFs0cCl3neTtpK5aHCgknMtPxuVt9oxt8qdusCnDniaf VMAqxllp4FY1dMrHTGuxOcW0f9IYKB8J/YcDl46qpV6+a0k0vXtPuqC8aUuMSUnMgI4H 7mzg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=Rmp1yqLn+WQdhJmXhsJjITlYvGU5krkcT6OphJv4y9I=; b=mW4Fzu5B20/bxOwEaLOyWobKR9HiefU5x5bAZRdvzifBhKEuu7smIlwjDHhpR1QZdD 4loz3vw424p0xL+UQD6aUWCUG83oqBRbjhqbdmf1CoG5ehDWe+KCbWjRxcBDbUM1kCBK cHLSKY0pFKCnFz1lPjt3kXLajqRwUibvh2BjrZ6Agi7zvxHYfyzHPPEsHafuBGUC2PXD NAGJQcKrKXB8TJBSgnfZxBLYoiSYbaSqcv5gW1Gi7Vh5B7VOI7FuAWndTTcG9ZNeW/xn OB3k70VHPYL2yjjXsVNMysY3KCsQrLJyOhWT0KUhSxsySLywuDRvWYoD+eFKygZySnbi NQGA== X-Gm-Message-State: APt69E2H32fgrqfN9WGvSHn6oHxSxPj7QkUD4ytVZOURJG/2EKzAN/at rZ91NzkbjAmh0K5JF+j/qfbZ3A== X-Google-Smtp-Source: AAOMgpfXBQkeuPKculJAAo6HNFCvSdFZ1TZvXRIJ8wFmnx2ESiAVDHtlI4PSTHQVZjdAHnyt/CHidA== X-Received: by 2002:adf:83a6:: with SMTP id 35-v6mr9885730wre.13.1530970824767; Sat, 07 Jul 2018 06:40:24 -0700 (PDT) Received: from localhost (adsl-112.91.140.88.tellas.gr. [91.140.88.112]) by smtp.gmail.com with ESMTPSA id e128-v6sm16688767wma.46.2018.07.07.06.40.23 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sat, 07 Jul 2018 06:40:24 -0700 (PDT) From: "Basil L. Contovounesios" To: Eli Zaretskii Subject: Re: bug#31988: scroll-other-window broken on master References: <87sh57ncom.fsf@tcd.ie> <18f5ace80f052837c724d942d832a146.squirrel@dancol.org> <874lhc9fax.fsf@tcd.ie> <7e1589a2b0bdd4a07d6826b594a96ab5.squirrel@dancol.org> <83pnzzjxl5.fsf@gnu.org> Date: Sat, 07 Jul 2018 16:40:17 +0300 In-Reply-To: <83pnzzjxl5.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 7 Jul 2018 10:48:06 +0300") Message-ID: <87a7r317we.fsf@tcd.ie> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 31988 Cc: Daniel Colascione , 31988-done@debbugs.gnu.org, 31988@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Eli Zaretskii writes: >> Date: Fri, 6 Jul 2018 16:31:24 -0700 >> From: "Daniel Colascione" >> Cc: 31988@debbugs.gnu.org >> >> > I don't have push access, so someone else will have to apply the patch >> > for me if there are no objections to it. >> >> I just applied it. Thanks! > > Thanks, but why didn't you use the commit log Basil provided? (It was > somewhat inaccurate, but more informative than what you used, IMO.) Thanks Daniel for applying the patch and Eli for your subsequent efficiency and documentation fix. I don't yet feel particularly good at or confident with writing changelog entries, let alone Emacs C code, so any guidance is more than welcome now and in the future. I'm not sure whether Daniel's addition of the 'close' tag had the intended effect, so I'm taking the liberty of CCing <31988-done@debbugs.gnu.org>; if this was the wrong thing to do, please let me know what I should have done instead. Thanks again, -- Basil From debbugs-submit-bounces@debbugs.gnu.org Sat Jul 07 09:50:53 2018 Received: (at 31988) by debbugs.gnu.org; 7 Jul 2018 13:50:53 +0000 Received: from localhost ([127.0.0.1]:49245 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fbnbx-0004QD-HG for submit@debbugs.gnu.org; Sat, 07 Jul 2018 09:50:53 -0400 Received: from eggs.gnu.org ([208.118.235.92]:48150) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fbnbw-0004Py-3C for 31988@debbugs.gnu.org; Sat, 07 Jul 2018 09:50:52 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fbnbn-0006GO-Lf for 31988@debbugs.gnu.org; Sat, 07 Jul 2018 09:50:46 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50 autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:53135) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fbnbn-0006GA-HL; Sat, 07 Jul 2018 09:50:43 -0400 Received: from [176.228.60.248] (port=2025 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1fbnbn-0003rl-1C; Sat, 07 Jul 2018 09:50:43 -0400 Date: Sat, 07 Jul 2018 16:50:47 +0300 Message-Id: <83wou7i288.fsf@gnu.org> From: Eli Zaretskii To: "Basil L. Contovounesios" In-reply-to: <87a7r317we.fsf@tcd.ie> (contovob@tcd.ie) Subject: Re: bug#31988: scroll-other-window broken on master References: <87sh57ncom.fsf@tcd.ie> <18f5ace80f052837c724d942d832a146.squirrel@dancol.org> <874lhc9fax.fsf@tcd.ie> <7e1589a2b0bdd4a07d6826b594a96ab5.squirrel@dancol.org> <83pnzzjxl5.fsf@gnu.org> <87a7r317we.fsf@tcd.ie> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 31988 Cc: dancol@dancol.org, 31988@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -6.0 (------) > From: "Basil L. Contovounesios" > Cc: Daniel Colascione , <31988@debbugs.gnu.org>, <31988-done@debbugs.gnu.org> > Date: Sat, 07 Jul 2018 16:40:17 +0300 > > I don't yet feel particularly good at or confident with writing > changelog entries, let alone Emacs C code, so any guidance is more than > welcome now and in the future. I think you are doing just fine, thank you. There's always some learning curve, of course. CONTRIBUTE should tell you enough, and you can study the log messages by veterans to pick up the spirit. The "inaccurate" part in my message related not to your wording (which was fine, AFAICT), but to the fact that the important part of your fix was to call save-excursion in the described case, not the part that set the buffer (which was actually a no-op). > I'm not sure whether Daniel's addition of the 'close' tag had the > intended effect It should have, but it looks like it didn't for some reason. > so I'm taking the liberty of CCing <31988-done@debbugs.gnu.org>; if > this was the wrong thing to do, please let me know what I should > have done instead. Doing that for a bug that should be closed can never do any harm, even if it was already closed. (You also don't need to CC both NNN@ and NNN-done@, as the message gets recorded by the tracker even if you only use the latter.) Thanks. From debbugs-submit-bounces@debbugs.gnu.org Sat Jul 07 10:14:45 2018 Received: (at 31988) by debbugs.gnu.org; 7 Jul 2018 14:14:45 +0000 Received: from localhost ([127.0.0.1]:50232 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fbnz2-0005D2-OP for submit@debbugs.gnu.org; Sat, 07 Jul 2018 10:14:44 -0400 Received: from mail-wr1-f51.google.com ([209.85.221.51]:34547) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fbnz0-0005Co-La for 31988@debbugs.gnu.org; Sat, 07 Jul 2018 10:14:43 -0400 Received: by mail-wr1-f51.google.com with SMTP id c13-v6so6633404wrt.1 for <31988@debbugs.gnu.org>; Sat, 07 Jul 2018 07:14:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tcd-ie.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=lHncBclgtvutyvqGUpHidI+7RRFsGPJ8tVYxkcQUO+w=; b=dStkC2QKU1ULS0l7/HrBr2DHxftNNpTKAMe8X2D9OEnDcoDcT4YjEwojHGEQVzjDqy xODPCJ1w731KFm8oXgUblrz0mbEii6ybrVxollrxgphY0/XQ/KcYWgCD+uKyomHyD13q Kt0vVckrFJWXfED1vqJByvCcf4KAWjvOCxjO6gIgOQEUVoZ+9O7yrcMLzGwjCpDlFiWn 8nWq5fudbbX2nROIE9YflGLsWGw5xEskuIBpJMKXlaL5Me42UFqWMePj0zHy8hVrvcZj HwBzm5QNherENp4yvgtxfj88vV5NzoLCVspJnqupsZhbD+oqgGWLLOiKOI8mOiVGoLCd K2ZQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=lHncBclgtvutyvqGUpHidI+7RRFsGPJ8tVYxkcQUO+w=; b=gxo6AEcsUR2r7otsnCRsKto1vFQjAkmyo3bXYB+54Pqwc0wFGvjMsB/llaho4YLdVs /NouRwMpi4DO6uVPWS5AU1PzC1Mu8lJqPNtjgom7kU9mEH9QhhxXC9AciZKN/JpFhYui yrc1a7C8oMtKTH5E4UHvctmirxBjSvMBqt9ZfdYUdSkFDk62i3skip5BB6DZV8hoJHZe A3NzV1pvZJ7EwUSuHHwb7ERyZeXexg0YLvkLOHdjJFjh/hUplCSNiQu4BSks2tOr0y1r /AFmgRxJn1SZxiv4fCrDOME7dYb1cxAdomCB9tw8VRtaH45uuTDY9HK/n0ssNOu5Yriy 8tQg== X-Gm-Message-State: APt69E0P8yjMLxPY623ms3JUi1wlHfhkHHTLOFSTSzkDt8iy1fvdlta9 gwYVnzIw792ZLtR62Ca0gQMb3mLm X-Google-Smtp-Source: AAOMgpddmssSWcXOpcFds48/LMneLZkGZ2DvFLSrKW0Vwa3/yZ9kEGfEHdw5d4DdgarCRB+vicL3qA== X-Received: by 2002:a5d:46c6:: with SMTP id g6-v6mr9513056wrs.76.1530972876974; Sat, 07 Jul 2018 07:14:36 -0700 (PDT) Received: from localhost (adsl-112.91.140.88.tellas.gr. [91.140.88.112]) by smtp.gmail.com with ESMTPSA id p184-v6sm5791556wmp.43.2018.07.07.07.14.35 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sat, 07 Jul 2018 07:14:36 -0700 (PDT) From: "Basil L. Contovounesios" To: Eli Zaretskii Subject: Re: bug#31988: scroll-other-window broken on master References: <87sh57ncom.fsf@tcd.ie> <18f5ace80f052837c724d942d832a146.squirrel@dancol.org> <874lhc9fax.fsf@tcd.ie> <7e1589a2b0bdd4a07d6826b594a96ab5.squirrel@dancol.org> <83pnzzjxl5.fsf@gnu.org> <87a7r317we.fsf@tcd.ie> <83wou7i288.fsf@gnu.org> Date: Sat, 07 Jul 2018 17:14:29 +0300 In-Reply-To: <83wou7i288.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 7 Jul 2018 16:50:47 +0300") Message-ID: <874lhb16be.fsf@tcd.ie> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 31988 Cc: dancol@dancol.org, 31988@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Eli Zaretskii writes: >> From: "Basil L. Contovounesios" >> Cc: Daniel Colascione , <31988@debbugs.gnu.org>, >> <31988-done@debbugs.gnu.org> >> Date: Sat, 07 Jul 2018 16:40:17 +0300 >> >> I don't yet feel particularly good at or confident with writing >> changelog entries, let alone Emacs C code, so any guidance is more than >> welcome now and in the future. > > I think you are doing just fine, thank you. There's always some > learning curve, of course. CONTRIBUTE should tell you enough, and you > can study the log messages by veterans to pick up the spirit. > > The "inaccurate" part in my message related not to your wording (which > was fine, AFAICT), but to the fact that the important part of your fix > was to call save-excursion in the described case, not the part that > set the buffer (which was actually a no-op). > >> I'm not sure whether Daniel's addition of the 'close' tag had the >> intended effect > > It should have, but it looks like it didn't for some reason. > >> so I'm taking the liberty of CCing <31988-done@debbugs.gnu.org>; if >> this was the wrong thing to do, please let me know what I should >> have done instead. > > Doing that for a bug that should be closed can never do any harm, even > if it was already closed. (You also don't need to CC both NNN@ and > NNN-done@, as the message gets recorded by the tracker even if you > only use the latter.) Thanks for explaining everything, it all makes sense. -- Basil From unknown Wed Jun 18 23:17:08 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sun, 05 Aug 2018 11:24:06 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator