Subject: shaderc fails its test suite on all hydra-supported systems

From: Mark H Weaver <[email-masked]>
Date: Tue, 26 Jun 2018 13:44:06 -0400

shaderc fails its test suite on all systems supported by Hydra, but the
builds succeed because the #f returned by meson-build-system's check
phase is ignored, due to <https://bugs.gnu.org/31974>.

  https://hydra.gnu.org/build/2811833  (x86_64-linux)
  https://hydra.gnu.org/build/2811921  (i686-linux)
  https://hydra.gnu.org/build/2812123  (armhf-linux)

See below for the relevant excerpt of the log.

I have a preliminary patch to fix 'meson-build-system' to return #t from
all phases, and will push after some testing.

      Mark

--8<---------------cut here---------------start------------->8---
phase `build' succeeded after 119.5 seconds
starting phase `check'
[0/1] Running tests...
Test project /tmp/guix-build-shaderc-0.0.0-2.be8e087.drv-0/source
    Start 1: spirv-tools-symbol-exports-SPIRV-Tools
1/4 Test #1: spirv-tools-symbol-exports-SPIRV-Tools ..........***Failed    0.60 sec
    Start 2: spirv-tools-symbol-exports-SPIRV-Tools-shared
2/4 Test #2: spirv-tools-symbol-exports-SPIRV-Tools-shared ...***Failed    0.13 sec
    Start 3: spirv-tools-symbol-exports-SPIRV-Tools-opt
3/4 Test #3: spirv-tools-symbol-exports-SPIRV-Tools-opt ......***Failed    0.14 sec
    Start 4: spirv-tools-symbol-exports-SPIRV-Tools-link
4/4 Test #4: spirv-tools-symbol-exports-SPIRV-Tools-link .....***Failed    0.12 sec

0% tests passed, 4 tests failed out of 4

Total Test time (real) =   1.02 sec

The following tests FAILED:
	  1 - spirv-tools-symbol-exports-SPIRV-Tools (Failed)
	  2 - spirv-tools-symbol-exports-SPIRV-Tools-shared (Failed)
	  3 - spirv-tools-symbol-exports-SPIRV-Tools-opt (Failed)
	  4 - spirv-tools-symbol-exports-SPIRV-Tools-link (Failed)
Errors while running CTest
FAILED: CMakeFiles/test.util 
cd /tmp/guix-build-shaderc-0.0.0-2.be8e087.drv-0/source && /gnu/store/g85ikfjxs2d7aydvg5w06jn2h9xrjmpc-cmake-3.11.0/bin/ctest --force-new-ctest-process
ninja: build stopped: subcommand failed.
phase `check' failed after 1.7 seconds
## WARNING: phase `check' returned `#f'.  Return values other than #t
## are deprecated.  Please migrate this package so that its phase
## procedures report errors by raising an exception, and otherwise
## always return #t.
starting phase `install'
--8<---------------cut here---------------end--------------->8---