From unknown Tue Jun 17 20:20:44 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#31974 <31974@debbugs.gnu.org> To: bug#31974 <31974@debbugs.gnu.org> Subject: Status: If a phase returns #f, a warning is issued, but the build continues Reply-To: bug#31974 <31974@debbugs.gnu.org> Date: Wed, 18 Jun 2025 03:20:44 +0000 retitle 31974 If a phase returns #f, a warning is issued, but the build con= tinues reassign 31974 guix submitter 31974 Mark H Weaver severity 31974 important thanks From debbugs-submit-bounces@debbugs.gnu.org Mon Jun 25 23:14:34 2018 Received: (at submit) by debbugs.gnu.org; 26 Jun 2018 03:14:34 +0000 Received: from localhost ([127.0.0.1]:35511 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fXeR7-0005Jd-Sd for submit@debbugs.gnu.org; Mon, 25 Jun 2018 23:14:34 -0400 Received: from eggs.gnu.org ([208.118.235.92]:50033) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fXeR5-0005JQ-CX for submit@debbugs.gnu.org; Mon, 25 Jun 2018 23:14:31 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fXeQz-0007Q2-Bi for submit@debbugs.gnu.org; Mon, 25 Jun 2018 23:14:26 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:44705) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1fXeQz-0007Py-8E for submit@debbugs.gnu.org; Mon, 25 Jun 2018 23:14:25 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:40997) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fXeQy-000730-6Y for bug-guix@gnu.org; Mon, 25 Jun 2018 23:14:25 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fXeQu-0007Oh-SF for bug-guix@gnu.org; Mon, 25 Jun 2018 23:14:24 -0400 Received: from world.peace.net ([64.112.178.59]:42294) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1fXeQu-0007OR-O7 for bug-guix@gnu.org; Mon, 25 Jun 2018 23:14:20 -0400 Received: from mhw by world.peace.net with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1fXeQt-0001iq-IB; Mon, 25 Jun 2018 23:14:19 -0400 From: Mark H Weaver To: bug-guix@gnu.org Subject: If a phase returns #f, a warning is issued, but the build continues Date: Mon, 25 Jun 2018 23:13:03 -0400 Message-ID: <87efgu8clc.fsf@netris.org> MIME-Version: 1.0 Content-Type: text/plain X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -6.0 (------) I just noticed that I made a mistake in commit d8a3b1b9e847d4a44d2695f95af77170d4d2788f, which changed 'gnu-build' in (guix build gnu-build-system) to issue a warning if a phase returns a value other than #t. The result is that if a phase returns a value other than #t, a warning is issued, but the build nonetheless continues to the next phase, and the build could ultimately "succeed" even some phases returned #f. In other words, the return values of phases are effectively ignored, except for the warning, so the only way to cause a build with phases to fail is to raise an exception. We can't fix this problem without a full rebuild. Sorry about that :-( The only good news here is that I've already fixed all of the core packages to return #t from all phases and to report errors using exceptions. Ditto for all of the packages that I use on my GNOME desktop. The remaining packages that might return #f from a phase could be fixed in 'master'. Mark From debbugs-submit-bounces@debbugs.gnu.org Wed Jun 27 16:15:06 2018 Received: (at 31974) by debbugs.gnu.org; 27 Jun 2018 20:15:06 +0000 Received: from localhost ([127.0.0.1]:37895 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fYGqI-0008O9-1z for submit@debbugs.gnu.org; Wed, 27 Jun 2018 16:15:06 -0400 Received: from eggs.gnu.org ([208.118.235.92]:40402) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fYGqH-0008NP-4i for 31974@debbugs.gnu.org; Wed, 27 Jun 2018 16:15:05 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fYGqB-0006uK-Ce for 31974@debbugs.gnu.org; Wed, 27 Jun 2018 16:15:00 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:54592) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fYGqB-0006u3-8o; Wed, 27 Jun 2018 16:14:59 -0400 Received: from [2a01:e0a:1d:7270:af76:b9b:ca24:c465] (port=44588 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1fYGqA-0006U4-NA; Wed, 27 Jun 2018 16:14:58 -0400 From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=) To: Mark H Weaver Subject: Re: bug#31974: If a phase returns #f, a warning is issued, but the build continues References: <87efgu8clc.fsf@netris.org> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: 9 Messidor an 226 de la =?utf-8?Q?R=C3=A9volution?= X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-pc-linux-gnu Date: Wed, 27 Jun 2018 22:14:57 +0200 In-Reply-To: <87efgu8clc.fsf@netris.org> (Mark H. Weaver's message of "Mon, 25 Jun 2018 23:13:03 -0400") Message-ID: <87bmbwx9z2.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 31974 Cc: 31974@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -6.0 (------) Mark H Weaver skribis: > I just noticed that I made a mistake in commit > d8a3b1b9e847d4a44d2695f95af77170d4d2788f, which changed 'gnu-build' in > (guix build gnu-build-system) to issue a warning if a phase returns a > value other than #t. > > The result is that if a phase returns a value other than #t, a warning > is issued, but the build nonetheless continues to the next phase, and > the build could ultimately "succeed" even some phases returned #f. > > In other words, the return values of phases are effectively ignored, > except for the warning, so the only way to cause a build with phases to > fail is to raise an exception. Thanks for the heads-up. In practice, I suppose many builds would eventually fail anyway, but we=E2=80=99ll have to keep an eye on it. Ludo=E2=80=99. From debbugs-submit-bounces@debbugs.gnu.org Wed Jun 27 16:50:13 2018 Received: (at control) by debbugs.gnu.org; 27 Jun 2018 20:50:13 +0000 Received: from localhost ([127.0.0.1]:37913 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fYHOH-0000my-IY for submit@debbugs.gnu.org; Wed, 27 Jun 2018 16:50:13 -0400 Received: from eggs.gnu.org ([208.118.235.92]:35308) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fYHOF-0000mk-Ju for control@debbugs.gnu.org; Wed, 27 Jun 2018 16:50:12 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fYHO9-0006gw-OC for control@debbugs.gnu.org; Wed, 27 Jun 2018 16:50:06 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:55109) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fYHO9-0006gR-Jq for control@debbugs.gnu.org; Wed, 27 Jun 2018 16:50:05 -0400 Received: from [2a01:e0a:1d:7270:af76:b9b:ca24:c465] (port=45498 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1fYHO8-0007ZC-B9 for control@debbugs.gnu.org; Wed, 27 Jun 2018 16:50:05 -0400 Date: Wed, 27 Jun 2018 22:50:02 +0200 Message-Id: <87vaa4vts5.fsf@gnu.org> To: control@debbugs.gnu.org From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=) Subject: control message for bug #31974 MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -6.0 (------) severity 31974 important From debbugs-submit-bounces@debbugs.gnu.org Thu Jun 28 01:10:50 2018 Received: (at 31974) by debbugs.gnu.org; 28 Jun 2018 05:10:50 +0000 Received: from localhost ([127.0.0.1]:38087 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fYPCk-0002A5-17 for submit@debbugs.gnu.org; Thu, 28 Jun 2018 01:10:50 -0400 Received: from world.peace.net ([64.112.178.59]:34142) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fYPCh-00029o-Ra for 31974@debbugs.gnu.org; Thu, 28 Jun 2018 01:10:48 -0400 Received: from mhw by world.peace.net with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1fYPCb-00029C-4y; Thu, 28 Jun 2018 01:10:41 -0400 From: Mark H Weaver To: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=) Subject: Re: bug#31974: If a phase returns #f, a warning is issued, but the build continues References: <87efgu8clc.fsf@netris.org> <87bmbwx9z2.fsf@gnu.org> Date: Thu, 28 Jun 2018 01:09:25 -0400 In-Reply-To: <87bmbwx9z2.fsf@gnu.org> ("Ludovic \=\?utf-8\?Q\?Court\=C3\=A8s\=22'\?\= \=\?utf-8\?Q\?s\?\= message of "Wed, 27 Jun 2018 22:14:57 +0200") Message-ID: <87y3ezqyyi.fsf@netris.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 31974 Cc: 31974@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) ludo@gnu.org (Ludovic Court=C3=A8s) writes: > Mark H Weaver skribis: > >> I just noticed that I made a mistake in commit >> d8a3b1b9e847d4a44d2695f95af77170d4d2788f, which changed 'gnu-build' in >> (guix build gnu-build-system) to issue a warning if a phase returns a >> value other than #t. >> >> The result is that if a phase returns a value other than #t, a warning >> is issued, but the build nonetheless continues to the next phase, and >> the build could ultimately "succeed" even some phases returned #f. >> >> In other words, the return values of phases are effectively ignored, >> except for the warning, so the only way to cause a build with phases to >> fail is to raise an exception. > > Thanks for the heads-up. In practice, I suppose many builds would > eventually fail anyway, but we=E2=80=99ll have to keep an eye on it. I grepped the build logs on Hydra from evaluation 110021 searching for the warning issued when a phase returns #f. Some of the build logs had been deleted, but of the builds whose logs are still present, these are the ones whose 'check' phase returned #f, but which nonetheless succeeded: aegis-4.24 (x86_64 i686) coq-8.8.0 (armhf) coq-gappa-1.3.2 (armhf) crawl-0.21.0 (armhf) gexiv2-0.10.8 (i686) java-eclipse-jetty-security-9.4.6 (x86_64) java-kafka-clients-1.0.0 (x86_64) maven-compat-3.5.3 (x86_64) ocaml-4.01.0 (armhf) python-django-1.11.11 (x86_64 i686) python-ptyprocess-0.5.2 (armhf) python2-astroid-1.5.3 (i686 armhf) python2-bz2file-0.98 (x86_64 i686 armhf) python2-dendropy-4.2.0 (i686) python2-django-1.11.11 (x86_64 i686) python2-django-allauth-0.30.0 (x86_64 i686) restic-0.9.1 (x86_64 i686) ruby-concurrent-1.0.5 (armhf) ruby-connection-pool-2.2.2 (i686) ruby-json-pure-2.1.0 (x86_64 i686) ruby-redcarpet-3.4.0 (i686 armhf) shaderc-0.0.0-2.be8e087 (x86_64 i686 armhf) skopeo-0.1.28 (i686) syncthing-0.14.48 (i686) Here are the ones where the 'build' phase returned #f: ocaml-gsl-1.19.3.drv (armhf) ocaml4.01-gsl-1.19.3.drv (armhf) scm-5f2.drv (i686 armhf) teeworlds-0.6.4.drv (armhf) And here are the ones where some other phase returned #f: gnome-dictionary-3.26.1.drv (x86_64 i686 armhf): ## WARNING: phase `inst= all' returned `#f'. hop-3.1.0-pre2.drv (armhf): ## WARNING: phase `conf= igure' returned `#f'. sorcer-1.1.3.drv (x86_64 i686 armhf): ## WARNING: phase `buil= d-faust-sources' returned `#f'. Here's a combined list with the derivations and links to the Hydra builds: https://hydra.gnu.org/build/2801304 | i686-linux | /gnu/store/1pzb1d2s03p= 6728wfifnhjxfbh02njik-aegis-4.24.drv https://hydra.gnu.org/build/2791716 | x86_64-linux | /gnu/store/sdhr6r50pch= w1c54gl6w3h7abnv9k63q-aegis-4.24.drv https://hydra.gnu.org/build/2842834 | armhf-linux | /gnu/store/6cd0sd5jllx= qw3q3g9s7z804f36kg9ll-coq-8.8.0.drv https://hydra.gnu.org/build/2841249 | armhf-linux | /gnu/store/77japmdnhrb= 9dws0cjak3lbkjmxkxvn9-coq-gappa-1.3.2.drv https://hydra.gnu.org/build/2805499 | armhf-linux | /gnu/store/mvf8j3fyp0w= q98yxr3fh8cdkyx8ap0ds-crawl-0.21.0.drv https://hydra.gnu.org/build/2797616 | i686-linux | /gnu/store/7h2zk83lpbh= 9ms41bhx5gpygi1rjv7nw-gexiv2-0.10.8.drv https://hydra.gnu.org/build/2841898 | armhf-linux | /gnu/store/ddgiz8db0y1= im3i3c2zh3j52wkkibas7-gnome-dictionary-3.26.1.drv https://hydra.gnu.org/build/2842705 | i686-linux | /gnu/store/lrgbx1qsz21= ylvdya8grx1rkpgr8zqa5-gnome-dictionary-3.26.1.drv https://hydra.gnu.org/build/2840885 | x86_64-linux | /gnu/store/fywqcpdgijb= bgc2w03wg57w76kzgrghn-gnome-dictionary-3.26.1.drv https://hydra.gnu.org/build/2842410 | x86_64-linux | /gnu/store/2jl85jn1q3l= lhzscy7b02x76izw5w284-java-eclipse-jetty-security-9.4.6.drv https://hydra.gnu.org/build/2841151 | x86_64-linux | /gnu/store/13cbi0mfhn4= 0dfa705q1bx77jayp0a5k-java-kafka-clients-1.0.0.drv https://hydra.gnu.org/build/2843944 | x86_64-linux | /gnu/store/wbc3fzqqvp4= f9nhn3f59bkd0kvjrvciz-maven-compat-3.5.3.drv https://hydra.gnu.org/build/2789087 | armhf-linux | /gnu/store/pkjxjs7rsrz= 5fn3m5vhs761prir1xiv7-ocaml-4.01.0.drv https://hydra.gnu.org/build/2843063 | armhf-linux | /gnu/store/93xqlng0ihn= g0xnxc3ilmw23malakp8q-ocaml-gsl-1.19.3.drv https://hydra.gnu.org/build/2815032 | armhf-linux | /gnu/store/gy1xv9n6q3n= h4bgwm42nzpqmc2gw8x2g-ocaml4.01-gsl-1.19.3.drv https://hydra.gnu.org/build/2839505 | i686-linux | /gnu/store/43nqys57lgy= 4z0ldxq983vl4vrxrzr4w-python-django-1.11.11.drv https://hydra.gnu.org/build/2840027 | x86_64-linux | /gnu/store/6nwm5zsfk5v= xj4vq5blckl7j4hyz246k-python-django-1.11.11.drv https://hydra.gnu.org/build/2791170 | armhf-linux | /gnu/store/0478c2n6cfp= x50viy95204dwwdqs3ggv-python-ptyprocess-0.5.2.drv https://hydra.gnu.org/build/2795214 | armhf-linux | /gnu/store/bxyr5vi0ilv= 2z3q5wfk6qfzl5ahl6hb7-python2-astroid-1.5.3.drv https://hydra.gnu.org/build/2795813 | i686-linux | /gnu/store/h4v2xcs0yyc= wn7dn4bjf8fci77bf7h05-python2-astroid-1.5.3.drv https://hydra.gnu.org/build/2799056 | armhf-linux | /gnu/store/jvbk35z3s5c= vyjs8a5ilz289k0gkgqmv-python2-bz2file-0.98.drv https://hydra.gnu.org/build/2798019 | i686-linux | /gnu/store/s19a20dlq6g= 4fm84jdgg8njvdl9ppz4d-python2-bz2file-0.98.drv https://hydra.gnu.org/build/2798128 | x86_64-linux | /gnu/store/0cln2r1ln15= avh0kmc6drwz756fc4bvv-python2-bz2file-0.98.drv https://hydra.gnu.org/build/2789737 | i686-linux | /gnu/store/d35bm2fjsmz= 4dzcavpd16khdg6pyfazr-python2-dendropy-4.2.0.drv https://hydra.gnu.org/build/2839515 | i686-linux | /gnu/store/y70lr6yk2ai= nc74j58fjdxyil2ys06qk-python2-django-1.11.11.drv https://hydra.gnu.org/build/2840426 | x86_64-linux | /gnu/store/bchmr8fynjh= 5j8zrfg9pxaqvm11vm1a6-python2-django-1.11.11.drv https://hydra.gnu.org/build/2842057 | i686-linux | /gnu/store/0v1dgqw1p8z= 96gi37i3ai958yl3zpj62-python2-django-allauth-0.30.0.drv https://hydra.gnu.org/build/2841037 | x86_64-linux | /gnu/store/9a7nx0pi3rs= 4nvy7nzif6frhlsa00qpz-python2-django-allauth-0.30.0.drv https://hydra.gnu.org/build/2843841 | i686-linux | /gnu/store/2wp8xbkipwm= 80zvh528whp4dgi3q8jya-restic-0.9.1.drv https://hydra.gnu.org/build/2843458 | x86_64-linux | /gnu/store/lbw8kyb4pzr= 550bi7b47zjzwgdybylix-restic-0.9.1.drv https://hydra.gnu.org/build/2796244 | armhf-linux | /gnu/store/4k62sq4dggy= i9xh10qsv2mihpz81d92q-ruby-concurrent-1.0.5.drv https://hydra.gnu.org/build/2789937 | i686-linux | /gnu/store/yc0rjldnjmp= 2m2b31y2q0kgn2956mvna-ruby-connection-pool-2.2.2.drv https://hydra.gnu.org/build/2842387 | i686-linux | /gnu/store/jqylsar0skx= z9l9mmxv1xx4xnl076y8y-ruby-json-pure-2.1.0.drv https://hydra.gnu.org/build/2841410 | x86_64-linux | /gnu/store/vj0xyabkyy8= jb5lih1j5zv0n7d7kr394-ruby-json-pure-2.1.0.drv https://hydra.gnu.org/build/2840802 | armhf-linux | /gnu/store/97wgys535pz= 9yi616arv1dkd3953vqa8-ruby-redcarpet-3.4.0.drv https://hydra.gnu.org/build/2842647 | i686-linux | /gnu/store/05mdymhhdhh= k3nr21xy4vnmjjv7f8wn7-ruby-redcarpet-3.4.0.drv https://hydra.gnu.org/build/2812123 | armhf-linux | /gnu/store/l7k1fywmmyc= 5fsrch9b15j86kcr3jwhd-shaderc-0.0.0-2.be8e087.drv https://hydra.gnu.org/build/2811921 | i686-linux | /gnu/store/y2qg306qp9x= 0yp0q6j69h4jpl7q4vk18-shaderc-0.0.0-2.be8e087.drv https://hydra.gnu.org/build/2811833 | x86_64-linux | /gnu/store/smax7jsialv= q2lhg6zf4wcxpnsqal7bv-shaderc-0.0.0-2.be8e087.drv https://hydra.gnu.org/build/2843817 | i686-linux | /gnu/store/7l5x373wrvh= lrcq2yqmfg0ghjddpv11l-skopeo-0.1.28.drv https://hydra.gnu.org/build/2842125 | armhf-linux | /gnu/store/c1ah46yc5yr= hizv4z0rkldpj45hg1mj2-sorcer-1.1.3.drv https://hydra.gnu.org/build/2841220 | i686-linux | /gnu/store/p5m5wjacj7j= 2yasn7419dv6xrpaflp23-sorcer-1.1.3.drv https://hydra.gnu.org/build/2840704 | x86_64-linux | /gnu/store/wix2rm45g4d= zn2l5rcnjbd1vlcyp0l32-sorcer-1.1.3.drv https://hydra.gnu.org/build/2844279 | i686-linux | /gnu/store/sjm4chzv7cv= 9nj0izvxlarvwlinpahwg-syncthing-0.14.48.drv Mark From debbugs-submit-bounces@debbugs.gnu.org Thu Jun 28 01:56:47 2018 Received: (at 31974) by debbugs.gnu.org; 28 Jun 2018 05:56:47 +0000 Received: from localhost ([127.0.0.1]:38093 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fYPvC-0003Hj-Rd for submit@debbugs.gnu.org; Thu, 28 Jun 2018 01:56:47 -0400 Received: from mail-it0-f54.google.com ([209.85.214.54]:35496) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fYPvA-0003HS-Cq for 31974@debbugs.gnu.org; Thu, 28 Jun 2018 01:56:45 -0400 Received: by mail-it0-f54.google.com with SMTP id l16-v6so10031084ita.0 for <31974@debbugs.gnu.org>; Wed, 27 Jun 2018 22:56:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Nk2Uee1MsV+3yAbqFVnyvkPIa0nOtMNrrZ8drGABRoU=; b=PWUoS2nP2RDXXP5Z7ooBwu931ECvoKgKuuM/1Q7Hlx0FasoT+ZOUHsw3zUcc39YCYp g1+0VsSDzuwxA+7Md+d124cus3NsfekwjOqTboFwum6vZlNt2Ew1PU+pM8842+xCsuX4 wirhOjEDPBd9SHOcKyq+CnDmp7TvieArPOVGCymZmRx44oVLZ5eB7qKNnevHOsQEHibb j8BrOr656YdmP8T1DKLvm2VQPOeo2L+bHFV3I5r8I93D6i638JUzTnop/ICPaRvjwHQE qYldsMLruA3W2vkJWN4F/3Au5t86j1AhZuWfvVU992Oga3cnld2HAsi194n19I17Q8fC LYMQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Nk2Uee1MsV+3yAbqFVnyvkPIa0nOtMNrrZ8drGABRoU=; b=HaVxnhkKbp1sxzn4flePdGTqYwIvxvTYwEa4KazdZwrePNV46zaWEhvn/CVDNqMdV6 5qH93JCMxFDK2XccCipyQUx7bU08JDIUajQ7iW0+DBFCt0CWN0xk+y8uPGfoD33HoB63 OhsrqyeBk0otMV+25uwuwNnlggM0UtTAKHo7vqOgME9vpMhl1O4PknOOxKW4iKIGqWNt TK24yz9q02RnfTkOamj4/qgXav/0NaHyl+Py2CrSgvzEY92UrtkhQ09gBnZbOa7sf2Du X55jK//EbJe57v3T3ULT2Efsm+o9syc6i9X85q8ZFsZ3Bjo1XJINdclqdqK627lqdIVc saFg== X-Gm-Message-State: APt69E0Bgz79RY8uRS12l8Uzuv3U79fvHiw5n8IH6FKNlMd9UlSgPPyJ bjYcBJDgqKqUT2Wma1PzWWwq5QZnqabLIgKbuw== X-Google-Smtp-Source: AAOMgpfxWrfQWzemwUgr3X2u3NpMLvWEM9SXIizU6hahO8OfJ6FeiY7dXG8iR8+PQ5ofyaQ14hQ3UfbPTruCKOoIf0Q= X-Received: by 2002:a24:50d1:: with SMTP id m200-v6mr7201830itb.11.1530165398689; Wed, 27 Jun 2018 22:56:38 -0700 (PDT) MIME-Version: 1.0 References: <87efgu8clc.fsf@netris.org> <87bmbwx9z2.fsf@gnu.org> <87y3ezqyyi.fsf@netris.org> In-Reply-To: <87y3ezqyyi.fsf@netris.org> From: =?UTF-8?Q?G=C3=A1bor_Boskovits?= Date: Thu, 28 Jun 2018 07:56:27 +0200 Message-ID: Subject: Re: bug#31974: If a phase returns #f, a warning is issued, but the build continues To: Mark H Weaver Content-Type: multipart/alternative; boundary="000000000000099040056fad652b" X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 31974 Cc: =?UTF-8?Q?Ludovic_Court=C3=A8s?= , 31974@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --000000000000099040056fad652b Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Mark H Weaver ezt =C3=ADrta (id=C5=91pont: 2018. j=C3=BAn.= 28., Cs, 7:11): > ludo@gnu.org (Ludovic Court=C3=A8s) writes: > > > Mark H Weaver skribis: > > > >> I just noticed that I made a mistake in commit > >> d8a3b1b9e847d4a44d2695f95af77170d4d2788f, which changed 'gnu-build' in > >> (guix build gnu-build-system) to issue a warning if a phase returns a > >> value other than #t. > >> > >> The result is that if a phase returns a value other than #t, a warning > >> is issued, but the build nonetheless continues to the next phase, and > >> the build could ultimately "succeed" even some phases returned #f. > >> > >> In other words, the return values of phases are effectively ignored, > >> except for the warning, so the only way to cause a build with phases t= o > >> fail is to raise an exception. > > > > Thanks for the heads-up. In practice, I suppose many builds would > > eventually fail anyway, but we=E2=80=99ll have to keep an eye on it. > > I grepped the build logs on Hydra from evaluation 110021 searching for > the warning issued when a phase returns #f. Some of the build logs had > been deleted, but of the builds whose logs are still present, these are > the ones whose 'check' phase returned #f, but which nonetheless > succeeded: > > aegis-4.24 (x86_64 i686) > coq-8.8.0 (armhf) > coq-gappa-1.3.2 (armhf) > crawl-0.21.0 (armhf) > gexiv2-0.10.8 (i686) > java-eclipse-jetty-security-9.4.6 (x86_64) > java-kafka-clients-1.0.0 (x86_64) > maven-compat-3.5.3 (x86_64) > Thanks, I will look at the two java and maven-compat. > ocaml-4.01.0 (armhf) > python-django-1.11.11 (x86_64 i686) > python-ptyprocess-0.5.2 (armhf) > python2-astroid-1.5.3 (i686 armhf) > python2-bz2file-0.98 (x86_64 i686 armhf) > python2-dendropy-4.2.0 (i686) > python2-django-1.11.11 (x86_64 i686) > python2-django-allauth-0.30.0 (x86_64 i686) > restic-0.9.1 (x86_64 i686) > ruby-concurrent-1.0.5 (armhf) > ruby-connection-pool-2.2.2 (i686) > ruby-json-pure-2.1.0 (x86_64 i686) > ruby-redcarpet-3.4.0 (i686 armhf) > shaderc-0.0.0-2.be8e087 (x86_64 i686 armhf) > skopeo-0.1.28 (i686) > syncthing-0.14.48 (i686) > > Here are the ones where the 'build' phase returned #f: > > ocaml-gsl-1.19.3.drv (armhf) > ocaml4.01-gsl-1.19.3.drv (armhf) > scm-5f2.drv (i686 armhf) > teeworlds-0.6.4.drv (armhf) > > And here are the ones where some other phase returned #f: > > gnome-dictionary-3.26.1.drv (x86_64 i686 armhf): ## WARNING: phase > `install' returned `#f'. > hop-3.1.0-pre2.drv (armhf): ## WARNING: phase > `configure' returned `#f'. > sorcer-1.1.3.drv (x86_64 i686 armhf): ## WARNING: phase > `build-faust-sources' returned `#f'. > > Here's a combined list with the derivations and links to the > Hydra builds: > > https://hydra.gnu.org/build/2801304 | i686-linux | > /gnu/store/1pzb1d2s03p6728wfifnhjxfbh02njik-aegis-4.24.drv > https://hydra.gnu.org/build/2791716 | x86_64-linux | > /gnu/store/sdhr6r50pchw1c54gl6w3h7abnv9k63q-aegis-4.24.drv > https://hydra.gnu.org/build/2842834 | armhf-linux | > /gnu/store/6cd0sd5jllxqw3q3g9s7z804f36kg9ll-coq-8.8.0.drv > https://hydra.gnu.org/build/2841249 | armhf-linux | > /gnu/store/77japmdnhrb9dws0cjak3lbkjmxkxvn9-coq-gappa-1.3.2.drv > https://hydra.gnu.org/build/2805499 | armhf-linux | > /gnu/store/mvf8j3fyp0wq98yxr3fh8cdkyx8ap0ds-crawl-0.21.0.drv > https://hydra.gnu.org/build/2797616 | i686-linux | > /gnu/store/7h2zk83lpbh9ms41bhx5gpygi1rjv7nw-gexiv2-0.10.8.drv > https://hydra.gnu.org/build/2841898 | armhf-linux | > /gnu/store/ddgiz8db0y1im3i3c2zh3j52wkkibas7-gnome-dictionary-3.26.1.drv > https://hydra.gnu.org/build/2842705 | i686-linux | > /gnu/store/lrgbx1qsz21ylvdya8grx1rkpgr8zqa5-gnome-dictionary-3.26.1.drv > https://hydra.gnu.org/build/2840885 | x86_64-linux | > /gnu/store/fywqcpdgijbbgc2w03wg57w76kzgrghn-gnome-dictionary-3.26.1.drv > https://hydra.gnu.org/build/2842410 | x86_64-linux | > /gnu/store/2jl85jn1q3llhzscy7b02x76izw5w284-java-eclipse-jetty-security-9= .4.6.drv > https://hydra.gnu.org/build/2841151 | x86_64-linux | > /gnu/store/13cbi0mfhn40dfa705q1bx77jayp0a5k-java-kafka-clients-1.0.0.drv > https://hydra.gnu.org/build/2843944 | x86_64-linux | > /gnu/store/wbc3fzqqvp4f9nhn3f59bkd0kvjrvciz-maven-compat-3.5.3.drv > https://hydra.gnu.org/build/2789087 | armhf-linux | > /gnu/store/pkjxjs7rsrz5fn3m5vhs761prir1xiv7-ocaml-4.01.0.drv > https://hydra.gnu.org/build/2843063 | armhf-linux | > /gnu/store/93xqlng0ihng0xnxc3ilmw23malakp8q-ocaml-gsl-1.19.3.drv > https://hydra.gnu.org/build/2815032 | armhf-linux | > /gnu/store/gy1xv9n6q3nh4bgwm42nzpqmc2gw8x2g-ocaml4.01-gsl-1.19.3.drv > https://hydra.gnu.org/build/2839505 | i686-linux | > /gnu/store/43nqys57lgy4z0ldxq983vl4vrxrzr4w-python-django-1.11.11.drv > https://hydra.gnu.org/build/2840027 | x86_64-linux | > /gnu/store/6nwm5zsfk5vxj4vq5blckl7j4hyz246k-python-django-1.11.11.drv > https://hydra.gnu.org/build/2791170 | armhf-linux | > /gnu/store/0478c2n6cfpx50viy95204dwwdqs3ggv-python-ptyprocess-0.5.2.drv > https://hydra.gnu.org/build/2795214 | armhf-linux | > /gnu/store/bxyr5vi0ilv2z3q5wfk6qfzl5ahl6hb7-python2-astroid-1.5.3.drv > https://hydra.gnu.org/build/2795813 | i686-linux | > /gnu/store/h4v2xcs0yycwn7dn4bjf8fci77bf7h05-python2-astroid-1.5.3.drv > https://hydra.gnu.org/build/2799056 | armhf-linux | > /gnu/store/jvbk35z3s5cvyjs8a5ilz289k0gkgqmv-python2-bz2file-0.98.drv > https://hydra.gnu.org/build/2798019 | i686-linux | > /gnu/store/s19a20dlq6g4fm84jdgg8njvdl9ppz4d-python2-bz2file-0.98.drv > https://hydra.gnu.org/build/2798128 | x86_64-linux | > /gnu/store/0cln2r1ln15avh0kmc6drwz756fc4bvv-python2-bz2file-0.98.drv > https://hydra.gnu.org/build/2789737 | i686-linux | > /gnu/store/d35bm2fjsmz4dzcavpd16khdg6pyfazr-python2-dendropy-4.2.0.drv > https://hydra.gnu.org/build/2839515 | i686-linux | > /gnu/store/y70lr6yk2ainc74j58fjdxyil2ys06qk-python2-django-1.11.11.drv > https://hydra.gnu.org/build/2840426 | x86_64-linux | > /gnu/store/bchmr8fynjh5j8zrfg9pxaqvm11vm1a6-python2-django-1.11.11.drv > https://hydra.gnu.org/build/2842057 | i686-linux | > /gnu/store/0v1dgqw1p8z96gi37i3ai958yl3zpj62-python2-django-allauth-0.30.0= .drv > https://hydra.gnu.org/build/2841037 | x86_64-linux | > /gnu/store/9a7nx0pi3rs4nvy7nzif6frhlsa00qpz-python2-django-allauth-0.30.0= .drv > https://hydra.gnu.org/build/2843841 | i686-linux | > /gnu/store/2wp8xbkipwm80zvh528whp4dgi3q8jya-restic-0.9.1.drv > https://hydra.gnu.org/build/2843458 | x86_64-linux | > /gnu/store/lbw8kyb4pzr550bi7b47zjzwgdybylix-restic-0.9.1.drv > https://hydra.gnu.org/build/2796244 | armhf-linux | > /gnu/store/4k62sq4dggyi9xh10qsv2mihpz81d92q-ruby-concurrent-1.0.5.drv > https://hydra.gnu.org/build/2789937 | i686-linux | > /gnu/store/yc0rjldnjmp2m2b31y2q0kgn2956mvna-ruby-connection-pool-2.2.2.dr= v > https://hydra.gnu.org/build/2842387 | i686-linux | > /gnu/store/jqylsar0skxz9l9mmxv1xx4xnl076y8y-ruby-json-pure-2.1.0.drv > https://hydra.gnu.org/build/2841410 | x86_64-linux | > /gnu/store/vj0xyabkyy8jb5lih1j5zv0n7d7kr394-ruby-json-pure-2.1.0.drv > https://hydra.gnu.org/build/2840802 | armhf-linux | > /gnu/store/97wgys535pz9yi616arv1dkd3953vqa8-ruby-redcarpet-3.4.0.drv > https://hydra.gnu.org/build/2842647 | i686-linux | > /gnu/store/05mdymhhdhhk3nr21xy4vnmjjv7f8wn7-ruby-redcarpet-3.4.0.drv > https://hydra.gnu.org/build/2812123 | armhf-linux | > /gnu/store/l7k1fywmmyc5fsrch9b15j86kcr3jwhd-shaderc-0.0.0-2.be8e087.drv > https://hydra.gnu.org/build/2811921 | i686-linux | > /gnu/store/y2qg306qp9x0yp0q6j69h4jpl7q4vk18-shaderc-0.0.0-2.be8e087.drv > https://hydra.gnu.org/build/2811833 | x86_64-linux | > /gnu/store/smax7jsialvq2lhg6zf4wcxpnsqal7bv-shaderc-0.0.0-2.be8e087.drv > https://hydra.gnu.org/build/2843817 | i686-linux | > /gnu/store/7l5x373wrvhlrcq2yqmfg0ghjddpv11l-skopeo-0.1.28.drv > https://hydra.gnu.org/build/2842125 | armhf-linux | > /gnu/store/c1ah46yc5yrhizv4z0rkldpj45hg1mj2-sorcer-1.1.3.drv > https://hydra.gnu.org/build/2841220 | i686-linux | > /gnu/store/p5m5wjacj7j2yasn7419dv6xrpaflp23-sorcer-1.1.3.drv > https://hydra.gnu.org/build/2840704 | x86_64-linux | > /gnu/store/wix2rm45g4dzn2l5rcnjbd1vlcyp0l32-sorcer-1.1.3.drv > https://hydra.gnu.org/build/2844279 | i686-linux | > /gnu/store/sjm4chzv7cv9nj0izvxlarvwlinpahwg-syncthing-0.14.48.drv > > Mark > > > > --000000000000099040056fad652b Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Mark H Weaver = <mhw@netris.org> ezt =C3=ADrta = (id=C5=91pont: 2018. j=C3=BAn. 28., Cs, 7:11):
ludo@gnu.or= g (Ludovic Court=C3=A8s) writes:

> Mark H Weaver <= mhw@netris.org> skribis:
>
>> I just noticed that I made a mistake in commit
>> d8a3b1b9e847d4a44d2695f95af77170d4d2788f, which changed 'gnu-b= uild' in
>> (guix build gnu-build-system) to issue a warning if a phase return= s a
>> value other than #t.
>>
>> The result is that if a phase returns a value other than #t, a war= ning
>> is issued, but the build nonetheless continues to the next phase, = and
>> the build could ultimately "succeed" even some phases re= turned #f.
>>
>> In other words, the return values of phases are effectively ignore= d,
>> except for the warning, so the only way to cause a build with phas= es to
>> fail is to raise an exception.
>
> Thanks for the heads-up.=C2=A0 In practice, I suppose many builds woul= d
> eventually fail anyway, but we=E2=80=99ll have to keep an eye on it.
I grepped the build logs on Hydra from evaluation 110021 searching for
the warning issued when a phase returns #f.=C2=A0 Some of the build logs ha= d
been deleted, but of the builds whose logs are still present, these are
the ones whose 'check' phase returned #f, but which nonetheless
succeeded:

=C2=A0 aegis-4.24 (x86_64 i686)
=C2=A0 coq-8.8.0 (armhf)
=C2=A0 coq-gappa-1.3.2 (armhf)
=C2=A0 crawl-0.21.0 (armhf)
=C2=A0 gexiv2-0.10.8 (i686)
=C2=A0 java-eclipse-jetty-security-9.4.6 (x86_64)
=C2=A0 java-kafka-clients-1.0.0 (x86_64)
=C2=A0 maven-compat-3.5.3 (x86_64)

Thanks, I will look at the two java and ma= ven-compat.
=C2=A0
=C2=A0 o= caml-4.01.0 (armhf)
=C2=A0 python-django-1.11.11 (x86_64 i686)
=C2=A0 python-ptyprocess-0.5.2 (armhf)
=C2=A0 python2-astroid-1.5.3 (i686 armhf)
=C2=A0 python2-bz2file-0.98 (x86_64 i686 armhf)
=C2=A0 python2-dendropy-4.2.0 (i686)
=C2=A0 python2-django-1.11.11 (x86_64 i686)
=C2=A0 python2-django-allauth-0.30.0 (x86_64 i686)
=C2=A0 restic-0.9.1 (x86_64 i686)
=C2=A0 ruby-concurrent-1.0.5 (armhf)
=C2=A0 ruby-connection-pool-2.2.2 (i686)
=C2=A0 ruby-json-pure-2.1.0 (x86_64 i686)
=C2=A0 ruby-redcarpet-3.4.0 (i686 armhf)
=C2=A0 shaderc-0.0.0-2.be8e087 (x86_64 i686 armhf)
=C2=A0 skopeo-0.1.28 (i686)
=C2=A0 syncthing-0.14.48 (i686)

Here are the ones where the 'build' phase returned #f:

=C2=A0 ocaml-gsl-1.19.3.drv (armhf)
=C2=A0 ocaml4.01-gsl-1.19.3.drv (armhf)
=C2=A0 scm-5f2.drv (i686 armhf)
=C2=A0 teeworlds-0.6.4.drv (armhf)

And here are the ones where some other phase returned #f:

=C2=A0 gnome-dictionary-3.26.1.drv (x86_64 i686 armhf):=C2=A0 ## WARNING: p= hase `install' returned `#f'.
=C2=A0 hop-3.1.0-pre2.drv (armhf):=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0= =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0## WARNING: phase `configure'= returned `#f'.
=C2=A0 sorcer-1.1.3.drv (x86_64 i686 armhf):=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0## WARNING: phase `build-faust-sources' returned `#f&#= 39;.

Here's a combined list with the derivations and links to the
Hydra builds:

https://hydra.gnu.org/build/2801304 | i686-linux=C2=A0 =C2= =A0| /gnu/store/1pzb1d2s03p6728wfifnhjxfbh02njik-aegis-4.24.drv
https://hydra.gnu.org/build/2791716 | x86_64-linux | /gnu/s= tore/sdhr6r50pchw1c54gl6w3h7abnv9k63q-aegis-4.24.drv
https://hydra.gnu.org/build/2842834 | armhf-linux=C2=A0 | /= gnu/store/6cd0sd5jllxqw3q3g9s7z804f36kg9ll-coq-8.8.0.drv
https://hydra.gnu.org/build/2841249 | armhf-linux=C2=A0 | /= gnu/store/77japmdnhrb9dws0cjak3lbkjmxkxvn9-coq-gappa-1.3.2.drv
https://hydra.gnu.org/build/2805499 | armhf-linux=C2=A0 | /= gnu/store/mvf8j3fyp0wq98yxr3fh8cdkyx8ap0ds-crawl-0.21.0.drv
https://hydra.gnu.org/build/2797616 | i686-linux=C2=A0 =C2= =A0| /gnu/store/7h2zk83lpbh9ms41bhx5gpygi1rjv7nw-gexiv2-0.10.8.drv
https://hydra.gnu.org/build/2841898 | armhf-linux=C2=A0 | /= gnu/store/ddgiz8db0y1im3i3c2zh3j52wkkibas7-gnome-dictionary-3.26.1.drv
https://hydra.gnu.org/build/2842705 | i686-linux=C2=A0 =C2= =A0| /gnu/store/lrgbx1qsz21ylvdya8grx1rkpgr8zqa5-gnome-dictionary-3.26.1.dr= v
https://hydra.gnu.org/build/2840885 | x86_64-linux | /gnu/s= tore/fywqcpdgijbbgc2w03wg57w76kzgrghn-gnome-dictionary-3.26.1.drv
https://hydra.gnu.org/build/2842410 | x86_64-linux | /gnu/s= tore/2jl85jn1q3llhzscy7b02x76izw5w284-java-eclipse-jetty-security-9.4.6.drv=
https://hydra.gnu.org/build/2841151 | x86_64-linux | /gnu/s= tore/13cbi0mfhn40dfa705q1bx77jayp0a5k-java-kafka-clients-1.0.0.drv
https://hydra.gnu.org/build/2843944 | x86_64-linux | /gnu/s= tore/wbc3fzqqvp4f9nhn3f59bkd0kvjrvciz-maven-compat-3.5.3.drv
https://hydra.gnu.org/build/2789087 | armhf-linux=C2=A0 | /= gnu/store/pkjxjs7rsrz5fn3m5vhs761prir1xiv7-ocaml-4.01.0.drv
https://hydra.gnu.org/build/2843063 | armhf-linux=C2=A0 | /= gnu/store/93xqlng0ihng0xnxc3ilmw23malakp8q-ocaml-gsl-1.19.3.drv
https://hydra.gnu.org/build/2815032 | armhf-linux=C2=A0 | /= gnu/store/gy1xv9n6q3nh4bgwm42nzpqmc2gw8x2g-ocaml4.01-gsl-1.19.3.drv
https://hydra.gnu.org/build/2839505 | i686-linux=C2=A0 =C2= =A0| /gnu/store/43nqys57lgy4z0ldxq983vl4vrxrzr4w-python-django-1.11.11.drv<= br> https://hydra.gnu.org/build/2840027 | x86_64-linux | /gnu/s= tore/6nwm5zsfk5vxj4vq5blckl7j4hyz246k-python-django-1.11.11.drv
https://hydra.gnu.org/build/2791170 | armhf-linux=C2=A0 | /= gnu/store/0478c2n6cfpx50viy95204dwwdqs3ggv-python-ptyprocess-0.5.2.drv
https://hydra.gnu.org/build/2795214 | armhf-linux=C2=A0 | /= gnu/store/bxyr5vi0ilv2z3q5wfk6qfzl5ahl6hb7-python2-astroid-1.5.3.drv
https://hydra.gnu.org/build/2795813 | i686-linux=C2=A0 =C2= =A0| /gnu/store/h4v2xcs0yycwn7dn4bjf8fci77bf7h05-python2-astroid-1.5.3.drv<= br> https://hydra.gnu.org/build/2799056 | armhf-linux=C2=A0 | /= gnu/store/jvbk35z3s5cvyjs8a5ilz289k0gkgqmv-python2-bz2file-0.98.drv
https://hydra.gnu.org/build/2798019 | i686-linux=C2=A0 =C2= =A0| /gnu/store/s19a20dlq6g4fm84jdgg8njvdl9ppz4d-python2-bz2file-0.98.drv https://hydra.gnu.org/build/2798128 | x86_64-linux | /gnu/s= tore/0cln2r1ln15avh0kmc6drwz756fc4bvv-python2-bz2file-0.98.drv
https://hydra.gnu.org/build/2789737 | i686-linux=C2=A0 =C2= =A0| /gnu/store/d35bm2fjsmz4dzcavpd16khdg6pyfazr-python2-dendropy-4.2.0.drv=
https://hydra.gnu.org/build/2839515 | i686-linux=C2=A0 =C2= =A0| /gnu/store/y70lr6yk2ainc74j58fjdxyil2ys06qk-python2-django-1.11.11.drv=
https://hydra.gnu.org/build/2840426 | x86_64-linux | /gnu/s= tore/bchmr8fynjh5j8zrfg9pxaqvm11vm1a6-python2-django-1.11.11.drv
https://hydra.gnu.org/build/2842057 | i686-linux=C2=A0 =C2= =A0| /gnu/store/0v1dgqw1p8z96gi37i3ai958yl3zpj62-python2-django-allauth-0.3= 0.0.drv
https://hydra.gnu.org/build/2841037 | x86_64-linux | /gnu/s= tore/9a7nx0pi3rs4nvy7nzif6frhlsa00qpz-python2-django-allauth-0.30.0.drv
https://hydra.gnu.org/build/2843841 | i686-linux=C2=A0 =C2= =A0| /gnu/store/2wp8xbkipwm80zvh528whp4dgi3q8jya-restic-0.9.1.drv
https://hydra.gnu.org/build/2843458 | x86_64-linux | /gnu/s= tore/lbw8kyb4pzr550bi7b47zjzwgdybylix-restic-0.9.1.drv
https://hydra.gnu.org/build/2796244 | armhf-linux=C2=A0 | /= gnu/store/4k62sq4dggyi9xh10qsv2mihpz81d92q-ruby-concurrent-1.0.5.drv
https://hydra.gnu.org/build/2789937 | i686-linux=C2=A0 =C2= =A0| /gnu/store/yc0rjldnjmp2m2b31y2q0kgn2956mvna-ruby-connection-pool-2.2.2= .drv
https://hydra.gnu.org/build/2842387 | i686-linux=C2=A0 =C2= =A0| /gnu/store/jqylsar0skxz9l9mmxv1xx4xnl076y8y-ruby-json-pure-2.1.0.drv https://hydra.gnu.org/build/2841410 | x86_64-linux | /gnu/s= tore/vj0xyabkyy8jb5lih1j5zv0n7d7kr394-ruby-json-pure-2.1.0.drv
https://hydra.gnu.org/build/2840802 | armhf-linux=C2=A0 | /= gnu/store/97wgys535pz9yi616arv1dkd3953vqa8-ruby-redcarpet-3.4.0.drv
https://hydra.gnu.org/build/2842647 | i686-linux=C2=A0 =C2= =A0| /gnu/store/05mdymhhdhhk3nr21xy4vnmjjv7f8wn7-ruby-redcarpet-3.4.0.drv https://hydra.gnu.org/build/2812123 | armhf-linux=C2=A0 | /= gnu/store/l7k1fywmmyc5fsrch9b15j86kcr3jwhd-shaderc-0.0.0-2.be8e087.drv
https://hydra.gnu.org/build/2811921 | i686-linux=C2=A0 =C2= =A0| /gnu/store/y2qg306qp9x0yp0q6j69h4jpl7q4vk18-shaderc-0.0.0-2.be8e087.dr= v
https://hydra.gnu.org/build/2811833 | x86_64-linux | /gnu/s= tore/smax7jsialvq2lhg6zf4wcxpnsqal7bv-shaderc-0.0.0-2.be8e087.drv
https://hydra.gnu.org/build/2843817 | i686-linux=C2=A0 =C2= =A0| /gnu/store/7l5x373wrvhlrcq2yqmfg0ghjddpv11l-skopeo-0.1.28.drv
https://hydra.gnu.org/build/2842125 | armhf-linux=C2=A0 | /= gnu/store/c1ah46yc5yrhizv4z0rkldpj45hg1mj2-sorcer-1.1.3.drv
https://hydra.gnu.org/build/2841220 | i686-linux=C2=A0 =C2= =A0| /gnu/store/p5m5wjacj7j2yasn7419dv6xrpaflp23-sorcer-1.1.3.drv
https://hydra.gnu.org/build/2840704 | x86_64-linux | /gnu/s= tore/wix2rm45g4dzn2l5rcnjbd1vlcyp0l32-sorcer-1.1.3.drv
https://hydra.gnu.org/build/2844279 | i686-linux=C2=A0 =C2= =A0| /gnu/store/sjm4chzv7cv9nj0izvxlarvwlinpahwg-syncthing-0.14.48.drv

=C2=A0 =C2=A0 =C2=A0 =C2=A0Mark



--000000000000099040056fad652b-- From debbugs-submit-bounces@debbugs.gnu.org Thu Jun 28 11:11:07 2018 Received: (at 31974) by debbugs.gnu.org; 28 Jun 2018 15:11:07 +0000 Received: from localhost ([127.0.0.1]:38733 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fYYZe-0002gH-QT for submit@debbugs.gnu.org; Thu, 28 Jun 2018 11:11:06 -0400 Received: from eggs.gnu.org ([208.118.235.92]:36229) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fYYZb-0002fl-R6 for 31974@debbugs.gnu.org; Thu, 28 Jun 2018 11:11:04 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fYYZS-00071r-HI for 31974@debbugs.gnu.org; Thu, 28 Jun 2018 11:10:58 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:41616) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fYYZS-00071Y-EY; Thu, 28 Jun 2018 11:10:54 -0400 Received: from [193.50.110.150] (port=56176 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1fYYZS-0008PW-1a; Thu, 28 Jun 2018 11:10:54 -0400 From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=) To: Mark H Weaver Subject: Re: bug#31974: If a phase returns #f, a warning is issued, but the build continues References: <87efgu8clc.fsf@netris.org> <87bmbwx9z2.fsf@gnu.org> <87y3ezqyyi.fsf@netris.org> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: 10 Messidor an 226 de la =?utf-8?Q?R=C3=A9volution?= X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-pc-linux-gnu Date: Thu, 28 Jun 2018 17:10:51 +0200 In-Reply-To: <87y3ezqyyi.fsf@netris.org> (Mark H. Weaver's message of "Thu, 28 Jun 2018 01:09:25 -0400") Message-ID: <87efgr3q10.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 31974 Cc: 31974@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -6.0 (------) Hello, Mark H Weaver skribis: > I grepped the build logs on Hydra from evaluation 110021 searching for > the warning issued when a phase returns #f. Some of the build logs had > been deleted, but of the builds whose logs are still present, these are > the ones whose 'check' phase returned #f, but which nonetheless > succeeded: Are these builds that succeeded despite these #f returns? The =E2=80=98check=E2=80=99 phase is a serious issue that I had overlooked;= in effect, everything is as if we were not running tests. Thanks for investigating! Ludo=E2=80=99. From debbugs-submit-bounces@debbugs.gnu.org Thu Jun 28 11:47:16 2018 Received: (at 31974) by debbugs.gnu.org; 28 Jun 2018 15:47:16 +0000 Received: from localhost ([127.0.0.1]:38762 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fYZ8d-0003XS-2W for submit@debbugs.gnu.org; Thu, 28 Jun 2018 11:47:15 -0400 Received: from mail-io0-f177.google.com ([209.85.223.177]:34565) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fYZ8b-0003XF-9r for 31974@debbugs.gnu.org; Thu, 28 Jun 2018 11:47:14 -0400 Received: by mail-io0-f177.google.com with SMTP id e15-v6so5695170iog.1 for <31974@debbugs.gnu.org>; Thu, 28 Jun 2018 08:47:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=lL7vJ6iWfIr+Dc8BpLvJBtjU2GZUbn1HBLvMtILdXqw=; b=Z0UeYKCOMC/O9oq+6Ole+LB6XcOwSUgdttn7NXNqwJntVJLLyM7S0QUQAggC6N3u8V Gj8A3zNP9sinT12WFxSP/zYv9PEj44UcHnJZMYZ3Dp5VEKY8NwU4O896wHOQBwZKH76b gaaKPaP0HjIYfdpmZoag41T51gQynxpHF//9b5lrGi8XAvbX2i7/rTvs+k65tqnMxQKe oc7mqgGH2xJChAGmiofMI+YfoOfdkXBnVG/bqdiIRW7u1ayVqfGUadqIbEBIBrFlv/5h iayNuYQZjZIfKvgdgpRYa+nLsUP3LExNVHF0aS+PWpjOqrNbBM0FbYQJ+Szk7EZGVnZq uCCw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=lL7vJ6iWfIr+Dc8BpLvJBtjU2GZUbn1HBLvMtILdXqw=; b=LQ5L1vdW6NzkSDT6e5H9W3Q4BPLSzgpeXm+GktBGBhs0nfIoyDvhtEI3loBJjQv4bl Dk+olzaPHcU9oh64+QYzqa/d+QB/JFHeKt/0wX4lgtbHxfICSjeclziDQrISmYfHmpkN U2YNbYCTPLTQo0GGeNneR8zfb7GQYEDEZ3jyqZWy0e/StzAvo7BJtUQWvCZVIeSv/XyI r+lj62P8elkm9wiqsd9XVqKWyj4dMVC+qUWrfVjX6n6dxv7wJSQtd1j9ElR2ovN3Qwkp YPouu3OUNgg1rQEd6+kM7BCiKF570GJho4mYfluupZplqWaZB3I8pe8uL5Jw+M2qn1mc rOGw== X-Gm-Message-State: APt69E2wJ6f7eUYnYxH2wdMs+pS1AFd7ivWU8ubDAShHfMlh5tHWtU4D Ut2aJnA1T4Un0gO/5n7PqB9667T7mhxpYoMk/A== X-Google-Smtp-Source: AAOMgpddIkV3tUS8r2cbyNXNfZWvu8pV/m1W0W7P8TCuKARX+PPJPmewQQP3hN6kBmMa4K6H7Mn5Rl5JvEVkHPW4TmE= X-Received: by 2002:a5e:940c:: with SMTP id q12-v6mr8510459ioj.224.1530200827876; Thu, 28 Jun 2018 08:47:07 -0700 (PDT) MIME-Version: 1.0 References: <87efgu8clc.fsf@netris.org> <87bmbwx9z2.fsf@gnu.org> <87y3ezqyyi.fsf@netris.org> In-Reply-To: From: =?UTF-8?Q?G=C3=A1bor_Boskovits?= Date: Thu, 28 Jun 2018 17:46:56 +0200 Message-ID: Subject: Re: bug#31974: If a phase returns #f, a warning is issued, but the build continues To: Mark H Weaver Content-Type: multipart/alternative; boundary="000000000000c7db80056fb5a449" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 31974 Cc: =?UTF-8?Q?Ludovic_Court=C3=A8s?= , 31974@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --000000000000c7db80056fb5a449 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable G=C3=A1bor Boskovits ezt =C3=ADrta (id=C5=91pont: 201= 8. j=C3=BAn. 28., Cs, 7:56): > Mark H Weaver ezt =C3=ADrta (id=C5=91pont: 2018. j=C3=BA= n. 28., Cs, > 7:11): > >> ludo@gnu.org (Ludovic Court=C3=A8s) writes: >> >> > Mark H Weaver skribis: >> > >> >> I just noticed that I made a mistake in commit >> >> d8a3b1b9e847d4a44d2695f95af77170d4d2788f, which changed 'gnu-build' i= n >> >> (guix build gnu-build-system) to issue a warning if a phase returns a >> >> value other than #t. >> >> >> >> The result is that if a phase returns a value other than #t, a warnin= g >> >> is issued, but the build nonetheless continues to the next phase, and >> >> the build could ultimately "succeed" even some phases returned #f. >> >> >> >> In other words, the return values of phases are effectively ignored, >> >> except for the warning, so the only way to cause a build with phases = to >> >> fail is to raise an exception. >> > >> > Thanks for the heads-up. In practice, I suppose many builds would >> > eventually fail anyway, but we=E2=80=99ll have to keep an eye on it. >> >> I grepped the build logs on Hydra from evaluation 110021 searching for >> the warning issued when a phase returns #f. Some of the build logs had >> been deleted, but of the builds whose logs are still present, these are >> the ones whose 'check' phase returned #f, but which nonetheless >> succeeded: >> >> aegis-4.24 (x86_64 i686) >> coq-8.8.0 (armhf) >> coq-gappa-1.3.2 (armhf) >> crawl-0.21.0 (armhf) >> gexiv2-0.10.8 (i686) >> java-eclipse-jetty-security-9.4.6 (x86_64) >> java-kafka-clients-1.0.0 (x86_64) >> maven-compat-3.5.3 (x86_64) >> > > Thanks, I will look at the two java and maven-compat. > java-eclipse-jetty-security fixed. > > >> ocaml-4.01.0 (armhf) >> python-django-1.11.11 (x86_64 i686) >> python-ptyprocess-0.5.2 (armhf) >> python2-astroid-1.5.3 (i686 armhf) >> python2-bz2file-0.98 (x86_64 i686 armhf) >> python2-dendropy-4.2.0 (i686) >> python2-django-1.11.11 (x86_64 i686) >> python2-django-allauth-0.30.0 (x86_64 i686) >> restic-0.9.1 (x86_64 i686) >> ruby-concurrent-1.0.5 (armhf) >> ruby-connection-pool-2.2.2 (i686) >> ruby-json-pure-2.1.0 (x86_64 i686) >> ruby-redcarpet-3.4.0 (i686 armhf) >> shaderc-0.0.0-2.be8e087 (x86_64 i686 armhf) >> skopeo-0.1.28 (i686) >> syncthing-0.14.48 (i686) >> >> Here are the ones where the 'build' phase returned #f: >> >> ocaml-gsl-1.19.3.drv (armhf) >> ocaml4.01-gsl-1.19.3.drv (armhf) >> scm-5f2.drv (i686 armhf) >> teeworlds-0.6.4.drv (armhf) >> >> And here are the ones where some other phase returned #f: >> >> gnome-dictionary-3.26.1.drv (x86_64 i686 armhf): ## WARNING: phase >> `install' returned `#f'. >> hop-3.1.0-pre2.drv (armhf): ## WARNING: phase >> `configure' returned `#f'. >> sorcer-1.1.3.drv (x86_64 i686 armhf): ## WARNING: phase >> `build-faust-sources' returned `#f'. >> >> Here's a combined list with the derivations and links to the >> Hydra builds: >> >> https://hydra.gnu.org/build/2801304 | i686-linux | >> /gnu/store/1pzb1d2s03p6728wfifnhjxfbh02njik-aegis-4.24.drv >> https://hydra.gnu.org/build/2791716 | x86_64-linux | >> /gnu/store/sdhr6r50pchw1c54gl6w3h7abnv9k63q-aegis-4.24.drv >> https://hydra.gnu.org/build/2842834 | armhf-linux | >> /gnu/store/6cd0sd5jllxqw3q3g9s7z804f36kg9ll-coq-8.8.0.drv >> https://hydra.gnu.org/build/2841249 | armhf-linux | >> /gnu/store/77japmdnhrb9dws0cjak3lbkjmxkxvn9-coq-gappa-1.3.2.drv >> https://hydra.gnu.org/build/2805499 | armhf-linux | >> /gnu/store/mvf8j3fyp0wq98yxr3fh8cdkyx8ap0ds-crawl-0.21.0.drv >> https://hydra.gnu.org/build/2797616 | i686-linux | >> /gnu/store/7h2zk83lpbh9ms41bhx5gpygi1rjv7nw-gexiv2-0.10.8.drv >> https://hydra.gnu.org/build/2841898 | armhf-linux | >> /gnu/store/ddgiz8db0y1im3i3c2zh3j52wkkibas7-gnome-dictionary-3.26.1.drv >> https://hydra.gnu.org/build/2842705 | i686-linux | >> /gnu/store/lrgbx1qsz21ylvdya8grx1rkpgr8zqa5-gnome-dictionary-3.26.1.drv >> https://hydra.gnu.org/build/2840885 | x86_64-linux | >> /gnu/store/fywqcpdgijbbgc2w03wg57w76kzgrghn-gnome-dictionary-3.26.1.drv >> https://hydra.gnu.org/build/2842410 | x86_64-linux | >> /gnu/store/2jl85jn1q3llhzscy7b02x76izw5w284-java-eclipse-jetty-security-= 9.4.6.drv >> https://hydra.gnu.org/build/2841151 | x86_64-linux | >> /gnu/store/13cbi0mfhn40dfa705q1bx77jayp0a5k-java-kafka-clients-1.0.0.drv >> https://hydra.gnu.org/build/2843944 | x86_64-linux | >> /gnu/store/wbc3fzqqvp4f9nhn3f59bkd0kvjrvciz-maven-compat-3.5.3.drv >> https://hydra.gnu.org/build/2789087 | armhf-linux | >> /gnu/store/pkjxjs7rsrz5fn3m5vhs761prir1xiv7-ocaml-4.01.0.drv >> https://hydra.gnu.org/build/2843063 | armhf-linux | >> /gnu/store/93xqlng0ihng0xnxc3ilmw23malakp8q-ocaml-gsl-1.19.3.drv >> https://hydra.gnu.org/build/2815032 | armhf-linux | >> /gnu/store/gy1xv9n6q3nh4bgwm42nzpqmc2gw8x2g-ocaml4.01-gsl-1.19.3.drv >> https://hydra.gnu.org/build/2839505 | i686-linux | >> /gnu/store/43nqys57lgy4z0ldxq983vl4vrxrzr4w-python-django-1.11.11.drv >> https://hydra.gnu.org/build/2840027 | x86_64-linux | >> /gnu/store/6nwm5zsfk5vxj4vq5blckl7j4hyz246k-python-django-1.11.11.drv >> https://hydra.gnu.org/build/2791170 | armhf-linux | >> /gnu/store/0478c2n6cfpx50viy95204dwwdqs3ggv-python-ptyprocess-0.5.2.drv >> https://hydra.gnu.org/build/2795214 | armhf-linux | >> /gnu/store/bxyr5vi0ilv2z3q5wfk6qfzl5ahl6hb7-python2-astroid-1.5.3.drv >> https://hydra.gnu.org/build/2795813 | i686-linux | >> /gnu/store/h4v2xcs0yycwn7dn4bjf8fci77bf7h05-python2-astroid-1.5.3.drv >> https://hydra.gnu.org/build/2799056 | armhf-linux | >> /gnu/store/jvbk35z3s5cvyjs8a5ilz289k0gkgqmv-python2-bz2file-0.98.drv >> https://hydra.gnu.org/build/2798019 | i686-linux | >> /gnu/store/s19a20dlq6g4fm84jdgg8njvdl9ppz4d-python2-bz2file-0.98.drv >> https://hydra.gnu.org/build/2798128 | x86_64-linux | >> /gnu/store/0cln2r1ln15avh0kmc6drwz756fc4bvv-python2-bz2file-0.98.drv >> https://hydra.gnu.org/build/2789737 | i686-linux | >> /gnu/store/d35bm2fjsmz4dzcavpd16khdg6pyfazr-python2-dendropy-4.2.0.drv >> https://hydra.gnu.org/build/2839515 | i686-linux | >> /gnu/store/y70lr6yk2ainc74j58fjdxyil2ys06qk-python2-django-1.11.11.drv >> https://hydra.gnu.org/build/2840426 | x86_64-linux | >> /gnu/store/bchmr8fynjh5j8zrfg9pxaqvm11vm1a6-python2-django-1.11.11.drv >> https://hydra.gnu.org/build/2842057 | i686-linux | >> /gnu/store/0v1dgqw1p8z96gi37i3ai958yl3zpj62-python2-django-allauth-0.30.= 0.drv >> https://hydra.gnu.org/build/2841037 | x86_64-linux | >> /gnu/store/9a7nx0pi3rs4nvy7nzif6frhlsa00qpz-python2-django-allauth-0.30.= 0.drv >> https://hydra.gnu.org/build/2843841 | i686-linux | >> /gnu/store/2wp8xbkipwm80zvh528whp4dgi3q8jya-restic-0.9.1.drv >> https://hydra.gnu.org/build/2843458 | x86_64-linux | >> /gnu/store/lbw8kyb4pzr550bi7b47zjzwgdybylix-restic-0.9.1.drv >> https://hydra.gnu.org/build/2796244 | armhf-linux | >> /gnu/store/4k62sq4dggyi9xh10qsv2mihpz81d92q-ruby-concurrent-1.0.5.drv >> https://hydra.gnu.org/build/2789937 | i686-linux | >> /gnu/store/yc0rjldnjmp2m2b31y2q0kgn2956mvna-ruby-connection-pool-2.2.2.d= rv >> https://hydra.gnu.org/build/2842387 | i686-linux | >> /gnu/store/jqylsar0skxz9l9mmxv1xx4xnl076y8y-ruby-json-pure-2.1.0.drv >> https://hydra.gnu.org/build/2841410 | x86_64-linux | >> /gnu/store/vj0xyabkyy8jb5lih1j5zv0n7d7kr394-ruby-json-pure-2.1.0.drv >> https://hydra.gnu.org/build/2840802 | armhf-linux | >> /gnu/store/97wgys535pz9yi616arv1dkd3953vqa8-ruby-redcarpet-3.4.0.drv >> https://hydra.gnu.org/build/2842647 | i686-linux | >> /gnu/store/05mdymhhdhhk3nr21xy4vnmjjv7f8wn7-ruby-redcarpet-3.4.0.drv >> https://hydra.gnu.org/build/2812123 | armhf-linux | >> /gnu/store/l7k1fywmmyc5fsrch9b15j86kcr3jwhd-shaderc-0.0.0-2.be8e087.drv >> https://hydra.gnu.org/build/2811921 | i686-linux | >> /gnu/store/y2qg306qp9x0yp0q6j69h4jpl7q4vk18-shaderc-0.0.0-2.be8e087.drv >> https://hydra.gnu.org/build/2811833 | x86_64-linux | >> /gnu/store/smax7jsialvq2lhg6zf4wcxpnsqal7bv-shaderc-0.0.0-2.be8e087.drv >> https://hydra.gnu.org/build/2843817 | i686-linux | >> /gnu/store/7l5x373wrvhlrcq2yqmfg0ghjddpv11l-skopeo-0.1.28.drv >> https://hydra.gnu.org/build/2842125 | armhf-linux | >> /gnu/store/c1ah46yc5yrhizv4z0rkldpj45hg1mj2-sorcer-1.1.3.drv >> https://hydra.gnu.org/build/2841220 | i686-linux | >> /gnu/store/p5m5wjacj7j2yasn7419dv6xrpaflp23-sorcer-1.1.3.drv >> https://hydra.gnu.org/build/2840704 | x86_64-linux | >> /gnu/store/wix2rm45g4dzn2l5rcnjbd1vlcyp0l32-sorcer-1.1.3.drv >> https://hydra.gnu.org/build/2844279 | i686-linux | >> /gnu/store/sjm4chzv7cv9nj0izvxlarvwlinpahwg-syncthing-0.14.48.drv >> >> Mark >> >> >> >> --000000000000c7db80056fb5a449 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
G=C3=A1bor Bos= kovits <boskovits@gmail.com&g= t; ezt =C3=ADrta (id=C5=91pont: 2018. j=C3=BAn. 28., Cs, 7:56):
Mark H Weaver <mhw@netris.org> ezt =C3=ADrta (id=C5=91= pont: 2018. j=C3=BAn. 28., Cs, 7:11):
ludo@gnu.org (Ludo= vic Court=C3=A8s) writes:

> Mark H Weaver <= mhw@netris.org> skribis:
>
>> I just noticed that I made a mistake in commit
>> d8a3b1b9e847d4a44d2695f95af77170d4d2788f, which changed 'gnu-b= uild' in
>> (guix build gnu-build-system) to issue a warning if a phase return= s a
>> value other than #t.
>>
>> The result is that if a phase returns a value other than #t, a war= ning
>> is issued, but the build nonetheless continues to the next phase, = and
>> the build could ultimately "succeed" even some phases re= turned #f.
>>
>> In other words, the return values of phases are effectively ignore= d,
>> except for the warning, so the only way to cause a build with phas= es to
>> fail is to raise an exception.
>
> Thanks for the heads-up.=C2=A0 In practice, I suppose many builds woul= d
> eventually fail anyway, but we=E2=80=99ll have to keep an eye on it.
I grepped the build logs on Hydra from evaluation 110021 searching for
the warning issued when a phase returns #f.=C2=A0 Some of the build logs ha= d
been deleted, but of the builds whose logs are still present, these are
the ones whose 'check' phase returned #f, but which nonetheless
succeeded:

=C2=A0 aegis-4.24 (x86_64 i686)
=C2=A0 coq-8.8.0 (armhf)
=C2=A0 coq-gappa-1.3.2 (armhf)
=C2=A0 crawl-0.21.0 (armhf)
=C2=A0 gexiv2-0.10.8 (i686)
=C2=A0 java-eclipse-jetty-security-9.4.6 (x86_64)
=C2=A0 java-kafka-clients-1.0.0 (x86_64)
=C2=A0 maven-compat-3.5.3 (x86_64)

Thanks, I will look at the two java and ma= ven-compat.
java-eclipse-jetty-security = fixed.
=C2=A0
=C2=A0
=C2=A0 ocaml-4.01.0 (armhf)
=C2=A0 python-django-1.11.11 (x86_64 i686)
=C2=A0 python-ptyprocess-0.5.2 (armhf)
=C2=A0 python2-astroid-1.5.3 (i686 armhf)
=C2=A0 python2-bz2file-0.98 (x86_64 i686 armhf)
=C2=A0 python2-dendropy-4.2.0 (i686)
=C2=A0 python2-django-1.11.11 (x86_64 i686)
=C2=A0 python2-django-allauth-0.30.0 (x86_64 i686)
=C2=A0 restic-0.9.1 (x86_64 i686)
=C2=A0 ruby-concurrent-1.0.5 (armhf)
=C2=A0 ruby-connection-pool-2.2.2 (i686)
=C2=A0 ruby-json-pure-2.1.0 (x86_64 i686)
=C2=A0 ruby-redcarpet-3.4.0 (i686 armhf)
=C2=A0 shaderc-0.0.0-2.be8e087 (x86_64 i686 armhf)
=C2=A0 skopeo-0.1.28 (i686)
=C2=A0 syncthing-0.14.48 (i686)

Here are the ones where the 'build' phase returned #f:

=C2=A0 ocaml-gsl-1.19.3.drv (armhf)
=C2=A0 ocaml4.01-gsl-1.19.3.drv (armhf)
=C2=A0 scm-5f2.drv (i686 armhf)
=C2=A0 teeworlds-0.6.4.drv (armhf)

And here are the ones where some other phase returned #f:

=C2=A0 gnome-dictionary-3.26.1.drv (x86_64 i686 armhf):=C2=A0 ## WARNING: p= hase `install' returned `#f'.
=C2=A0 hop-3.1.0-pre2.drv (armhf):=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0= =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0## WARNING: phase `configure'= returned `#f'.
=C2=A0 sorcer-1.1.3.drv (x86_64 i686 armhf):=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0## WARNING: phase `build-faust-sources' returned `#f&#= 39;.

Here's a combined list with the derivations and links to the
Hydra builds:

https://hydra.gnu.org/build/2801304 | i686-linux=C2=A0 =C2= =A0| /gnu/store/1pzb1d2s03p6728wfifnhjxfbh02njik-aegis-4.24.drv
https://hydra.gnu.org/build/2791716 | x86_64-linux | /gnu/s= tore/sdhr6r50pchw1c54gl6w3h7abnv9k63q-aegis-4.24.drv
https://hydra.gnu.org/build/2842834 | armhf-linux=C2=A0 | /= gnu/store/6cd0sd5jllxqw3q3g9s7z804f36kg9ll-coq-8.8.0.drv
https://hydra.gnu.org/build/2841249 | armhf-linux=C2=A0 | /= gnu/store/77japmdnhrb9dws0cjak3lbkjmxkxvn9-coq-gappa-1.3.2.drv
https://hydra.gnu.org/build/2805499 | armhf-linux=C2=A0 | /= gnu/store/mvf8j3fyp0wq98yxr3fh8cdkyx8ap0ds-crawl-0.21.0.drv
https://hydra.gnu.org/build/2797616 | i686-linux=C2=A0 =C2= =A0| /gnu/store/7h2zk83lpbh9ms41bhx5gpygi1rjv7nw-gexiv2-0.10.8.drv
https://hydra.gnu.org/build/2841898 | armhf-linux=C2=A0 | /= gnu/store/ddgiz8db0y1im3i3c2zh3j52wkkibas7-gnome-dictionary-3.26.1.drv
https://hydra.gnu.org/build/2842705 | i686-linux=C2=A0 =C2= =A0| /gnu/store/lrgbx1qsz21ylvdya8grx1rkpgr8zqa5-gnome-dictionary-3.26.1.dr= v
https://hydra.gnu.org/build/2840885 | x86_64-linux | /gnu/s= tore/fywqcpdgijbbgc2w03wg57w76kzgrghn-gnome-dictionary-3.26.1.drv
https://hydra.gnu.org/build/2842410 | x86_64-linux | /gnu/s= tore/2jl85jn1q3llhzscy7b02x76izw5w284-java-eclipse-jetty-security-9.4.6.drv=
https://hydra.gnu.org/build/2841151 | x86_64-linux | /gnu/s= tore/13cbi0mfhn40dfa705q1bx77jayp0a5k-java-kafka-clients-1.0.0.drv
https://hydra.gnu.org/build/2843944 | x86_64-linux | /gnu/s= tore/wbc3fzqqvp4f9nhn3f59bkd0kvjrvciz-maven-compat-3.5.3.drv
https://hydra.gnu.org/build/2789087 | armhf-linux=C2=A0 | /= gnu/store/pkjxjs7rsrz5fn3m5vhs761prir1xiv7-ocaml-4.01.0.drv
https://hydra.gnu.org/build/2843063 | armhf-linux=C2=A0 | /= gnu/store/93xqlng0ihng0xnxc3ilmw23malakp8q-ocaml-gsl-1.19.3.drv
https://hydra.gnu.org/build/2815032 | armhf-linux=C2=A0 | /= gnu/store/gy1xv9n6q3nh4bgwm42nzpqmc2gw8x2g-ocaml4.01-gsl-1.19.3.drv
https://hydra.gnu.org/build/2839505 | i686-linux=C2=A0 =C2= =A0| /gnu/store/43nqys57lgy4z0ldxq983vl4vrxrzr4w-python-django-1.11.11.drv<= br> https://hydra.gnu.org/build/2840027 | x86_64-linux | /gnu/s= tore/6nwm5zsfk5vxj4vq5blckl7j4hyz246k-python-django-1.11.11.drv
https://hydra.gnu.org/build/2791170 | armhf-linux=C2=A0 | /= gnu/store/0478c2n6cfpx50viy95204dwwdqs3ggv-python-ptyprocess-0.5.2.drv
https://hydra.gnu.org/build/2795214 | armhf-linux=C2=A0 | /= gnu/store/bxyr5vi0ilv2z3q5wfk6qfzl5ahl6hb7-python2-astroid-1.5.3.drv
https://hydra.gnu.org/build/2795813 | i686-linux=C2=A0 =C2= =A0| /gnu/store/h4v2xcs0yycwn7dn4bjf8fci77bf7h05-python2-astroid-1.5.3.drv<= br> https://hydra.gnu.org/build/2799056 | armhf-linux=C2=A0 | /= gnu/store/jvbk35z3s5cvyjs8a5ilz289k0gkgqmv-python2-bz2file-0.98.drv
https://hydra.gnu.org/build/2798019 | i686-linux=C2=A0 =C2= =A0| /gnu/store/s19a20dlq6g4fm84jdgg8njvdl9ppz4d-python2-bz2file-0.98.drv https://hydra.gnu.org/build/2798128 | x86_64-linux | /gnu/s= tore/0cln2r1ln15avh0kmc6drwz756fc4bvv-python2-bz2file-0.98.drv
https://hydra.gnu.org/build/2789737 | i686-linux=C2=A0 =C2= =A0| /gnu/store/d35bm2fjsmz4dzcavpd16khdg6pyfazr-python2-dendropy-4.2.0.drv=
https://hydra.gnu.org/build/2839515 | i686-linux=C2=A0 =C2= =A0| /gnu/store/y70lr6yk2ainc74j58fjdxyil2ys06qk-python2-django-1.11.11.drv=
https://hydra.gnu.org/build/2840426 | x86_64-linux | /gnu/s= tore/bchmr8fynjh5j8zrfg9pxaqvm11vm1a6-python2-django-1.11.11.drv
https://hydra.gnu.org/build/2842057 | i686-linux=C2=A0 =C2= =A0| /gnu/store/0v1dgqw1p8z96gi37i3ai958yl3zpj62-python2-django-allauth-0.3= 0.0.drv
https://hydra.gnu.org/build/2841037 | x86_64-linux | /gnu/s= tore/9a7nx0pi3rs4nvy7nzif6frhlsa00qpz-python2-django-allauth-0.30.0.drv
https://hydra.gnu.org/build/2843841 | i686-linux=C2=A0 =C2= =A0| /gnu/store/2wp8xbkipwm80zvh528whp4dgi3q8jya-restic-0.9.1.drv
https://hydra.gnu.org/build/2843458 | x86_64-linux | /gnu/s= tore/lbw8kyb4pzr550bi7b47zjzwgdybylix-restic-0.9.1.drv
https://hydra.gnu.org/build/2796244 | armhf-linux=C2=A0 | /= gnu/store/4k62sq4dggyi9xh10qsv2mihpz81d92q-ruby-concurrent-1.0.5.drv
https://hydra.gnu.org/build/2789937 | i686-linux=C2=A0 =C2= =A0| /gnu/store/yc0rjldnjmp2m2b31y2q0kgn2956mvna-ruby-connection-pool-2.2.2= .drv
https://hydra.gnu.org/build/2842387 | i686-linux=C2=A0 =C2= =A0| /gnu/store/jqylsar0skxz9l9mmxv1xx4xnl076y8y-ruby-json-pure-2.1.0.drv https://hydra.gnu.org/build/2841410 | x86_64-linux | /gnu/s= tore/vj0xyabkyy8jb5lih1j5zv0n7d7kr394-ruby-json-pure-2.1.0.drv
https://hydra.gnu.org/build/2840802 | armhf-linux=C2=A0 | /= gnu/store/97wgys535pz9yi616arv1dkd3953vqa8-ruby-redcarpet-3.4.0.drv
https://hydra.gnu.org/build/2842647 | i686-linux=C2=A0 =C2= =A0| /gnu/store/05mdymhhdhhk3nr21xy4vnmjjv7f8wn7-ruby-redcarpet-3.4.0.drv https://hydra.gnu.org/build/2812123 | armhf-linux=C2=A0 | /= gnu/store/l7k1fywmmyc5fsrch9b15j86kcr3jwhd-shaderc-0.0.0-2.be8e087.drv
https://hydra.gnu.org/build/2811921 | i686-linux=C2=A0 =C2= =A0| /gnu/store/y2qg306qp9x0yp0q6j69h4jpl7q4vk18-shaderc-0.0.0-2.be8e087.dr= v
https://hydra.gnu.org/build/2811833 | x86_64-linux | /gnu/s= tore/smax7jsialvq2lhg6zf4wcxpnsqal7bv-shaderc-0.0.0-2.be8e087.drv
https://hydra.gnu.org/build/2843817 | i686-linux=C2=A0 =C2= =A0| /gnu/store/7l5x373wrvhlrcq2yqmfg0ghjddpv11l-skopeo-0.1.28.drv
https://hydra.gnu.org/build/2842125 | armhf-linux=C2=A0 | /= gnu/store/c1ah46yc5yrhizv4z0rkldpj45hg1mj2-sorcer-1.1.3.drv
https://hydra.gnu.org/build/2841220 | i686-linux=C2=A0 =C2= =A0| /gnu/store/p5m5wjacj7j2yasn7419dv6xrpaflp23-sorcer-1.1.3.drv
https://hydra.gnu.org/build/2840704 | x86_64-linux | /gnu/s= tore/wix2rm45g4dzn2l5rcnjbd1vlcyp0l32-sorcer-1.1.3.drv
https://hydra.gnu.org/build/2844279 | i686-linux=C2=A0 =C2= =A0| /gnu/store/sjm4chzv7cv9nj0izvxlarvwlinpahwg-syncthing-0.14.48.drv

=C2=A0 =C2=A0 =C2=A0 =C2=A0Mark



--000000000000c7db80056fb5a449-- From debbugs-submit-bounces@debbugs.gnu.org Thu Jun 28 13:52:23 2018 Received: (at 31974) by debbugs.gnu.org; 28 Jun 2018 17:52:23 +0000 Received: from localhost ([127.0.0.1]:38821 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fYb5j-0006Ux-1O for submit@debbugs.gnu.org; Thu, 28 Jun 2018 13:52:23 -0400 Received: from world.peace.net ([64.112.178.59]:37378) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fYb5h-0006Uj-94 for 31974@debbugs.gnu.org; Thu, 28 Jun 2018 13:52:21 -0400 Received: from mhw by world.peace.net with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1fYb5b-0005wp-8y; Thu, 28 Jun 2018 13:52:15 -0400 From: Mark H Weaver To: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=) Subject: Re: bug#31974: If a phase returns #f, a warning is issued, but the build continues References: <87efgu8clc.fsf@netris.org> <87bmbwx9z2.fsf@gnu.org> <87y3ezqyyi.fsf@netris.org> <87efgr3q10.fsf@gnu.org> Date: Thu, 28 Jun 2018 13:51:01 -0400 In-Reply-To: <87efgr3q10.fsf@gnu.org> ("Ludovic \=\?utf-8\?Q\?Court\=C3\=A8s\=22'\?\= \=\?utf-8\?Q\?s\?\= message of "Thu, 28 Jun 2018 17:10:51 +0200") Message-ID: <87o9fuztoa.fsf@netris.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 31974 Cc: 31974@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) ludo@gnu.org (Ludovic Court=C3=A8s) writes: > Mark H Weaver skribis: > >> I grepped the build logs on Hydra from evaluation 110021 searching for >> the warning issued when a phase returns #f. Some of the build logs had >> been deleted, but of the builds whose logs are still present, these are >> the ones whose 'check' phase returned #f, but which nonetheless >> succeeded: > > Are these builds that succeeded despite these #f returns? Yes, except for 'scm', 'teeworlds', and 'hop'. Those builds ultimately failed, so they should have been omitted from the lists I provided. Mark From debbugs-submit-bounces@debbugs.gnu.org Fri Aug 03 23:25:17 2018 Received: (at 31974) by debbugs.gnu.org; 4 Aug 2018 03:25:17 +0000 Received: from localhost ([127.0.0.1]:40349 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1flnBr-0006e8-L5 for submit@debbugs.gnu.org; Fri, 03 Aug 2018 23:25:17 -0400 Received: from world.peace.net ([64.112.178.59]:58312) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1flnBp-0006dv-Dz for 31974@debbugs.gnu.org; Fri, 03 Aug 2018 23:25:13 -0400 Received: from mhw by world.peace.net with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1flnBi-00046d-Qv; Fri, 03 Aug 2018 23:25:06 -0400 From: Mark H Weaver To: 31974@debbugs.gnu.org Subject: Re: bug#31974: If a phase returns #f, a warning is issued, but the build continues References: <87efgu8clc.fsf@netris.org> Date: Fri, 03 Aug 2018 23:23:52 -0400 In-Reply-To: <87efgu8clc.fsf@netris.org> (Mark H. Weaver's message of "Mon, 25 Jun 2018 23:13:03 -0400") Message-ID: <87600qstkn.fsf@netris.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 31974 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Mark H Weaver writes: > I just noticed that I made a mistake in commit > d8a3b1b9e847d4a44d2695f95af77170d4d2788f, which changed 'gnu-build' in > (guix build gnu-build-system) to issue a warning if a phase returns a > value other than #t. > > The result is that if a phase returns a value other than #t, a warning > is issued, but the build nonetheless continues to the next phase, and > the build could ultimately "succeed" even some phases returned #f. > > In other words, the return values of phases are effectively ignored, > except for the warning, so the only way to cause a build with phases to > fail is to raise an exception. This should be fixed by commit 82230603ce06de7aa3e4aef2fa093a6dbf0ef8df in core-updates. Mark From debbugs-submit-bounces@debbugs.gnu.org Sun Aug 19 09:53:12 2018 Received: (at 31974) by debbugs.gnu.org; 19 Aug 2018 13:53:12 +0000 Received: from localhost ([127.0.0.1]:54484 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1frO8m-0007mR-Lj for submit@debbugs.gnu.org; Sun, 19 Aug 2018 09:53:12 -0400 Received: from eggs.gnu.org ([208.118.235.92]:47932) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1frO8l-0007m8-1m for 31974@debbugs.gnu.org; Sun, 19 Aug 2018 09:53:11 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1frO8f-0005Fv-7t for 31974@debbugs.gnu.org; Sun, 19 Aug 2018 09:53:05 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:50076) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1frO8f-0005Fi-5B; Sun, 19 Aug 2018 09:53:05 -0400 Received: from [2a01:e0a:1d:7270:af76:b9b:ca24:c465] (port=50662 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1frO8e-0003z1-UQ; Sun, 19 Aug 2018 09:53:05 -0400 From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=) To: Mark H Weaver Subject: Re: bug#31974: If a phase returns #f, a warning is issued, but the build continues References: <87efgu8clc.fsf@netris.org> <87600qstkn.fsf@netris.org> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: 2 Fructidor an 226 de la =?utf-8?Q?R=C3=A9volution?= X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-pc-linux-gnu Date: Sun, 19 Aug 2018 15:53:03 +0200 In-Reply-To: <87600qstkn.fsf@netris.org> (Mark H. Weaver's message of "Fri, 03 Aug 2018 23:23:52 -0400") Message-ID: <876006ihts.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 31974 Cc: 31974@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -6.0 (------) Mark H Weaver skribis: > Mark H Weaver writes: > >> I just noticed that I made a mistake in commit >> d8a3b1b9e847d4a44d2695f95af77170d4d2788f, which changed 'gnu-build' in >> (guix build gnu-build-system) to issue a warning if a phase returns a >> value other than #t. >> >> The result is that if a phase returns a value other than #t, a warning >> is issued, but the build nonetheless continues to the next phase, and >> the build could ultimately "succeed" even some phases returned #f. >> >> In other words, the return values of phases are effectively ignored, >> except for the warning, so the only way to cause a build with phases to >> fail is to raise an exception. > > This should be fixed by commit 82230603ce06de7aa3e4aef2fa093a6dbf0ef8df > in core-updates. Cool, thanks for not forgetting! :-) Ludo=E2=80=99. From debbugs-submit-bounces@debbugs.gnu.org Wed Jan 09 15:38:32 2019 Received: (at 31974-done) by debbugs.gnu.org; 9 Jan 2019 20:38:32 +0000 Received: from localhost ([127.0.0.1]:52589 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ghKcR-0007Gc-T7 for submit@debbugs.gnu.org; Wed, 09 Jan 2019 15:38:32 -0500 Received: from hera.aquilenet.fr ([185.233.100.1]:50170) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ghKcO-0007GQ-N0 for 31974-done@debbugs.gnu.org; Wed, 09 Jan 2019 15:38:29 -0500 Received: from localhost (localhost [127.0.0.1]) by hera.aquilenet.fr (Postfix) with ESMTP id 049E79C1; Wed, 9 Jan 2019 21:38:28 +0100 (CET) X-Virus-Scanned: Debian amavisd-new at aquilenet.fr Received: from hera.aquilenet.fr ([127.0.0.1]) by localhost (hera.aquilenet.fr [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id GP7mjbch27s3; Wed, 9 Jan 2019 21:38:26 +0100 (CET) Received: from ribbon (unknown [IPv6:2a01:e0a:1d:7270:af76:b9b:ca24:c465]) by hera.aquilenet.fr (Postfix) with ESMTPSA id 8AE291DF; Wed, 9 Jan 2019 21:38:26 +0100 (CET) From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: Mark H Weaver Subject: Re: bug#31974: If a phase returns #f, a warning is issued, but the build continues References: <87efgu8clc.fsf@netris.org> Date: Wed, 09 Jan 2019 21:38:25 +0100 In-Reply-To: <87efgu8clc.fsf@netris.org> (Mark H. Weaver's message of "Mon, 25 Jun 2018 23:13:03 -0400") Message-ID: <87a7k936ta.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: 31974-done Cc: 31974-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) Mark H Weaver skribis: > I just noticed that I made a mistake in commit > d8a3b1b9e847d4a44d2695f95af77170d4d2788f, which changed 'gnu-build' in > (guix build gnu-build-system) to issue a warning if a phase returns a > value other than #t. > > The result is that if a phase returns a value other than #t, a warning > is issued, but the build nonetheless continues to the next phase, and > the build could ultimately "succeed" even some phases returned #f. This was fixed in commit 82230603ce06de7aa3e4aef2fa093a6dbf0ef8df. Closing! Ludo'. From unknown Tue Jun 17 20:20:44 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Thu, 07 Feb 2019 12:24:09 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator