GNU bug report logs - #31965
[PATCH] gnu: Add gaupol.

Previous Next

Full log

View this message in rfc822 format

From: ludo <at> gnu.org (Ludovic Courtès)
To: Pierre Neidhardt <ambrevar <at> gmail.com>
Cc: 31965 <at> debbugs.gnu.org
Subject: [bug#31965] [PATCH] gnu: Add gaupol.
Date: Thu, 12 Jul 2018 23:20:16 +0200

Hello Pierre!

Pierre Neidhardt <ambrevar <at> gmail.com> skribis:

> * gnu/packages/video.scm (gaupol): New variable.

[...]

> +         (add-after 'install 'patch-data-dir
> +           ;; Fix some path variables that setup.py seems to garble.
> +           (lambda* (#:key outputs #:allow-other-keys)
> +             (let ((out (assoc-ref outputs "out")))
> +               (substitute* (string-append out "/lib/python3.6/site-packages/aeidon/paths.py")

This could break silently the day we switch to Python 3.7.  Instead, I
think you can write:

  (substitute* (find-files out "^paths\\.py$")
    …)

There’s possibly another issue: if there exists a ‘paths.pyc’ file, it
becomes outdated once we’ve modified ‘paths.py’.

Perhaps we should move this phase before the build phase?

Otherwise LGTM, thanks!

Ludo’.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.