Subject: Re: [bug#31958] [PATCH] gnu: Add python-pyblake2.

From: Marius Bakke <[email-masked]>
Date: Mon, 25 Jun 2018 21:52:30 +0200

Vagrant Cascadian <[email-masked]> writes:

> Add new package definition for python-pyblake2, needed to upgrade
> python-trezor to recent versions.

Thanks!  Some comments:

[...]

> * gnu/packages/libusb.scm (python-pyblake2): New variable.
> ---
>  gnu/packages/python.scm | 19 +++++++++++++++++++
>  1 file changed, 19 insertions(+)

There is a mismatch between the commit message and the code here :-)
Though I think this is better suited in 'python-crypto.scm'.  WDYT?

[...]

> +    (home-page "https://github.com/dchest/pyblake2")
> +    (synopsis
> +     "BLAKE2 hash function extension module")

Superfluous line break.

> +    (description
> +     "BLAKE2 hash function extension module")

Can you try to expand on this a little?

> +    (license license:cc0)))

According to COPYING, this software is actually "octuple-licensed":

* CC0 Universal 1.0 - http://creativecommons.org/publicdomain/zero/1.0
* Unlicense — http://unlicense.org/
* WTFPL Version 2 - http://www.wtfpl.net/
* Apache Public License 2.0 - https://www.apache.org/licenses/LICENSE-2.0
* OpenSSL License - https://www.openssl.org/source/license.html
* MIT License - https://opensource.org/licenses/MIT
* The BSD 3-Clause License - https://opensource.org/licenses/BSD-3-Clause
* ISC License - https://opensource.org/licenses/ISC

Can you add each of these, along with an explaning comment?

Thanks in advance!