From debbugs-submit-bounces@debbugs.gnu.org Sun Jun 24 16:04:36 2018 Received: (at submit) by debbugs.gnu.org; 24 Jun 2018 20:04:37 +0000 Received: from localhost ([127.0.0.1]:34112 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fXBFU-0006Ig-JX for submit@debbugs.gnu.org; Sun, 24 Jun 2018 16:04:36 -0400 Received: from eggs.gnu.org ([208.118.235.92]:41193) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fXBFT-0006IU-9X for submit@debbugs.gnu.org; Sun, 24 Jun 2018 16:04:36 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fXBFN-0005Mm-7I for submit@debbugs.gnu.org; Sun, 24 Jun 2018 16:04:30 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:51683) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1fXBFN-0005MY-3L for submit@debbugs.gnu.org; Sun, 24 Jun 2018 16:04:29 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:60397) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fXBFL-0006HQ-SH for guix-patches@gnu.org; Sun, 24 Jun 2018 16:04:28 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fXBFK-0005KJ-SF for guix-patches@gnu.org; Sun, 24 Jun 2018 16:04:27 -0400 Received: from cascadia.aikidev.net ([2600:3c01:e000:267:0:a171:de7:c]:34999) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fXBFK-0005JW-Jd for guix-patches@gnu.org; Sun, 24 Jun 2018 16:04:26 -0400 Received: from localhost (unknown [IPv6:2600:3c01:e000:21:21:21:0:100b]) (Authenticated sender: vagrant@cascadia.debian.net) by cascadia.aikidev.net (Postfix) with ESMTPSA id 066C11B585 for ; Sun, 24 Jun 2018 13:04:24 -0700 (PDT) From: Vagrant Cascadian To: guix-patches@gnu.org Subject: [PATCH] gnu: Add python-libusb1. Date: Sun, 24 Jun 2018 13:04:06 -0700 Message-ID: <87r2kwne89.fsf@aikidev.net> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="==-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -6.0 (------) --==-=-= Content-Type: multipart/mixed; boundary="=-=-=" --=-=-= Content-Type: text/plain Add new package definition for python-libusb1, needed to upgrade python-trezor to newer versions. live well, vagrant --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=0001-gnu-Add-python-libusb1.patch Content-Transfer-Encoding: quoted-printable From=20282280cbaba47389f7a9c3e14eb8fe7834adbd39 Mon Sep 17 00:00:00 2001 From: Vagrant Cascadian Date: Sun, 24 Jun 2018 19:20:47 +0000 Subject: [PATCH] gnu: Add python-libusb1. * gnu/packages/libusb.scm (python-libusb1): New variable. =2D-- gnu/packages/libusb.scm | 38 ++++++++++++++++++++++++++++++++++++++ 1 file changed, 38 insertions(+) diff --git a/gnu/packages/libusb.scm b/gnu/packages/libusb.scm index 62c936c19..9fa2d816a 100644 =2D-- a/gnu/packages/libusb.scm +++ b/gnu/packages/libusb.scm @@ -214,6 +214,44 @@ with usb4java.") implementing @code{javax.usb} (JSR-80).") (license expat))) =20 +(define-public python-libusb1 + (package + (name "python-libusb1") + (version "1.6.4") + (source + (origin + (method url-fetch) + (uri (pypi-uri "libusb1" version)) + (sha256 + (base32 + "03b7xrz8vqg8w0za5r503jhcmbd1ls5610jcja1rqz833nf0v4wc")))) + (build-system python-build-system) + (arguments + `(#:modules ((srfi srfi-1) + (srfi srfi-26) + (guix build utils) + (guix build python-build-system)) + #:phases + (modify-phases %standard-phases + (add-after 'unpack 'fix-libusb-reference + (lambda* (#:key inputs #:allow-other-keys) + (substitute* "usb1/libusb1.py" + (("libusb_path =3D ctypes.util.find_library\\(base_name\\)") + (string-append + "libusb_path =3D \"" + (find (negate symbolic-link?) + (find-files (assoc-ref inputs "libusb") + "^libusb.*\\.so\\..*")) + "\""))) + #t))))) + (inputs `(("libusb" ,libusb))) + (home-page + "http://github.com/vpelletier/python-libusb1") + (synopsis "Pure-python wrapper for libusb-1.0") + (description + "Pure-python wrapper for libusb-1.0") + (license lgpl2.1+))) + (define-public python-pyusb (package (name "python-pyusb") =2D-=20 2.11.0 --=-=-=-- --==-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEcDardHbDotegGFCHt4uC1IFLkbYFAlsv+TYACgkQt4uC1IFL kbafaw//U9R0zZ1ermnDIVcoTSNREU7UOCDNFKnVqxbTOErmgaj64wZ4PuANORWo +LGuH8QRQ/r5tysFiJeLEKoIRZ0TFnewEaTg/XOOb0nZ9IUI976/cjebT5BCs7da UWYIE91hadu22f3GJiDiTQ3Inh2NTTEZj7zSUwfd+qDL2QWnAhKfeZL+9v77t+8m yLHWwkG1i8xVnFQ4PwiQKaRnUs/Na43lJ8FCzlZledi0pZ3a7QYpp4aCd8msvvtM rB5ioB7ljekA9mZmafcDby+Rs5WLYho6kseATxkcrZLwQ30/PY4730qWTm307Ia8 GbdckGNH7cDsQne6XAQQLJVSIFiaPK6BjJsvjZ1sWuhzkaxb3Ik6Glm1iiE8nokY PmSoca/lXUeMvzAb3KiHVkzdOu2TC2d6Gh9Mf0TWnHeyIRhA5Xys7Qn36azmyq7D cyRJK1f1lOX1WX9VrslGbIi8IWAE473/p89iDZ8fA2Pv7pFL9tsC9UIF2cHdN05j EGuK52/EieClEadQ7D8ldTtqqpmi7ZixjxEKwl2EsbbWw0tM0eWv2rSJvPOpHD/4 ycQlt8EgWW2lSKCBUmXCITSW/gmi3ePMxsXbg80tjsle9lRVR6Tt9eTh9FDgK7UT MOgsQtUUe9r3cGxSB2eHiKucK342FrxRVw/iE+7K1jfIHhlIYJ0= =jYlL -----END PGP SIGNATURE----- --==-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Mon Jun 25 15:46:31 2018 Received: (at 31957) by debbugs.gnu.org; 25 Jun 2018 19:46:31 +0000 Received: from localhost ([127.0.0.1]:35255 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fXXRW-0005cp-SC for submit@debbugs.gnu.org; Mon, 25 Jun 2018 15:46:31 -0400 Received: from out2-smtp.messagingengine.com ([66.111.4.26]:43649) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fXXRV-0005ci-HA for 31957@debbugs.gnu.org; Mon, 25 Jun 2018 15:46:29 -0400 Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.nyi.internal (Postfix) with ESMTP id 5EAEE21B03; Mon, 25 Jun 2018 15:46:29 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute5.internal (MEProxy); Mon, 25 Jun 2018 15:46:29 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fastmail.com; h= content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to:x-me-sender:x-me-sender:x-sasl-enc; s= fm3; bh=caDmY0XcbvxbSq5So8p7qa/VRI/QDY5EmFm4pcngj6c=; b=RlzaTTWE shivlI6XpTaRQikXvarXxY9fBpAwBTUOWILYOm8kmWS74p4NJEhUeGGW3taPHYOM M2Mpoig/KO2ZH14DPPaGCRihNa33lau0//3I2O/4/I1+/81Z7OKF6zpJXXwRxTSh mfbNfxCwFLypTzNi9qqDU5pi0j9oh05IR1JiXbaa2FGpag9Asb4tSPJMUy8jmPb1 faYylynmeBWm3O5/qlAR/Ykn6WezxUBDm0OTqf+rBtLEv/AF8+P8MuZmR8vpc3Xc A5SpRjirjCVjwDsmCs5P3WSR/B9pk4HxgO3iYkNNT1N8VogSQZl5KVQUQzvP9emP x58pcmPv5ITpTQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=fm3; bh=caDmY0XcbvxbSq5So8p7qa/VRI/QD Y5EmFm4pcngj6c=; b=ZE0iaZ1EZoVTAslVZ6lyFnw+OzGwGpTUyfoR16r20MQik Sat/yG2F92it66x8ku0wFdqNwGa2VCoi6y3tHtfXtmcNr+8Rt6m1vcSSbi+XaIYd Q+CkmQPKTNFEQGAODZOHkG5JAZXj1GbP+g37pshoLLvHwTbfH/NH0sky3mGXQX9Z lsIG19Q4KnTrG1fcj7AOYNqO+6WkhxxaWY6g3mbyYwCik68zWYHIcJ59ACvZDJAh /eZgMY+XhEd5tp8cSHE6ikUdLvVEh8N5n2xTehFEBgiR46hte9p+gwV8v63+0lKj JhXElQivnA5KZX5QKxiIP3s+elMAo2jXPnqTmgI5w== X-ME-Proxy: X-ME-Sender: Received: from localhost (cm-84.214.174.185.getinternet.no [84.214.174.185]) by mail.messagingengine.com (Postfix) with ESMTPA id BADD410262; Mon, 25 Jun 2018 15:46:28 -0400 (EDT) From: Marius Bakke To: Vagrant Cascadian , 31957@debbugs.gnu.org Subject: Re: [bug#31957] [PATCH] gnu: Add python-libusb1. In-Reply-To: <87r2kwne89.fsf@aikidev.net> References: <87r2kwne89.fsf@aikidev.net> User-Agent: Notmuch/0.27 (https://notmuchmail.org) Emacs/26.1 (x86_64-pc-linux-gnu) Date: Mon, 25 Jun 2018 21:46:27 +0200 Message-ID: <877emmejjg.fsf@fastmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 31957 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Vagrant Cascadian writes: > Add new package definition for python-libusb1, needed to upgrade > python-trezor to newer versions. Thanks! I have some minor nitpicks: [...] > * gnu/packages/libusb.scm (python-libusb1): New variable. Can you also add yourself to the copyright header in this file? [...] =20=20 > +(define-public python-libusb1 > + (package > + (name "python-libusb1") > + (version "1.6.4") > + (source > + (origin > + (method url-fetch) > + (uri (pypi-uri "libusb1" version)) > + (sha256 > + (base32 > + "03b7xrz8vqg8w0za5r503jhcmbd1ls5610jcja1rqz833nf0v4wc")))) > + (build-system python-build-system) > + (arguments > + `(#:modules ((srfi srfi-1) > + (srfi srfi-26) Is srfi-26 actually used here? > + (guix build utils) > + (guix build python-build-system)) > + #:phases > + (modify-phases %standard-phases > + (add-after 'unpack 'fix-libusb-reference > + (lambda* (#:key inputs #:allow-other-keys) > + (substitute* "usb1/libusb1.py" > + (("libusb_path =3D ctypes.util.find_library\\(base_name\\= )") > + (string-append > + "libusb_path =3D \"" > + (find (negate symbolic-link?) > + (find-files (assoc-ref inputs "libusb") > + "^libusb.*\\.so\\..*")) > + "\""))) > + #t))))) > + (inputs `(("libusb" ,libusb))) > + (home-page > + "http://github.com/vpelletier/python-libusb1") This line break is unnecessary :-) > + (synopsis "Pure-python wrapper for libusb-1.0") > + (description > + "Pure-python wrapper for libusb-1.0") This description is rather thin. Can you try to make it into one or more full sentences? > + (license lgpl2.1+))) I noticed the source contains GPL2 in COPYING, and LGPL2.1 as "COPYING.LESSER". Can you make sure we don't install the former? Can you send an updated patch? Thanks in advance! --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCgAdFiEEu7At3yzq9qgNHeZDoqBt8qM6VPoFAlsxRpMACgkQoqBt8qM6 VPq26Af/d8rDUNL9Qti+/nr3NhdOe+07zOjyZXftfl/86wv+Jz7//A1nH0NXGRyG DycWyhpJaIO6DoTHnuFrIbYvMU+5OGcz9scTg3Pk2WWgoGpYmiNT12dqVbNrd3Ks KVoNbySmKv2xn3YHascEdYldlKbRxfUCWPebxiJVHo0wLuz73V7HK0bzxEjJaI/w y4LyGPctv6w9B1p/f3Pj9EJtS4eEELTJwfD5oNFXA/4hZGpjtrFEjB2+F8ZDfpD4 lazy8ShUJgNbhAVxzQfxUJZHaExI9FMcd+LmcsdkilKhjTg5khrFsyVX77lsg/yB oQPstSEHSfEUZJelDlwG+6BNSLmdhg== =H7mK -----END PGP SIGNATURE----- --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Mon Jun 25 16:54:36 2018 Received: (at 31957) by debbugs.gnu.org; 25 Jun 2018 20:54:37 +0000 Received: from localhost ([127.0.0.1]:35338 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fXYVQ-0007KB-Lq for submit@debbugs.gnu.org; Mon, 25 Jun 2018 16:54:36 -0400 Received: from cascadia.aikidev.net ([173.255.214.101]:39395) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fXYVO-0007Jk-7b for 31957@debbugs.gnu.org; Mon, 25 Jun 2018 16:54:35 -0400 Received: from localhost (unknown [IPv6:2600:3c01:e000:21:21:21:0:100b]) (Authenticated sender: vagrant@cascadia.debian.net) by cascadia.aikidev.net (Postfix) with ESMTPSA id 0C7C81B585; Mon, 25 Jun 2018 13:54:28 -0700 (PDT) From: Vagrant Cascadian To: Marius Bakke , 31957@debbugs.gnu.org Subject: Re: [bug#31957] [PATCH] gnu: Add python-libusb1. In-Reply-To: <877emmejjg.fsf@fastmail.com> References: <87r2kwne89.fsf@aikidev.net> <877emmejjg.fsf@fastmail.com> Date: Mon, 25 Jun 2018 13:54:15 -0700 Message-ID: <87bmbyoadk.fsf@aikidev.net> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 31957 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-=-= Content-Type: text/plain On 2018-06-25, Marius Bakke wrote: > Vagrant Cascadian writes: > >> Add new package definition for python-libusb1, needed to upgrade >> python-trezor to newer versions. > > Thanks! I have some minor nitpicks: > > [...] > >> * gnu/packages/libusb.scm (python-libusb1): New variable. > > Can you also add yourself to the copyright header in this file? Sure. >> +(define-public python-libusb1 >> + (package >> + (name "python-libusb1") >> + (version "1.6.4") >> + (source >> + (origin >> + (method url-fetch) >> + (uri (pypi-uri "libusb1" version)) >> + (sha256 >> + (base32 >> + "03b7xrz8vqg8w0za5r503jhcmbd1ls5610jcja1rqz833nf0v4wc")))) >> + (build-system python-build-system) >> + (arguments >> + `(#:modules ((srfi srfi-1) >> + (srfi srfi-26) > > Is srfi-26 actually used here? No idea, I admittedly cargo-culted this from python-pyusb... fix-libusb-reference didn't work until I added the modules block, and I didn't narrow-down which of the specific modules were actually needed. >> + (guix build utils) >> + (guix build python-build-system)) >> + #:phases >> + (modify-phases %standard-phases >> + (add-after 'unpack 'fix-libusb-reference >> + (lambda* (#:key inputs #:allow-other-keys) >> + (substitute* "usb1/libusb1.py" >> + (("libusb_path = ctypes.util.find_library\\(base_name\\)") >> + (string-append >> + "libusb_path = \"" >> + (find (negate symbolic-link?) >> + (find-files (assoc-ref inputs "libusb") >> + "^libusb.*\\.so\\..*")) >> + "\""))) >> + #t))))) >> + (inputs `(("libusb" ,libusb))) >> + (home-page >> + "http://github.com/vpelletier/python-libusb1") > > This line break is unnecessary :-) Ok. >> + (synopsis "Pure-python wrapper for libusb-1.0") >> + (description >> + "Pure-python wrapper for libusb-1.0") > > This description is rather thin. Can you try to make it into one or > more full sentences? Will try. >> + (license lgpl2.1+))) > > I noticed the source contains GPL2 in COPYING, and LGPL2.1 as > "COPYING.LESSER". Can you make sure we don't install the former? I was a bit confused by that, but looking at all the actual code, it only appears to be LGPL2.1. So you're saying to explicitly remove COPYING from the package? > Can you send an updated patch? Thanks in advance! Sure. Thanks for the review! live well, vagrant --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEcDardHbDotegGFCHt4uC1IFLkbYFAlsxVngACgkQt4uC1IFL kbbt5Q/9G4wdQu9xesyDBZ9KvLT016t8TINt92Nh7i0YLQRAupF0pC09WEC/nOKC g5ykUr6Ek1S2btwcIGoVd4H4HjB7BeFkP5gcBr9TWTouiSLNUr9RX1LbyifMaXrK l8s+NKy5UoycohOKjLXX4m25VusPgAmyX3h7WQ8XQO0fxTz1xH1CMgT/peP7OuBy MAiyNMlI/8U/bqdnKnfrw/7U7s/NaURMGXaVjwT0RNa0EB1/GvtyB+DMP3KAc+DA 5BIYnsoMfQGCq95rHbBGt7dt5VVq7lA2tbUSuVI3VwP3KDg0+Kfu5e/sMk4KnHy+ 48LKdNsjH81ej8AGbFAU+e1M8gURQylSE8MvB/ycLS81Q3NgFeZiiuAy1VDu9f3t NvmLrNyqR4Z6OgOSnWFnOTmtVlxpW1zA7kzc7BNCSzawXtTMzBsvQcbXv2nioY6u GyBQKCdUcqommbqyR3+niQsFPPFNEThWYkqTYtiZHdMLiiY90eevcLysHrYzS5pw o7UPh93uLzBQkCJcwcEh2xSGOUpSx66nd53VKsOuAMrzAmcjNmwtw0EP9XXkXF+q LjX1U+QNIiGz/4cB2sZIIDkUym5ctMY7Zh/89nORcyMgu3wTK93z4XkdLvETQRlG ze7JJtYKqU9/wU6feqGGfzWxod3A1uKkU+GPsw+u+RxUel/o4oA= =idMX -----END PGP SIGNATURE----- --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Mon Jun 25 17:26:11 2018 Received: (at 31957) by debbugs.gnu.org; 25 Jun 2018 21:26:11 +0000 Received: from localhost ([127.0.0.1]:35378 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fXYzz-00086i-8I for submit@debbugs.gnu.org; Mon, 25 Jun 2018 17:26:11 -0400 Received: from out2-smtp.messagingengine.com ([66.111.4.26]:44303) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fXYzx-00086a-91 for 31957@debbugs.gnu.org; Mon, 25 Jun 2018 17:26:09 -0400 Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.nyi.internal (Postfix) with ESMTP id 0676D21D60; Mon, 25 Jun 2018 17:26:09 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute5.internal (MEProxy); Mon, 25 Jun 2018 17:26:09 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fastmail.com; h= content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to:x-me-sender:x-me-sender:x-sasl-enc; s= fm3; bh=tex63m2pY0KsqYe281LddRlgMSwv6So8+yOAJHjxdso=; b=DOmdoCYv teGLTsrGHkf+eJjAtlP+TWtNm6R0E7fWu3yc4vEHsoYNtKGWcwmH2uapbU2Oq6CN 9toW/rcIiZKGFEIzaSffK2SNbBQHLkIUJdvpQ85poSXUAnrPdkeOk3pq4d+pLuUY N9BZer/5edlK9yef25E7TEnEIUitF/O22vSufHZOw5SSaS2vmbdvxfbifo1R7IHx c+W2q/s66vK8bjlsFKSJ6GPjWuK8HiCtEb7Q2o5GhYkv+AePB/gupcAfuY0isG/R DvgSSXSVgHboFpSei0vMTxFxoA/G1z1Wu0unKv7UPVLf+fnqadpdT3jQBShz2NSO HM3WpXa8hwO6FQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=fm3; bh=tex63m2pY0KsqYe281LddRlgMSwv6 So8+yOAJHjxdso=; b=Dzot50ADdd5EcRjQiD7zLy/xdWhHe8a43eyacSuWK95py UxLXfoCt+0icwakEX15GBn6h28BKGBWVDhiX4Kc+XeTrFvVhihrV+hkrVUnrGk88 3AgLxLBgGiN1U6MiHXULrwM4UlgQ6+UVVuYr4F+RmgmTLxIS8af8gd4uIWHmygLF CKInxIXOjjhoqnbEh4MRef9LdXTM4Xb2s2V+iLL71DEESyTfECj+Hs0fHNn9Tt8u 3yAnohRWqXkmIn6iTDze5PMH9G5RdsfWOwibwHkpPHI9NeU7duZstPCuMsCp4364 XX5xLZ6o2VRDzmwiYynUQ2rQmXS/CbT4j1gbPNLkw== X-ME-Proxy: X-ME-Sender: Received: from localhost (cm-84.214.174.185.getinternet.no [84.214.174.185]) by mail.messagingengine.com (Postfix) with ESMTPA id 8F4D11025D; Mon, 25 Jun 2018 17:26:08 -0400 (EDT) From: Marius Bakke To: Vagrant Cascadian , 31957@debbugs.gnu.org Subject: Re: [bug#31957] [PATCH] gnu: Add python-libusb1. In-Reply-To: <87bmbyoadk.fsf@aikidev.net> References: <87r2kwne89.fsf@aikidev.net> <877emmejjg.fsf@fastmail.com> <87bmbyoadk.fsf@aikidev.net> User-Agent: Notmuch/0.27 (https://notmuchmail.org) Emacs/26.1 (x86_64-pc-linux-gnu) Date: Mon, 25 Jun 2018 23:26:07 +0200 Message-ID: <87efguzhg0.fsf@fastmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 31957 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) --=-=-= Content-Type: text/plain Vagrant Cascadian writes: >>> + (license lgpl2.1+))) >> >> I noticed the source contains GPL2 in COPYING, and LGPL2.1 as >> "COPYING.LESSER". Can you make sure we don't install the former? > > I was a bit confused by that, but looking at all the actual code, it > only appears to be LGPL2.1. So you're saying to explicitly remove > COPYING from the package? Yes, it seems COPYING is simply a leftover, so I'd prefer not to install it somehow (e.g. by overriding the 'install-license-files' phase). --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCgAdFiEEu7At3yzq9qgNHeZDoqBt8qM6VPoFAlsxXe8ACgkQoqBt8qM6 VPrGewgAisNkiqdWI+vIBlOQ/8UWB/QRslFzNfkI5Rw0D7T3DSUnqyLJ34BvvVZq 8A5unxLiVWY0LUMcD21lTH2Ay1qKU4MxVNb1KlW4nnbSkM0ok5v7OcRhMYQBgKLQ 6PeCpkvNauBTh6/O+OBQPJm8QZnoKCWZDoTV4E24imgH6mfsWS8JCDCKAyK9lVav 2P2w65RfiiOwxQQj3hNbPUix4lUDKDsjqrihx7h4DsPdFrC3Tj3uncnUAZUEAIXD peU5qqegfBWz1olHeMh1G74xMWjxTpl2+cQb6w+MZkw2TpeT4PaEW2UociZ1oxNL z0TkX9XuRPxiAw99wi27AbjlyaG+aQ== =F3gY -----END PGP SIGNATURE----- --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Tue Jun 26 01:36:05 2018 Received: (at 31957) by debbugs.gnu.org; 26 Jun 2018 05:36:05 +0000 Received: from localhost ([127.0.0.1]:35547 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fXge5-0000Jr-03 for submit@debbugs.gnu.org; Tue, 26 Jun 2018 01:36:05 -0400 Received: from cascadia.aikidev.net ([173.255.214.101]:39551) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fXge3-0000JN-10 for 31957@debbugs.gnu.org; Tue, 26 Jun 2018 01:36:03 -0400 Received: from localhost (unknown [IPv6:2600:3c01:e000:21:21:21:0:100b]) (Authenticated sender: vagrant@cascadia.debian.net) by cascadia.aikidev.net (Postfix) with ESMTPSA id B25011B585; Mon, 25 Jun 2018 22:35:56 -0700 (PDT) From: Vagrant Cascadian To: Marius Bakke , 31957@debbugs.gnu.org Subject: Re: [bug#31957] [PATCH] gnu: Add python-libusb1. In-Reply-To: <877emmejjg.fsf@fastmail.com> References: <87r2kwne89.fsf@aikidev.net> <877emmejjg.fsf@fastmail.com> Date: Mon, 25 Jun 2018 22:35:40 -0700 Message-ID: <8736xanm8j.fsf@aikidev.net> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="==-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 31957 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --==-=-= Content-Type: multipart/mixed; boundary="=-=-=" --=-=-= Content-Type: text/plain On 2018-06-25, Marius Bakke wrote: > Vagrant Cascadian writes: > >> Add new package definition for python-libusb1, needed to upgrade >> python-trezor to newer versions. > > Thanks! I have some minor nitpicks: ... > Can you send an updated patch? Thanks in advance! Updated patch attached: - Add myself to copyright headers - Drop unused srfi-26 - Remove needless line break - Flesh out description a bit... - Remove COPYING file, which didn't match the licensing of the files The removal of COPYING was pretty much a shotgun-style approach, but I couldn't figure out how to do a more surgical removal, and there weren't any other COPYING files in the source. The description could probably be further improved... but that's as far as I got for now... :) live well, vagrant --=-=-= Content-Type: text/x-diff; charset=utf-8 Content-Disposition: inline; filename=0001-gnu-Add-python-libusb1.patch Content-Transfer-Encoding: quoted-printable From=20088c81c4ca3a95bf51f04aec836aaedee8ab9ba8 Mon Sep 17 00:00:00 2001 From: Vagrant Cascadian Date: Tue, 26 Jun 2018 05:22:48 +0000 Subject: [PATCH] gnu: Add python-libusb1. * gnu/packages/libusb.scm (python-libusb1): New variable. =2D-- gnu/packages/libusb.scm | 44 ++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 44 insertions(+) diff --git a/gnu/packages/libusb.scm b/gnu/packages/libusb.scm index 62c936c19..39814bc90 100644 =2D-- a/gnu/packages/libusb.scm +++ b/gnu/packages/libusb.scm @@ -7,6 +7,7 @@ ;;; Copyright =C2=A9 2016 Theodoros Foradis ;;; Copyright =C2=A9 2017 Jonathan Brielmaier ;;; Copyright =C2=A9 2018 Tobias Geerinckx-Rice +;;; Copyright =C2=A9 2018 Vagrant Cascadian ;;; ;;; This file is part of GNU Guix. ;;; @@ -214,6 +215,49 @@ with usb4java.") implementing @code{javax.usb} (JSR-80).") (license expat))) =20 +(define-public python-libusb1 + (package + (name "python-libusb1") + (version "1.6.4") + (source + (origin + (method url-fetch) + (uri (pypi-uri "libusb1" version)) + (sha256 + (base32 + "03b7xrz8vqg8w0za5r503jhcmbd1ls5610jcja1rqz833nf0v4wc")))) + (build-system python-build-system) + (arguments + `(#:modules ((srfi srfi-1) + (guix build utils) + (guix build python-build-system)) + #:phases + (modify-phases %standard-phases + (add-before 'install-license-files 'remove-incorrect-license + (lambda* (#:key out #:allow-other-keys) + ;; Was reliscensed to LGPL 2.1+, but old COPYING file still l= eft + ;; in source. Remove it so it does not get installed. + (delete-file-recursively "COPYING") + #t)) + (add-after 'unpack 'fix-libusb-reference + (lambda* (#:key inputs #:allow-other-keys) + (substitute* "usb1/libusb1.py" + (("libusb_path =3D ctypes.util.find_library\\(base_name\\)") + (string-append + "libusb_path =3D \"" + (find (negate symbolic-link?) + (find-files (assoc-ref inputs "libusb") + "^libusb.*\\.so\\..*")) + "\""))) + #t))))) + (inputs `(("libusb" ,libusb))) + (home-page "http://github.com/vpelletier/python-libusb1") + (synopsis "Pure-python wrapper for libusb-1.0") + (description "Libusb is a library that gives applications easy access = to +USB devices on various operating systems. This is a python wrapper for +acessing libusb-1.0") + (license lgpl2.1+))) + (define-public python-pyusb (package (name "python-pyusb") =2D-=20 2.11.0 --=-=-=-- --==-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEcDardHbDotegGFCHt4uC1IFLkbYFAlsx0KwACgkQt4uC1IFL kba6zQ/+PL1IBColD++X9UCgBmPJeohwee/lboY/junfjLmPrlDxdNiZ4v/UX+Cj HpOXFJeYtW+32BZ+ImxolTQUSefIuapjr0XW6DIS4OCVF39IDL9+JmMLj5fsHp5/ Z2QV0Ve+YDSrtHD95qQbYfRWujO2A40QQnpbiUw1OLL4VgpcpWFOBxZX/+0x7tKY v94nqB1WWVtrD8CgERE8C3M64ICHUaR2uMET4nWFbONg3gM74CwvEfFXIYHiaG4t gVQWEFY1p7WV2Nqvec4Ql+dlOM6C6BiOG7ImH8pRlDv1hrd2jjYKxG+qMN7NVpXj Nc5SWeUoBHNG9Q9GydsZ64Ka+Jd7R+NUZlRjNcxWSHIvD3YSek+XGsEyAIVw7/Mq h998kwS2BbQ+UcdH39MoHOCBjjEgEsi66p2tlhSkTKcAhfdCEAKMrdbKo5TmkfoG Uza22aTkxQOjUvTGqMaghdNIZxRGuT+Aq8Dh6H0quFJ8xFBBhCgcnK6ajssHO+cQ 01ebUJTJZFpO6prGZR4kkCvQGBjQBkKlLCHEGF30i0PpkUeo0Y6i84EYhhy1U+IM Ur8jE1kpySTX87CkzEvZ87zn+v78+AXHbpjq0x/CvsN+QFx7m2QV2ar4nIF3M6D2 TuVo1FG03RAIiYFLxodb3ns1h+BmQyfIsebFg8l+QrwVOM7+rNA= =RNHY -----END PGP SIGNATURE----- --==-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Tue Jun 26 17:39:51 2018 Received: (at 31957) by debbugs.gnu.org; 26 Jun 2018 21:39:51 +0000 Received: from localhost ([127.0.0.1]:36667 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fXvgl-0003rt-33 for submit@debbugs.gnu.org; Tue, 26 Jun 2018 17:39:51 -0400 Received: from out2-smtp.messagingengine.com ([66.111.4.26]:60107) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fXvgj-0003rl-LU for 31957@debbugs.gnu.org; Tue, 26 Jun 2018 17:39:50 -0400 Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.nyi.internal (Postfix) with ESMTP id 1C9F621CDF; Tue, 26 Jun 2018 17:39:49 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute5.internal (MEProxy); Tue, 26 Jun 2018 17:39:49 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fastmail.com; h= content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to:x-me-sender:x-me-sender:x-sasl-enc; s= fm3; bh=Hpwp7u3LzrJCFipsP6hfoJr0m+xo0S5xKcBb9bEyZ7w=; b=r/oILQMo hBTAbqFknNR6GH+WpXX9YOB0pmrKVcaW6OhT0pw0mQM/png2cwGeHqI3vVUCczOP +lcRJ1vUQbMOyepnJVKXXueR+WSJlDYRJTaDebn6vmDdvj+ADy9RSd4jnVn4meYV 2SgooicgmYGmw/vA89cKoomCk2KXOB48V39G38OlYG4OabLkmPuIiW7kGiIAf4S0 Pf7VoAe9wDhgJ7ryVy6FLLvet7l0j/vrzOvH5fDaRdoPbnP5apRrOMEMGzKIsAn3 /sog2XSXjuIQo8s4o+b+e4A/5op3/90RkEQXp9xCLNgD3YjUJ+kiPDkFZGKZcjQo v/VAnFlnolLfEw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=fm3; bh=Hpwp7u3LzrJCFipsP6hfoJr0m+xo0 S5xKcBb9bEyZ7w=; b=KHAs0ehNVdOHr9hTj5nWiiKJ/q+h/S7MV8aig7gC3pqyV ERKGROfLPu9eQv6agOJ8yyG+a3Pevbphdx0xskto58ANN/Iv8AFdYvMtVDyH6VRk QlVQ8EX6dA2xmHTSq+8gx2d9Pt5QN2DLBTtExvCheQpV1FhW5v90Wm4M5x3I9eFt xJdMCZcjPPuS1UB9zG+zns1TB0ei0pod64tWcfcIQymQDl8zN+8/bRMXbszEbotS f+YDEtcpuYkdlR3ttD+dEhar5UEVKLBAQXtr7w8ldAdQ0ptzp7ddhyB27TItiavb DdB6/BcN2KBMTsqEkKK8k4fd2mXuf3kbUx80r3Alw== X-ME-Proxy: X-ME-Sender: Received: from localhost (cm-84.214.174.185.getinternet.no [84.214.174.185]) by mail.messagingengine.com (Postfix) with ESMTPA id 97A82E407B; Tue, 26 Jun 2018 17:39:48 -0400 (EDT) From: Marius Bakke To: Vagrant Cascadian , 31957@debbugs.gnu.org Subject: Re: [bug#31957] [PATCH] gnu: Add python-libusb1. In-Reply-To: <8736xanm8j.fsf@aikidev.net> References: <87r2kwne89.fsf@aikidev.net> <877emmejjg.fsf@fastmail.com> <8736xanm8j.fsf@aikidev.net> User-Agent: Notmuch/0.27 (https://notmuchmail.org) Emacs/26.1 (x86_64-pc-linux-gnu) Date: Tue, 26 Jun 2018 23:39:46 +0200 Message-ID: <87bmbxxm59.fsf@fastmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="==-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 31957 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) --==-=-= Content-Type: multipart/mixed; boundary="=-=-=" --=-=-= Content-Type: text/plain Vagrant Cascadian writes: > On 2018-06-25, Marius Bakke wrote: >> Vagrant Cascadian writes: >> >>> Add new package definition for python-libusb1, needed to upgrade >>> python-trezor to newer versions. >> >> Thanks! I have some minor nitpicks: > ... >> Can you send an updated patch? Thanks in advance! > > Updated patch attached: > > - Add myself to copyright headers > - Drop unused srfi-26 > - Remove needless line break > - Flesh out description a bit... > - Remove COPYING file, which didn't match the licensing of the files > > The removal of COPYING was pretty much a shotgun-style approach, but I > couldn't figure out how to do a more surgical removal, and there weren't > any other COPYING files in the source. > > The description could probably be further improved... but that's as far > as I got for now... :) Thanks! Applied with these cosmetic changes (mostly to please `guix lint`): --=-=-= Content-Type: text/x-patch Content-Disposition: inline 1 file changed, 5 insertions(+), 5 deletions(-) gnu/packages/libusb.scm | 10 +++++----- modified gnu/packages/libusb.scm @@ -235,9 +235,9 @@ implementing @code{javax.usb} (JSR-80).") (modify-phases %standard-phases (add-before 'install-license-files 'remove-incorrect-license (lambda* (#:key out #:allow-other-keys) - ;; Was reliscensed to LGPL 2.1+, but old COPYING file still left + ;; Was relicensed to LGPL 2.1+, but old COPYING file still left ;; in source. Remove it so it does not get installed. - (delete-file-recursively "COPYING") + (delete-file "COPYING") #t)) (add-after 'unpack 'fix-libusb-reference (lambda* (#:key inputs #:allow-other-keys) @@ -251,11 +251,11 @@ implementing @code{javax.usb} (JSR-80).") "\""))) #t))))) (inputs `(("libusb" ,libusb))) - (home-page "http://github.com/vpelletier/python-libusb1") + (home-page "https://github.com/vpelletier/python-libusb1") (synopsis "Pure-python wrapper for libusb-1.0") (description "Libusb is a library that gives applications easy access to -USB devices on various operating systems. This is a python wrapper for -acessing libusb-1.0") +USB devices on various operating systems. This package provides a Python +wrapper for accessing libusb-1.0.") (license lgpl2.1+))) (define-public python-pyusb [back] --=-=-=-- --==-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCgAdFiEEu7At3yzq9qgNHeZDoqBt8qM6VPoFAlsysqIACgkQoqBt8qM6 VPpYzwf+IfdgY4onnQFMw64h3JhsvgNya2K6wCv76CopxTYmS0NqReFLQSFWbkH/ gFrwHEgAGWKpxmYvoWi6/syX20R8DlU2herHy3ALVFxMA42fT22/TsNu7+Yu7LfN bKswhVMCCdHsLDFoFGfHjgoQSYBujTXnhWoI4/c8NgJgnpsf0g4bu0memlyL9ju7 HeWHfyw1AAigUYf4osMP5u4+sYu0J0lZ5VK47eqmdS0+KvBb8028g5IBm5ybg9lZ 5Ea3w5lduXK0wlCS60GDH5m/k4nZEjyGMG2Ytge3JboFCrp3q1unCige4/tU5e42 zo9P6H3UD5NT6h42IuXFrKnlaz/IUg== =ptSR -----END PGP SIGNATURE----- --==-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Tue Jun 26 17:54:00 2018 Received: (at 31957-done) by debbugs.gnu.org; 26 Jun 2018 21:54:00 +0000 Received: from localhost ([127.0.0.1]:36674 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fXvuM-0004B9-Ed for submit@debbugs.gnu.org; Tue, 26 Jun 2018 17:54:00 -0400 Received: from out2-smtp.messagingengine.com ([66.111.4.26]:44157) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fXvuJ-0004Ay-HE; Tue, 26 Jun 2018 17:53:53 -0400 Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.nyi.internal (Postfix) with ESMTP id 108C521D26; Tue, 26 Jun 2018 17:53:51 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute5.internal (MEProxy); Tue, 26 Jun 2018 17:53:51 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fastmail.com; h= cc:content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to:x-me-sender:x-me-sender:x-sasl-enc; s= fm3; bh=xmj06v6OSU4Bl7hldIr1I8nRarTGRUVhVQq86Y62gGQ=; b=cI4KRw6v ulf8z1WWHtw2zHL4TTiwtN7vbVkbWqOYHuEEM6Bs0KV2nvrd864+uyAbqB6ck+vf /ESqkZmArQq4eJUjKhORylTTk+kstaNT+74OC5ol+zzpYY98P5yuu97l8ownRPwC +wVL1TlS5BS2FjD+PBBS4O0FrT3yqmGm0XRTaMWyOeXzQgsOU9cF6uCb91TGu/kt 16AOONfnz2eAUksbNUONS2H6TMYLzCNhIp/1Jy/jyMbruKQR+DRjm0k9RyadVB64 2op7iVG52FFStU+nYNvbG9I0n8BX8wHDcVMpxNJZJ9v4BTkt0BX8uAft1wqAMmGr L4IDrMpnLIgQUQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=fm3; bh=xmj06v6OSU4Bl7hldIr1I8nRarTGR UVhVQq86Y62gGQ=; b=YED82a7jj1P8iX9kiMD4bM+LB5H2kfhLayBVW1QsbCsTs lhbg5WkJ+iczfiiLAUDaYLImFwHRYiHaSjK9HaNofwG9GGPdGx/5JJTo5Ikmf1Rd i1dyGbFlBEpTmSuB8Jk/epE0PhkHknXkA4wLPQM2jX2hIrV8bFXGe18FmOtifVIq nUvzIdoxEznsAhe7NGxDHancgwSvGgjdDZ2ZJHoYrEEm8OuAtPyVMx1IbX5XBD/G MiWH6AFrAvWWeyZfIySVpdl24LNT5uGe4N0ieVvR/P6p8/i+eVqfcJ6IxZweDt2V AAMQ/W25B+xjzGUHzOWUIWT7PFaudbh5POWYoKTEQ== X-ME-Proxy: X-ME-Sender: Received: from localhost (cm-84.214.174.185.getinternet.no [84.214.174.185]) by mail.messagingengine.com (Postfix) with ESMTPA id 8AF71E461E; Tue, 26 Jun 2018 17:53:50 -0400 (EDT) From: Marius Bakke To: Vagrant Cascadian , 31958-done@debbugs.gnu.org Subject: Re: [bug#31958] [PATCH] gnu: Add python-pyblake2. In-Reply-To: <876026nowz.fsf@aikidev.net> References: <87o9g0ne4s.fsf@aikidev.net> <874lhqej9d.fsf@fastmail.com> <878t72o9r4.fsf@aikidev.net> <87h8lqzhq0.fsf@fastmail.com> <876026nowz.fsf@aikidev.net> User-Agent: Notmuch/0.27 (https://notmuchmail.org) Emacs/26.1 (x86_64-pc-linux-gnu) Date: Tue, 26 Jun 2018 23:53:49 +0200 Message-ID: <878t71xlhu.fsf@fastmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 31957-done Cc: 31957-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Vagrant Cascadian writes: > On 2018-06-25, Marius Bakke wrote: >> Vagrant Cascadian writes: >>>> According to COPYING, this software is actually "octuple-licensed": >>>> >>>> * CC0 Universal 1.0 - http://creativecommons.org/publicdomain/zero/1.0 >>>> * Unlicense =E2=80=94 http://unlicense.org/ >>>> * WTFPL Version 2 - http://www.wtfpl.net/ >>>> * Apache Public License 2.0 - https://www.apache.org/licenses/LICENSE-= 2.0 >>>> * OpenSSL License - https://www.openssl.org/source/license.html >>>> * MIT License - https://opensource.org/licenses/MIT >>>> * The BSD 3-Clause License - https://opensource.org/licenses/BSD-3-Cla= use >>>> * ISC License - https://opensource.org/licenses/ISC >>>> >>>> Can you add each of these, along with an explaning comment? >>> >>> And all of those are merely fallback licenses to the author's intention >>> of public domain... and in the files themselves (pyblake2module.c, >>> setup.py), they only reference: >>> >>> http://creativecommons.org/publicdomain/zero/1.0 >>> >>> But if it's more appropriate for guix to list all possible licenses, >>> sure. :) >> >> Right. I missed the top comment of the COPYING file[0], which dedicates >> the software to the public domain. But it also says that you are free >> to choose any of the others at your discretion. >> >> So I think CC0 is appropriate, but please add a comment explaning the >> situation. Thanks! >> >> [0] https://github.com/dchest/pyblake2/blob/master/COPYING > > Updated patch: > - fixed commit message > - moved to python-crypto.scm > - removed needless linebreak > - updated description > - updated licensing to public-domain/cc0 > - clarified additional licensing in comments > > Hopefully that covers everything. Thank you! I shortened the description a bit while adding @code{} notations where appropriate, and also added a copyright statement for you. Hope that was okay :-) I also moved the package so it wasn't squeezed between the Python3 and Python2 variants of python-py-bcrypt. (...and closing the previous patch bug while at it...) Pushed as e64088f0b521145286bfe3f028699e418baf4832! --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCgAdFiEEu7At3yzq9qgNHeZDoqBt8qM6VPoFAlsyte0ACgkQoqBt8qM6 VPpVEgf/Tc8Y3b/0IaUsOQXr1UHT1AkLf4FrUrMi6eM4XFfSBtK7iHnfYNx2W2+3 Mes+AXqcwLbEygXlUmfniJooB+UKBqC9UiuSkTyQLf0iJ2ve03/rG95awV5On7cv m9Ty3MdU6OejrrwvZe9vATXmErZaWA/18FMLDyBPNR+lFY8LyabI9nH0sAqXO/zz DMgJYnPYHqaSsisT7SxD7q+GOevnhv+lNjmQYB+5wV583tvp/5A2WTwGLJYAK6TJ GDdI8wL+Ko4IeV4czWRw8wqwi0jA+gNdfs9aTHQespqKQpssBGEWXis679qcuJdr pOHpFX+J0pyatu3QNROVUNLLV0KgVA== =p405 -----END PGP SIGNATURE----- --=-=-=-- From unknown Fri Jun 13 10:30:40 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Wed, 25 Jul 2018 11:24:06 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator