Subject: Re: [bug#31954] [PATCH] gnu: Add emacs-org-brain.

From: Vasile Dumitrascu <[email-masked]>
Date: Wed, 04 Jul 2018 16:30:00 +0000

Hi

@Marius: Please find attached an updated patch with the requested
changes. Do let me know if anything else is to be adjusted.

@Charlie: I am glad you find it useful. You are welcome!

  Thank you,

  Vasile

Marius Bakke:
> Vasile Dumitrascu <[email-masked]> writes:
> 
>> * gnu/packages/emacs.scm (emacs-org-brain): New variable.
> 
> Thanks for this patch!  Overall it LGTM, but it does not apply to my git
> checkout, so here are some nitpicks that I'd normally fix myself:
> 
> [...]
> 
>> +(define-public emacs-org-brain
>> +  (let ((version "20180522")  ; no proper tag, use date of commit
> 
> 'org-brain.el' has "Version: 0.5" in the source header.  Perhaps we
> should use that instead?
> 
> [...]
> 
>> +      (description "@code{emacs-org-brain} implements a variant of concept
>> +mapping in Emacs, using @code{org-mode}. It is heavily inspired by a piece of
>> +software called The Brain.")
> 
> Make sure to use double spaces in descriptions (guix lint should complain
> about this).  We also should not refer to nonfree software, can you try
> to expand on this description without mentioning the inspiration?
> 
> The commentary inside 'org-brain.el' contains a pretty good description.
> 
> Can you send an updated patch please?  Thanks in advance!
> 
>From 097ea36392360028cec20d2e8908755c926dcbcb Mon Sep 17 00:00:00 2001
From: Vasile Dumitrascu <[email-masked]>
Date: Wed, 4 Jul 2018 18:24:50 +0200
Subject: [PATCH] gnu: Add emacs-org-brain.

* gnu/packges/emacs.scm (emacs-org-brain): New variable.
---
 gnu/packages/emacs.scm | 26 ++++++++++++++++++++++++++
 1 file changed, 26 insertions(+)

diff --git a/gnu/packages/emacs.scm b/gnu/packages/emacs.scm
index 467791e21..712dd1363 100644
--- a/gnu/packages/emacs.scm
+++ b/gnu/packages/emacs.scm
@@ -11290,3 +11290,29 @@ To use, add @code{allow-emacs-pinentry} to @code{~/.gnupg/gpg-agent.conf},
 reload the configuration with @code{gpgconf --reload gpg-agent}, and start the
 server with @code{M-x pinentry-start}.")
       (license license:gpl3+))))
+
+(define-public emacs-org-brain
+  (package
+    (name "emacs-org-brain")
+    (version "0.5")
+    (source
+     (origin
+       (method git-fetch)
+       (uri (git-reference
+             (url "https://github.com/Kungsgeten/org-brain.git")
+             (commit "3faf9303af3f2356e3444e69c22dc6c5774047d1")))
+       (file-name (git-file-name name version))
+       (sha256
+        (base32
+         "1ad681zk6kckw2zbk0r4iaj4bw8cfqrbd1s3gdwgdjlzq81q9mmj"))))
+    (build-system emacs-build-system)
+    (home-page "https://github.com/Kungsgeten/org-brain")
+    (synopsis "Org-mode wiki and concept-mapping for Emacs")
+    (description "@code{emacs-org-brain} implements a variant of concept
+mapping in Emacs, using @code{org-mode}.  An org-brain is a network of
+org-mode entries, where each entry is a file or a headline, and you can get a
+visual overview of the relationships between the entries: parents, children,
+siblings and friends.  This visual overview can also be used to browse your
+entries.  You can think of entries as nodes in a mind map, or pages in a
+wiki.")
+    (license license:expat)))
-- 
2.18.0